{"thread":{"id":"65215","subject":"[GSoC PATCH] t9200: handle missing CVS with skip_all","startedAt":"2026-03-11T19:40:11Z","lastAt":"2026-03-11T19:49:37Z","messageCount":2,"participants":["Pablo Sabater","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"538669","messageId":"20260311194002.190195-1-pabloosabaterr@gmail.com","threadId":"65215","inReplyTo":null,"subject":"[GSoC PATCH] t9200: handle missing CVS with skip_all","fromName":"Pablo Sabater","fromEmail":"pabloosabaterr@gmail.com","sentAt":"2026-03-11T19:40:02Z","receivedAt":"2026-03-11T19:40:11Z","isPatch":true,"sender":{"key":"pabloosabaterr@gmail.com","avatar":"https://avatars.githubusercontent.com/u/63864637?v=4"},"body":"CVS initialization runs outside a test_expect_success and when it\nfails, the error report isn't good.\n\nWrap CVS initialization in a skip_all check so when CVS initialization\nfails, the error report becomes clearer.\n\nMove the Git repo initialization into its own test_expect_success instead\nof being in the same CVS check.\n\nSigned-off-by: Pablo Sabater <pabloosabaterr@gmail.com>\n---\n t/t9200-git-cvsexportcommit.sh | 18 +++++++++++-------\n 1 file changed, 11 insertions(+), 7 deletions(-)\n\ndiff --git a/t/t9200-git-cvsexportcommit.sh b/t/t9200-git-cvsexportcommit.sh\nindex a44eabf0d8..cba3b1a28a 100755\n--- a/t/t9200-git-cvsexportcommit.sh\n+++ b/t/t9200-git-cvsexportcommit.sh\n@@ -30,13 +30,17 @@ export CVSROOT CVSWORK GIT_DIR\n \n rm -rf \"$CVSROOT\" \"$CVSWORK\"\n \n-cvs init &&\n-test -d \"$CVSROOT\" &&\n-cvs -Q co -d \"$CVSWORK\" . &&\n-echo >empty &&\n-git add empty &&\n-git commit -q -a -m \"Initial\" 2>/dev/null ||\n-exit 1\n+if ! cvs init || ! test -d \"$CVSROOT\" || ! cvs -Q co -d \"$CVSWORK\" .\n+then\n+\tskip_all=\"cvs repository set-up fails\"\n+\ttest_done\n+fi\n+\n+test_expect_success 'git setup' '\n+\techo >empty &&\n+\tgit add empty &&\n+\tgit commit -q -a -m Initial\n+'\n \n check_entries () {\n \t# $1 == directory, $2 == expected\n-- \n2.43.0\n\n"},{"id":"538674","messageId":"xmqqy0jym9ip.fsf@gitster.g","threadId":"65215","inReplyTo":"20260311194002.190195-1-pabloosabaterr@gmail.com","subject":"Re: [GSoC PATCH] t9200: handle missing CVS with skip_all","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-03-11T19:49:34Z","receivedAt":"2026-03-11T19:49:37Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Pablo Sabater <pabloosabaterr@gmail.com> writes:\n\n> CVS initialization runs outside a test_expect_success and when it\n> fails, the error report isn't good.\n>\n> Wrap CVS initialization in a skip_all check so when CVS initialization\n> fails, the error report becomes clearer.\n>\n> Move the Git repo initialization into its own test_expect_success instead\n> of being in the same CVS check.\n>\n> Signed-off-by: Pablo Sabater <pabloosabaterr@gmail.com>\n> ---\n>  t/t9200-git-cvsexportcommit.sh | 18 +++++++++++-------\n>  1 file changed, 11 insertions(+), 7 deletions(-)\n\nMakes sense.  Will queue.  Thanks.\n\n\n> diff --git a/t/t9200-git-cvsexportcommit.sh b/t/t9200-git-cvsexportcommit.sh\n> index a44eabf0d8..cba3b1a28a 100755\n> --- a/t/t9200-git-cvsexportcommit.sh\n> +++ b/t/t9200-git-cvsexportcommit.sh\n> @@ -30,13 +30,17 @@ export CVSROOT CVSWORK GIT_DIR\n>  \n>  rm -rf \"$CVSROOT\" \"$CVSWORK\"\n>  \n> -cvs init &&\n> -test -d \"$CVSROOT\" &&\n> -cvs -Q co -d \"$CVSWORK\" . &&\n> -echo >empty &&\n> -git add empty &&\n> -git commit -q -a -m \"Initial\" 2>/dev/null ||\n> -exit 1\n> +if ! cvs init || ! test -d \"$CVSROOT\" || ! cvs -Q co -d \"$CVSWORK\" .\n> +then\n> +\tskip_all=\"cvs repository set-up fails\"\n> +\ttest_done\n> +fi\n> +\n> +test_expect_success 'git setup' '\n> +\techo >empty &&\n> +\tgit add empty &&\n> +\tgit commit -q -a -m Initial\n> +'\n>  \n>  check_entries () {\n>  \t# $1 == directory, $2 == expected\n"}]}