{"thread":{"id":"65129","subject":"[PATCH 1/2] t7412: fix typo 'submodue' in test_description","startedAt":"2026-03-03T17:58:29Z","lastAt":"2026-03-04T05:16:30Z","messageCount":4,"participants":["Yuvraj Singh Chauhan","Patrick Steinhardt"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"537707","messageId":"20260303175750.361563-1-ysinghcin@gmail.com","threadId":"65129","inReplyTo":null,"subject":"[PATCH 1/2] t7412: fix typo 'submodue' in test_description","fromName":"Yuvraj Singh Chauhan","fromEmail":"ysinghcin@gmail.com","sentAt":"2026-03-03T17:57:49Z","receivedAt":"2026-03-03T17:58:29Z","isPatch":true,"sender":{"key":"ysinghcin@gmail.com","avatar":"https://avatars.githubusercontent.com/u/133221941?v=4"},"body":"Signed-off-by: Yuvraj Singh Chauhan <ysinghcin@gmail.com>\n---\n t/t7412-submodule-absorbgitdirs.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t7412-submodule-absorbgitdirs.sh b/t/t7412-submodule-absorbgitdirs.sh\nindex 0490499573..41ee035e3c 100755\n--- a/t/t7412-submodule-absorbgitdirs.sh\n+++ b/t/t7412-submodule-absorbgitdirs.sh\n@@ -2,7 +2,7 @@\n \n test_description='Test submodule absorbgitdirs\n \n-This test verifies that `git submodue absorbgitdirs` moves a submodules git\n+This test verifies that `git submodule absorbgitdirs` moves a submodules git\n directory into the superproject.\n '\n \n-- \n2.53.0.290.g4805bb9930\n\n"},{"id":"537708","messageId":"20260303175750.361563-2-ysinghcin@gmail.com","threadId":"65129","inReplyTo":"20260303175750.361563-1-ysinghcin@gmail.com","subject":"[PATCH 2/2] t7412: modernize path checks to use test helper functions","fromName":"Yuvraj Singh Chauhan","fromEmail":"ysinghcin@gmail.com","sentAt":"2026-03-03T17:57:50Z","receivedAt":"2026-03-03T17:59:01Z","isPatch":true,"sender":{"key":"ysinghcin@gmail.com","avatar":"https://avatars.githubusercontent.com/u/133221941?v=4"},"body":"Replace 11 raw 'test -f', 'test -d', and '! test -e' calls with the\ncorresponding test library helpers:\n\n  - 'test -f' -> 'test_path_is_file'\n  - 'test -d' -> 'test_path_is_dir'\n  - '! test -e' -> 'test_path_is_missing'\n\nThese helpers emit a descriptive message on failure, \nmaking failing tests easier to diagnose than the silent \npass/fail of the raw shell primitives.\n\nSigned-off-by: Yuvraj Singh Chauhan <ysinghcin@gmail.com>\n---\n t/t7412-submodule-absorbgitdirs.sh | 22 +++++++++++-----------\n 1 file changed, 11 insertions(+), 11 deletions(-)\n\ndiff --git a/t/t7412-submodule-absorbgitdirs.sh b/t/t7412-submodule-absorbgitdirs.sh\nindex 41ee035e3c..cdc7f59e12 100755\n--- a/t/t7412-submodule-absorbgitdirs.sh\n+++ b/t/t7412-submodule-absorbgitdirs.sh\n@@ -34,8 +34,8 @@ test_expect_success 'absorb the git dir' '\n \tgit submodule absorbgitdirs 2>actual &&\n \ttest_cmp expect actual &&\n \tgit fsck &&\n-\ttest -f sub1/.git &&\n-\ttest -d .git/modules/sub1 &&\n+\ttest_path_is_file sub1/.git &&\n+\ttest_path_is_dir .git/modules/sub1 &&\n \tgit status >actual.1 &&\n \tgit -C sub1 rev-parse HEAD >actual.2 &&\n \ttest_cmp expect.1 actual.1 &&\n@@ -47,9 +47,9 @@ test_expect_success 'absorbing does not fail for deinitialized submodules' '\n \tgit submodule deinit --all &&\n \tgit submodule absorbgitdirs 2>err &&\n \ttest_must_be_empty err &&\n-\ttest -d .git/modules/sub1 &&\n-\ttest -d sub1 &&\n-\t! test -e sub1/.git\n+\ttest_path_is_dir .git/modules/sub1 &&\n+\ttest_path_is_dir sub1 &&\n+\ttest_path_is_missing sub1/.git\n '\n \n test_expect_success 'setup nested submodule' '\n@@ -72,8 +72,8 @@ test_expect_success 'absorb the git dir in a nested submodule' '\n \tEOF\n \tgit submodule absorbgitdirs 2>actual &&\n \ttest_cmp expect actual &&\n-\ttest -f sub1/nested/.git &&\n-\ttest -d .git/modules/sub1/modules/nested &&\n+\ttest_path_is_file sub1/nested/.git &&\n+\ttest_path_is_dir .git/modules/sub1/modules/nested &&\n \tgit status >actual.1 &&\n \tgit -C sub1/nested rev-parse HEAD >actual.2 &&\n \ttest_cmp expect.1 actual.1 &&\n@@ -109,9 +109,9 @@ test_expect_success 'absorb the git dir in a nested submodule' '\n \tEOF\n \tgit submodule absorbgitdirs 2>actual &&\n \ttest_cmp expect actual &&\n-\ttest -f sub1/.git &&\n-\ttest -f sub1/nested/.git &&\n-\ttest -d .git/modules/sub1/modules/nested &&\n+\ttest_path_is_file sub1/.git &&\n+\ttest_path_is_file sub1/nested/.git &&\n+\ttest_path_is_dir .git/modules/sub1/modules/nested &&\n \tgit status >actual.1 &&\n \tgit -C sub1/nested rev-parse HEAD >actual.2 &&\n \ttest_cmp expect.1 actual.1 &&\n@@ -155,7 +155,7 @@ test_expect_success 'absorbing the git dir fails for incomplete submodules' '\n \ttest_must_fail git submodule absorbgitdirs 2>actual &&\n \ttest_cmp expect actual &&\n \tgit -C sub2 fsck &&\n-\ttest -d sub2/.git &&\n+\ttest_path_is_dir sub2/.git &&\n \tgit status >actual &&\n \tgit -C sub2 rev-parse HEAD >actual.2 &&\n \ttest_cmp expect.1 actual.1 &&\n-- \n2.53.0.290.g4805bb9930\n\n"},{"id":"537747","messageId":"aafAIqqq1PdzmQW3@pks.im","threadId":"65129","inReplyTo":"20260303175750.361563-1-ysinghcin@gmail.com","subject":"Re: [PATCH 1/2] t7412: fix typo 'submodue' in test_description","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2026-03-04T05:16:18Z","receivedAt":"2026-03-04T05:16:25Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Tue, Mar 03, 2026 at 11:27:49PM +0530, Yuvraj Singh Chauhan wrote:\n\nOne micro nit, not worth rerolling over: I think in general we prefer to\nhave at least a sentence in the commit message body, even if it repeats\nmost of what the subject has already said.\n\nAt least for me it makes the review a bit easier, as the subject of the\nmessage will be gone at the time I start writing a reply during the\nreview.\n\n> Signed-off-by: Yuvraj Singh Chauhan <ysinghcin@gmail.com>\n> ---\n>  t/t7412-submodule-absorbgitdirs.sh | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/t/t7412-submodule-absorbgitdirs.sh b/t/t7412-submodule-absorbgitdirs.sh\n> index 0490499573..41ee035e3c 100755\n> --- a/t/t7412-submodule-absorbgitdirs.sh\n> +++ b/t/t7412-submodule-absorbgitdirs.sh\n> @@ -2,7 +2,7 @@\n>  \n>  test_description='Test submodule absorbgitdirs\n>  \n> -This test verifies that `git submodue absorbgitdirs` moves a submodules git\n> +This test verifies that `git submodule absorbgitdirs` moves a submodules git\n>  directory into the superproject.\n>  '\n\nAn obvious fix indeed.\n\nPatrick\n"},{"id":"537748","messageId":"aafAKc41y4CdZmUt@pks.im","threadId":"65129","inReplyTo":"20260303175750.361563-2-ysinghcin@gmail.com","subject":"Re: [PATCH 2/2] t7412: modernize path checks to use test helper functions","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2026-03-04T05:16:25Z","receivedAt":"2026-03-04T05:16:30Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Tue, Mar 03, 2026 at 11:27:50PM +0530, Yuvraj Singh Chauhan wrote:\n> Replace 11 raw 'test -f', 'test -d', and '! test -e' calls with the\n\nThis explicit number of course made me verify that you didn't miscount,\nand you indeed didn't :)\n\n> corresponding test library helpers:\n> \n>   - 'test -f' -> 'test_path_is_file'\n>   - 'test -d' -> 'test_path_is_dir'\n>   - '! test -e' -> 'test_path_is_missing'\n> \n> These helpers emit a descriptive message on failure, \n> making failing tests easier to diagnose than the silent \n> pass/fail of the raw shell primitives.\n\nYup, the reasoning is sound.\n\nBy the way, you have trailing whitespace in the commit message. I guess\nit'll get stripped when Junio applies the patch anyway, but maybe\nsomething to watch out for in the future.\n\n> diff --git a/t/t7412-submodule-absorbgitdirs.sh b/t/t7412-submodule-absorbgitdirs.sh\n> index 41ee035e3c..cdc7f59e12 100755\n> --- a/t/t7412-submodule-absorbgitdirs.sh\n> +++ b/t/t7412-submodule-absorbgitdirs.sh\n\nThe changes all look obviously correct to me. Thanks!\n\nPatrick\n"}]}