{"thread":{"id":"65120","subject":"[GSoC PATCH 0/3] doc: improve gitprotocol-pack","startedAt":"2026-03-02T16:09:48Z","lastAt":"2026-03-03T01:48:26Z","messageCount":15,"participants":["LorenzoPegorari","Junio C Hamano","Lorenzo Pegorari"],"isPatch":true,"patchVersion":1,"patchTotal":3},"messages":[{"id":"537541","messageId":"cover.1772467050.git.lorenzo.pegorari2002@gmail.com","threadId":"65120","inReplyTo":null,"subject":"[GSoC PATCH 0/3] doc: improve gitprotocol-pack","fromName":"LorenzoPegorari","fromEmail":"lorenzo.pegorari2002@gmail.com","sentAt":"2026-03-02T16:09:44Z","receivedAt":"2026-03-02T16:09:48Z","isPatch":true,"sender":{"key":"lorenzo.pegorari2002@gmail.com","avatar":"https://avatars.githubusercontent.com/u/132087553?v=4"},"body":"While studying the `gitprotocol-pack` documentation, I found various\nsmall style inconsistencies.\n\nThe patches are just tiny, simple improvements, mostly to improve the\nclarity of the documentation.\n\nLorenzoPegorari (3):\n doc: gitprotocol-pack: fix pronoun-antecedent agreement\n doc: gitprotocol-pack: improve paragraphs structure\n doc: gitprotocol-pack: normalize inline code formatting\n\n Documentation/gitprotocol-pack.adoc | 18 ++++++++++--------\n 1 file changed, 10 insertions(+), 8 deletions(-)\n\n-- \n2.43.0\n\n"},{"id":"537542","messageId":"0d679e5eb514f33aed92f7fba4843efc53e6c461.1772467050.git.lorenzo.pegorari2002@gmail.com","threadId":"65120","inReplyTo":"cover.1772467050.git.lorenzo.pegorari2002@gmail.com","subject":"[GSoC PATCH 1/3] doc: gitprotocol-pack: fix pronoun-antecedent agreement","fromName":"LorenzoPegorari","fromEmail":"lorenzo.pegorari2002@gmail.com","sentAt":"2026-03-02T16:10:12Z","receivedAt":"2026-03-02T16:10:16Z","isPatch":true,"sender":{"key":"lorenzo.pegorari2002@gmail.com","avatar":"https://avatars.githubusercontent.com/u/132087553?v=4"},"body":"Fix \"pronoun-antecedent agreement\" errors.\n\nSigned-off-by: LorenzoPegorari \n---\n Documentation/gitprotocol-pack.adoc | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/gitprotocol-pack.adoc b/Documentation/gitprotocol-pack.adoc\nindex 837b691c89..9952fac188 100644\n--- a/Documentation/gitprotocol-pack.adoc\n+++ b/Documentation/gitprotocol-pack.adoc\n@@ -65,7 +65,7 @@ Extra Parameters\n ----------------\n \n The protocol provides a mechanism in which clients can send additional\n-information in its first message to the server. These are called \"Extra\n+information in their first message to the server. These are called \"Extra\n Parameters\", and are supported by the Git, SSH, and HTTP protocols.\n \n Each Extra Parameter takes the form of `=` or ``.\n@@ -277,7 +277,7 @@ out of what the server said it could do with the first 'want' line.\n filter-request = PKT-LINE(\"filter\" SP filter-spec)\n ----\n \n-Clients MUST send all the obj-ids it wants from the reference\n+Clients MUST send all the obj-ids they want from the reference\n discovery phase as 'want' lines. Clients MUST send at least one\n 'want' command in the request body. Clients MUST NOT mention an\n obj-id in a 'want' command which did not appear in the response\n-- \n2.43.0\n\n"},{"id":"537543","messageId":"8a6b5d4c98bd239e66faaaaf5883cbb50f1f1802.1772467050.git.lorenzo.pegorari2002@gmail.com","threadId":"65120","inReplyTo":"cover.1772467050.git.lorenzo.pegorari2002@gmail.com","subject":"[GSoC PATCH 2/3] doc: gitprotocol-pack: improve paragraphs structure","fromName":"LorenzoPegorari","fromEmail":"lorenzo.pegorari2002@gmail.com","sentAt":"2026-03-02T16:10:28Z","receivedAt":"2026-03-02T16:10:32Z","isPatch":true,"sender":{"key":"lorenzo.pegorari2002@gmail.com","avatar":"https://avatars.githubusercontent.com/u/132087553?v=4"},"body":"Logically separate the introductory sentence from the first transport\ndescription to improve readability and structural clarity.\n\nSigned-off-by: LorenzoPegorari \n---\n Documentation/gitprotocol-pack.adoc | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)\n\ndiff --git a/Documentation/gitprotocol-pack.adoc b/Documentation/gitprotocol-pack.adoc\nindex 9952fac188..f4c9e024b0 100644\n--- a/Documentation/gitprotocol-pack.adoc\n+++ b/Documentation/gitprotocol-pack.adoc\n@@ -47,7 +47,9 @@ process defined in this protocol is terminated.\n Transports\n ----------\n There are three transports over which the packfile protocol is\n-initiated. The Git transport is a simple, unauthenticated server that\n+initiated.\n+\n+The Git transport is a simple, unauthenticated server that\n takes the command (almost always 'upload-pack', though Git\n servers can be configured to be globally writable, in which 'receive-\n pack' initiation is also allowed) with which the client wishes to\n-- \n2.43.0\n\n"},{"id":"537545","messageId":"e0e4ea3d22d11d8d6b6e721228f1420cb8dfa612.1772467050.git.lorenzo.pegorari2002@gmail.com","threadId":"65120","inReplyTo":"cover.1772467050.git.lorenzo.pegorari2002@gmail.com","subject":"[GSoC PATCH 3/3] doc: gitprotocol-pack: normalize inline code formatting","fromName":"LorenzoPegorari","fromEmail":"lorenzo.pegorari2002@gmail.com","sentAt":"2026-03-02T16:10:58Z","receivedAt":"2026-03-02T16:11:23Z","isPatch":true,"sender":{"key":"lorenzo.pegorari2002@gmail.com","avatar":"https://avatars.githubusercontent.com/u/132087553?v=4"},"body":"Uniform inline code usage for command and process names.\n\nSigned-off-by: LorenzoPegorari \n---\n Documentation/gitprotocol-pack.adoc | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/Documentation/gitprotocol-pack.adoc b/Documentation/gitprotocol-pack.adoc\nindex f4c9e024b0..63d3971037 100644\n--- a/Documentation/gitprotocol-pack.adoc\n+++ b/Documentation/gitprotocol-pack.adoc\n@@ -117,7 +117,7 @@ process on the server side over the Git protocol is this:\n SSH Transport\n -------------\n \n-Initiating the upload-pack or receive-pack processes over SSH is\n+Initiating the 'upload-pack' or 'receive-pack' processes over SSH is\n executing the binary on the server via SSH remote execution.\n It is basically equivalent to running this:\n \n@@ -131,7 +131,7 @@ two commands, or even just one of them.\n \n In an ssh:// format URI, it's absolute in the URI, so the '/' after\n the host name (or port number) is sent as an argument, which is then\n-read by the remote git-upload-pack exactly as is, so it's effectively\n+read by the remote `git-upload-pack` exactly as is, so it's effectively\n an absolute path in the remote filesystem.\n \n git clone ssh://user@example.com/project.git\n@@ -163,7 +163,7 @@ supports passing environment variables as an argument.\n \n A few things to remember here:\n \n-- The \"command name\" is spelled with dash (e.g. git-upload-pack), but\n+- The \"command name\" is spelled with dash (e.g. `git-upload-pack`), but\n this can be overridden by the client;\n \n - The repository path is always quoted with single quotes.\n@@ -377,10 +377,10 @@ In multi_ack_detailed mode:\n \n Without either multi_ack or multi_ack_detailed:\n \n- * upload-pack sends \"ACK obj-id\" on the first common object it finds.\n+ * `upload-pack` sends \"ACK obj-id\" on the first common object it finds.\n After that it says nothing until the client gives it a \"done\".\n \n- * upload-pack sends \"NAK\" on a flush-pkt if no common object\n+ * `upload-pack` sends \"NAK\" on a flush-pkt if no common object\n has been found yet. If one has been found, and thus an ACK\n was already sent, it's silent on the flush-pkt.\n \n-- \n2.43.0\n\n"},{"id":"537628","messageId":"xmqqms0px2de.fsf@gitster.g","threadId":"65120","inReplyTo":"e0e4ea3d22d11d8d6b6e721228f1420cb8dfa612.1772467050.git.lorenzo.pegorari2002@gmail.com","subject":"Re: [GSoC PATCH 3/3] doc: gitprotocol-pack: normalize inline code formatting","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-03-02T23:01:17Z","receivedAt":"2026-03-02T23:01:19Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"LorenzoPegorari writes:\n\n> Uniform inline code usage for command and process names.\n>\n> Signed-off-by: LorenzoPegorari \n> ---\n> Documentation/gitprotocol-pack.adoc | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n>\n> diff --git a/Documentation/gitprotocol-pack.adoc b/Documentation/gitprotocol-pack.adoc\n> index f4c9e024b0..63d3971037 100644\n> --- a/Documentation/gitprotocol-pack.adoc\n> +++ b/Documentation/gitprotocol-pack.adoc\n> @@ -117,7 +117,7 @@ process on the server side over the Git protocol is this:\n> SSH Transport\n> -------------\n> \n> -Initiating the upload-pack or receive-pack processes over SSH is\n> +Initiating the 'upload-pack' or 'receive-pack' processes over SSH is\n\nThese are not `backquoted` for teletype text typesetting,\nlike the other hunks in this patch do?\n\nAll other things in these three patches I found them reasonable,\nexcept for this hunk.\n\nThanks.\n\n> executing the binary on the server via SSH remote execution.\n> It is basically equivalent to running this:\n> \n> @@ -131,7 +131,7 @@ two commands, or even just one of them.\n> \n> In an ssh:// format URI, it's absolute in the URI, so the '/' after\n> the host name (or port number) is sent as an argument, which is then\n> -read by the remote git-upload-pack exactly as is, so it's effectively\n> +read by the remote `git-upload-pack` exactly as is, so it's effectively\n> an absolute path in the remote filesystem.\n> \n> git clone ssh://user@example.com/project.git\n> @@ -163,7 +163,7 @@ supports passing environment variables as an argument.\n> \n> A few things to remember here:\n> \n> -- The \"command name\" is spelled with dash (e.g. git-upload-pack), but\n> +- The \"command name\" is spelled with dash (e.g. `git-upload-pack`), but\n> this can be overridden by the client;\n> \n> - The repository path is always quoted with single quotes.\n> @@ -377,10 +377,10 @@ In multi_ack_detailed mode:\n> \n> Without either multi_ack or multi_ack_detailed:\n> \n> - * upload-pack sends \"ACK obj-id\" on the first common object it finds.\n> + * `upload-pack` sends \"ACK obj-id\" on the first common object it finds.\n> After that it says nothing until the client gives it a \"done\".\n> \n> - * upload-pack sends \"NAK\" on a flush-pkt if no common object\n> + * `upload-pack` sends \"NAK\" on a flush-pkt if no common object\n> has been found yet. If one has been found, and thus an ACK\n> was already sent, it's silent on the flush-pkt.\n"},{"id":"537630","messageId":"aaY4tQzdEGE0hfvB@lorenzo-VM","threadId":"65120","inReplyTo":"xmqqms0px2de.fsf@gitster.g","subject":"Re: [GSoC PATCH 3/3] doc: gitprotocol-pack: normalize inline code formatting","fromName":"Lorenzo Pegorari","fromEmail":"lorenzo.pegorari2002@gmail.com","sentAt":"2026-03-03T01:26:13Z","receivedAt":"2026-03-03T01:26:16Z","isPatch":true,"sender":{"key":"lorenzo.pegorari2002@gmail.com","avatar":"https://avatars.githubusercontent.com/u/132087553?v=4"},"body":"On Mon, Mar 02, 2026 at 03:01:17PM -0800, Junio C Hamano wrote:\n> LorenzoPegorari writes:\n> \n> > Uniform inline code usage for command and process names.\n> >\n> > Signed-off-by: LorenzoPegorari \n> > ---\n> > Documentation/gitprotocol-pack.adoc | 10 +++++-----\n> > 1 file changed, 5 insertions(+), 5 deletions(-)\n> >\n> > diff --git a/Documentation/gitprotocol-pack.adoc b/Documentation/gitprotocol-pack.adoc\n> > index f4c9e024b0..63d3971037 100644\n> > --- a/Documentation/gitprotocol-pack.adoc\n> > +++ b/Documentation/gitprotocol-pack.adoc\n> > @@ -117,7 +117,7 @@ process on the server side over the Git protocol is this:\n> > SSH Transport\n> > -------------\n> > \n> > -Initiating the upload-pack or receive-pack processes over SSH is\n> > +Initiating the 'upload-pack' or 'receive-pack' processes over SSH is\n> \n> These are not `backquoted` for teletype text typesetting,\n> like the other hunks in this patch do?\n> \n> All other things in these three patches I found them reasonable,\n> except for this hunk.\n> \n> Thanks.\n\nThank you so much for catching all my mistakes Junio.\n\nI misread the existing formatting: I mistook the apostrophes for\nbackticks, and so I incorrectly assumed that the document used inline\ncode for command and process names. In reality, the rest of the document\nuses italics for these elements.\n\nI'm sending a v2 where I correctly uniform command and process names to\nuse the italic style ASAP.\n\n"},{"id":"537631","messageId":"cover.1772500189.git.lorenzo.pegorari2002@gmail.com","threadId":"65120","inReplyTo":"cover.1772467050.git.lorenzo.pegorari2002@gmail.com","subject":"[GSoC PATCH v2 0/3] doc: improve gitprotocol-pack","fromName":"LorenzoPegorari","fromEmail":"lorenzo.pegorari2002@gmail.com","sentAt":"2026-03-03T01:34:10Z","receivedAt":"2026-03-03T01:34:14Z","isPatch":true,"sender":{"key":"lorenzo.pegorari2002@gmail.com","avatar":"https://avatars.githubusercontent.com/u/132087553?v=4"},"body":"While studying the `gitprotocol-pack` documentation, I found various\nsmall style inconsistencies.\n\nThese patches are just tiny, simple improvements, mostly to improve the\nclarity of the documentation.\n\nV2 DIFF:\n * Fixed final patch to properly conform command and process names to\n italic format, instead of the inline code format\n\nLorenzoPegorari (3):\n doc: gitprotocol-pack: fix pronoun-antecedent agreement\n doc: gitprotocol-pack: improve paragraphs structure\n doc: gitprotocol-pack: normalize italic formatting\n\n Documentation/gitprotocol-pack.adoc | 18 ++++++++++--------\n 1 file changed, 10 insertions(+), 8 deletions(-)\n\nRange-diff against v1:\n1: 0d679e5eb5 = 1: 0d679e5eb5 doc: gitprotocol-pack: fix pronoun-antecedent agreement\n2: 8a6b5d4c98 = 2: 8a6b5d4c98 doc: gitprotocol-pack: improve paragraphs structure\n3: e0e4ea3d22 ! 3: 6410967d65 doc: gitprotocol-pack: normalize inline code formatting\n @@ Metadata\n Author: LorenzoPegorari \n \n ## Commit message ##\n - doc: gitprotocol-pack: normalize inline code formatting\n + doc: gitprotocol-pack: normalize italic formatting\n \n - Uniform inline code usage for command and process names.\n + Uniform italic style usage for command and process names.\n \n Signed-off-by: LorenzoPegorari \n \n @@ Documentation/gitprotocol-pack.adoc: supports passing environment variables as a\n A few things to remember here:\n \n -- The \"command name\" is spelled with dash (e.g. git-upload-pack), but\n -+- The \"command name\" is spelled with dash (e.g. `git-upload-pack`), but\n ++- The \"command name\" is spelled with dash (e.g. 'git-upload-pack'), but\n this can be overridden by the client;\n \n - The repository path is always quoted with single quotes.\n @@ Documentation/gitprotocol-pack.adoc: In multi_ack_detailed mode:\n Without either multi_ack or multi_ack_detailed:\n \n - * upload-pack sends \"ACK obj-id\" on the first common object it finds.\n -+ * `upload-pack` sends \"ACK obj-id\" on the first common object it finds.\n ++ * 'upload-pack' sends \"ACK obj-id\" on the first common object it finds.\n After that it says nothing until the client gives it a \"done\".\n \n - * upload-pack sends \"NAK\" on a flush-pkt if no common object\n -+ * `upload-pack` sends \"NAK\" on a flush-pkt if no common object\n ++ * 'upload-pack' sends \"NAK\" on a flush-pkt if no common object\n has been found yet. If one has been found, and thus an ACK\n was already sent, it's silent on the flush-pkt.\n \n-- \n2.43.0\n\n"},{"id":"537632","messageId":"0d679e5eb514f33aed92f7fba4843efc53e6c461.1772500189.git.lorenzo.pegorari2002@gmail.com","threadId":"65120","inReplyTo":"cover.1772500189.git.lorenzo.pegorari2002@gmail.com","subject":"[GSoC PATCH v2 1/3] doc: gitprotocol-pack: fix pronoun-antecedent agreement","fromName":"LorenzoPegorari","fromEmail":"lorenzo.pegorari2002@gmail.com","sentAt":"2026-03-03T01:34:35Z","receivedAt":"2026-03-03T01:34:40Z","isPatch":true,"sender":{"key":"lorenzo.pegorari2002@gmail.com","avatar":"https://avatars.githubusercontent.com/u/132087553?v=4"},"body":"Fix \"pronoun-antecedent agreement\" errors.\n\nSigned-off-by: LorenzoPegorari \n---\n Documentation/gitprotocol-pack.adoc | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/gitprotocol-pack.adoc b/Documentation/gitprotocol-pack.adoc\nindex 837b691c89..9952fac188 100644\n--- a/Documentation/gitprotocol-pack.adoc\n+++ b/Documentation/gitprotocol-pack.adoc\n@@ -65,7 +65,7 @@ Extra Parameters\n ----------------\n \n The protocol provides a mechanism in which clients can send additional\n-information in its first message to the server. These are called \"Extra\n+information in their first message to the server. These are called \"Extra\n Parameters\", and are supported by the Git, SSH, and HTTP protocols.\n \n Each Extra Parameter takes the form of `=` or ``.\n@@ -277,7 +277,7 @@ out of what the server said it could do with the first 'want' line.\n filter-request = PKT-LINE(\"filter\" SP filter-spec)\n ----\n \n-Clients MUST send all the obj-ids it wants from the reference\n+Clients MUST send all the obj-ids they want from the reference\n discovery phase as 'want' lines. Clients MUST send at least one\n 'want' command in the request body. Clients MUST NOT mention an\n obj-id in a 'want' command which did not appear in the response\n-- \n2.43.0\n\n"},{"id":"537633","messageId":"8a6b5d4c98bd239e66faaaaf5883cbb50f1f1802.1772500189.git.lorenzo.pegorari2002@gmail.com","threadId":"65120","inReplyTo":"cover.1772500189.git.lorenzo.pegorari2002@gmail.com","subject":"[GSoC PATCH v2 2/3] doc: gitprotocol-pack: improve paragraphs structure","fromName":"LorenzoPegorari","fromEmail":"lorenzo.pegorari2002@gmail.com","sentAt":"2026-03-03T01:35:05Z","receivedAt":"2026-03-03T01:35:09Z","isPatch":true,"sender":{"key":"lorenzo.pegorari2002@gmail.com","avatar":"https://avatars.githubusercontent.com/u/132087553?v=4"},"body":"Logically separate the introductory sentence from the first transport\ndescription to improve readability and structural clarity.\n\nSigned-off-by: LorenzoPegorari \n---\n Documentation/gitprotocol-pack.adoc | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)\n\ndiff --git a/Documentation/gitprotocol-pack.adoc b/Documentation/gitprotocol-pack.adoc\nindex 9952fac188..f4c9e024b0 100644\n--- a/Documentation/gitprotocol-pack.adoc\n+++ b/Documentation/gitprotocol-pack.adoc\n@@ -47,7 +47,9 @@ process defined in this protocol is terminated.\n Transports\n ----------\n There are three transports over which the packfile protocol is\n-initiated. The Git transport is a simple, unauthenticated server that\n+initiated.\n+\n+The Git transport is a simple, unauthenticated server that\n takes the command (almost always 'upload-pack', though Git\n servers can be configured to be globally writable, in which 'receive-\n pack' initiation is also allowed) with which the client wishes to\n-- \n2.43.0\n\n"},{"id":"537634","messageId":"6410967d65c9db333f0fc31f3d7069723a1ac7c8.1772500189.git.lorenzo.pegorari2002@gmail.com","threadId":"65120","inReplyTo":"cover.1772500189.git.lorenzo.pegorari2002@gmail.com","subject":"[GSoC PATCH v2 3/3] doc: gitprotocol-pack: normalize italic formatting","fromName":"LorenzoPegorari","fromEmail":"lorenzo.pegorari2002@gmail.com","sentAt":"2026-03-03T01:38:47Z","receivedAt":"2026-03-03T01:38:51Z","isPatch":true,"sender":{"key":"lorenzo.pegorari2002@gmail.com","avatar":"https://avatars.githubusercontent.com/u/132087553?v=4"},"body":"Uniform italic style usage for command and process names.\n\nSigned-off-by: LorenzoPegorari \n---\n Documentation/gitprotocol-pack.adoc | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/Documentation/gitprotocol-pack.adoc b/Documentation/gitprotocol-pack.adoc\nindex f4c9e024b0..7ed591a0bd 100644\n--- a/Documentation/gitprotocol-pack.adoc\n+++ b/Documentation/gitprotocol-pack.adoc\n@@ -117,7 +117,7 @@ process on the server side over the Git protocol is this:\n SSH Transport\n -------------\n \n-Initiating the upload-pack or receive-pack processes over SSH is\n+Initiating the 'upload-pack' or 'receive-pack' processes over SSH is\n executing the binary on the server via SSH remote execution.\n It is basically equivalent to running this:\n \n@@ -131,7 +131,7 @@ two commands, or even just one of them.\n \n In an ssh:// format URI, it's absolute in the URI, so the '/' after\n the host name (or port number) is sent as an argument, which is then\n-read by the remote git-upload-pack exactly as is, so it's effectively\n+read by the remote `git-upload-pack` exactly as is, so it's effectively\n an absolute path in the remote filesystem.\n \n git clone ssh://user@example.com/project.git\n@@ -163,7 +163,7 @@ supports passing environment variables as an argument.\n \n A few things to remember here:\n \n-- The \"command name\" is spelled with dash (e.g. git-upload-pack), but\n+- The \"command name\" is spelled with dash (e.g. 'git-upload-pack'), but\n this can be overridden by the client;\n \n - The repository path is always quoted with single quotes.\n@@ -377,10 +377,10 @@ In multi_ack_detailed mode:\n \n Without either multi_ack or multi_ack_detailed:\n \n- * upload-pack sends \"ACK obj-id\" on the first common object it finds.\n+ * 'upload-pack' sends \"ACK obj-id\" on the first common object it finds.\n After that it says nothing until the client gives it a \"done\".\n \n- * upload-pack sends \"NAK\" on a flush-pkt if no common object\n+ * 'upload-pack' sends \"NAK\" on a flush-pkt if no common object\n has been found yet. If one has been found, and thus an ACK\n was already sent, it's silent on the flush-pkt.\n \n-- \n2.43.0\n\n"},{"id":"537635","messageId":"cover.1772502209.git.lorenzo.pegorari2002@gmail.com","threadId":"65120","inReplyTo":"cover.1772500189.git.lorenzo.pegorari2002@gmail.com","subject":"[GSoC PATCH v3 0/3] doc: improve gitprotocol-pack","fromName":"LorenzoPegorari","fromEmail":"lorenzo.pegorari2002@gmail.com","sentAt":"2026-03-03T01:45:45Z","receivedAt":"2026-03-03T01:45:49Z","isPatch":true,"sender":{"key":"lorenzo.pegorari2002@gmail.com","avatar":"https://avatars.githubusercontent.com/u/132087553?v=4"},"body":"While studying the `gitprotocol-pack` documentation, I found various\nsmall style inconsistencies.\n\nThese patches are just tiny, simple improvements, mostly to improve the\nclarity of the documentation.\n\nV3 DIFF:\n * Fixed final patch to properly conform command and process names to\n italic format, instead of the inline code format\n * Fixed typo that I forgot to change in v2\n\nLorenzoPegorari (3):\n doc: gitprotocol-pack: fix pronoun-antecedent agreement\n doc: gitprotocol-pack: improve paragraphs structure\n doc: gitprotocol-pack: normalize italic formatting\n\n Documentation/gitprotocol-pack.adoc | 18 ++++++++++--------\n 1 file changed, 10 insertions(+), 8 deletions(-)\n\nRange-diff against v2:\n1: 0d679e5eb5 = 1: 0d679e5eb5 doc: gitprotocol-pack: fix pronoun-antecedent agreement\n2: 8a6b5d4c98 = 2: 8a6b5d4c98 doc: gitprotocol-pack: improve paragraphs structure\n3: 6410967d65 ! 3: 2cf8a13eaf doc: gitprotocol-pack: normalize italic formatting\n @@ Documentation/gitprotocol-pack.adoc: two commands, or even just one of them.\n In an ssh:// format URI, it's absolute in the URI, so the '/' after\n the host name (or port number) is sent as an argument, which is then\n -read by the remote git-upload-pack exactly as is, so it's effectively\n -+read by the remote `git-upload-pack` exactly as is, so it's effectively\n ++read by the remote 'git-upload-pack' exactly as is, so it's effectively\n an absolute path in the remote filesystem.\n \n git clone ssh://user@example.com/project.git\n-- \n2.43.0\n\n"},{"id":"537636","messageId":"0d679e5eb514f33aed92f7fba4843efc53e6c461.1772502209.git.lorenzo.pegorari2002@gmail.com","threadId":"65120","inReplyTo":"cover.1772502209.git.lorenzo.pegorari2002@gmail.com","subject":"[GSoC PATCH v3 1/3] doc: gitprotocol-pack: fix pronoun-antecedent agreement","fromName":"LorenzoPegorari","fromEmail":"lorenzo.pegorari2002@gmail.com","sentAt":"2026-03-03T01:45:59Z","receivedAt":"2026-03-03T01:46:04Z","isPatch":true,"sender":{"key":"lorenzo.pegorari2002@gmail.com","avatar":"https://avatars.githubusercontent.com/u/132087553?v=4"},"body":"Fix \"pronoun-antecedent agreement\" errors.\n\nSigned-off-by: LorenzoPegorari \n---\n Documentation/gitprotocol-pack.adoc | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/gitprotocol-pack.adoc b/Documentation/gitprotocol-pack.adoc\nindex 837b691c89..9952fac188 100644\n--- a/Documentation/gitprotocol-pack.adoc\n+++ b/Documentation/gitprotocol-pack.adoc\n@@ -65,7 +65,7 @@ Extra Parameters\n ----------------\n \n The protocol provides a mechanism in which clients can send additional\n-information in its first message to the server. These are called \"Extra\n+information in their first message to the server. These are called \"Extra\n Parameters\", and are supported by the Git, SSH, and HTTP protocols.\n \n Each Extra Parameter takes the form of `=` or ``.\n@@ -277,7 +277,7 @@ out of what the server said it could do with the first 'want' line.\n filter-request = PKT-LINE(\"filter\" SP filter-spec)\n ----\n \n-Clients MUST send all the obj-ids it wants from the reference\n+Clients MUST send all the obj-ids they want from the reference\n discovery phase as 'want' lines. Clients MUST send at least one\n 'want' command in the request body. Clients MUST NOT mention an\n obj-id in a 'want' command which did not appear in the response\n-- \n2.43.0\n\n"},{"id":"537637","messageId":"8a6b5d4c98bd239e66faaaaf5883cbb50f1f1802.1772502209.git.lorenzo.pegorari2002@gmail.com","threadId":"65120","inReplyTo":"cover.1772502209.git.lorenzo.pegorari2002@gmail.com","subject":"[GSoC PATCH v3 2/3] doc: gitprotocol-pack: improve paragraphs structure","fromName":"LorenzoPegorari","fromEmail":"lorenzo.pegorari2002@gmail.com","sentAt":"2026-03-03T01:46:10Z","receivedAt":"2026-03-03T01:46:14Z","isPatch":true,"sender":{"key":"lorenzo.pegorari2002@gmail.com","avatar":"https://avatars.githubusercontent.com/u/132087553?v=4"},"body":"Logically separate the introductory sentence from the first transport\ndescription to improve readability and structural clarity.\n\nSigned-off-by: LorenzoPegorari \n---\n Documentation/gitprotocol-pack.adoc | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)\n\ndiff --git a/Documentation/gitprotocol-pack.adoc b/Documentation/gitprotocol-pack.adoc\nindex 9952fac188..f4c9e024b0 100644\n--- a/Documentation/gitprotocol-pack.adoc\n+++ b/Documentation/gitprotocol-pack.adoc\n@@ -47,7 +47,9 @@ process defined in this protocol is terminated.\n Transports\n ----------\n There are three transports over which the packfile protocol is\n-initiated. The Git transport is a simple, unauthenticated server that\n+initiated.\n+\n+The Git transport is a simple, unauthenticated server that\n takes the command (almost always 'upload-pack', though Git\n servers can be configured to be globally writable, in which 'receive-\n pack' initiation is also allowed) with which the client wishes to\n-- \n2.43.0\n\n"},{"id":"537638","messageId":"2cf8a13eafd7d99d5633da95d62acd0c28af8c68.1772502209.git.lorenzo.pegorari2002@gmail.com","threadId":"65120","inReplyTo":"cover.1772502209.git.lorenzo.pegorari2002@gmail.com","subject":"[GSoC PATCH v3 3/3] doc: gitprotocol-pack: normalize italic formatting","fromName":"LorenzoPegorari","fromEmail":"lorenzo.pegorari2002@gmail.com","sentAt":"2026-03-03T01:46:29Z","receivedAt":"2026-03-03T01:46:33Z","isPatch":true,"sender":{"key":"lorenzo.pegorari2002@gmail.com","avatar":"https://avatars.githubusercontent.com/u/132087553?v=4"},"body":"Uniform italic style usage for command and process names.\n\nSigned-off-by: LorenzoPegorari \n---\n Documentation/gitprotocol-pack.adoc | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/Documentation/gitprotocol-pack.adoc b/Documentation/gitprotocol-pack.adoc\nindex f4c9e024b0..633deecf2d 100644\n--- a/Documentation/gitprotocol-pack.adoc\n+++ b/Documentation/gitprotocol-pack.adoc\n@@ -117,7 +117,7 @@ process on the server side over the Git protocol is this:\n SSH Transport\n -------------\n \n-Initiating the upload-pack or receive-pack processes over SSH is\n+Initiating the 'upload-pack' or 'receive-pack' processes over SSH is\n executing the binary on the server via SSH remote execution.\n It is basically equivalent to running this:\n \n@@ -131,7 +131,7 @@ two commands, or even just one of them.\n \n In an ssh:// format URI, it's absolute in the URI, so the '/' after\n the host name (or port number) is sent as an argument, which is then\n-read by the remote git-upload-pack exactly as is, so it's effectively\n+read by the remote 'git-upload-pack' exactly as is, so it's effectively\n an absolute path in the remote filesystem.\n \n git clone ssh://user@example.com/project.git\n@@ -163,7 +163,7 @@ supports passing environment variables as an argument.\n \n A few things to remember here:\n \n-- The \"command name\" is spelled with dash (e.g. git-upload-pack), but\n+- The \"command name\" is spelled with dash (e.g. 'git-upload-pack'), but\n this can be overridden by the client;\n \n - The repository path is always quoted with single quotes.\n@@ -377,10 +377,10 @@ In multi_ack_detailed mode:\n \n Without either multi_ack or multi_ack_detailed:\n \n- * upload-pack sends \"ACK obj-id\" on the first common object it finds.\n+ * 'upload-pack' sends \"ACK obj-id\" on the first common object it finds.\n After that it says nothing until the client gives it a \"done\".\n \n- * upload-pack sends \"NAK\" on a flush-pkt if no common object\n+ * 'upload-pack' sends \"NAK\" on a flush-pkt if no common object\n has been found yet. If one has been found, and thus an ACK\n was already sent, it's silent on the flush-pkt.\n \n-- \n2.43.0\n\n"},{"id":"537639","messageId":"xmqqv7fdvg2g.fsf@gitster.g","threadId":"65120","inReplyTo":"aaY4tQzdEGE0hfvB@lorenzo-VM","subject":"Re: [GSoC PATCH 3/3] doc: gitprotocol-pack: normalize inline code formatting","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-03-03T01:48:23Z","receivedAt":"2026-03-03T01:48:26Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Lorenzo Pegorari writes:\n\n>> > -Initiating the upload-pack or receive-pack processes over SSH is\n>> > +Initiating the 'upload-pack' or 'receive-pack' processes over SSH is\n>> \n>> These are not `backquoted` for teletype text typesetting,\n>> like the other hunks in this patch do?\n>> \n>> All other things in these three patches I found them reasonable,\n>> except for this hunk.\n>> \n>> Thanks.\n>\n> Thank you so much for catching all my mistakes Junio.\n>\n> I misread the existing formatting: I mistook the apostrophes for\n> backticks, and so I incorrectly assumed that the document used inline\n> code for command and process names. In reality, the rest of the document\n> uses italics for these elements.\n>\n> I'm sending a v2 where I correctly uniform command and process names to\n> use the italic style ASAP.\n\nSorry but I am confused. \n\nI am not sure we want emphasis for most of these things;\nwhen we spell names of commands that users would type literally, in\nwhich case we would do the monospaced, no?\n\nI may be way off, though. I'd appreciate our Doc experts to inject\na bit of sanity.\n\nThanks.\n\n\n\n\n\n"}]}