{"thread":{"id":"65079","subject":"[PATCH] gitk: support config the color of linkfgcolor via Gitk Preferences","startedAt":"2026-02-26T12:33:18Z","lastAt":"2026-03-01T10:30:23Z","messageCount":10,"participants":["Gary Wang via GitGitGadget","Junio C Hamano","Johannes Sixt","Wang Zichong"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"537183","messageId":"pull.2217.git.git.1772109195114.gitgitgadget@gmail.com","threadId":"65079","inReplyTo":null,"subject":"[PATCH] gitk: support config the color of linkfgcolor via Gitk Preferences","fromName":"Gary Wang via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2026-02-26T12:33:15Z","receivedAt":"2026-02-26T12:33:18Z","isPatch":true,"sender":{"key":"name:Gary Wang","avatar":null},"body":"From: Wang Zichong \n\nAs a dark-theme user, I use the Preferences dialog to set colors\nfor gitk, the only color I cannot change via that dialog is the\nlink foreground color, which will lead me to use the default link\ncolor on a dark background that make it not really readable.\n\nThis patch makes the link foreground color also configurable in the\nGitk Preferences dialog's Color tab, so user won't need to dig into\nthe code/manual to know if the link color is configurable and can\nsimply set the color there.\n\nCC: Mark Levedahl , Paul Mackerras \nSigned-off-by: Wang Zichong \n---\n gitk: support config the color of linkfgcolor via Gitk Preferences\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2217%2FBLumia%2Fgitk-linkfgcolor-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2217/BLumia/gitk-linkfgcolor-v1\nPull-Request: https://github.com/git/git/pull/2217\n\n gitk-git/gitk | 10 ++++++++--\n 1 file changed, 8 insertions(+), 2 deletions(-)\n\ndiff --git a/gitk-git/gitk b/gitk-git/gitk\nindex cbaaee994e..b60f140636 100755\n--- a/gitk-git/gitk\n+++ b/gitk-git/gitk\n@@ -11796,7 +11796,7 @@ proc prefspage_general {notebook} {\n \n proc prefspage_colors {notebook} {\n global bgcolor fgcolor ctext diffcolors selectbgcolor markbgcolor\n- global diffbgcolors\n+ global diffbgcolors linkfgcolor\n global themeloader\n \n set page [create_prefs_page $notebook.colors]\n@@ -11873,6 +11873,11 @@ proc prefspage_colors {notebook} {\n -command [list choosecolor selectbgcolor {} $page [mc \"background\"]]\n grid x $page.selbgbut $page.selbgsep -sticky w\n \n+ label $page.linkfg -padx 40 -relief sunk -background $linkfgcolor\n+ ttk::button $page.linkfgbut -text [mc \"Link color\"] \\\n+ -command [list choosecolor linkfgcolor {} $page [mc \"link color\"]]\n+ grid x $page.linkfgbut $page.linkfg -sticky w\n+\n grid columnconfigure $page 2 -weight 1\n \n return $page\n@@ -11880,7 +11885,7 @@ proc prefspage_colors {notebook} {\n \n proc prefspage_set_colorswatches {page} {\n global bgcolor fgcolor ctext diffcolors selectbgcolor markbgcolor\n- global diffbgcolors\n+ global diffbgcolors linkfgcolor\n \n $page.bg configure -background $bgcolor\n $page.fg configure -background $fgcolor\n@@ -11891,6 +11896,7 @@ proc prefspage_set_colorswatches {page} {\n $page.hunksep configure -background [lindex $diffcolors 2]\n $page.markbgsep configure -background $markbgcolor\n $page.selbgsep configure -background $selectbgcolor\n+ $page.linkfg configure -background $linkfgcolor\n }\n \n proc prefspage_fonts {notebook} {\n\nbase-commit: 7b2bccb0d58d4f24705bf985de1f4612e4cf06e5\n-- \ngitgitgadget\n"},{"id":"537197","messageId":"xmqqecm75xym.fsf@gitster.g","threadId":"65079","inReplyTo":"pull.2217.git.git.1772109195114.gitgitgadget@gmail.com","subject":"Re: [PATCH] gitk: support config the color of linkfgcolor via Gitk Preferences","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-02-26T15:25:05Z","receivedAt":"2026-02-26T15:25:07Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Gary Wang via GitGitGadget\" writes:\n\n> From: Wang Zichong \n>\n> As a dark-theme user, I use the Preferences dialog to set colors\n> for gitk, the only color I cannot change via that dialog is the\n> link foreground color, which will lead me to use the default link\n> color on a dark background that make it not really readable.\n>\n> This patch makes the link foreground color also configurable in the\n> Gitk Preferences dialog's Color tab, so user won't need to dig into\n> the code/manual to know if the link color is configurable and can\n> simply set the color there.\n>\n> CC: Mark Levedahl , Paul Mackerras \n> Signed-off-by: Wang Zichong \n> ---\n> gitk: support config the color of linkfgcolor via Gitk Preferences\n>\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2217%2FBLumia%2Fgitk-linkfgcolor-v1\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2217/BLumia/gitk-linkfgcolor-v1\n> Pull-Request: https://github.com/git/git/pull/2217\n>\n> gitk-git/gitk | 10 ++++++++--\n> 1 file changed, 8 insertions(+), 2 deletions(-)\n>\n> diff --git a/gitk-git/gitk b/gitk-git/gitk\n> index cbaaee994e..b60f140636 100755\n> --- a/gitk-git/gitk\n> +++ b/gitk-git/gitk\n> @@ -11796,7 +11796,7 @@ proc prefspage_general {notebook} {\n> \n> proc prefspage_colors {notebook} {\n> global bgcolor fgcolor ctext diffcolors selectbgcolor markbgcolor\n> - global diffbgcolors\n> + global diffbgcolors linkfgcolor\n> global themeloader\n> \n> set page [create_prefs_page $notebook.colors]\n> @@ -11873,6 +11873,11 @@ proc prefspage_colors {notebook} {\n> -command [list choosecolor selectbgcolor {} $page [mc \"background\"]]\n> grid x $page.selbgbut $page.selbgsep -sticky w\n> \n> + label $page.linkfg -padx 40 -relief sunk -background $linkfgcolor\n> + ttk::button $page.linkfgbut -text [mc \"Link color\"] \\\n> + -command [list choosecolor linkfgcolor {} $page [mc \"link color\"]]\n> + grid x $page.linkfgbut $page.linkfg -sticky w\n> +\n> grid columnconfigure $page 2 -weight 1\n> \n> return $page\n> @@ -11880,7 +11885,7 @@ proc prefspage_colors {notebook} {\n> \n> proc prefspage_set_colorswatches {page} {\n> global bgcolor fgcolor ctext diffcolors selectbgcolor markbgcolor\n> - global diffbgcolors\n> + global diffbgcolors linkfgcolor\n> \n> $page.bg configure -background $bgcolor\n> $page.fg configure -background $fgcolor\n> @@ -11891,6 +11896,7 @@ proc prefspage_set_colorswatches {page} {\n> $page.hunksep configure -background [lindex $diffcolors 2]\n> $page.markbgsep configure -background $markbgcolor\n> $page.selbgsep configure -background $selectbgcolor\n> + $page.linkfg configure -background $linkfgcolor\n> }\n> \n> proc prefspage_fonts {notebook} {\n>\n> base-commit: 7b2bccb0d58d4f24705bf985de1f4612e4cf06e5\n"},{"id":"537276","messageId":"ffd58cd5-811b-4ebf-8572-cca681ec9bf7@kdbg.org","threadId":"65079","inReplyTo":"pull.2217.git.git.1772109195114.gitgitgadget@gmail.com","subject":"Re: [PATCH] gitk: support config the color of linkfgcolor via Gitk Preferences","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2026-02-27T07:37:20Z","receivedAt":"2026-02-27T08:18:19Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Am 26.02.26 um 13:33 schrieb Gary Wang via GitGitGadget:\n> From: Wang Zichong \n> \n> As a dark-theme user, I use the Preferences dialog to set colors\n> for gitk, the only color I cannot change via that dialog is the\n> link foreground color, which will lead me to use the default link\n> color on a dark background that make it not really readable.\n> \n> This patch makes the link foreground color also configurable in the\n> Gitk Preferences dialog's Color tab, so user won't need to dig into\n> the code/manual to know if the link color is configurable and can\n> simply set the color there.\n\nMakes sense.\n\nOur usual style is to not say \"This patch does X to...\", but to write in\nimperative mood \"Do X to...\".\n\n> \n> CC: Mark Levedahl , Paul Mackerras \n> Signed-off-by: Wang Zichong \n> ---\n> gitk: support config the color of linkfgcolor via Gitk Preferences\n\nIn the subject line, perhaps:\n\n gitk: support link color in the Preferences dialog\n\n> + label $page.linkfg -padx 40 -relief sunk -background $linkfgcolor\n> + ttk::button $page.linkfgbut -text [mc \"Link color\"] \\\n> + -command [list choosecolor linkfgcolor {} $page [mc \"link color\"]]\n\nThis text \"link color\" is used in the title of the color selection\ndialog. It then reads awkwardly \"Gitk: choose color for link color\".\nLet's just use the text \"links\" for this purpose, and then also just\n\"Links\" as the label on the button.\n\n> @@ -11891,6 +11896,7 @@ proc prefspage_set_colorswatches {page} {\n> $page.hunksep configure -background [lindex $diffcolors 2]\n> $page.markbgsep configure -background $markbgcolor\n> $page.selbgsep configure -background $selectbgcolor\n> + $page.linkfg configure -background $linkfgcolor\n\nThe variable's value is already serialized in the configuration and\nneeds no additional treatment. Good.\n\n-- Hannes\n\n"},{"id":"537302","messageId":"xmqq8qcet9ln.fsf@gitster.g","threadId":"65079","inReplyTo":"ffd58cd5-811b-4ebf-8572-cca681ec9bf7@kdbg.org","subject":"Re: [PATCH] gitk: support config the color of linkfgcolor via Gitk Preferences","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-02-27T16:49:40Z","receivedAt":"2026-02-27T16:49:43Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Sixt writes:\n\n> Am 26.02.26 um 13:33 schrieb Gary Wang via GitGitGadget:\n>> From: Wang Zichong \n>> \n>> As a dark-theme user, I use the Preferences dialog to set colors\n>> for gitk, the only color I cannot change via that dialog is the\n>> link foreground color, which will lead me to use the default link\n>> color on a dark background that make it not really readable.\n>> \n>> This patch makes the link foreground color also configurable in the\n>> Gitk Preferences dialog's Color tab, so user won't need to dig into\n>> the code/manual to know if the link color is configurable and can\n>> simply set the color there.\n>\n> Makes sense.\n>\n> Our usual style is to not say \"This patch does X to...\", but to write in\n> imperative mood \"Do X to...\".\n\nA bit of tangent, but I wonder if it would help new comers if we add\nwhat I sometimes send (e.g., a recent one found in\n\n https://lore.kernel.org/git/xmqq343ehu4o.fsf@gitster.g/\n\n) somewhere more prominent, like MyFirstContribution?\n\n>> CC: Mark Levedahl , Paul Mackerras \n\nIt is unusual to see multiple people listed on a single Cc: trailer.\n\n>> Signed-off-by: Wang Zichong \n>> ---\n>> gitk: support config the color of linkfgcolor via Gitk Preferences\n>\n> In the subject line, perhaps:\n>\n> gitk: support link color in the Preferences dialog\n>\n>> + label $page.linkfg -padx 40 -relief sunk -background $linkfgcolor\n>> + ttk::button $page.linkfgbut -text [mc \"Link color\"] \\\n>> + -command [list choosecolor linkfgcolor {} $page [mc \"link color\"]]\n>\n> This text \"link color\" is used in the title of the color selection\n> dialog. It then reads awkwardly \"Gitk: choose color for link color\".\n> Let's just use the text \"links\" for this purpose, and then also just\n> \"Links\" as the label on the button.\n>\n>> @@ -11891,6 +11896,7 @@ proc prefspage_set_colorswatches {page} {\n>> $page.hunksep configure -background [lindex $diffcolors 2]\n>> $page.markbgsep configure -background $markbgcolor\n>> $page.selbgsep configure -background $selectbgcolor\n>> + $page.linkfg configure -background $linkfgcolor\n>\n> The variable's value is already serialized in the configuration and\n> needs no additional treatment. Good.\n>\n> -- Hannes\n"},{"id":"537371","messageId":"3FA6BA9ACF1B34AF+20260228033725.2546976-1-wangzichong@deepin.org","threadId":"65079","inReplyTo":"xmqq8qcet9ln.fsf@gitster.g","subject":"Re: [PATCH] gitk: support config the color of linkfgcolor via Gitk Preferences","fromName":"Wang Zichong","fromEmail":"wangzichong@deepin.org","sentAt":"2026-02-28T03:37:25Z","receivedAt":"2026-02-28T03:38:23Z","isPatch":true,"sender":{"key":"wangzichong@deepin.org","avatar":null},"body":">> Our usual style is to not say \"This patch does X to...\", but to write in\n>> imperative mood \"Do X to...\".\n>\n>A bit of tangent, but I wonder if it would help new comers if we add\n>what I sometimes send (e.g., a recent one found in\n>\n> https://lore.kernel.org/git/xmqq343ehu4o.fsf@gitster.g/\n>\n>) somewhere more prominent, like MyFirstContribution?\n\nAgree!\n\n>>> CC: Mark Levedahl , Paul Mackerras \n>\n>It is unusual to see multiple people listed on a single Cc: trailer.\n\nThis usage is actually from the example provided at GitGitGadget's\nlanding page:\n\n https://gitgitgadget.github.io/\n\nIf writing multiple CC trailers is preferred, maybe we also need to update\nGitGitGadget's documentation as well.\n\n-- Gary\n"},{"id":"537372","messageId":"pull.2217.v2.git.git.1772251558434.gitgitgadget@gmail.com","threadId":"65079","inReplyTo":"pull.2217.git.git.1772109195114.gitgitgadget@gmail.com","subject":"[PATCH v2] gitk: support link color in the Preferences dialog","fromName":"Gary Wang via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2026-02-28T04:05:58Z","receivedAt":"2026-02-28T04:06:00Z","isPatch":true,"sender":{"key":"name:Gary Wang","avatar":null},"body":"From: Wang Zichong \n\nAs a dark-theme user, I use the Preferences dialog to set colors\nfor gitk. The only color I cannot change via that dialog is the\nlink foreground color, which leads to using the default link color\non a dark background that makes it hard to read.\n\nMake the link foreground color also configurable in the Gitk\nPreferences dialog's Color tab, so users won't need to dig into\nthe code/manual to check if it is configurable and can simply set\nthe color there.\n\nCC: Mark Levedahl \nCC: Paul Mackerras \nCC: Johannes Sixt \nSigned-off-by: Wang Zichong \n---\n gitk: support config the color of linkfgcolor via Gitk Preferences\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2217%2FBLumia%2Fgitk-linkfgcolor-v2\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2217/BLumia/gitk-linkfgcolor-v2\nPull-Request: https://github.com/git/git/pull/2217\n\nRange-diff vs v1:\n\n 1: d5d8897fbb ! 1: f533af7ac5 gitk: support config the color of linkfgcolor via Gitk Preferences\n @@ Metadata\n Author: Wang Zichong \n \n ## Commit message ##\n - gitk: support config the color of linkfgcolor via Gitk Preferences\n + gitk: support link color in the Preferences dialog\n \n As a dark-theme user, I use the Preferences dialog to set colors\n - for gitk, the only color I cannot change via that dialog is the\n - link foreground color, which will lead me to use the default link\n - color on a dark background that make it not really readable.\n + for gitk. The only color I cannot change via that dialog is the\n + link foreground color, which leads to using the default link color\n + on a dark background that makes it hard to read.\n \n - This patch makes the link foreground color also configurable in the\n - Gitk Preferences dialog's Color tab, so user won't need to dig into\n - the code/manual to know if the link color is configurable and can\n - simply set the color there.\n + Make the link foreground color also configurable in the Gitk\n + Preferences dialog's Color tab, so users won't need to dig into\n + the code/manual to check if it is configurable and can simply set\n + the color there.\n \n - CC: Mark Levedahl , Paul Mackerras \n + CC: Mark Levedahl \n + CC: Paul Mackerras \n + CC: Johannes Sixt \n Signed-off-by: Wang Zichong \n + ---\n + Changelog (v2):\n +\n + * reword commit message as suggesed by Johannes\n + * Rename button text from \"link color\" to \"link\" as suggested\n + by Johannes\n \n ## gitk-git/gitk ##\n @@ gitk-git/gitk: proc prefspage_general {notebook} {\n @@ gitk-git/gitk: proc prefspage_colors {notebook} {\n grid x $page.selbgbut $page.selbgsep -sticky w\n \n + label $page.linkfg -padx 40 -relief sunk -background $linkfgcolor\n -+ ttk::button $page.linkfgbut -text [mc \"Link color\"] \\\n -+ -command [list choosecolor linkfgcolor {} $page [mc \"link color\"]]\n ++ ttk::button $page.linkfgbut -text [mc \"Link\"] \\\n ++ -command [list choosecolor linkfgcolor {} $page [mc \"link\"]]\n + grid x $page.linkfgbut $page.linkfg -sticky w\n +\n grid columnconfigure $page 2 -weight 1\n\n\nChangelog (v2):\n\n * reword commit message as suggesed by Johannes\n * Rename button text from \"link color\" to \"link\" as suggested\n by Johannes\n---\n gitk-git/gitk | 10 ++++++++--\n 1 file changed, 8 insertions(+), 2 deletions(-)\n\ndiff --git a/gitk-git/gitk b/gitk-git/gitk\nindex cbaaee994e..1c289174d5 100755\n--- a/gitk-git/gitk\n+++ b/gitk-git/gitk\n@@ -11796,7 +11796,7 @@ proc prefspage_general {notebook} {\n \n proc prefspage_colors {notebook} {\n global bgcolor fgcolor ctext diffcolors selectbgcolor markbgcolor\n- global diffbgcolors\n+ global diffbgcolors linkfgcolor\n global themeloader\n \n set page [create_prefs_page $notebook.colors]\n@@ -11873,6 +11873,11 @@ proc prefspage_colors {notebook} {\n -command [list choosecolor selectbgcolor {} $page [mc \"background\"]]\n grid x $page.selbgbut $page.selbgsep -sticky w\n \n+ label $page.linkfg -padx 40 -relief sunk -background $linkfgcolor\n+ ttk::button $page.linkfgbut -text [mc \"Link\"] \\\n+ -command [list choosecolor linkfgcolor {} $page [mc \"link\"]]\n+ grid x $page.linkfgbut $page.linkfg -sticky w\n+\n grid columnconfigure $page 2 -weight 1\n \n return $page\n@@ -11880,7 +11885,7 @@ proc prefspage_colors {notebook} {\n \n proc prefspage_set_colorswatches {page} {\n global bgcolor fgcolor ctext diffcolors selectbgcolor markbgcolor\n- global diffbgcolors\n+ global diffbgcolors linkfgcolor\n \n $page.bg configure -background $bgcolor\n $page.fg configure -background $fgcolor\n@@ -11891,6 +11896,7 @@ proc prefspage_set_colorswatches {page} {\n $page.hunksep configure -background [lindex $diffcolors 2]\n $page.markbgsep configure -background $markbgcolor\n $page.selbgsep configure -background $selectbgcolor\n+ $page.linkfg configure -background $linkfgcolor\n }\n \n proc prefspage_fonts {notebook} {\n\nbase-commit: 7b2bccb0d58d4f24705bf985de1f4612e4cf06e5\n-- \ngitgitgadget\n"},{"id":"537377","messageId":"8526ae9b-804b-4f39-b5bd-1a8971cc7d6c@kdbg.org","threadId":"65079","inReplyTo":"3FA6BA9ACF1B34AF+20260228033725.2546976-1-wangzichong@deepin.org","subject":"Re: [PATCH] gitk: support config the color of linkfgcolor via Gitk Preferences","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2026-02-28T07:51:01Z","receivedAt":"2026-02-28T07:51:20Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Am 28.02.26 um 04:37 schrieb Wang Zichong:\n> This usage is actually from the example provided at GitGitGadget's\n> landing page:\n> \n> https://gitgitgadget.github.io/\n> \n> If writing multiple CC trailers is preferred, maybe we also need to update\n> GitGitGadget's documentation as well.\nThis page says:\n\n\"You can CC potential reviewers by adding a footer to the PR description...\"\n\nThe commit message is not the PR description. Please don't add Cc lines\nto the commit message. Edit the PR description on Github before you\n/submit the patches with GitGitGadget.\n\n-- Hannes\n\n"},{"id":"537378","messageId":"pull.2217.v3.git.git.1772265584806.gitgitgadget@gmail.com","threadId":"65079","inReplyTo":"pull.2217.v2.git.git.1772251558434.gitgitgadget@gmail.com","subject":"[PATCH v3] gitk: support link color in the Preferences dialog","fromName":"Gary Wang via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2026-02-28T07:59:44Z","receivedAt":"2026-02-28T07:59:47Z","isPatch":true,"sender":{"key":"name:Gary Wang","avatar":null},"body":"From: Wang Zichong \n\nAs a dark-theme user, I use the Preferences dialog to set colors\nfor gitk. The only color I cannot change via that dialog is the\nlink foreground color, which leads to using the default link color\non a dark background that makes it hard to read.\n\nMake the link foreground color also configurable in the Gitk\nPreferences dialog's Color tab, so users won't need to dig into\nthe code/manual to check if it is configurable and can simply set\nthe color there.\n\nSigned-off-by: Wang Zichong \n---\n gitk: support config the color of linkfgcolor via Gitk Preferences\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2217%2FBLumia%2Fgitk-linkfgcolor-v3\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2217/BLumia/gitk-linkfgcolor-v3\nPull-Request: https://github.com/git/git/pull/2217\n\nRange-diff vs v2:\n\n 1: f533af7ac5 ! 1: a2be1c0441 gitk: support link color in the Preferences dialog\n @@ Commit message\n the code/manual to check if it is configurable and can simply set\n the color there.\n \n - CC: Mark Levedahl \n - CC: Paul Mackerras \n - CC: Johannes Sixt \n Signed-off-by: Wang Zichong \n ---\n - Changelog (v2):\n + Changelog (v3):\n \n - * reword commit message as suggesed by Johannes\n - * Rename button text from \"link color\" to \"link\" as suggested\n - by Johannes\n + * Remove CC list from commit message as suggested by Hannes\n \n ## gitk-git/gitk ##\n @@ gitk-git/gitk: proc prefspage_general {notebook} {\n\n\nChangelog (v3):\n\n * Remove CC list from commit message as suggested by Hannes\n---\n gitk-git/gitk | 10 ++++++++--\n 1 file changed, 8 insertions(+), 2 deletions(-)\n\ndiff --git a/gitk-git/gitk b/gitk-git/gitk\nindex cbaaee994e..1c289174d5 100755\n--- a/gitk-git/gitk\n+++ b/gitk-git/gitk\n@@ -11796,7 +11796,7 @@ proc prefspage_general {notebook} {\n \n proc prefspage_colors {notebook} {\n global bgcolor fgcolor ctext diffcolors selectbgcolor markbgcolor\n- global diffbgcolors\n+ global diffbgcolors linkfgcolor\n global themeloader\n \n set page [create_prefs_page $notebook.colors]\n@@ -11873,6 +11873,11 @@ proc prefspage_colors {notebook} {\n -command [list choosecolor selectbgcolor {} $page [mc \"background\"]]\n grid x $page.selbgbut $page.selbgsep -sticky w\n \n+ label $page.linkfg -padx 40 -relief sunk -background $linkfgcolor\n+ ttk::button $page.linkfgbut -text [mc \"Link\"] \\\n+ -command [list choosecolor linkfgcolor {} $page [mc \"link\"]]\n+ grid x $page.linkfgbut $page.linkfg -sticky w\n+\n grid columnconfigure $page 2 -weight 1\n \n return $page\n@@ -11880,7 +11885,7 @@ proc prefspage_colors {notebook} {\n \n proc prefspage_set_colorswatches {page} {\n global bgcolor fgcolor ctext diffcolors selectbgcolor markbgcolor\n- global diffbgcolors\n+ global diffbgcolors linkfgcolor\n \n $page.bg configure -background $bgcolor\n $page.fg configure -background $fgcolor\n@@ -11891,6 +11896,7 @@ proc prefspage_set_colorswatches {page} {\n $page.hunksep configure -background [lindex $diffcolors 2]\n $page.markbgsep configure -background $markbgcolor\n $page.selbgsep configure -background $selectbgcolor\n+ $page.linkfg configure -background $linkfgcolor\n }\n \n proc prefspage_fonts {notebook} {\n\nbase-commit: 7b2bccb0d58d4f24705bf985de1f4612e4cf06e5\n-- \ngitgitgadget\n"},{"id":"537379","messageId":"03C4B4FC7F6D3C97+20260228080212.3338436-1-wangzichong@deepin.org","threadId":"65079","inReplyTo":"8526ae9b-804b-4f39-b5bd-1a8971cc7d6c@kdbg.org","subject":"Re: [PATCH] gitk: support config the color of linkfgcolor via Gitk Preferences","fromName":"Wang Zichong","fromEmail":"wangzichong@deepin.org","sentAt":"2026-02-28T08:02:12Z","receivedAt":"2026-02-28T08:03:06Z","isPatch":true,"sender":{"key":"wangzichong@deepin.org","avatar":null},"body":"> This page says:\n>\n> \"You can CC potential reviewers by adding a footer to the PR description...\"\n>\n> The commit message is not the PR description. Please don't add Cc lines\n> to the commit message. Edit the PR description on Github before you\n> /submit the patches with GitGitGadget.\n>\n> -- Hannes\n\nSorry! Patch now updated with CC removed from commit message and moved to PR\ndescription.\n\n-- Gary\n"},{"id":"537431","messageId":"a8dff43f-0454-40a5-93b1-aeb7cab8e9c4@kdbg.org","threadId":"65079","inReplyTo":"pull.2217.v3.git.git.1772265584806.gitgitgadget@gmail.com","subject":"Re: [PATCH v3] gitk: support link color in the Preferences dialog","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2026-03-01T10:30:12Z","receivedAt":"2026-03-01T10:30:23Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Thanks, queued.\n\n-- Hannes\n\n"}]}