{"thread":{"id":"65048","subject":"[PATCH] merge-base, ls-remote, ls-tree: fix error message formatting","startedAt":"2026-02-23T08:56:22Z","lastAt":"2026-02-23T08:56:22Z","messageCount":1,"participants":["Md Ferdous Alam via GitGitGadget"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"536713","messageId":"pull.2053.git.1771836979176.gitgitgadget@gmail.com","threadId":"65048","inReplyTo":null,"subject":"[PATCH] merge-base, ls-remote, ls-tree: fix error message formatting","fromName":"Md Ferdous Alam via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2026-02-23T08:56:19Z","receivedAt":"2026-02-23T08:56:22Z","isPatch":true,"sender":{"key":"name:Md Ferdous Alam","avatar":null},"body":"From: mdferdousalam <mdferdousalam1989@yahoo.com>\n\nThe CodingGuidelines state that error messages should not begin\nwith a capital letter and should not end with a full stop.  Fix\nthe die() messages in builtin/merge-base.c, builtin/ls-remote.c,\nand builtin/ls-tree.c that violate these rules.\n\nSigned-off-by: mdferdousalam <mdferdousalam1989@yahoo.com>\n---\n    merge-base, ls-remote, ls-tree: fix error message formatting\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-2053%2Fmdferdousalam%2Ffix-error-messages-misc-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2053/mdferdousalam/fix-error-messages-misc-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/2053\n\n builtin/ls-remote.c  | 2 +-\n builtin/ls-tree.c    | 2 +-\n builtin/merge-base.c | 6 +++---\n 3 files changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/builtin/ls-remote.c b/builtin/ls-remote.c\nindex fe77829557..51d7579ca1 100644\n--- a/builtin/ls-remote.c\n+++ b/builtin/ls-remote.c\n@@ -128,7 +128,7 @@ int cmd_ls_remote(int argc,\n \tif (!remote) {\n \t\tif (dest)\n \t\t\tdie(\"bad repository '%s'\", dest);\n-\t\tdie(\"No remote configured to list refs from.\");\n+\t\tdie(\"no remote configured to list refs from\");\n \t}\n \n \tif (get_url) {\ndiff --git a/builtin/ls-tree.c b/builtin/ls-tree.c\nindex 113e4a960d..7670aa77a3 100644\n--- a/builtin/ls-tree.c\n+++ b/builtin/ls-tree.c\n@@ -406,7 +406,7 @@ int cmd_ls_tree(int argc,\n \t\tusage_with_options(ls_tree_usage, ls_tree_options);\n \tif (repo_get_oid_with_flags(the_repository, argv[0], &oid,\n \t\t\t\t    GET_OID_HASH_ANY))\n-\t\tdie(\"Not a valid object name %s\", argv[0]);\n+\t\tdie(\"not a valid object name %s\", argv[0]);\n \n \t/*\n \t * show_recursive() rolls its own matching code and is\ndiff --git a/builtin/merge-base.c b/builtin/merge-base.c\nindex c7ee97fa6a..e337f283f7 100644\n--- a/builtin/merge-base.c\n+++ b/builtin/merge-base.c\n@@ -47,10 +47,10 @@ static struct commit *get_commit_reference(const char *arg)\n \tstruct commit *r;\n \n \tif (repo_get_oid(the_repository, arg, &revkey))\n-\t\tdie(\"Not a valid object name %s\", arg);\n+\t\tdie(\"not a valid object name %s\", arg);\n \tr = lookup_commit_reference(the_repository, &revkey);\n \tif (!r)\n-\t\tdie(\"Not a valid commit name %s\", arg);\n+\t\tdie(\"not a valid commit name %s\", arg);\n \n \treturn r;\n }\n@@ -131,7 +131,7 @@ static int handle_fork_point(int argc, const char **argv)\n \n \tcommitname = (argc == 2) ? argv[1] : \"HEAD\";\n \tif (repo_get_oid(the_repository, commitname, &oid))\n-\t\tdie(\"Not a valid object name: '%s'\", commitname);\n+\t\tdie(\"not a valid object name: '%s'\", commitname);\n \n \tderived = lookup_commit_reference(the_repository, &oid);\n \n\nbase-commit: 7c02d39fc2ed2702223c7674f73150d9a7e61ba4\n-- \ngitgitgadget\n"}]}