{"thread":{"id":"64950","subject":"[PATCH] version: stop using the_repository","startedAt":"2026-02-08T17:01:26Z","lastAt":"2026-02-09T09:24:23Z","messageCount":2,"participants":["René Scharfe","Patrick Steinhardt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"535483","messageId":"afccdc3a-8672-49a7-b260-e77e617d8976@web.de","threadId":"64950","inReplyTo":null,"subject":"[PATCH] version: stop using the_repository","fromName":"René Scharfe","fromEmail":"l.s.r@web.de","sentAt":"2026-02-08T17:01:24Z","receivedAt":"2026-02-08T17:01:26Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"Actually it has never been used in version.c since cf7ee481902 (agent:\nadvertise OS name via agent capability, 2025-02-15) added the dependency\nmacro.  Remove it, along with the also unused struct declaration.\n\nSigned-off-by: René Scharfe <l.s.r@web.de>\n---\n version.c | 2 --\n version.h | 2 --\n 2 files changed, 4 deletions(-)\n\ndiff --git a/version.c b/version.c\nindex 279269cc50..21ec7c0fbe 100644\n--- a/version.c\n+++ b/version.c\n@@ -1,5 +1,3 @@\n-#define USE_THE_REPOSITORY_VARIABLE\n-\n #include \"git-compat-util.h\"\n #include \"version.h\"\n #include \"strbuf.h\"\ndiff --git a/version.h b/version.h\nindex bbde6d371a..7d502dcee0 100644\n--- a/version.h\n+++ b/version.h\n@@ -1,8 +1,6 @@\n #ifndef VERSION_H\n #define VERSION_H\n \n-struct repository;\n-\n extern const char git_version_string[];\n extern const char git_built_from_commit_string[];\n \n-- \n2.52.0\n"},{"id":"535509","messageId":"aYmnwcFFmbjE5UPe@pks.im","threadId":"64950","inReplyTo":"afccdc3a-8672-49a7-b260-e77e617d8976@web.de","subject":"Re: [PATCH] version: stop using the_repository","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2026-02-09T09:24:17Z","receivedAt":"2026-02-09T09:24:23Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Sun, Feb 08, 2026 at 06:01:24PM +0100, René Scharfe wrote:\n> Actually it has never been used in version.c since cf7ee481902 (agent:\n> advertise OS name via agent capability, 2025-02-15) added the dependency\n> macro.  Remove it, along with the also unused struct declaration.\n\nQuite straight forward, looks good to me. Thanks!\n\nPatrick\n"}]}