{"thread":{"id":"64889","subject":"[PATCH] .github/CONTRIBUTING.md: fix broken link to SubmittingPatches","startedAt":"2026-01-31T16:14:10Z","lastAt":"2026-02-01T00:27:08Z","messageCount":4,"participants":["Abdalrhman Mohamed","Junio C Hamano","Todd Zullinger"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"534916","messageId":"20260131161401.48693-1-Eng.Abdalrhman.Abdalmonem@gmail.com","threadId":"64889","inReplyTo":null,"subject":"[PATCH] .github/CONTRIBUTING.md: fix broken link to SubmittingPatches","fromName":"Abdalrhman Mohamed","fromEmail":"eng.abdalrhman.abdalmonem@gmail.com","sentAt":"2026-01-31T16:14:01Z","receivedAt":"2026-01-31T16:14:10Z","isPatch":true,"sender":{"key":"eng.abdalrhman.abdalmonem@gmail.com","avatar":null},"body":"The link to SubmittingPatches documentation was pointing to a\nnon-existent 'Documentation' branch. Correct it to point to the\n'master' branch so that new contributors on GitHub can find the\nsubmission guidelines.\n\nSigned-off-by: Abdalrhman Mohamed \n---\n .github/CONTRIBUTING.md | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md\nindex c8755e38de..e5d696fd42 100644\n--- a/.github/CONTRIBUTING.md\n+++ b/.github/CONTRIBUTING.md\n@@ -10,7 +10,7 @@ conveniently send your Pull Requests commits to our mailing list.\n \n Please read [\"A note from the maintainer\"](https://git.kernel.org/pub/scm/git/git.git/plain/MaintNotes?h=todo)\n to learn how the Git project is managed, and how you can work with it.\n-In addition, we highly recommend you to read [our submission guidelines](../Documentation/SubmittingPatches).\n+In addition, we highly recommend you to read [our submission guidelines](https://github.com/git/git/blob/master/Documentation/SubmittingPatches).\n \n If you prefer video, then [this talk](https://www.youtube.com/watch?v=Q7i_qQW__q4&feature=youtu.be&t=6m4s)\n might be useful to you as the presenter walks you through the contribution\n-- \n2.25.1\n\n"},{"id":"534925","messageId":"xmqqms1t4l4z.fsf@gitster.g","threadId":"64889","inReplyTo":"20260131161401.48693-1-Eng.Abdalrhman.Abdalmonem@gmail.com","subject":"Re: [PATCH] .github/CONTRIBUTING.md: fix broken link to SubmittingPatches","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-01-31T19:50:20Z","receivedAt":"2026-01-31T19:50:23Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Abdalrhman Mohamed writes:\n\n> -In addition, we highly recommend you to read [our submission guidelines](../Documentation/SubmittingPatches).\n> +In addition, we highly recommend you to read [our submission guidelines](https://github.com/git/git/blob/master/Documentation/SubmittingPatches).\n\nThe line is overly long already in the original; can we make it a\nbit more readable?\n\nAs to the contents, referring to our preformatted docs, like\n\n https://git.github.io/htmldocs/SubmittingPatches\n\nwould probably be more appropriate, no?\n"},{"id":"534927","messageId":"aX5sNO4aMVE-qcrz@teonanacatl.net","threadId":"64889","inReplyTo":"xmqqms1t4l4z.fsf@gitster.g","subject":"Re: [PATCH] .github/CONTRIBUTING.md: fix broken link to SubmittingPatches","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2026-01-31T20:55:16Z","receivedAt":"2026-01-31T20:55:18Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"Junio C Hamano wrote:\n> Abdalrhman Mohamed writes:\n> \n>> -In addition, we highly recommend you to read [our submission guidelines](../Documentation/SubmittingPatches).\n>> +In addition, we highly recommend you to read [our submission guidelines](https://github.com/git/git/blob/master/Documentation/SubmittingPatches).\n> \n> The line is overly long already in the original; can we make it a\n> bit more readable?\n> \n> As to the contents, referring to our preformatted docs, like\n> \n> https://git.github.io/htmldocs/SubmittingPatches\n> \n> would probably be more appropriate, no?\n\nA few lines below, the document links to git-scm.com/docs:\n\n Or, you can follow the [\"My First Contribution\"](https://git-scm.com/docs/MyFirstContribution)\n tutorial for another example of the contribution process.\n\nI didn't look at any discussion around b75a219904 (docs:\nmention MyFirstContribution in more places, 2020-06-08)\nwhere that was added. It would make sense to be consistent\nabout where the links point, e.g.:\n\n https://git-scm.com/docs/SubmittingPatches\n\nAs CONTRIBUTING.md is in the .github directory, it's\nprobably fine to link there for both. On the other hand,\nhaving more references to the upstream site might be good\nfor consistency across the various places the Git code is\nhosted. Maybe that increases the standing of git-scm.com in\nsearch rankings too, I don't know.\n\nWhatever the reasoning, it should probably apply to both\nlinks.\n\n-- \nTodd\n"},{"id":"534936","messageId":"20260201002658.133153-1-Eng.Abdalrhman.Abdalmonem@gmail.com","threadId":"64889","inReplyTo":"aX5sNO4aMVE-qcrz@teonanacatl.net","subject":"[PATCH v2] .github/CONTRIBUTING.md: link to SubmittingPatches on git-scm.com","fromName":"Abdalrhman Mohamed","fromEmail":"eng.abdalrhman.abdalmonem@gmail.com","sentAt":"2026-02-01T00:26:43Z","receivedAt":"2026-02-01T00:27:08Z","isPatch":true,"sender":{"key":"eng.abdalrhman.abdalmonem@gmail.com","avatar":null},"body":"The relative link to SubmittingPatches is broken when viewed through\nGitHub's specialized \"Contributing\" tab. Update the link to point to\nthe documentation on git-scm.com to be consistent with other links in\nthe same file. Also, wrap the line to improve readability.\n\nSigned-off-by: Abdalrhman Mohamed \n---\n .github/CONTRIBUTING.md | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)\n\ndiff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md\nindex c8755e38de..93042128d6 100644\n--- a/.github/CONTRIBUTING.md\n+++ b/.github/CONTRIBUTING.md\n@@ -10,7 +10,8 @@ conveniently send your Pull Requests commits to our mailing list.\n \n Please read [\"A note from the maintainer\"](https://git.kernel.org/pub/scm/git/git.git/plain/MaintNotes?h=todo)\n to learn how the Git project is managed, and how you can work with it.\n-In addition, we highly recommend you to read [our submission guidelines](../Documentation/SubmittingPatches).\n+In addition, we highly recommend you to read\n+[our submission guidelines](https://git-scm.com/docs/SubmittingPatches).\n \n If you prefer video, then [this talk](https://www.youtube.com/watch?v=Q7i_qQW__q4&feature=youtu.be&t=6m4s)\n might be useful to you as the presenter walks you through the contribution\n-- \n2.50.1\n\n"}]}