{"thread":{"id":"6473","subject":"[RESEND PATCH 1/3] Insert ACTIVESTATE_STRING in Git.pm","startedAt":"2007-01-22T17:11:11Z","lastAt":"2007-01-22T17:11:11Z","messageCount":1,"participants":["Alex Riesen"],"isPatch":true,"patchVersion":1,"patchTotal":3},"messages":[{"id":"32310","messageId":"81b0412b0701220911r27dcc98j733012c31b84f443@mail.gmail.com","threadId":"6473","inReplyTo":null,"subject":"[RESEND PATCH 1/3] Insert ACTIVESTATE_STRING in Git.pm","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2007-01-22T17:11:11Z","receivedAt":"2007-01-22T17:11:11Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"Also add \"git\" to the pipe parameters, otherwise it does not work at all, as\nno git commands are usable out of git context.\n\nSigned-off-by: Alex Riesen <raa.lkml@gmail.com>\n---\n perl/Git.pm |    7 ++++---\n 1 files changed, 4 insertions(+), 3 deletions(-)\n\n\nFrom 12d5d319ac8643d43db4a7273832f67fa55ef750 Mon Sep 17 00:00:00 2001\nFrom: Alex Riesen <raa.lkml@gmail.com>\nDate: Mon, 22 Jan 2007 17:14:56 +0100\nSubject: [PATCH 1/3] Insert ACTIVESTATE_STRING in Git.pm\n\nAlso add \"git\" to the pipe parameters, otherwise it does not work at all, as\nno git commands are usable out of git context.\n\nSigned-off-by: Alex Riesen <raa.lkml@gmail.com>\n---\n perl/Git.pm |    7 ++++---\n 1 files changed, 4 insertions(+), 3 deletions(-)\n\ndiff --git a/perl/Git.pm b/perl/Git.pm\nindex 3474ad3..58414e3 100644\n--- a/perl/Git.pm\n+++ b/perl/Git.pm\n@@ -736,7 +736,7 @@ sub _command_common_pipe {\n \t_check_valid_cmd($cmd);\n \n \tmy $fh;\n-\tif ($^O eq '##INSERT_ACTIVESTATE_STRING_HERE##') {\n+\tif ($^O eq 'MSWin32') {\n \t\t# ActiveState Perl\n \t\t#defined $opts{STDERR} and\n \t\t#\twarn 'ignoring STDERR option - running w/ ActiveState';\n@@ -809,8 +809,9 @@ sub TIEHANDLE {\n \t# FIXME: This is probably horrible idea and the thing will explode\n \t# at the moment you give it arguments that require some quoting,\n \t# but I have no ActiveState clue... --pasky\n-\tmy $cmdline = join \" \", @params;\n-\tmy @data = qx{$cmdline};\n+\t# Let's just hope ActiveState Perl does at least the quoting\n+\t# correctly.\n+\tmy @data = qx{git @params};\n \tbless { i => 0, data => \\@data }, $class;\n }\n \n-- \n1.5.0.rc2.g3f1a\n\n"}]}