{"thread":{"id":"64716","subject":"[PATCH] doc: define timestamp in pack protocol grammar","startedAt":"2026-01-04T03:08:45Z","lastAt":"2026-01-04T06:28:31Z","messageCount":2,"participants":["Heath Dutton🕴️ via GitGitGadget","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"532970","messageId":"pull.2154.git.git.1767496120852.gitgitgadget@gmail.com","threadId":"64716","inReplyTo":null,"subject":"[PATCH] doc: define timestamp in pack protocol grammar","fromName":"Heath Dutton🕴️ via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2026-01-04T03:08:40Z","receivedAt":"2026-01-04T03:08:45Z","isPatch":true,"sender":{"key":"name:Heath Dutton🕴️","avatar":null},"body":"From: =?UTF-8?q?Heath=20Dutton=F0=9F=95=B4=EF=B8=8F?=\n <heathdutton@gmail.com>\n\nThe grammar for depth-request uses 'timestamp' but never defines it,\nunlike 'depth' which is properly defined as '1*DIGIT'. Add the missing\ndefinition.\n\nSigned-off-by: Heath Dutton <heathdutton@gmail.com>\n---\n    doc: define timestamp in pack protocol grammar\n    \n    Fixes https://git.issues.gerritcodereview.com/issues/40000018\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2154%2Fheathdutton%2Fhd%2Fdoc-protocol-timestamp-40000018-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2154/heathdutton/hd/doc-protocol-timestamp-40000018-v1\nPull-Request: https://github.com/git/git/pull/2154\n\n Documentation/gitprotocol-pack.adoc | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/Documentation/gitprotocol-pack.adoc b/Documentation/gitprotocol-pack.adoc\nindex 837b691c89..7ad63322c2 100644\n--- a/Documentation/gitprotocol-pack.adoc\n+++ b/Documentation/gitprotocol-pack.adoc\n@@ -273,6 +273,7 @@ out of what the server said it could do with the first 'want' line.\n   additional-want   =  PKT-LINE(\"want\" SP obj-id)\n \n   depth             =  1*DIGIT\n+  timestamp         =  1*DIGIT\n \n   filter-request    =  PKT-LINE(\"filter\" SP filter-spec)\n ----\n\nbase-commit: 68cb7f9e92a5d8e9824f5b52ac3d0a9d8f653dbe\n-- \ngitgitgadget\n"},{"id":"532978","messageId":"xmqqv7hhnb76.fsf@gitster.g","threadId":"64716","inReplyTo":"pull.2154.git.git.1767496120852.gitgitgadget@gmail.com","subject":"Re: [PATCH] doc: define timestamp in pack protocol grammar","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-01-04T06:28:29Z","receivedAt":"2026-01-04T06:28:31Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Heath Dutton🕴️ via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: =?UTF-8?q?Heath=20Dutton=F0=9F=95=B4=EF=B8=8F?=\n>  <heathdutton@gmail.com>\n\nThis name is expected to be identical to ...\n\n> The grammar for depth-request uses 'timestamp' but never defines it,\n> unlike 'depth' which is properly defined as '1*DIGIT'. Add the missing\n> definition.\n>\n> Signed-off-by: Heath Dutton <heathdutton@gmail.com>\n\n... what we have here.  There is something weird going on after the\nname before the e-mail on the in-body From: line, though?\n\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2154%2Fheathdutton%2Fhd%2Fdoc-protocol-timestamp-40000018-v1\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2154/heathdutton/hd/doc-protocol-timestamp-40000018-v1\n> Pull-Request: https://github.com/git/git/pull/2154\n>\n>  Documentation/gitprotocol-pack.adoc | 1 +\n>  1 file changed, 1 insertion(+)\n>\n> diff --git a/Documentation/gitprotocol-pack.adoc b/Documentation/gitprotocol-pack.adoc\n> index 837b691c89..7ad63322c2 100644\n> --- a/Documentation/gitprotocol-pack.adoc\n> +++ b/Documentation/gitprotocol-pack.adoc\n> @@ -273,6 +273,7 @@ out of what the server said it could do with the first 'want' line.\n>    additional-want   =  PKT-LINE(\"want\" SP obj-id)\n>  \n>    depth             =  1*DIGIT\n> +  timestamp         =  1*DIGIT\n\nOK.\n\nIt was added at 569e554b (upload-pack: add deepen-since to cut\nshallow repos based on time, 2016-06-12) by Duy for deepen-since\nwhich is parsed using parse_timestamp() that is a fancier name for\nstrtoumax(), so 1*DIGIT sounds fine.\n\nThanks.\n"}]}