{"thread":{"id":"64711","subject":"[PATCH] t2021: use test helpers instead of shell primitives","startedAt":"2026-01-02T11:05:24Z","lastAt":"2026-01-02T11:05:24Z","messageCount":1,"participants":["pushkarkumarsingh1970@gmail.com"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"532914","messageId":"20260102110452.19221-1-pushkarkumarsingh1970@gmail.com","threadId":"64711","inReplyTo":null,"subject":"[PATCH] t2021: use test helpers instead of shell primitives","fromName":"","fromEmail":"pushkarkumarsingh1970@gmail.com","sentAt":"2026-01-02T11:03:51Z","receivedAt":"2026-01-02T11:05:24Z","isPatch":true,"sender":{"key":"pushkarkumarsingh1970@gmail.com","avatar":"https://avatars.githubusercontent.com/u/173247767?v=4"},"body":"From: Pushkar Singh <pushkarkumarsingh1970@gmail.com>\n\nThe tests here used plain `test -f` and `test -h` checks. Replacing them\nwith `test_path_is_file` and `test_path_is_symlink` makes failures easier\nto understand and keeps the test style consistent with the rest of the\nsuite.\n\nSigned-off-by: Pushkar Singh <pushkarkumarsingh1970@gmail.com>\n---\n t/t2021-checkout-overwrite.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t2021-checkout-overwrite.sh b/t/t2021-checkout-overwrite.sh\nindex a5c03d5d4a..38c41ae373 100755\n--- a/t/t2021-checkout-overwrite.sh\n+++ b/t/t2021-checkout-overwrite.sh\n@@ -27,7 +27,7 @@ test_expect_success 'checkout commit with dir must not remove untracked a/b' '\n \tgit rm --cached a/b &&\n \tgit commit -m \"un-track the file\" &&\n \ttest_must_fail git checkout start &&\n-\ttest -f a/b\n+\ttest_path_is_file a/b\n '\n \n test_expect_success 'create a commit where dir a/b changed to symlink' '\n@@ -49,7 +49,7 @@ test_expect_success 'checkout commit with dir must not remove untracked a/b' '\n \n test_expect_success SYMLINKS 'the symlink remained' '\n \n-\ttest -h a/b\n+\ttest_path_is_symlink a/b\n '\n \n test_expect_success 'cleanup after previous symlink tests' '\n-- \n2.43.0\n\n"}]}