{"thread":{"id":"64710","subject":"[PATCH v2] t1300: use test helpers instead of shell primitives","startedAt":"2026-01-02T09:53:19Z","lastAt":"2026-01-02T09:53:19Z","messageCount":1,"participants":["pushkarkumarsingh1970@gmail.com"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"532913","messageId":"20260102095248.18780-1-pushkarkumarsingh1970@gmail.com","threadId":"64710","inReplyTo":null,"subject":"[PATCH v2] t1300: use test helpers instead of shell primitives","fromName":"","fromEmail":"pushkarkumarsingh1970@gmail.com","sentAt":"2026-01-02T09:46:55Z","receivedAt":"2026-01-02T09:53:19Z","isPatch":true,"sender":{"key":"pushkarkumarsingh1970@gmail.com","avatar":"https://avatars.githubusercontent.com/u/173247767?v=4"},"body":"From: Pushkar Singh <pushkarkumarsingh1970@gmail.com>\n\nReplace plain \"test -f\" (regular file checks) with \"test_path_is_file\" and \"test -h\"\n(symbolic link checks) with \"test_path_is_symlink\". The test framework helpers\nprovide clearer diagnostics and better consistency across the test suite.\n\nSigned-off-by: Pushkar Singh <pushkarkumarsingh1970@gmail.com>\n---\nv2: expand commit message to clarify that\n\t- test -f checks regular files\n\t- test -h checks symbolic links\n\n t/t1300-config.sh | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t1300-config.sh b/t/t1300-config.sh\nindex 358d636379..9850fcd5b5 100755\n--- a/t/t1300-config.sh\n+++ b/t/t1300-config.sh\n@@ -1232,12 +1232,12 @@ test_expect_success SYMLINKS 'symlinked configuration' '\n \ttest_when_finished \"rm myconfig\" &&\n \tln -s notyet myconfig &&\n \tgit config --file=myconfig test.frotz nitfol &&\n-\ttest -h myconfig &&\n-\ttest -f notyet &&\n+\ttest_path_is_symlink myconfig &&\n+\ttest_path_is_file notyet &&\n \ttest \"z$(git config --file=notyet test.frotz)\" = znitfol &&\n \tgit config --file=myconfig test.xyzzy rezrov &&\n-\ttest -h myconfig &&\n-\ttest -f notyet &&\n+\ttest_path_is_symlink myconfig &&\n+\ttest_path_is_file notyet &&\n \tcat >expect <<-\\EOF &&\n \tnitfol\n \trezrov\n-- \n2.43.0\n\n"}]}