{"thread":{"id":"64614","subject":"What's cooking in git.git (Dec 2025, #03)","startedAt":"2025-12-12T10:26:16Z","lastAt":"2025-12-18T06:22:50Z","messageCount":16,"participants":["Junio C Hamano","Adrian Ratiu","René Scharfe","Patrick Steinhardt","Emily Shaffer","Aaron Plattner","Jeff King"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"532065","messageId":"xmqq4ipwc7y2.fsf@gitster.g","threadId":"64614","inReplyTo":null,"subject":"What's cooking in git.git (Dec 2025, #03)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-12-12T10:26:13Z","receivedAt":"2025-12-12T10:26:16Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Here are the topics that have been cooking in my tree. Commits\nprefixed with '+' are in 'next' (being in 'next' is a sign that a\ntopic is stable enough to be used and are candidate to be in a\nfuture release). Commits prefixed with '-' are only in 'seen', and\naren't considered \"accepted\" at all and may be annotated with an URL\nto a message that raises issues but they are no means exhaustive. A\ntopic without enough support may be discarded after a long period of\nno activity (of course they can be resubmit when new interests\narise).\n\nCopies of the source code to Git live in many repositories, and the\nfollowing is a list of the ones I push into or their mirrors. Some\nrepositories have only a subset of branches.\n\nWith maint, master, next, seen, todo:\n\n\tgit://git.kernel.org/pub/scm/git/git.git/\n\tgit://repo.or.cz/alt-git.git/\n\thttps://kernel.googlesource.com/pub/scm/git/git/\n\thttps://github.com/git/git/\n\thttps://gitlab.com/git-scm/git/\n\nWith all the integration branches and topics broken out:\n\n\thttps://github.com/gitster/git/\n\nEven though the preformatted documentation in HTML and man format\nare not sources, they are published in these repositories for\nconvenience (replace \"htmldocs\" with \"manpages\" for the manual\npages):\n\n\tgit://git.kernel.org/pub/scm/git/git-htmldocs.git/\n\thttps://github.com/gitster/git-htmldocs.git/\n\nRelease tarballs are available at:\n\n\thttps://www.kernel.org/pub/software/scm/git/\n\n--------------------------------------------------\n[New Topics]\n\n* jt/repo-struct-more-objinfo (2025-12-09) 6 commits\n - builtin/repo: add object disk size info to structure table\n - builtin/repo: add disk size info to keyvalue stucture output\n - builtin/repo: add inflated object info to structure table\n - builtin/repo: add inflated object info to keyvalue structure output\n - builtin/repo: humanise count values in structure output\n - builtin/repo: group per-type object values into struct\n\n More object database related information are shown in \"git repo\n structure\" output.\n\n Comments?\n source: <20251209225820.2861276-1-jltobler@gmail.com>\n\n\n* jc/c99-fam (2025-12-11) 1 commit\n - 3.0: require C99 flexible-array member syntax\n\n Require C99 style flexible array member support after Git 3.0\n boundary.\n\n Comments?\n source: \n\n\n* jc/macports-darwinports (2025-12-10) 1 commit\n - Makefile: help macOS novices by mentioning MacPorts\n\n Makefile in-comment doc update.\n\n Will merge to 'next'.\n source: \n\n\n* rs/macos-iconv-workaround (2025-12-09) 1 commit\n - config.mak.uname: use iconv from Homebrew on macOS\n\n Workaround that \"iconv\" shipped as part of macOS, which is broken\n handling ISO-2022 encoded strings.\n\n Will merge to 'next'?\n source: <16efc726-34be-44f5-aa92-4e82b663ab3d@web.de>\n\n\n* rs/replay-wrong-onto-fix (2025-12-11) 2 commits\n - replay: move onto NULL check before first use\n - Merge branch 'sa/replay-atomic-ref-updates' into rs/replay-wrong-onto-fix\n\n \"git replay --onto= ...\", when is mistyped,\n started to segfault with recent change, which has been corrected.\n\n Will merge to 'next'.\n source: <9db2b913-b5d6-4617-b079-b4612eaa2b97@web.de>\n\n\n* tc/memzero-array (2025-12-10) 3 commits\n - contrib/coccinelle: pass include paths to spatch(1)\n - git-compat-util: introduce MEMZERO_ARRAY() macro\n - Merge branch 'tc/last-modified-active-paths-optimization' into tc/memzero-array\n (this branch uses tc/last-modified-active-paths-optimization.)\n\n MEMZERO_ARRAY() helper is introduced to avoid clearing only the\n first N bytes of an N-element array whose elements are larger than\n a byte.\n\n Will merge to 'next'?\n cf. \n source: <20251210-toon-cocci-memzero-v1-0-ae916a79065b@iotcl.com>\n\n--------------------------------------------------\n[Cooking]\n\n* jc/capability-leak (2025-12-06) 1 commit\n (merged to 'next' on 2025-12-10 at cfe8ce92b1)\n + connect: plug protocol capability leak\n\n Leakfix.\n\n Will merge to 'master'.\n source: \n\n\n* kh/doc-replay-updates (2025-12-07) 3 commits\n - doc: replay: link section using markup\n - doc: replay: document --contained\n - doc: replay: mention no output on conflicts\n\n \"git replay\" documentation updates.\n\n Expecting a (hopefully small and final) reroll.\n cf. <39b57721-ab9e-489d-a382-16d9fe94c300@app.fastmail.com>\n source: \n\n\n* lo/repo-info-keys (2025-12-09) 3 commits\n - repo: add new flag --keys to git-repo-info\n - repo: add a default output format to enum output_format\n - Merge branch 'lo/repo-struct-z' into lo/repo-info-keys\n (this branch uses lo/repo-struct-z.)\n\n \"git repo info\" learns \"--keys\" action to list known keys.\n\n Comments?\n source: <20251209194616.61620-1-lucasseikioshiro@gmail.com>\n\n\n* kh/doc-pre-commit-fix (2025-12-07) 1 commit\n (merged to 'next' on 2025-12-10 at f21f000140)\n + doc: join default pre-commit paragraphs\n\n Docfix.\n\n Will merge to 'master'.\n source: \n\n\n* kh/doc-send-email-paragraph-fix (2025-12-08) 1 commit\n (merged to 'next' on 2025-12-10 at 674ac2bdf7)\n + doc: send-email: fix broken list continuation\n\n Docfix.\n\n Will merge to 'master'.\n source: \n\n\n* mh/doc-config-gui-gcwarning (2025-12-08) 1 commit\n (merged to 'next' on 2025-12-10 at 15d6df9a04)\n + config: document 'gui.GCWarning'\n\n Docfix.\n\n Will merge to 'master'.\n source: <20251208190400.64920-1-matthewhughes934@gmail.com>\n\n\n* ps/odb-alternates-object-sources (2025-12-11) 8 commits\n (merged to 'next' on 2025-12-12 at 1dd061c0dc)\n + odb: write alternates via sources\n + odb: read alternates via sources\n + odb: drop forward declaration of `read_info_alternates()`\n + odb: remove mutual recursion when parsing alternates\n + odb: stop splitting alternate in `odb_add_to_alternates_file()`\n + odb: move computation of normalized objdir into `alt_odb_usable()`\n + odb: resolve relative alternative paths when parsing\n + odb: refactor parsing of alternates to be self-contained\n\n Code refactoring around alternate object store.\n\n Will merge to 'master'.\n source: <20251211-b4-pks-odb-alternates-via-source-v3-0-00e3f54d07ba@pks.im>\n\n\n* ps/repack-avoid-noop-midx-rewrite (2025-12-10) 3 commits\n - midx-write: skip rewriting MIDX with `--stdin-packs` unless needed\n - midx-write: extract function to test whether MIDX needs updating\n - midx: fix `BUG()` when getting preferred pack without a reverse index\n\n Even when there is no changes in the packfile and no need to\n recompute bitmaps, \"git repack\" recomputed and updated the MIDX\n file, which has been corrected.\n\n Comments?\n source: <20251210-pks-skip-noop-rewrite-v2-0-f813a9e44f28@pks.im>\n\n\n* sb/doc-update-ref-markup-fix (2025-12-08) 1 commit\n - doc: fix `update-ref` `symref-create` formatting\n\n Doc mark-up fix.\n\n Will merget to 'next'.\n source: \n\n\n* ap/packfile-promisor-object-optim (2025-12-08) 2 commits\n - packfile: skip hash checks in add_promisor_object()\n - object: apply skip_hash and discard_tree optimizations to unknown blobs too\n\n The code path that enumerates promisor objects have been optimized\n to skip pointlessly parsing blob objects.\n\n Comments?\n source: <20251209014900.402637-1-aplattner@nvidia.com>\n\n\n* je/doc-pull (2025-12-03) 1 commit\n (merged to 'next' on 2025-12-05 at 601711e5f2)\n + doc: git-pull: fix 'git --rebase abort' typo\n\n Doc fixup.\n\n Will merge to 'master'.\n source: \n\n\n* js/last-modified-with-sparse-checkouts (2025-11-29) 1 commit\n (merged to 'next' on 2025-12-05 at f1d5abdd14)\n + last-modified: support sparse checkouts\n\n \"git last-modified\" used to mishandle \"--\" to mark the beginning of\n pathspec, which has been corrected.\n\n Will merge to 'master'.\n source: \n\n\n* kh/advise-w-git-help-in-branch (2025-12-02) 1 commit\n (merged to 'next' on 2025-12-05 at 3b7b03150e)\n + branch: advice using git-help(1) instead of man(1)\n\n A help message from \"git branch\" now mentions \"git help\" instead of\n \"man\" when suggesting to read some documentation.\n\n Will merge to 'master'.\n source: \n\n\n* lo/repo-struct-z (2025-12-04) 3 commits\n (merged to 'next' on 2025-12-06 at 4f602e14d8)\n + repo: add -z as an alias for --format=nul to git-repo-structure\n + repo: use [--format=... | -z] instead of [-z] in git-repo-info synopsis\n + repo: remove blank line from Documentation/git-repo.adoc\n (this branch is used by lo/repo-info-keys.)\n\n \"git repo struct\" learned to take \"-z\" as a synonym to \"--format=nul\".\n\n Will merge to 'master'.\n cf. \n source: <20251204210843.79411-1-lucasseikioshiro@gmail.com>\n\n\n* tc/meson-cross-compile-fix (2025-12-03) 3 commits\n (merged to 'next' on 2025-12-05 at c45b57ca74)\n + meson: use is_cross_build() where possible\n + meson: only detect ICONV_OMITS_BOM if possible\n + meson: ignore subprojects/.wraplock\n\n Build fix.\n\n Will merge to 'master'.\n source: <20251202-toon-cross-compile-v1-0-cabc8bce529f@iotcl.com>\n\n\n* je/doc-data-model (2025-12-02) 1 commit\n (merged to 'next' on 2025-12-06 at 3f4935d65f)\n + doc: remove stray text in Git data model\n\n Docfix.\n\n Will merge to 'master'.\n source: \n\n\n* ps/odb-misc-fixes (2025-12-10) 3 commits\n - odb: properly close sources before freeing them\n - builtin/gc: fix condition for whether to write commit graphs\n - Merge branch 'ps/object-source-management' into ps/odb-misc-fixes\n\n Miscellaneous fixes on object database layer.\n\n Comments?\n source: <20251211-odb-related-fixes-v2-0-bdf875ce51fc@pks.im>\n\n\n* ps/clar-integers (2025-12-06) 3 commits\n - gitattributes: disable blank-at-eof errors for clar test expectations\n - t/unit-tests: demonstrate use of integer comparison assertions\n - t/unit-tests: update clar to 39f11fe\n\n Import newer version of \"clar\", unit testing framework.\n\n Comments?\n source: <20251206-b4-pks-clar-update-v2-0-9a14b10c1a36@pks.im>\n\n\n* rs/ban-mktemp (2025-12-06) 5 commits\n (merged to 'next' on 2025-12-09 at d459e9d8dd)\n + compat: remove gitmkdtemp()\n + banned.h: ban mktemp(3)\n + compat: remove mingw_mktemp()\n + compat: use git_mkdtemp()\n + wrapper: add git_mkdtemp()\n\n Rewrite the only use of \"mktemp()\" that is subject to TOCTOU race\n and Stop using the insecure \"mktemp()\" function.\n\n Will merge to 'master'.\n source: <64e62623-b911-4ddd-a481-05191853c0a6@web.de>\n\n\n* tb/incremental-midx-part-3.2 (2025-12-06) 17 commits\n - midx: enable reachability bitmaps during MIDX compaction\n - midx: implement MIDX compaction\n - t/helper/test-read-midx.c: plug memory leak when selecting layer\n - midx-write.c: factor fanout layering from `compute_sorted_entries()`\n - midx-write.c: enumerate `pack_int_id` values directly\n - midx-write.c: extract `fill_pack_from_midx()`\n - midx-write.c: introduce `midx_pack_perm()` helper\n - git-compat-util.h: introduce `u32_add()`\n - midx: do not require packs to be sorted in lexicographic order\n - midx-write.c: introduce `struct write_midx_opts`\n - midx-write.c: don't use `pack_perm` when assigning `bitmap_pos`\n - t/t5319-multi-pack-index.sh: fix copy-and-paste error in t5319.39\n - git-multi-pack-index(1): align SYNOPSIS with 'git multi-pack-index -h'\n - git-multi-pack-index(1): remove non-existent incompatibility\n - builtin/multi-pack-index.c: make '--progress' a common option\n - midx: split `get_midx_checksum()` by adding `get_midx_hash()`\n - midx: mark `get_midx_checksum()` arguments as const\n\n Further work on incremental repacking using MIDX/bitmap\n\n Expecting a reroll.\n cf. \n source: \n\n\n* yc/histogram-hunk-shift-fix (2025-12-06) 1 commit\n - xdiff: re-diff shifted change groups when using histogram algorithm\n\n The final clean-up phase of the diff output could turn the result of\n histogram diff algorithm suboptimal, which has been corrected.\n\n Comments?\n source: \n\n\n* jc/completion-no-single-letter-options (2025-12-06) 1 commit\n - completion: clarify support for short options and arguments\n\n In-code comment update to clarify that single-letter options are\n outside of the scope of command line completion script.\n\n Comments?\n source: \n\n\n* tc/last-modified-active-paths-optimization (2025-11-28) 1 commit\n (merged to 'next' on 2025-12-05 at 42c18b607f)\n + last-modified: fix use of uninitialized memory\n (this branch is used by tc/memzero-array.)\n\n Recent optimization to \"last-modified\" command introduced use of\n uninitialized block of memory, which has been corrected.\n\n Will merge to 'master'.\n source: <20251128-toon-big-endian-ci-v1-1-80da0f629c1e@iotcl.com>\n\n\n* jk/parse-int (2025-11-30) 5 commits\n - fsck: use parse_unsigned_from_buf() for parsing timestamp\n - cache-tree: use parse_int_from_buf()\n - parse: add functions for parsing from non-string buffers\n - parse: prefer bool to int for boolean returns\n - Merge branch 'jk/asan-bonanza' into jk/parse-int\n\n Introduce a more robust way to parse a decimal integer stored in a\n piece of memory that is not necessarily terminated with NUL (which\n Asan strict-string-check complains even when use of strtol() is\n safe due to varified existence of whitespace after the digits).\n\n Expecting a reroll.\n cf. \n cf. <4d83375b-76e2-4420-80dd-6a04d3201532@gmail.com>\n source: <20251130131351.GA198697@coredump.intra.peff.net>\n\n\n* js/test-symlink-windows (2025-12-05) 10 commits\n - t7800: work around the MSYS path conversion on Windows\n - t6423: introduce Windows-specific handling for symlinking to /dev/null\n - t1305: skip symlink tests that do not apply to Windows\n - t1006: accommodate for symlink support in MSYS2\n - t0600: fix incomplete prerequisite for a test case\n - t0301: another fix for Windows compatibility\n - t0001: handle `diff --no-index` gracefully\n - mingw: special-case `open(symlink, O_CREAT | O_EXCL)`\n - apply: symbolic links lack a \"trustable executable bit\"\n - t9700: accommodate for Windows paths\n\n Prepare test suite for Git for Windows that supports symbolic\n links.\n\n Comments?\n cf. \n cf. \n source: \n\n\n* rs/diff-index-find-copies-harder-optim (2025-11-30) 1 commit\n (merged to 'next' on 2025-12-05 at 539b086bfc)\n + diff-index: don't queue unchanged filepairs with diff_change()\n\n Halve the memory consumed by artificial filepairs created during\n \"git diff --find-copioes-harder\", also making the operation run\n faster.\n\n Will merge to 'master'.\n source: \n\n\n* tc/last-modified-options-cleanup (2025-11-26) 4 commits\n - fixup! last-modified: document option --max-depth\n - last-modified: document how depth is handled better\n - last-modified: document option --max-depth\n - last-modified: handle and document NUL termination\n\n The \"-z\" and \"--max-depth\" documentation (and implementation of\n \"-z\") in the \"git last-modified\" command have been updated.\n\n Expecting a reroll.\n source: <20251126-toon-last-modified-zzzz-v1-0-608350df0caa@iotcl.com>\n\n\n* ds/doc-scalar-config (2025-12-01) 5 commits\n - scalar: document config settings\n - scalar: alphabetize and simplify config\n - scalar: remove stale config values\n - scalar: use index.skipHash=true for performance\n - scalar: annotate config file with \"set by scalar\"\n\n Documentation updates.\n\n Expecting a reroll.\n cf. \n source: \n\n\n* pw/replay-drop-empty (2025-11-27) 2 commits\n - replay: drop commits that become empty\n - Merge branch 'ps/history' into pw/replay-drop-empty\n (this branch uses ps/history.)\n\n \"git replay\" is taught to drop commits that become empty (not the\n ones that are empty in the original).\n\n On hold, until the base topic stabilizes.\n source: <8a2a1215306452147cc7b803530ab2429bf57f15.1764260150.git.phillip.wood@dunelm.org.uk>\n\n\n* sp/shallow-time-boundary (2025-11-23) 1 commit\n - shallow: set borders which are all reachable after clone shallow since\n\n The set of shallow boundary \"git clone --shallow-since\" leaves\n contained commits that are not on the boundary, which has been\n corrected.\n\n Comments?\n source: \n\n\n* gf/win32-pthread-cond-init (2025-11-20) 1 commit\n (merged to 'next' on 2025-12-09 at 202516d20c)\n + win32: pthread_cond_init should return a value\n\n Emulation code clean-up.\n\n Will merge to 'master'.\n source: \n\n\n* kn/ref-location (2025-12-01) 2 commits\n - refs: add GIT_REF_URI to specify reference backend and directory\n - refs: support obtaining ref_store for given dir\n\n A mechanism to specify what reference backend to use and store\n references in which directory is introduced, which would likely to\n be useful during ref migration.\n\n Comments?\n source: <20251201-kn-alternate-ref-dir-v3-0-c11b946bc2fa@gmail.com>\n\n\n* dw/config-global-list (2025-10-09) 4 commits\n - config: keep bailing on unreadable global files\n - config: read global scope via config_sequence\n - config: test home and xdg files in `list --global`\n - cleanup_path: force forward slashes on Windows\n\n \"git config --list --global\", unlike \"git config --list\", did not\n consult both of the two possible per-user sources of the\n configuration files, i.e. $HOME/.gitconfig and the XDG one, which\n has been corrected.\n\n Expecting a reroll.\n cf. <20251122020047.GB3947@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>\n source: \n\n\n* ps/object-read-stream (2025-11-23) 20 commits\n (merged to 'next' on 2025-12-09 at c8d645f8ea)\n + streaming: drop redundant type and size pointers\n + streaming: move into object database subsystem\n + streaming: refactor interface to be object-database-centric\n + streaming: move logic to read packed objects streams into backend\n + streaming: move logic to read loose objects streams into backend\n + streaming: make the `odb_read_stream` definition public\n + streaming: get rid of `the_repository`\n + streaming: rely on object sources to create object stream\n + packfile: introduce function to read object info from a store\n + streaming: move zlib stream into backends\n + streaming: create structure for filtered object streams\n + streaming: create structure for packed object streams\n + streaming: create structure for loose object streams\n + streaming: create structure for in-core object streams\n + streaming: allocate stream inside the backend-specific logic\n + streaming: explicitly pass packfile info when streaming a packed object\n + streaming: propagate final object type via the stream\n + streaming: drop the `open()` callback function\n + streaming: rename `git_istream` into `odb_read_stream`\n + Merge branch 'ps/object-source-loose' into ps/object-read-stream\n\n The \"git_istream\" abstraction has been revamped to make it easier\n to interface with pluggable object database design.\n\n Will merge to 'master'.\n source: <20251123-b4-pks-odb-read-stream-v3-0-1a129182822b@pks.im>\n\n\n* jc/submodule-add (2025-11-15) 1 commit\n - submodule add: sanity check existing .gitmodules\n\n \"git submodule add\" to add a submodule under segfaulted,\n when a submodule..something is already in .gitmodules file\n without defining where its submodule..path is, which has been\n corrected.\n\n Comments?\n source: \n\n\n* kn/fix-fetch-backfill-tag-with-batched-ref-updates (2025-11-21) 3 commits\n - fetch: fix failed batched updates skipping operations\n - fetch: fix non-conflicting tags not being committed\n - fetch: extract out reference committing logic\n\n \"git fetch\" that involves fetching tags, when a tag being fetched\n needs to overwrite existing one, failed to fetch other tags, which\n has been corrected.\n\n Expecting a (hopefully small and final) reroll.\n cf. \n source: <20251121-fix-tags-not-fetching-v8-0-23b53a8a8334@gmail.com>\n\n\n* lc/rebase-trailer (2025-11-05) 4 commits\n - rebase: support --trailer\n - trailer: append trailers in-process and drop the fork to `interpret-trailers`\n - trailer: move process_trailers to trailer.h\n - interpret-trailers: factor out buffer-based processing to process_trailers()\n\n Refactor code paths to run \"interpret-trailers\" from \"git\n commit/tag\" and use it in \"git rebase\".\n\n Expecting a reroll.\n cf. <19a8fe42354.3909481a3912041.7970296104893780556@linux.beauty>\n source: <20251105142944.73061-1-me@linux.beauty>\n\n\n* jc/exclude-with-gitignore (2025-11-04) 1 commit\n - dir.c: do not be fooled by :(exclude) pathspec elements\n\n \"git add ':(exclude)foo.o'\" is clearly a request not to add 'foo.o',\n but the command complained about listing an ignored path foo.o on\n the command line, which has been corrected.\n\n Comments?\n source: \n\n\n* bc/sha1-256-interop-02 (2025-11-17) 15 commits\n - object-file-convert: always make sure object ID algo is valid\n - rust: add a small wrapper around the hashfile code\n - rust: add a new binary object map format\n - rust: add functionality to hash an object\n - rust: add a build.rs script for tests\n - hash: expose hash context functions to Rust\n - write-or-die: add an fsync component for the object map\n - csum-file: define hashwrite's count as a uint32_t\n - rust: add additional helpers for ObjectID\n - hash: add a function to look up hash algo structs\n - rust: add a hash algorithm abstraction\n - rust: add a ObjectID struct\n - hash: use uint32_t for object_id algorithm\n - conversion: don't crash when no destination algo\n - repository: require Rust support for interoperability\n\n The code to maintain mapping between object names in multiple hash\n functions is being added, written in Rust.\n source: <20251117221621.2863243-1-sandals@crustytoothpaste.net>\n\n\n* ar/run-command-hook (2025-12-04) 11 commits\n - receive-pack: convert receive hooks to hook API\n - receive-pack: convert update hooks to new API\n - hooks: allow callers to capture output\n - run-command: allow capturing of collated output\n - hook: allow overriding the ungroup option\n - reference-transaction: use hook API instead of run-command\n - transport: convert pre-push to hook API\n - hook: convert 'post-rewrite' hook in sequencer.c to hook API\n - hook: provide stdin via callback\n - run-command: add stdin callback for parallelization\n - run-command: add first helper for pp child states\n\n Use hook API to replace ad-hoc invocation of hook scripts with the\n run_command() API.\n\n Will merge to 'next'?\n source: <20251204141535.1986263-1-adrian.ratiu@collabora.com>\n\n\n* je/doc-reset (2025-10-17) 4 commits\n - doc: git-reset: clarify `git reset `\n - doc: git-reset: clarify `git reset [mode]`\n - doc: git-reset: clarify intro\n - doc: git-reset: reorder the forms\n\n Documentation updates.\n\n Expecting a reroll.\n cf. <8099e7ef-2673-407e-8cca-e6b566b99549@app.fastmail.com>\n source: \n\n\n* ps/history (2025-12-03) 13 commits\n - builtin/history: implement \"split\" subcommand\n - cache-tree: allow writing in-memory index as tree\n - add-patch: allow disabling editing of hunks\n - add-patch: add support for in-memory index patching\n - add-patch: remove dependency on \"add-interactive\" subsystem\n - add-patch: split out `struct interactive_options`\n - add-patch: split out header from \"add-interactive.h\"\n - builtin/history: implement \"reword\" subcommand\n - builtin: add new \"history\" command\n - replay: stop using `the_repository`\n - replay: extract logic to pick commits\n - wt-status: provide function to expose status for trees\n - Merge branch 'pw/replay-exclude-gpgsig-fix' into ps/history\n (this branch is used by pw/replay-drop-empty.)\n\n \"git history\" history rewriting UI.\n\n Ready?\n source: <20251203-b4-pks-history-builtin-v7-0-9e9f849bfd0e@pks.im>\n\n\n* ms/doc-worktree-side-by-side (2025-10-10) 2 commits\n - doc: git-worktree: Add side by side branch checkout example\n - doc: git-worktree: Link to examples\n\n Document \"git worktree add\" and use of out-of-tree worktrees with\n examples.\n\n Expecting a reroll.\n cf. \n source: \n\n\n* ar/submodule-gitdir-tweak (2025-11-19) 7 commits\n - meson/Makefile: allow setting submodule encoding at build time\n - submodule: use hashed name for gitdir\n - submodule: fix case-folding gitdir filesystem colisions\n - submodule: add extension to encode gitdir paths\n - submodule: always validate gitdirs inside submodule_name_to_gitdir\n - builtin/credential-store: move is_rfc3986_unreserved to url.[ch]\n - submodule--helper: use submodule_name_to_gitdir in add_submodule\n\n Avoid local submodule repository directory paths overlapping with\n each other by encoding submodule names before using them as path\n components.\n\n Expecting a reroll.\n source: <20251119211030.2008441-1-adrian.ratiu@collabora.com>\n\n--------------------------------------------------\n[Discarded]\n\n* wm/complete-git-short-opts (2025-11-26) 1 commit\n - completion: complete \"git -\" with short options\n\n The command line completion script (in contrib/) learned to\n complete \"git -\" to give single-letter options like \"-C\".\n\n Will discard. We do not complete single-letter options themselves.\n cf. \n source: \n"},{"id":"532114","messageId":"87ldj6x1ys.fsf@gentoo.mail-host-address-is-not-set","threadId":"64614","inReplyTo":"xmqq4ipwc7y2.fsf@gitster.g","subject":"Re: What's cooking in git.git (Dec 2025, #03)","fromName":"Adrian Ratiu","fromEmail":"adrian.ratiu@collabora.com","sentAt":"2025-12-13T07:42:03Z","receivedAt":"2025-12-13T07:42:14Z","isPatch":false,"sender":{"key":"adrian.ratiu@collabora.com","avatar":"https://avatars.githubusercontent.com/u/12472556?v=4"},"body":"On Fri, 12 Dec 2025, Junio C Hamano wrote:\n> * ar/run-command-hook (2025-12-04) 11 commits\n> - receive-pack: convert receive hooks to hook API\n> - receive-pack: convert update hooks to new API\n> - hooks: allow callers to capture output\n> - run-command: allow capturing of collated output\n> - hook: allow overriding the ungroup option\n> - reference-transaction: use hook API instead of run-command\n> - transport: convert pre-push to hook API\n> - hook: convert 'post-rewrite' hook in sequencer.c to hook API\n> - hook: provide stdin via callback\n> - run-command: add stdin callback for parallelization\n> - run-command: add first helper for pp child states\n>\n> Use hook API to replace ad-hoc invocation of hook scripts with the\n> run_command() API.\n>\n> Will merge to 'next'?\n> source: <20251204141535.1986263-1-adrian.ratiu@collabora.com>\n\nI think this can be merged to next, since the latest iteration has been\nsitting for a few weeks with no more feedback and all tests are green.\n\nLanding this will also unblock my next series to add parallel/config\nhooks on top of this one.\n\nMany thanks,\nAdrian\n"},{"id":"532138","messageId":"8cf62607-5fcc-4b7a-8811-9046b7c3e7d7@web.de","threadId":"64614","inReplyTo":"xmqq4ipwc7y2.fsf@gitster.g","subject":"Re: What's cooking in git.git (Dec 2025, #03)","fromName":"René Scharfe","fromEmail":"l.s.r@web.de","sentAt":"2025-12-13T18:45:25Z","receivedAt":"2025-12-13T18:45:27Z","isPatch":false,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"On 12/12/25 11:26 AM, Junio C Hamano wrote:\n> * rs/macos-iconv-workaround (2025-12-09) 1 commit\n> - config.mak.uname: use iconv from Homebrew on macOS\n> \n> Workaround that \"iconv\" shipped as part of macOS, which is broken\n> handling ISO-2022 encoded strings.\n> \n> Will merge to 'next'?\n> source: <16efc726-34be-44f5-aa92-4e82b663ab3d@web.de>\nNot, yet, please. Just sent v2 which adds NO_HOMEBREW.\n\nRené\n\n"},{"id":"532233","messageId":"xmqq1pkv5gpv.fsf@gitster.g","threadId":"64614","inReplyTo":"87ldj6x1ys.fsf@gentoo.mail-host-address-is-not-set","subject":"Re: What's cooking in git.git (Dec 2025, #03)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-12-16T01:59:56Z","receivedAt":"2025-12-16T01:59:58Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Adrian Ratiu writes:\n\n> On Fri, 12 Dec 2025, Junio C Hamano wrote:\n>> * ar/run-command-hook (2025-12-04) 11 commits\n>> ...\n>> Use hook API to replace ad-hoc invocation of hook scripts with the\n>> run_command() API.\n>>\n>> Will merge to 'next'?\n>> source: <20251204141535.1986263-1-adrian.ratiu@collabora.com>\n>\n> I think this can be merged to next, since the latest iteration has been\n> sitting for a few weeks with no more feedback and all tests are green.\n\n\"tests being green\" tells us that with the current coverage we\ndidn't see any regression but not more than that. Especially, it\ndoes not say anything about the quality of new code (and test) and\nif it is in good shape to build on top. \n\nIt also is very hard to tell from \"no more feedback\" if there is no\nroom for further improvements, or people are simply disinterested in\nthe topic and are not tempted to spend their brain cycles to help\nimprove the topic.\n\nIf there is no more comments, I'll try to see if I can block some\ntime to read the topic over myself with a pair of fresh eyes before\ndeciding.\n\nThanks for pinging.\n\n\n"},{"id":"532244","messageId":"aUEUrXFaAfgzSs12@pks.im","threadId":"64614","inReplyTo":"xmqq1pkv5gpv.fsf@gitster.g","subject":"Re: What's cooking in git.git (Dec 2025, #03)","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2025-12-16T08:13:33Z","receivedAt":"2025-12-16T08:13:39Z","isPatch":false,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Tue, Dec 16, 2025 at 10:59:56AM +0900, Junio C Hamano wrote:\n> Adrian Ratiu writes:\n> \n> > On Fri, 12 Dec 2025, Junio C Hamano wrote:\n> >> * ar/run-command-hook (2025-12-04) 11 commits\n> >> ...\n> >> Use hook API to replace ad-hoc invocation of hook scripts with the\n> >> run_command() API.\n> >>\n> >> Will merge to 'next'?\n> >> source: <20251204141535.1986263-1-adrian.ratiu@collabora.com>\n> >\n> > I think this can be merged to next, since the latest iteration has been\n> > sitting for a few weeks with no more feedback and all tests are green.\n> \n> \"tests being green\" tells us that with the current coverage we\n> didn't see any regression but not more than that. Especially, it\n> does not say anything about the quality of new code (and test) and\n> if it is in good shape to build on top. \n> \n> It also is very hard to tell from \"no more feedback\" if there is no\n> room for further improvements, or people are simply disinterested in\n> the topic and are not tempted to spend their brain cycles to help\n> improve the topic.\n> \n> If there is no more comments, I'll try to see if I can block some\n> time to read the topic over myself with a pair of fresh eyes before\n> deciding.\n\nThanks for the ping, I've now did another pass through v4 of this patch\nseries. It looked mostly good except for one question I had. Depending\non the answer I think this should be ready to go.\n\nThanks!\n\nPatrick\n"},{"id":"532259","messageId":"87v7i6g13j.fsf@collabora.com","threadId":"64614","inReplyTo":"aUEUrXFaAfgzSs12@pks.im","subject":"Re: What's cooking in git.git (Dec 2025, #03)","fromName":"Adrian Ratiu","fromEmail":"adrian.ratiu@collabora.com","sentAt":"2025-12-16T10:41:52Z","receivedAt":"2025-12-16T10:42:13Z","isPatch":false,"sender":{"key":"adrian.ratiu@collabora.com","avatar":"https://avatars.githubusercontent.com/u/12472556?v=4"},"body":"On Tue, 16 Dec 2025, Patrick Steinhardt wrote:\n> On Tue, Dec 16, 2025 at 10:59:56AM +0900, Junio C Hamano wrote:\n>> Adrian Ratiu writes:\n>> \n>> > On Fri, 12 Dec 2025, Junio C Hamano wrote:\n>> >> * ar/run-command-hook (2025-12-04) 11 commits\n>> >> ...\n>> >> Use hook API to replace ad-hoc invocation of hook scripts with the\n>> >> run_command() API.\n>> >>\n>> >> Will merge to 'next'?\n>> >> source: <20251204141535.1986263-1-adrian.ratiu@collabora.com>\n>> >\n>> > I think this can be merged to next, since the latest iteration has been\n>> > sitting for a few weeks with no more feedback and all tests are green.\n>> \n>> \"tests being green\" tells us that with the current coverage we\n>> didn't see any regression but not more than that. Especially, it\n>> does not say anything about the quality of new code (and test) and\n>> if it is in good shape to build on top. \n>> \n>> It also is very hard to tell from \"no more feedback\" if there is no\n>> room for further improvements, or people are simply disinterested in\n>> the topic and are not tempted to spend their brain cycles to help\n>> improve the topic.\n>> \n>> If there is no more comments, I'll try to see if I can block some\n>> time to read the topic over myself with a pair of fresh eyes before\n>> deciding.\n>\n> Thanks for the ping, I've now did another pass through v4 of this patch\n> series. It looked mostly good except for one question I had. Depending\n> on the answer I think this should be ready to go.\n\nI'll give Junio some more days in case he wants to take a look again at\nthe series, then send one last re-roll fixing your nits/question and\nalso addressing Junio's feedback, if there is any.\n\nThanks!\n"},{"id":"532295","messageId":"CAJoAoZk8AYmJHkFc58LGqn9yengsAd+5iTN-WuFtzBnews7EyA@mail.gmail.com","threadId":"64614","inReplyTo":"87v7i6g13j.fsf@collabora.com","subject":"Re: What's cooking in git.git (Dec 2025, #03)","fromName":"Emily Shaffer","fromEmail":"nasamuffin@google.com","sentAt":"2025-12-16T17:49:29Z","receivedAt":"2025-12-16T17:49:41Z","isPatch":false,"sender":{"key":"nasamuffin@google.com","avatar":"https://avatars.githubusercontent.com/u/1606826?v=4"},"body":"On Tue, Dec 16, 2025 at 2:42 AM Adrian Ratiu wrote:\n>\n> On Tue, 16 Dec 2025, Patrick Steinhardt wrote:\n> > On Tue, Dec 16, 2025 at 10:59:56AM +0900, Junio C Hamano wrote:\n> >> Adrian Ratiu writes:\n> >>\n> >> > On Fri, 12 Dec 2025, Junio C Hamano wrote:\n> >> >> * ar/run-command-hook (2025-12-04) 11 commits\n> >> >> ...\n> >> >> Use hook API to replace ad-hoc invocation of hook scripts with the\n> >> >> run_command() API.\n> >> >>\n> >> >> Will merge to 'next'?\n> >> >> source: <20251204141535.1986263-1-adrian.ratiu@collabora.com>\n> >> >\n> >> > I think this can be merged to next, since the latest iteration has been\n> >> > sitting for a few weeks with no more feedback and all tests are green.\n> >>\n> >> \"tests being green\" tells us that with the current coverage we\n> >> didn't see any regression but not more than that. Especially, it\n> >> does not say anything about the quality of new code (and test) and\n> >> if it is in good shape to build on top.\n> >>\n> >> It also is very hard to tell from \"no more feedback\" if there is no\n> >> room for further improvements, or people are simply disinterested in\n> >> the topic and are not tempted to spend their brain cycles to help\n> >> improve the topic.\n> >>\n> >> If there is no more comments, I'll try to see if I can block some\n> >> time to read the topic over myself with a pair of fresh eyes before\n> >> deciding.\n> >\n> > Thanks for the ping, I've now did another pass through v4 of this patch\n> > series. It looked mostly good except for one question I had. Depending\n> > on the answer I think this should be ready to go.\n>\n> I'll give Junio some more days in case he wants to take a look again at\n> the series, then send one last re-roll fixing your nits/question and\n> also addressing Junio's feedback, if there is any.\n\nFWIW, I also expect Josh Steadmon to find time to take a look at this\nseries soon, but he has been busy with personal side of things for the\nlast few days. It's not that there's disinterest from our side, more\nthat there is a lot going on :)\n\n - Emily\n\n>\n> Thanks!\n"},{"id":"532314","messageId":"93afac3c-c532-4183-a1fd-7e2322ee912f@nvidia.com","threadId":"64614","inReplyTo":"xmqq4ipwc7y2.fsf@gitster.g","subject":"Re: What's cooking in git.git (Dec 2025, #03)","fromName":"Aaron Plattner","fromEmail":"aplattner@nvidia.com","sentAt":"2025-12-17T00:09:30Z","receivedAt":"2025-12-17T00:09:35Z","isPatch":false,"sender":{"key":"aplattner@nvidia.com","avatar":"https://avatars.githubusercontent.com/u/343551?v=4"},"body":"On 12/12/25 2:26 AM, Junio C Hamano wrote:\n> * ap/packfile-promisor-object-optim (2025-12-08) 2 commits\n> - packfile: skip hash checks in add_promisor_object()\n> - object: apply skip_hash and discard_tree optimizations to unknown blobs too\n> \n> The code path that enumerates promisor objects have been optimized\n> to skip pointlessly parsing blob objects.\n> \n> Comments?\n> source: <20251209014900.402637-1-aplattner@nvidia.com>\nJeff King said v2 of the patch looked good to him but recommended \nsplitting it into two changes. I don't know if he wanted to review v3 or \nif he was okay with it based on his comments on v2. The only differences \nin v3 are the commit count and descriptions.\n\n-- Aaron\n"},{"id":"532317","messageId":"xmqqecot3dm1.fsf@gitster.g","threadId":"64614","inReplyTo":"93afac3c-c532-4183-a1fd-7e2322ee912f@nvidia.com","subject":"Re: What's cooking in git.git (Dec 2025, #03)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-12-17T05:02:14Z","receivedAt":"2025-12-17T05:02:17Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Aaron Plattner writes:\n\n> On 12/12/25 2:26 AM, Junio C Hamano wrote:\n>> * ap/packfile-promisor-object-optim (2025-12-08) 2 commits\n>> - packfile: skip hash checks in add_promisor_object()\n>> - object: apply skip_hash and discard_tree optimizations to unknown blobs too\n>> \n>> The code path that enumerates promisor objects have been optimized\n>> to skip pointlessly parsing blob objects.\n>> \n>> Comments?\n>> source: <20251209014900.402637-1-aplattner@nvidia.com>\n> Jeff King said v2 of the patch looked good to him but recommended \n> splitting it into two changes. I don't know if he wanted to review v3 or \n> if he was okay with it based on his comments on v2. The only differences \n> in v3 are the commit count and descriptions.\n\nv3 did not have links back to previous iterations, and\n\nhttps://lore.kernel.org/git/?q=s%3A%22improve+--exclude-promisor-objects+performance%22\n\ndoes not even show v1 or v2 (understandable if the topic was\nretitled, which is not a bad thing, but makes it harder to find the\nprevious discussions in a case like this). So as far as whoever\nwrote the entry in the \"What's cooking\" report you quoted was\nconcerned, what [*] showed\n\n * https://lore.kernel.org/git/20251209014900.402637-1-aplattner@nvidia.com/\n\nwas everything known about the topic, which unfortunately had no\nsupporting comments.\n\nIs this\n\n https://lore.kernel.org/git/20251206002014.2066644-1-aplattner@nvidia.com/\n\nwhich I found in\n\n https://lore.kernel.org/git/?q=f%3Aaplattner%40nvidia.com\n\nthe v2 discussion? We are lucky that you are not as prolific as\nsome contributors, for whom an author-name search would have found\nway too many messages ;-)\n\nI can see that the end result of applying the v3 patches match what\nwas in v2, and v3 separates along the lines Peff suggested in his\n\n https://lore.kernel.org/git/20251208202812.GC216526@coredump.intra.peff.net/\n\nso that's an endorsement enough, I guess ;-).\n\nLet's mark the topic for 'next', then. Thanks.\n\n"},{"id":"532318","messageId":"xmqqa4zh3dhp.fsf@gitster.g","threadId":"64614","inReplyTo":"CAJoAoZk8AYmJHkFc58LGqn9yengsAd+5iTN-WuFtzBnews7EyA@mail.gmail.com","subject":"Re: What's cooking in git.git (Dec 2025, #03)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-12-17T05:04:50Z","receivedAt":"2025-12-17T05:04:52Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Emily Shaffer writes:\n\n> FWIW, I also expect Josh Steadmon to find time to take a look at this\n> series soon, but he has been busy with personal side of things for the\n> last few days. It's not that there's disinterest from our side, more\n> that there is a lot going on :)\n\nThanks, and thanks Josh for further inputs.\n"},{"id":"532319","messageId":"9a318697-4bf5-4ac9-ab9f-f9851da7c54f@nvidia.com","threadId":"64614","inReplyTo":"xmqqecot3dm1.fsf@gitster.g","subject":"Re: What's cooking in git.git (Dec 2025, #03)","fromName":"Aaron Plattner","fromEmail":"aplattner@nvidia.com","sentAt":"2025-12-17T05:20:05Z","receivedAt":"2025-12-17T05:21:13Z","isPatch":false,"sender":{"key":"aplattner@nvidia.com","avatar":"https://avatars.githubusercontent.com/u/343551?v=4"},"body":"On 12/16/25 9:02 PM, Junio C Hamano wrote:\n> Aaron Plattner writes:\n> \n>> On 12/12/25 2:26 AM, Junio C Hamano wrote:\n>>> * ap/packfile-promisor-object-optim (2025-12-08) 2 commits\n>>> - packfile: skip hash checks in add_promisor_object()\n>>> - object: apply skip_hash and discard_tree optimizations to unknown blobs too\n>>>\n>>> The code path that enumerates promisor objects have been optimized\n>>> to skip pointlessly parsing blob objects.\n>>>\n>>> Comments?\n>>> source: <20251209014900.402637-1-aplattner@nvidia.com>\n>> Jeff King said v2 of the patch looked good to him but recommended\n>> splitting it into two changes. I don't know if he wanted to review v3 or\n>> if he was okay with it based on his comments on v2. The only differences\n>> in v3 are the commit count and descriptions.\n> \n> v3 did not have links back to previous iterations, and\n> \n> https://lore.kernel.org/git/?q=s%3A%22improve+--exclude-promisor-objects+performance%22\n> \n> does not even show v1 or v2 (understandable if the topic was\n> retitled, which is not a bad thing, but makes it harder to find the\n> previous discussions in a case like this). So as far as whoever\n> wrote the entry in the \"What's cooking\" report you quoted was\n> concerned, what [*] showed\n> \n> * https://lore.kernel.org/git/20251209014900.402637-1-aplattner@nvidia.com/\n> \n> was everything known about the topic, which unfortunately had no\n> supporting comments.\n> \n> Is this\n> \n> https://lore.kernel.org/git/20251206002014.2066644-1-aplattner@nvidia.com/\n> \n> which I found in\n> \n> https://lore.kernel.org/git/?q=f%3Aaplattner%40nvidia.com\n> \n> the v2 discussion? We are lucky that you are not as prolific as\n> some contributors, for whom an author-name search would have found\n> way too many messages ;-)\n\nI'm sorry, I should have looked more closely at the format of other \nv(n>1) messages on the list and noticed the links to the previous \ndiscussions. In retrospect, that should have been an obvious requirement...\n\nFor completeness, here's all of the discussion:\n\nv1: \nhttps://lore.kernel.org/git/4bd18399-26b3-44cd-93a7-8d2d32bef709@nvidia.com/T/\nv2: \nhttps://lore.kernel.org/git/20251206002014.2066644-1-aplattner@nvidia.com/T/\nv3: \nhttps://lore.kernel.org/git/20251209014900.402637-1-aplattner@nvidia.com/T/\n\n> I can see that the end result of applying the v3 patches match what\n> was in v2, and v3 separates along the lines Peff suggested in his\n> \n> https://lore.kernel.org/git/20251208202812.GC216526@coredump.intra.peff.net/\n> \n> so that's an endorsement enough, I guess ;-).\n> \n> Let's mark the topic for 'next', then. Thanks.\n\nThank you, I appreciate it!\n\n-- Aaron\n"},{"id":"532320","messageId":"20251217061841.GA1472759@coredump.intra.peff.net","threadId":"64614","inReplyTo":"9a318697-4bf5-4ac9-ab9f-f9851da7c54f@nvidia.com","subject":"Re: What's cooking in git.git (Dec 2025, #03)","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2025-12-17T06:18:41Z","receivedAt":"2025-12-17T06:18:48Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Dec 16, 2025 at 09:20:05PM -0800, Aaron Plattner wrote:\n\n> > I can see that the end result of applying the v3 patches match what\n> > was in v2, and v3 separates along the lines Peff suggested in his\n> > \n> > https://lore.kernel.org/git/20251208202812.GC216526@coredump.intra.peff.net/\n> > \n> > so that's an endorsement enough, I guess ;-).\n> > \n> > Let's mark the topic for 'next', then. Thanks.\n> \n> Thank you, I appreciate it!\n\nSorry, I'm a bit behind on reading the list. Yes, v3 looks great to me.\nThanks for working on it, and for pinging for review!\n\n-Peff\n"},{"id":"532329","messageId":"xmqqo6nx1asa.fsf@gitster.g","threadId":"64614","inReplyTo":"9a318697-4bf5-4ac9-ab9f-f9851da7c54f@nvidia.com","subject":"Re: What's cooking in git.git (Dec 2025, #03)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-12-17T13:46:13Z","receivedAt":"2025-12-17T13:46:16Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Aaron Plattner writes:\n\n>> Let's mark the topic for 'next', then. Thanks.\n>\n> Thank you, I appreciate it!\n\n;-)\n"},{"id":"532386","messageId":"f4ba7e89-4717-4b36-921f-56537131fd69@nvidia.com","threadId":"64614","inReplyTo":"xmqq4ipwc7y2.fsf@gitster.g","subject":"Re: What's cooking in git.git (Dec 2025, #03)","fromName":"Aaron Plattner","fromEmail":"aplattner@nvidia.com","sentAt":"2025-12-17T20:26:58Z","receivedAt":"2025-12-17T21:01:21Z","isPatch":false,"sender":{"key":"aplattner@nvidia.com","avatar":"https://avatars.githubusercontent.com/u/343551?v=4"},"body":"On 12/12/25 2:26 AM, Junio C Hamano wrote:\n> * ps/object-read-stream (2025-11-23) 20 commits\n> (merged to 'next' on 2025-12-09 at c8d645f8ea)\n> + streaming: drop redundant type and size pointers\n> + streaming: move into object database subsystem\n> + streaming: refactor interface to be object-database-centric\n> + streaming: move logic to read packed objects streams into backend\n> + streaming: move logic to read loose objects streams into backend\n> + streaming: make the `odb_read_stream` definition public\n> + streaming: get rid of `the_repository`\n> + streaming: rely on object sources to create object stream\n> + packfile: introduce function to read object info from a store\n\nThis commit seems to have caused a slowdown in commit performance. On my \nproduction codebase (the one from [1] with the ridiculously enormous \npromisor pack), a simple commit that touches 9 files (out of 232,259 \ntotal in the tree) goes from 0.38 seconds to 1508 seconds.\n\nI'm pretty sure the problem is when do_oid_object_info_extended() \nsubstitutes the blank oi here:\n\n\tif (!oi)\n\t\toi = &blank_oi;\n\nand then packfile_store_read_object_info() compares it to its own local \nblank oi:\n\n\tstatic struct object_info blank_oi = OBJECT_INFO_INIT;\n\n [...]\n\n\t/*\n\t * We know that the caller doesn't actually need the\n\t * information below, so return early.\n\t */\n\tif (oi == &blank_oi)\n\t\treturn 0;\n\nHere it's comparing the oi parameter to the address of a local static \nvariable instead of the one from the caller, and the condition is always \nfalse.\n\n-- Aaron\n\n> + streaming: move zlib stream into backends\n> + streaming: create structure for filtered object streams\n> + streaming: create structure for packed object streams\n> + streaming: create structure for loose object streams\n> + streaming: create structure for in-core object streams\n> + streaming: allocate stream inside the backend-specific logic\n> + streaming: explicitly pass packfile info when streaming a packed object\n> + streaming: propagate final object type via the stream\n> + streaming: drop the `open()` callback function\n> + streaming: rename `git_istream` into `odb_read_stream`\n> + Merge branch 'ps/object-source-loose' into ps/object-read-stream\n> \n> The \"git_istream\" abstraction has been revamped to make it easier\n> to interface with pluggable object database design.\n> \n> Will merge to 'master'.\n> source: <20251123-b4-pks-odb-read-stream-v3-0-1a129182822b@pks.im>\n[1] \nhttps://lore.kernel.org/git/20251209014900.402637-1-aplattner@nvidia.com/T/\n"},{"id":"532405","messageId":"xmqqtsxoxzs5.fsf@gitster.g","threadId":"64614","inReplyTo":"f4ba7e89-4717-4b36-921f-56537131fd69@nvidia.com","subject":"Re: What's cooking in git.git (Dec 2025, #03)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-12-18T02:57:30Z","receivedAt":"2025-12-18T02:57:33Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Aaron Plattner writes:\n\n> I'm pretty sure the problem is when do_oid_object_info_extended() \n> substitutes the blank oi here:\n>\n> \tif (!oi)\n> \t\toi = &blank_oi;\n>\n> and then packfile_store_read_object_info() compares it to its own local \n> blank oi:\n>\n> \tstatic struct object_info blank_oi = OBJECT_INFO_INIT;\n\nAhh, that's an unusual mistake.\n\nThe following was done on top of 'seen', but would it help? We\nshouldn't have to use the stand-in \"blank\" thing to begin with.\n\nBesides, explicitly handling the NULL case would reduce the\npotential chance of errors that somebody accidentally writes into\nblank_oi, making its contents dirty.\n\n\n\n\n object-file.c | 8 ++++----\n odb.c | 29 +++++++++++++----------------\n packfile.c | 3 +--\n 3 files changed, 18 insertions(+), 22 deletions(-)\n\ndiff --git c/object-file.c w/object-file.c\nindex af1c3f972d..6280e42f34 100644\n--- c/object-file.c\n+++ w/object-file.c\n@@ -426,7 +426,7 @@ int odb_source_loose_read_object_info(struct odb_source *source,\n \tunsigned long size_scratch;\n \tenum object_type type_scratch;\n \n-\tif (oi->delta_base_oid)\n+\tif (oi && oi->delta_base_oid)\n \t\toidclr(oi->delta_base_oid, source->odb->repo->hash_algo);\n \n \t/*\n@@ -437,13 +437,13 @@ int odb_source_loose_read_object_info(struct odb_source *source,\n \t * return value implicitly indicates whether the\n \t * object even exists.\n \t */\n-\tif (!oi->typep && !oi->sizep && !oi->contentp) {\n+\tif (!oi || (!oi->typep && !oi->sizep && !oi->contentp)) {\n \t\tstruct stat st;\n-\t\tif (!oi->disk_sizep && (flags & OBJECT_INFO_QUICK))\n+\t\tif ((!oi || !oi->disk_sizep) && (flags & OBJECT_INFO_QUICK))\n \t\t\treturn quick_has_loose(source->loose, oid) ? 0 : -1;\n \t\tif (stat_loose_object(source->loose, oid, &st, &path) < 0)\n \t\t\treturn -1;\n-\t\tif (oi->disk_sizep)\n+\t\tif (oi && oi->disk_sizep)\n \t\t\t*oi->disk_sizep = st.st_size;\n \t\treturn 0;\n \t}\ndiff --git c/odb.c w/odb.c\nindex 01a9d2e70f..8278ef39a0 100644\n--- c/odb.c\n+++ w/odb.c\n@@ -680,34 +680,31 @@ static int do_oid_object_info_extended(struct object_database *odb,\n \t\t\t\t const struct object_id *oid,\n \t\t\t\t struct object_info *oi, unsigned flags)\n {\n-\tstatic struct object_info blank_oi = OBJECT_INFO_INIT;\n \tconst struct cached_object *co;\n \tconst struct object_id *real = oid;\n \tint already_retried = 0;\n \n-\n \tif (flags & OBJECT_INFO_LOOKUP_REPLACE)\n \t\treal = lookup_replace_object(odb->repo, oid);\n \n \tif (is_null_oid(real))\n \t\treturn -1;\n \n-\tif (!oi)\n-\t\toi = &blank_oi;\n-\n \tco = find_cached_object(odb, real);\n \tif (co) {\n-\t\tif (oi->typep)\n-\t\t\t*(oi->typep) = co->type;\n-\t\tif (oi->sizep)\n-\t\t\t*(oi->sizep) = co->size;\n-\t\tif (oi->disk_sizep)\n-\t\t\t*(oi->disk_sizep) = 0;\n-\t\tif (oi->delta_base_oid)\n-\t\t\toidclr(oi->delta_base_oid, odb->repo->hash_algo);\n-\t\tif (oi->contentp)\n-\t\t\t*oi->contentp = xmemdupz(co->buf, co->size);\n-\t\toi->whence = OI_CACHED;\n+\t\tif (oi) {\n+\t\t\tif (oi->typep)\n+\t\t\t\t*(oi->typep) = co->type;\n+\t\t\tif (oi->sizep)\n+\t\t\t\t*(oi->sizep) = co->size;\n+\t\t\tif (oi->disk_sizep)\n+\t\t\t\t*(oi->disk_sizep) = 0;\n+\t\t\tif (oi->delta_base_oid)\n+\t\t\t\toidclr(oi->delta_base_oid, odb->repo->hash_algo);\n+\t\t\tif (oi->contentp)\n+\t\t\t\t*oi->contentp = xmemdupz(co->buf, co->size);\n+\t\t\toi->whence = OI_CACHED;\n+\t\t}\n \t\treturn 0;\n \t}\n \ndiff --git c/packfile.c w/packfile.c\nindex ce6716fbea..3ffd6c7240 100644\n--- c/packfile.c\n+++ w/packfile.c\n@@ -2132,7 +2132,6 @@ int packfile_store_read_object_info(struct packfile_store *store,\n \t\t\t\t struct object_info *oi,\n \t\t\t\t unsigned flags UNUSED)\n {\n-\tstatic struct object_info blank_oi = OBJECT_INFO_INIT;\n \tstruct pack_entry e;\n \tint rtype;\n \n@@ -2143,7 +2142,7 @@ int packfile_store_read_object_info(struct packfile_store *store,\n \t * We know that the caller doesn't actually need the\n \t * information below, so return early.\n \t */\n-\tif (oi == &blank_oi)\n+\tif (!oi)\n \t\treturn 0;\n \n \trtype = packed_object_info(store->source->odb->repo, e.p, e.offset, oi);\n\n\n"},{"id":"532412","messageId":"aUOdtDrmtGtQg596@pks.im","threadId":"64614","inReplyTo":"xmqqtsxoxzs5.fsf@gitster.g","subject":"Re: What's cooking in git.git (Dec 2025, #03)","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2025-12-18T06:22:44Z","receivedAt":"2025-12-18T06:22:50Z","isPatch":false,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Thu, Dec 18, 2025 at 11:57:30AM +0900, Junio C Hamano wrote:\n> Aaron Plattner writes:\n> \n> > I'm pretty sure the problem is when do_oid_object_info_extended() \n> > substitutes the blank oi here:\n> >\n> > \tif (!oi)\n> > \t\toi = &blank_oi;\n> >\n> > and then packfile_store_read_object_info() compares it to its own local \n> > blank oi:\n> >\n> > \tstatic struct object_info blank_oi = OBJECT_INFO_INIT;\n> \n> Ahh, that's an unusual mistake.\n> \n> The following was done on top of 'seen', but would it help? We\n> shouldn't have to use the stand-in \"blank\" thing to begin with.\n> \n> Besides, explicitly handling the NULL case would reduce the\n> potential chance of errors that somebody accidentally writes into\n> blank_oi, making its contents dirty.\n\nYeah, indeed I've already found that regression myself and got it\ncooking in a local patch series. I was holding off from sending that\nseries because there was a minor conflict with an in-flight one. But\nI'll take this opportunity and send it out now.\n\nThanks for the report and your initial triaging, Junio!\n\nPatrick\n"}]}