{"thread":{"id":"64560","subject":"[PATCH] t/t1517: indicate that `gui--askyesno` fails with GIT_TEST_INSTALLED","startedAt":"2025-12-01T03:10:44Z","lastAt":"2025-12-31T19:10:14Z","messageCount":2,"participants":["Brian Lyles","Adam Dinwoodie"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"531482","messageId":"20251201031040.1120091-1-brianmlyles@gmail.com","threadId":"64560","inReplyTo":null,"subject":"[PATCH] t/t1517: indicate that `gui--askyesno` fails with GIT_TEST_INSTALLED","fromName":"Brian Lyles","fromEmail":"brianmlyles@gmail.com","sentAt":"2025-12-01T03:10:35Z","receivedAt":"2025-12-01T03:10:44Z","isPatch":true,"sender":{"key":"brianmlyles@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1123282?v=4"},"body":"Commit e749c87e75 (git-gui: provide question helper for retry fallback\non Windows, 2025-08-28) causes `git-gui--askyesno` to be installed when\nrunning `make install`. This triggers a new occurrence of the issue\nnoted in commit c4cf8caadd (t/t1517: mark tests that fail with\nGIT_TEST_INSTALLED, 2025-08-19), which prevents Git v2.52.0 from\nbuilding in nixpkgs [1]. Indicate that this is an expected failure.\n\n[1]: https://github.com/NixOS/nixpkgs/issues/465178#issuecomment-3580790826\n\nSigned-off-by: Brian Lyles <brianmlyles@gmail.com>\n---\n\nNote that while this does allow nixpkgs to build v2.52.0, I suspect that\nthis sort of issue is likely to crop up again in the future. I wonder if\nit may be beneficial to make some more fundamental change to this test\nto avoid future occurrences. If that is preferred (and something that\nsomeone has time to tackle in the near future), I am happy to allow this\npatch to be obviated by such a change.\n\n t/t1517-outside-repo.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t1517-outside-repo.sh b/t/t1517-outside-repo.sh\nindex c824c1a25c..13540388f9 100755\n--- a/t/t1517-outside-repo.sh\n+++ b/t/t1517-outside-repo.sh\n@@ -115,7 +115,7 @@ do\n \tcredential-osxkeychain | cvsexportcommit | cvsimport | cvsserver | \\\n \tdaemon | \\\n \tdifftool--helper | filter-branch | fsck-objects | get-tar-commit-id | \\\n-\tgui | gui--askpass | \\\n+\tgui | gui--askpass | gui--askyesno | \\\n \thttp-backend | http-fetch | http-push | init-db | \\\n \tmerge-octopus | merge-one-file | merge-resolve | mergetool | \\\n \tmktag | p4 | p4.py | pickaxe | remote-ftp | remote-ftps | \\\n--\n2.51.2\n"},{"id":"532867","messageId":"CA+kUOanGT2eOHexpXk3jEKY6CZjutN_099Sihy2V=R0M9593pg@mail.gmail.com","threadId":"64560","inReplyTo":"20251201031040.1120091-1-brianmlyles@gmail.com","subject":"Re: [PATCH] t/t1517: indicate that `gui--askyesno` fails with GIT_TEST_INSTALLED","fromName":"Adam Dinwoodie","fromEmail":"adam@dinwoodie.org","sentAt":"2025-12-31T19:09:36Z","receivedAt":"2025-12-31T19:10:14Z","isPatch":true,"sender":{"key":"adam@dinwoodie.org","avatar":"https://avatars.githubusercontent.com/u/1397507?v=4"},"body":"On Mon, 1 Dec 2025 at 03:10, Brian Lyles <brianmlyles@gmail.com> wrote:\n>\n> Commit e749c87e75 (git-gui: provide question helper for retry fallback\n> on Windows, 2025-08-28) causes `git-gui--askyesno` to be installed when\n> running `make install`. This triggers a new occurrence of the issue\n> noted in commit c4cf8caadd (t/t1517: mark tests that fail with\n> GIT_TEST_INSTALLED, 2025-08-19), which prevents Git v2.52.0 from\n> building in nixpkgs [1]. Indicate that this is an expected failure.\n>\n> [1]: https://github.com/NixOS/nixpkgs/issues/465178#issuecomment-3580790826\n>\n> Signed-off-by: Brian Lyles <brianmlyles@gmail.com>\n> ---\n>\n> Note that while this does allow nixpkgs to build v2.52.0, I suspect that\n> this sort of issue is likely to crop up again in the future. I wonder if\n> it may be beneficial to make some more fundamental change to this test\n> to avoid future occurrences. If that is preferred (and something that\n> someone has time to tackle in the near future), I am happy to allow this\n> patch to be obviated by such a change.\n>\n>  t/t1517-outside-repo.sh | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n\nNotwithstanding the discussion at\nhttps://lore.kernel.org/git/xmqqect7fhnp.fsf@gitster.g/ et seq, it'd\nbe good to get this fix in a release. Ideally we'd have a better\nlong-term fix, but I don't think that should prevent fixing the\nproblems we have right now.\n\nSigned-off-by: Adam Dinwoodie <adam@dinwoodie.org>\n"}]}