{"thread":{"id":"64537","subject":"[GIT PULL] gitk: restore window position, external diff of renamed files","startedAt":"2025-11-26T15:38:52Z","lastAt":"2025-11-26T17:35:32Z","messageCount":2,"participants":["Johannes Sixt","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"531306","messageId":"a3e24a03-55c8-4c1e-8c19-e800f5a128b4@kdbg.org","threadId":"64537","inReplyTo":null,"subject":"[GIT PULL] gitk: restore window position, external diff of renamed files","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2025-11-26T15:38:35Z","receivedAt":"2025-11-26T15:38:52Z","isPatch":false,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"The following changes since commit c435c515dad872532705d45d9ff81d3f4af22d6d:\n\n  Merge branch 'ml/themes' (2025-10-05 13:09:49 +0200)\n\nare available in the Git repository at:\n\n  https://github.com/j6t/gitk.git master\n\nfor you to fetch changes up to 776223c4d8482a29585266e189ea8f1933ac9652:\n\n  Merge branch 'tb/external-diff-renamed' (2025-11-26 16:04:14 +0100)\n\n\nThe commit that reinstates that the main window position is saved across\nsessions is controversial and needs testing. In b9bee11526ec (gitk: Only\nrestore window size from ~/.gitk, not position, 2008-03-10) [1] it was\nargued that restoring the main window position is inconvenient. With the\nreversal of that patch I have now implemented my preference (to restore\nthe position) with the purpose to solicit feedback whether it is still\ninconvenient. We can revert the patch again or find a better solution if\nneeded.\n\n[1] https://lore.kernel.org/git/20080223113759.12854.qmail@6a8737aa4695b2.315fe32.mid.smarden.org/\n\n----------------------------------------------------------------\nJohannes Sixt (6):\n      Revert \"gitk: Only restore window size from ~/.gitk, not position\"\n      gitk: persist position and size of the Tags and Heads window\n      gitk: fix a 'continue' statement outside a loop to 'return'\n      gitk: show unescaped file names on 'rename' and 'copy' lines\n      Merge branch 'js/persist-ref-window-geometry'\n      Merge branch 'tb/external-diff-renamed'\n\nTobias Boesch (1):\n      gitk: add external diff file rename detection\n\n gitk | 87 ++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------\n 1 file changed, 69 insertions(+), 18 deletions(-)\n"},{"id":"531317","messageId":"xmqqcy54ofxa.fsf@gitster.g","threadId":"64537","inReplyTo":"a3e24a03-55c8-4c1e-8c19-e800f5a128b4@kdbg.org","subject":"Re: [GIT PULL] gitk: restore window position, external diff of renamed files","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-11-26T17:35:29Z","receivedAt":"2025-11-26T17:35:32Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Sixt <j6t@kdbg.org> writes:\n\n> The following changes since commit c435c515dad872532705d45d9ff81d3f4af22d6d:\n>\n>   Merge branch 'ml/themes' (2025-10-05 13:09:49 +0200)\n>\n> are available in the Git repository at:\n>\n>   https://github.com/j6t/gitk.git master\n>\n> for you to fetch changes up to 776223c4d8482a29585266e189ea8f1933ac9652:\n>\n>   Merge branch 'tb/external-diff-renamed' (2025-11-26 16:04:14 +0100)\n>\n>\n> The commit that reinstates that the main window position is saved across\n> sessions is controversial and needs testing. In b9bee11526ec (gitk: Only\n> restore window size from ~/.gitk, not position, 2008-03-10) [1] it was\n> argued that restoring the main window position is inconvenient. With the\n> reversal of that patch I have now implemented my preference (to restore\n> the position) with the purpose to solicit feedback whether it is still\n> inconvenient. We can revert the patch again or find a better solution if\n> needed.\n>\n> [1] https://lore.kernel.org/git/20080223113759.12854.qmail@6a8737aa4695b2.315fe32.mid.smarden.org/\n>\n> ----------------------------------------------------------------\n> Johannes Sixt (6):\n>       Revert \"gitk: Only restore window size from ~/.gitk, not position\"\n>       gitk: persist position and size of the Tags and Heads window\n>       gitk: fix a 'continue' statement outside a loop to 'return'\n>       gitk: show unescaped file names on 'rename' and 'copy' lines\n>       Merge branch 'js/persist-ref-window-geometry'\n>       Merge branch 'tb/external-diff-renamed'\n>\n> Tobias Boesch (1):\n>       gitk: add external diff file rename detection\n>\n>  gitk | 87 ++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------\n>  1 file changed, 69 insertions(+), 18 deletions(-)\n\nThanks, pulled.\n"}]}