{"thread":{"id":"6451","subject":"[PATCH] --walk-reflogs: actually find the right commit by date.","startedAt":"2007-01-20T09:49:15Z","lastAt":"2007-01-21T18:14:49Z","messageCount":8,"participants":["Johannes Schindelin","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"32145","messageId":"Pine.LNX.4.63.0701201048560.22628@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"6451","inReplyTo":null,"subject":"[PATCH] --walk-reflogs: actually find the right commit by date.","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-01-20T09:49:15Z","receivedAt":"2007-01-20T09:49:15Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"\nEmbarassing thinko.\n\nSigned-off-by: Johannes Schindelin \n---\n reflog-walk.c | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/reflog-walk.c b/reflog-walk.c\nindex d4b49c7..d58ff9b 100644\n--- a/reflog-walk.c\n+++ b/reflog-walk.c\n@@ -70,7 +70,7 @@ static int get_reflog_recno_by_time(struct complete_reflogs *array,\n \tunsigned long timestamp)\n {\n \tint i;\n-\tfor (i = array->nr - 1; i >= 0; i++)\n+\tfor (i = array->nr - 1; i >= 0; i--)\n \t\tif (timestamp >= array->items[i].timestamp)\n \t\t\treturn i;\n \treturn -1;\n-- \n1.5.0.rc1.gd85c\n"},{"id":"32146","messageId":"Pine.LNX.4.63.0701201051320.22628@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"6451","inReplyTo":"Pine.LNX.4.63.0701201048560.22628@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: [PATCH] --walk-reflogs: actually find the right commit by date.","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-01-20T09:52:35Z","receivedAt":"2007-01-20T09:52:35Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Sat, 20 Jan 2007, Johannes Schindelin wrote:\n\n> Embarassing thinko.\n\nBTW this fixes your \"git-log --walk-reflogs -1 --pretty=s master@{1.day}\" \nbug.\n\nCiao,\nDscho\n"},{"id":"32147","messageId":"7vhcum80u4.fsf@assigned-by-dhcp.cox.net","threadId":"6451","inReplyTo":"Pine.LNX.4.63.0701201048560.22628@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: [PATCH] --walk-reflogs: actually find the right commit by date.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-01-20T10:11:15Z","receivedAt":"2007-01-20T10:11:15Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin writes:\n\n> Embarassing thinko.\n\nAha, progress ;-). But it still seems to pick up entry that is\nless than specified number of hours if I do:\n\n\t$ git log --walk-reflogs -4 master@{1.hour} | head -2\n commit 33dd19c2a9c0b114436f53d86fc1c2c5e00c26bb\n Reflog: master@{Sat, 20 Jan 2007 00:01:35 -0800} (Junio C Ham\n\nIt is Jan 20th 02:10 now and the master was not pointing at that\ncommit 1 hour ago.\n\nAnyway, I am done for the night -- I haven't finished testing\nthe updated 'master' and 'next', so I'll push out the tip of\n'pu' (which contains all of the tentitive 'master' and 'next'\nchanges I haven't verified yet) and call it a day.\n"},{"id":"32175","messageId":"Pine.LNX.4.63.0701202225020.22628@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"6451","inReplyTo":"7vhcum80u4.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] --walk-reflogs: actually find the right commit by date.","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-01-20T21:36:31Z","receivedAt":"2007-01-20T21:36:31Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Sat, 20 Jan 2007, Junio C Hamano wrote:\n\n> Johannes Schindelin writes:\n> \n> > Embarassing thinko.\n> \n> Aha, progress ;-). But it still seems to pick up entry that is\n> less than specified number of hours if I do:\n> \n> \t$ git log --walk-reflogs -4 master@{1.hour} | head -2\n> commit 33dd19c2a9c0b114436f53d86fc1c2c5e00c26bb\n> Reflog: master@{Sat, 20 Jan 2007 00:01:35 -0800} (Junio C Ham\n> \n> It is Jan 20th 02:10 now and the master was not pointing at that\n> commit 1 hour ago.\n\nI tried to reproduce this effect, but so far no luck. I even let the \nfunction get_reflog_recno_by_time() output what it does, and it picks \nexactly the right commit. Do you have a time skew?\n\nCiao,\nDscho\n"},{"id":"32190","messageId":"7vhcuk500j.fsf@assigned-by-dhcp.cox.net","threadId":"6451","inReplyTo":"Pine.LNX.4.63.0701202225020.22628@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: [PATCH] --walk-reflogs: actually find the right commit by date.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-01-21T07:09:32Z","receivedAt":"2007-01-21T07:09:32Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin writes:\n\n> Hi,\n>\n> On Sat, 20 Jan 2007, Junio C Hamano wrote:\n>\n>> Johannes Schindelin writes:\n>> \n>> > Embarassing thinko.\n>> \n>> Aha, progress ;-). But it still seems to pick up entry that is\n>> less than specified number of hours if I do:\n>> \n>> \t$ git log --walk-reflogs -4 master@{1.hour} | head -2\n>> commit 33dd19c2a9c0b114436f53d86fc1c2c5e00c26bb\n>> Reflog: master@{Sat, 20 Jan 2007 00:01:35 -0800} (Junio C Ham\n>> \n>> It is Jan 20th 02:10 now and the master was not pointing at that\n>> commit 1 hour ago.\n>\n> I tried to reproduce this effect, but so far no luck.\n\nSorry, I was reading the timestamp wrong. That is one minute\nthirty-five seconds past midnight, not thirty five minute past\none o'clock.\n"},{"id":"32198","messageId":"Pine.LNX.4.63.0701211152400.22628@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"6451","inReplyTo":"7vhcuk500j.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] --walk-reflogs: actually find the right commit by date.","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-01-21T10:53:02Z","receivedAt":"2007-01-21T10:53:02Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Sat, 20 Jan 2007, Junio C Hamano wrote:\n\n> Sorry, I was reading the timestamp wrong. That is one minute \n> thirty-five seconds past midnight, not thirty five minute past one \n> o'clock.\n\nWow! I missed that completely!\n\nCiao,\nDscho\n"},{"id":"32202","messageId":"7vac0c39uw.fsf@assigned-by-dhcp.cox.net","threadId":"6451","inReplyTo":"Pine.LNX.4.63.0701211152400.22628@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: [PATCH] --walk-reflogs: actually find the right commit by date.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-01-21T11:19:51Z","receivedAt":"2007-01-21T11:19:51Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin writes:\n\n> On Sat, 20 Jan 2007, Junio C Hamano wrote:\n>\n>> Sorry, I was reading the timestamp wrong. That is one minute \n>> thirty-five seconds past midnight, not thirty five minute past one \n>> o'clock.\n>\n> Wow! I missed that completely!\n\nSorry for that. It was late and I was tired.\n\nBy the way, \"git log --walk-reflog master@{now}\" seems to give\nme one non-reflog entry output for me at the end (which is I\nthink the parent of the oldest reflog entry which itself does\nnot have the record of being at the tip of the ref in\nquestion). Other than that I think we are Ok.\n\nAlso doesn't --walk-reflog sound too long?\n"},{"id":"32215","messageId":"Pine.LNX.4.63.0701211913060.22628@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"6451","inReplyTo":"7vac0c39uw.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] --walk-reflogs: actually find the right commit by date.","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-01-21T18:14:49Z","receivedAt":"2007-01-21T18:14:49Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Sun, 21 Jan 2007, Junio C Hamano wrote:\n\n> By the way, \"git log --walk-reflog master@{now}\" seems to give me one \n> non-reflog entry output for me at the end (which is I think the parent \n> of the oldest reflog entry which itself does not have the record of \n> being at the tip of the ref in question). Other than that I think we \n> are Ok.\n\nYes, I realized that. It might bear some information, but if you don't \nlike it, I can change that.\n\n> Also doesn't --walk-reflog sound too long?\n\nYes. Suggestions? (--reflog is already taken :-( )\n\nCiao,\nDscho\n"}]}