{"thread":{"id":"64480","subject":"CI Failures","startedAt":"2025-11-14T20:00:41Z","lastAt":"2025-11-17T00:25:08Z","messageCount":8,"participants":["Phillip Wood","Junio C Hamano","Koji Nakamaru"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"530698","messageId":"ddefb36d-f023-45c1-b518-a9f70dba0696@gmail.com","threadId":"64480","inReplyTo":null,"subject":"CI Failures","fromName":"Phillip Wood","fromEmail":"phillip.wood123@gmail.com","sentAt":"2025-11-14T20:00:36Z","receivedAt":"2025-11-14T20:00:41Z","isPatch":false,"sender":{"key":"phillip.wood@dunelm.org.uk","avatar":null},"body":"I'm seeing all the Ubuntu based jobs fail. Judging by the error messages \nat [1] it appears that their version of sudo no longer supports \n\"--preserve-env\" which breaks all of our scripts. Does anyone know how \nto make sure we install the C version of sudo rather than the rust \nversion? Failing that I guess we could switch to using \"runuser\"\n\nThanks\n\nPhillip\n\n[1] \nhttps://github.com/phillipwood/git/actions/runs/19371231059/job/55427466699\n"},{"id":"530700","messageId":"b1775e1a-4f6c-4116-9587-69526d379b42@gmail.com","threadId":"64480","inReplyTo":"ddefb36d-f023-45c1-b518-a9f70dba0696@gmail.com","subject":"Re: CI Failures","fromName":"Phillip Wood","fromEmail":"phillip.wood123@gmail.com","sentAt":"2025-11-14T20:11:13Z","receivedAt":"2025-11-14T20:11:18Z","isPatch":false,"sender":{"key":"phillip.wood@dunelm.org.uk","avatar":null},"body":"On 14/11/2025 20:00, Phillip Wood wrote:\n> I'm seeing all the Ubuntu based jobs fail. Judging by the error messages \n> at [1] it appears that their version of sudo no longer supports \"-- \n> preserve-env\" which breaks all of our scripts. Does anyone know how to \n> make sure we install the C version of sudo rather than the rust version? \n> Failing that I guess we could switch to using \"runuser\"\n\nSorry for the noise, I see this was fixed last month, I had accidentally \nrebased onto a stale branch.\n\nThanks\n\nPhillip\n> Thanks\n> \n> Phillip\n> \n> [1] https://github.com/phillipwood/git/actions/runs/19371231059/ \n> job/55427466699\n\n"},{"id":"530703","messageId":"xmqqv7jcgy8y.fsf@gitster.g","threadId":"64480","inReplyTo":"b1775e1a-4f6c-4116-9587-69526d379b42@gmail.com","subject":"Re: CI Failures","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-11-14T20:22:53Z","receivedAt":"2025-11-14T20:22:55Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Phillip Wood writes:\n\n> On 14/11/2025 20:00, Phillip Wood wrote:\n>> I'm seeing all the Ubuntu based jobs fail. Judging by the error messages \n>> at [1] it appears that their version of sudo no longer supports \"-- \n>> preserve-env\" which breaks all of our scripts. Does anyone know how to \n>> make sure we install the C version of sudo rather than the rust version? \n>> Failing that I guess we could switch to using \"runuser\"\n>\n> Sorry for the noise, I see this was fixed last month, I had accidentally \n> rebased onto a stale branch.\n\nI think we've merged the fix down to the maint-2.51 track but not to\nmaint-2.50 and below. fddb4842 (ci: fix broken jobs on Ubuntu 25.10\ncaused by switch to sudo-rs(1), 2025-10-10) cannot be merged below\nthere, but you should be able to cherry-pick if needed.\n\n"},{"id":"530704","messageId":"xmqqqzu0gxq2.fsf_-_@gitster.g","threadId":"64480","inReplyTo":"xmqqv7jcgy8y.fsf@gitster.g","subject":"CI Failures (osx with p4)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-11-14T20:34:13Z","receivedAt":"2025-11-14T20:34:16Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Speaking of CI failures, I think we are seeing unusually high rate\nof failures from random osx jobs failing to successfully run t98xx\nseries. Is p4 on macOSX still a thing? As macOSX tests tend to\ntake very long to complete compared to other jobs, I am tempted to\nsuggest dropping p4 tests from there.\n\nOpinions?\n\n----- >8 -----\nSubject: [PATCH] CI: drop Perforce tests from macOSX jobs\n\nIt seems that we seem to be getting unusually higher rate of\nfailures from random macOSX jobs failing to run t98xx series, even\nthough we haven't changed Perforce interaction part of our codebase\nfor quite some time, and the failures seem to be limited to macOSX\njobs and no other platforms.\n\nMost importantly, nobody from the macOSX community seems to have\nraised an issue here, reporting any failures.\n\nPerhaps we should stop testing the combination of P4 and macOSX to\nsave cycles, electricity, and my sanity ;-)\n\nSigned-off-by: Junio C Hamano \n---\n ci/install-dependencies.sh | 4 ----\n 1 file changed, 4 deletions(-)\n\ndiff --git c/ci/install-dependencies.sh w/ci/install-dependencies.sh\nindex 50628ee2dd..3f718dad41 100755\n--- c/ci/install-dependencies.sh\n+++ w/ci/install-dependencies.sh\n@@ -109,10 +109,6 @@ macos-*)\n \tbrew link --force gettext\n \n \tmkdir -p \"$CUSTOM_PATH\"\n-\twget -q \"$P4WHENCE/bin.macosx1015x86_64/helix-core-server.tgz\" &&\n-\ttar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d &&\n-\tsudo xattr -d com.apple.quarantine \"$CUSTOM_PATH/p4\" \"$CUSTOM_PATH/p4d\" 2>/dev/null || true\n-\trm helix-core-server.tgz\n \n \tcase \"$jobname\" in\n \tosx-meson)\n"},{"id":"530772","messageId":"CAOTNsDwS2er+31iFt4EnhW_ZupPG+Uree_qobBVj9v1q1+0vPA@mail.gmail.com","threadId":"64480","inReplyTo":"xmqqqzu0gxq2.fsf_-_@gitster.g","subject":"Re: CI Failures (osx with p4)","fromName":"Koji Nakamaru","fromEmail":"koji.nakamaru@gree.net","sentAt":"2025-11-16T15:23:34Z","receivedAt":"2025-11-16T15:23:47Z","isPatch":false,"sender":{"key":"koji.nakamaru@gree.net","avatar":"https://avatars.githubusercontent.com/u/2645978?v=4"},"body":"On Sat, Nov 15, 2025 at 5:34 AM Junio C Hamano wrote:\n>\n> Speaking of CI failures, I think we are seeing unusually high rate\n> of failures from random osx jobs failing to successfully run t98xx\n> series. Is p4 on macOSX still a thing? As macOSX tests tend to\n> take very long to complete compared to other jobs, I am tempted to\n> suggest dropping p4 tests from there.\n>\n> Opinions?\n>\n> ----- >8 -----\n> Subject: [PATCH] CI: drop Perforce tests from macOSX jobs\n>\n> It seems that we seem to be getting unusually higher rate of\n> failures from random macOSX jobs failing to run t98xx series, even\n> though we haven't changed Perforce interaction part of our codebase\n> for quite some time, and the failures seem to be limited to macOSX\n> jobs and no other platforms.\n>\n> Most importantly, nobody from the macOSX community seems to have\n> raised an issue here, reporting any failures.\n>\n> Perhaps we should stop testing the combination of P4 and macOSX to\n> save cycles, electricity, and my sanity ;-)\n>\n> Signed-off-by: Junio C Hamano \n> ---\n> ci/install-dependencies.sh | 4 ----\n> 1 file changed, 4 deletions(-)\n>\n> diff --git c/ci/install-dependencies.sh w/ci/install-dependencies.sh\n> index 50628ee2dd..3f718dad41 100755\n> --- c/ci/install-dependencies.sh\n> +++ w/ci/install-dependencies.sh\n> @@ -109,10 +109,6 @@ macos-*)\n> brew link --force gettext\n>\n> mkdir -p \"$CUSTOM_PATH\"\n> - wget -q \"$P4WHENCE/bin.macosx1015x86_64/helix-core-server.tgz\" &&\n> - tar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d &&\n> - sudo xattr -d com.apple.quarantine \"$CUSTOM_PATH/p4\" \"$CUSTOM_PATH/p4d\" 2>/dev/null || true\n> - rm helix-core-server.tgz\n>\n> case \"$jobname\" in\n> osx-meson)\n>\n\nThe cause might be that the macos-14 and later images are for arm64 [1],\nbut install-dependencies.sh still downloads the x86_64 Perforce\ncommands. This leads to Rosetta translation overhead. The arm64 Perforce\ncommands can be downloaded with the following modification. I confirmed\nthat this modified version runs without any error [2].\n\n[1]: https://github.com/actions/runner-images?tab=readme-ov-file#available-images\n[2]: https://github.com/KojiNakamaru/git/actions/runs/19407172619\n\n--\ndiff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh\nindex 50628ee2dd..16ee593d30 100755\n--- a/ci/install-dependencies.sh\n+++ b/ci/install-dependencies.sh\n@@ -7,7 +7,7 @@\n\n begin_group \"Install dependencies\"\n\n-P4WHENCE=https://cdist2.perforce.com/perforce/r23.2\n+P4WHENCE=https://cdist2.perforce.com/perforce/r24.2\n LFSWHENCE=https://github.com/github/git-lfs/releases/download/v$LINUX_GIT_LFS_VERSION\n JGITWHENCE=https://repo1.maven.org/maven2/org/eclipse/jgit/org.eclipse.jgit.pgm/6.8.0.202311291450-r/org.eclipse.jgit.pgm-6.8.0.202311291450-r.sh\n CARGO_MSRV_VERSION=0.18.4\n@@ -109,7 +109,7 @@ macos-*)\n brew link --force gettext\n\n mkdir -p \"$CUSTOM_PATH\"\n- wget -q \"$P4WHENCE/bin.macosx1015x86_64/helix-core-server.tgz\" &&\n+ wget -q \"$P4WHENCE/bin.macosx12arm64/helix-core-server.tgz\" &&\n tar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d &&\n sudo xattr -d com.apple.quarantine \"$CUSTOM_PATH/p4\"\n\"$CUSTOM_PATH/p4d\" 2>/dev/null || true\n rm helix-core-server.tgz\n"},{"id":"530775","messageId":"xmqqh5utdhfv.fsf@gitster.g","threadId":"64480","inReplyTo":"CAOTNsDwS2er+31iFt4EnhW_ZupPG+Uree_qobBVj9v1q1+0vPA@mail.gmail.com","subject":"Re: CI Failures (osx with p4)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-11-16T17:18:44Z","receivedAt":"2025-11-16T17:18:47Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Koji Nakamaru writes:\n\n> The cause might be that the macos-14 and later images are for arm64 [1],\n> but install-dependencies.sh still downloads the x86_64 Perforce\n> commands. This leads to Rosetta translation overhead. The arm64 Perforce\n> commands can be downloaded with the following modification. I confirmed\n> that this modified version runs without any error [2].\n>\n> [1]: https://github.com/actions/runner-images?tab=readme-ov-file#available-images\n> [2]: https://github.com/KojiNakamaru/git/actions/runs/19407172619\n\nAh, sounds great. Or switch to macos-14-large, which seems to be\nstill x86-64? I have no strong preference, but given that newer\nunits are all running on Apple silicon, perhaps testing with them,\ninstead of what was discontinued a few years ago, may probably be\nstill a better choice.\n\n\n> --\n> diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh\n> index 50628ee2dd..16ee593d30 100755\n> --- a/ci/install-dependencies.sh\n> +++ b/ci/install-dependencies.sh\n> @@ -7,7 +7,7 @@\n>\n> begin_group \"Install dependencies\"\n>\n> -P4WHENCE=https://cdist2.perforce.com/perforce/r23.2\n> +P4WHENCE=https://cdist2.perforce.com/perforce/r24.2\n\nJust being curious, other than \"because it is newer than r23.2\", was\nthere a particular reason why r24.2 was picked? It is not the\nlatest that has arm64 macos (r25.1 also has bin.macosx12arm64\nsubdirectory at the above distribution site), and r23.2 also has\nbin.macosx12arm64 subdirectory, too, which makes the above update\ncurious if it comes without explanation, given that this would also\naffect Ubuntu that slurps bin.linux26x86_64 from there.\n\n> LFSWHENCE=https://github.com/github/git-lfs/releases/download/v$LINUX_GIT_LFS_VERSION\n> JGITWHENCE=https://repo1.maven.org/maven2/org/eclipse/jgit/org.eclipse.jgit.pgm/6.8.0.202311291450-r/org.eclipse.jgit.pgm-6.8.0.202311291450-r.sh\n> CARGO_MSRV_VERSION=0.18.4\n> @@ -109,7 +109,7 @@ macos-*)\n> brew link --force gettext\n>\n> mkdir -p \"$CUSTOM_PATH\"\n> - wget -q \"$P4WHENCE/bin.macosx1015x86_64/helix-core-server.tgz\" &&\n> + wget -q \"$P4WHENCE/bin.macosx12arm64/helix-core-server.tgz\" &&\n\nYou explained this change very well. I didn't consider that the\nrosetta-2 may get in the way.\n\n> tar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d &&\n> sudo xattr -d com.apple.quarantine \"$CUSTOM_PATH/p4\"\n> \"$CUSTOM_PATH/p4d\" 2>/dev/null || true\n> rm helix-core-server.tgz\n\nThanks.\n"},{"id":"530779","messageId":"CAOTNsDzqXZVMhW+kuWG_ZnxSc0U-g01AXkG7EbP8HXzR16LO7Q@mail.gmail.com","threadId":"64480","inReplyTo":"xmqqh5utdhfv.fsf@gitster.g","subject":"Re: CI Failures (osx with p4)","fromName":"Koji Nakamaru","fromEmail":"koji.nakamaru@gree.net","sentAt":"2025-11-16T23:25:10Z","receivedAt":"2025-11-16T23:25:22Z","isPatch":false,"sender":{"key":"koji.nakamaru@gree.net","avatar":"https://avatars.githubusercontent.com/u/2645978?v=4"},"body":"On Mon, Nov 17, 2025 at 2:18 AM Junio C Hamano wrote:\n> > --\n> > diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh\n> > index 50628ee2dd..16ee593d30 100755\n> > --- a/ci/install-dependencies.sh\n> > +++ b/ci/install-dependencies.sh\n> > @@ -7,7 +7,7 @@\n> >\n> > begin_group \"Install dependencies\"\n> >\n> > -P4WHENCE=https://cdist2.perforce.com/perforce/r23.2\n> > +P4WHENCE=https://cdist2.perforce.com/perforce/r24.2\n>\n> Just being curious, other than \"because it is newer than r23.2\", was\n> there a particular reason why r24.2 was picked? It is not the\n> latest that has arm64 macos (r25.1 also has bin.macosx12arm64\n> subdirectory at the above distribution site), and r23.2 also has\n> bin.macosx12arm64 subdirectory, too, which makes the above update\n> curious if it comes without explanation, given that this would also\n> affect Ubuntu that slurps bin.linux26x86_64 from there.\n\nWhen I first looked in r23.2 in the browser, somehow I could not find\nbin.macosx12arm64, so I looked for another version that included\nit. It now exists in r23.2 as you mentioned, and I totally agree that\nit is better to keep using r23.2. I confirmed r23.2 runs without any\nerror [1].\n\n[1]: https://github.com/KojiNakamaru/git/actions/runs/19413263298\n"},{"id":"530781","messageId":"xmqqms4lbj4t.fsf@gitster.g","threadId":"64480","inReplyTo":"CAOTNsDzqXZVMhW+kuWG_ZnxSc0U-g01AXkG7EbP8HXzR16LO7Q@mail.gmail.com","subject":"Re: CI Failures (osx with p4)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-11-17T00:25:06Z","receivedAt":"2025-11-17T00:25:08Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Koji Nakamaru writes:\n\n> On Mon, Nov 17, 2025 at 2:18 AM Junio C Hamano wrote:\n>> > --\n>> > diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh\n>> > index 50628ee2dd..16ee593d30 100755\n>> > --- a/ci/install-dependencies.sh\n>> > +++ b/ci/install-dependencies.sh\n>> > @@ -7,7 +7,7 @@\n>> >\n>> > begin_group \"Install dependencies\"\n>> >\n>> > -P4WHENCE=https://cdist2.perforce.com/perforce/r23.2\n>> > +P4WHENCE=https://cdist2.perforce.com/perforce/r24.2\n>>\n>> Just being curious, other than \"because it is newer than r23.2\", was\n>> there a particular reason why r24.2 was picked? It is not the\n>> latest that has arm64 macos (r25.1 also has bin.macosx12arm64\n>> subdirectory at the above distribution site), and r23.2 also has\n>> bin.macosx12arm64 subdirectory, too, which makes the above update\n>> curious if it comes without explanation, given that this would also\n>> affect Ubuntu that slurps bin.linux26x86_64 from there.\n>\n> When I first looked in r23.2 in the browser, somehow I could not find\n> bin.macosx12arm64, so I looked for another version that included\n> it. It now exists in r23.2 as you mentioned, and I totally agree that\n> it is better to keep using r23.2. I confirmed r23.2 runs without any\n> error [1].\n>\n> [1]: https://github.com/KojiNakamaru/git/actions/runs/19413263298\n\nThanks!\n"}]}