{"thread":{"id":"64447","subject":"[PATCH] refs: Add missing space in message","startedAt":"2025-11-05T22:48:21Z","lastAt":"2025-11-06T12:45:45Z","messageCount":3,"participants":["Peter Krefting","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"530282","messageId":"a8220721-3260-15cb-6960-ca8b6433d7b5@softwolves.pp.se","threadId":"64447","inReplyTo":null,"subject":"[PATCH] refs: Add missing space in message","fromName":"Peter Krefting","fromEmail":"peter@softwolves.pp.se","sentAt":"2025-11-05T21:47:17Z","receivedAt":"2025-11-05T22:48:21Z","isPatch":true,"sender":{"key":"peter@softwolves.pp.se","avatar":"https://avatars.githubusercontent.com/u/990764?v=4"},"body":"Signed-off-by: Peter Krefting <peter@softwolves.pp.se>\n---\n refs/files-backend.c    | 2 +-\n refs/reftable-backend.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/refs/files-backend.c b/refs/files-backend.c\nindex 054cf42f4e..1adc4b5182 100644\n--- a/refs/files-backend.c\n+++ b/refs/files-backend.c\n@@ -3124,7 +3124,7 @@ static int parse_and_write_reflog(struct files_ref_store *refs,\n \t\tif (!(update->flags & REF_HAVE_OLD) ||\n \t\t    !(update->flags & REF_HAVE_NEW) ||\n \t\t    !(update->flags & REF_LOG_ONLY)) {\n-\t\t\tstrbuf_addf(err, _(\"trying to write reflog for '%s'\"\n+\t\t\tstrbuf_addf(err, _(\"trying to write reflog for '%s' \"\n \t\t\t\t\t   \"with incomplete values\"), update->refname);\n \t\t\treturn REF_TRANSACTION_ERROR_GENERIC;\n \t\t}\ndiff --git a/refs/reftable-backend.c b/refs/reftable-backend.c\nindex d4b7928620..eeec64798f 100644\n--- a/refs/reftable-backend.c\n+++ b/refs/reftable-backend.c\n@@ -1103,7 +1103,7 @@ static enum ref_transaction_error prepare_single_update(struct reftable_ref_stor\n \t\tif (!(u->flags & REF_HAVE_OLD) ||\n \t\t    !(u->flags & REF_HAVE_NEW) ||\n \t\t    !(u->flags & REF_LOG_ONLY)) {\n-\t\t\tstrbuf_addf(err, _(\"trying to write reflog for '%s'\"\n+\t\t\tstrbuf_addf(err, _(\"trying to write reflog for '%s' \"\n \t\t\t\t\t   \"with incomplete values\"), u->refname);\n \t\t\treturn REF_TRANSACTION_ERROR_GENERIC;\n \t\t}\n-- \n2.47.2\n\n"},{"id":"530283","messageId":"xmqqikfokrq0.fsf@gitster.g","threadId":"64447","inReplyTo":"a8220721-3260-15cb-6960-ca8b6433d7b5@softwolves.pp.se","subject":"Re: [PATCH] refs: Add missing space in message","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-11-05T23:03:03Z","receivedAt":"2025-11-05T23:03:06Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Peter Krefting <peter@softwolves.pp.se> writes:\n\n> Signed-off-by: Peter Krefting <peter@softwolves.pp.se>\n> ---\n>  refs/files-backend.c    | 2 +-\n>  refs/reftable-backend.c | 2 +-\n>  2 files changed, 2 insertions(+), 2 deletions(-)\n\nGood eyes.  Both of these came from 465eff81 (refs: fix invalid old\nobject IDs when migrating reflogs, 2025-08-06), which appeared in\nGit 2.51.1 already.  Let's merge it before the upcoming release.\n\nThanks.\n\n\n> diff --git a/refs/files-backend.c b/refs/files-backend.c\n> index 054cf42f4e..1adc4b5182 100644\n> --- a/refs/files-backend.c\n> +++ b/refs/files-backend.c\n> @@ -3124,7 +3124,7 @@ static int parse_and_write_reflog(struct files_ref_store *refs,\n>  \t\tif (!(update->flags & REF_HAVE_OLD) ||\n>  \t\t    !(update->flags & REF_HAVE_NEW) ||\n>  \t\t    !(update->flags & REF_LOG_ONLY)) {\n> -\t\t\tstrbuf_addf(err, _(\"trying to write reflog for '%s'\"\n> +\t\t\tstrbuf_addf(err, _(\"trying to write reflog for '%s' \"\n>  \t\t\t\t\t   \"with incomplete values\"), update->refname);\n>  \t\t\treturn REF_TRANSACTION_ERROR_GENERIC;\n>  \t\t}\n> diff --git a/refs/reftable-backend.c b/refs/reftable-backend.c\n> index d4b7928620..eeec64798f 100644\n> --- a/refs/reftable-backend.c\n> +++ b/refs/reftable-backend.c\n> @@ -1103,7 +1103,7 @@ static enum ref_transaction_error prepare_single_update(struct reftable_ref_stor\n>  \t\tif (!(u->flags & REF_HAVE_OLD) ||\n>  \t\t    !(u->flags & REF_HAVE_NEW) ||\n>  \t\t    !(u->flags & REF_LOG_ONLY)) {\n> -\t\t\tstrbuf_addf(err, _(\"trying to write reflog for '%s'\"\n> +\t\t\tstrbuf_addf(err, _(\"trying to write reflog for '%s' \"\n>  \t\t\t\t\t   \"with incomplete values\"), u->refname);\n>  \t\t\treturn REF_TRANSACTION_ERROR_GENERIC;\n>  \t\t}\n"},{"id":"530312","messageId":"2013e26e02fe07c1908ed8ce09359d57@softwolves.pp.se","threadId":"64447","inReplyTo":"xmqqikfokrq0.fsf@gitster.g","subject":"Re: [PATCH] refs: Add missing space in message","fromName":"Peter Krefting","fromEmail":"peter@softwolves.pp.se","sentAt":"2025-11-06T12:45:37Z","receivedAt":"2025-11-06T12:45:45Z","isPatch":true,"sender":{"key":"peter@softwolves.pp.se","avatar":"https://avatars.githubusercontent.com/u/990764?v=4"},"body":"2025-11-06 00:03 skrev Junio C Hamano:\n\n> Good eyes.\n\nThey are easy to spot when doing the localization, as gettext only wraps \nthe generated PO template at whitespace.\n\nIn case someone wants to spellcheck the user interface, I would \nrecommend starting from the PO template (make po/git.pot).\n\n-- \n\\\\// Peter - http://www.softwolves.pp.se/\n"}]}