{"thread":{"id":"64439","subject":"[PATCH] perl: also mark git-contacts executable","startedAt":"2025-11-04T18:21:07Z","lastAt":"2025-11-11T20:19:00Z","messageCount":8,"participants":["D. Ben Knoble","Patrick Steinhardt","Ben Knoble","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"530208","messageId":"7fbb341e8f05fcde3a1543e3bb4e5a3ec1101692.1762280097.git.ben.knoble+github@gmail.com","threadId":"64439","inReplyTo":null,"subject":"[PATCH] perl: also mark git-contacts executable","fromName":"D. Ben Knoble","fromEmail":"ben.knoble+github@gmail.com","sentAt":"2025-11-04T18:14:57Z","receivedAt":"2025-11-04T18:21:07Z","isPatch":true,"sender":{"key":"ben.knoble@gmail.com","avatar":"https://avatars.githubusercontent.com/u/22802209?v=4"},"body":"When install git-contacts with Meson via -Dcontrib=contacts, the default\nPerl generation fails to mark it executable. As a result, \"git contacts\"\nreports \"'contacts' is not a git command.\"\n\nUnlike generate-script.sh, we aren't testing the basename here; so, glob\nthe script name in the case arm to match wherever the input comes from.\n\nSigned-off-by: D. Ben Knoble <ben.knoble+github@gmail.com>\n---\n\nTested like [1]. I was surprised to find my packager didn't have contacts\ninstalled, despite it being requested. But the issue is upstream (here): the\ninstaller doesn't mark the program as executable. I wrote this on top of the\npatch in [1], but it should be independent. A quick test says the\nprerequisite-patch-id shouldn't bother application?\n\n[1]: https://lore.kernel.org/git/0423F0C4-D0AD-471D-9315-FB208A8171B4@gmail.com/T/#t\n\n generate-perl.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/generate-perl.sh b/generate-perl.sh\nindex 65f122ebfc..796d835932 100755\n--- a/generate-perl.sh\n+++ b/generate-perl.sh\n@@ -30,7 +30,7 @@\n     \"$INPUT\" >\"$OUTPUT\"\n \n case \"$INPUT\" in\n-*.perl)\n+*.perl|*git-contacts)\n \tchmod a+x \"$OUTPUT\";;\n *)\n \t;;\n\nbase-commit: 7f278e958afbf9b7e0727631b4c26dcfa1c63d6e\nprerequisite-patch-id: 664e4667d11a226a89da52814505a0c8d31b9fba\n-- \n2.48.1\n\n"},{"id":"530290","messageId":"aQxMmnzPR6swvG-d@pks.im","threadId":"64439","inReplyTo":"7fbb341e8f05fcde3a1543e3bb4e5a3ec1101692.1762280097.git.ben.knoble+github@gmail.com","subject":"Re: [PATCH] perl: also mark git-contacts executable","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2025-11-06T07:22:02Z","receivedAt":"2025-11-06T07:22:08Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Tue, Nov 04, 2025 at 01:14:57PM -0500, D. Ben Knoble wrote:\n> When install git-contacts with Meson via -Dcontrib=contacts, the default\n\ns/install/installing/\n\n> Perl generation fails to mark it executable. As a result, \"git contacts\"\n> reports \"'contacts' is not a git command.\"\n> \n> Unlike generate-script.sh, we aren't testing the basename here; so, glob\n> the script name in the case arm to match wherever the input comes from.\n\nYeah, that feels sensibel to me.\n\n> diff --git a/generate-perl.sh b/generate-perl.sh\n> index 65f122ebfc..796d835932 100755\n> --- a/generate-perl.sh\n> +++ b/generate-perl.sh\n> @@ -30,7 +30,7 @@\n>      \"$INPUT\" >\"$OUTPUT\"\n>  \n>  case \"$INPUT\" in\n> -*.perl)\n> +*.perl|*git-contacts)\n>  \tchmod a+x \"$OUTPUT\";;\n>  *)\n>  \t;;\n\nAnd the change looks as expected. An alternative could of course be to\nrename the file in-tree to \"git-contacts.perl\". In that case we wouldn't\nrequire this special case at all. But I guess that this here is good\nenough, and there might be other consequences if we renamed the script.\n\nThanks!\n\nPatrick\n"},{"id":"530316","messageId":"87BB8F6A-7176-4C51-9F36-BA613E7D8B08@gmail.com","threadId":"64439","inReplyTo":"aQxMmnzPR6swvG-d@pks.im","subject":"Re: [PATCH] perl: also mark git-contacts executable","fromName":"Ben Knoble","fromEmail":"ben.knoble@gmail.com","sentAt":"2025-11-06T14:07:06Z","receivedAt":"2025-11-06T14:07:17Z","isPatch":true,"sender":{"key":"ben.knoble@gmail.com","avatar":"https://avatars.githubusercontent.com/u/22802209?v=4"},"body":"\n\n> Le 6 nov. 2025 à 02:22, Patrick Steinhardt <ps@pks.im> a écrit :\n> \n> On Tue, Nov 04, 2025 at 01:14:57PM -0500, D. Ben Knoble wrote:\n>> When install git-contacts with Meson via -Dcontrib=contacts, the default\n> \n> s/install/installing/\n\nThanks. If Junio doesn’t mind the trivial fix, I’ll avoid sending v2 for now :)\n\n> \n>> Perl generation fails to mark it executable. As a result, \"git contacts\"\n>> reports \"'contacts' is not a git command.\"\n>> \n>> Unlike generate-script.sh, we aren't testing the basename here; so, glob\n>> the script name in the case arm to match wherever the input comes from.\n> \n> Yeah, that feels sensibel to me.\n> \n>> diff --git a/generate-perl.sh b/generate-perl.sh\n>> index 65f122ebfc..796d835932 100755\n>> --- a/generate-perl.sh\n>> +++ b/generate-perl.sh\n>> @@ -30,7 +30,7 @@\n>>     \"$INPUT\" >\"$OUTPUT\"\n>> \n>> case \"$INPUT\" in\n>> -*.perl)\n>> +*.perl|*git-contacts)\n>>    chmod a+x \"$OUTPUT\";;\n>> *)\n>>    ;;\n> \n> And the change looks as expected. An alternative could of course be to\n> rename the file in-tree to \"git-contacts.perl\". In that case we wouldn't\n> require this special case at all. But I guess that this here is good\n> enough, and there might be other consequences if we renamed the script.\n\nMy worry too. \n\n> Thanks!\n> \n> Patrick\n\nThanks for the review!"},{"id":"530322","messageId":"xmqqikfnji40.fsf@gitster.g","threadId":"64439","inReplyTo":"87BB8F6A-7176-4C51-9F36-BA613E7D8B08@gmail.com","subject":"Re: [PATCH] perl: also mark git-contacts executable","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-11-06T15:28:15Z","receivedAt":"2025-11-06T15:28:18Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ben Knoble <ben.knoble@gmail.com> writes:\n\n>> Le 6 nov. 2025 à 02:22, Patrick Steinhardt <ps@pks.im> a écrit :\n>> \n>> On Tue, Nov 04, 2025 at 01:14:57PM -0500, D. Ben Knoble wrote:\n>>> When install git-contacts with Meson via -Dcontrib=contacts, the default\n>> \n>> s/install/installing/\n>\n> Thanks. If Junio doesn’t mind the trivial fix, I’ll avoid sending v2 for now :)\n\nWe'd be in pre-release freeze starting with -rc1, so no need to hurry.\n\n>> And the change looks as expected. An alternative could of course be to\n>> rename the file in-tree to \"git-contacts.perl\". In that case we wouldn't\n>> require this special case at all. But I guess that this here is good\n>> enough, and there might be other consequences if we renamed the script.\n\nHeh, I tend to thnik that consistently naming any Perl source to end\nin .perl (and Shell .sh) is the right fix, but anything in contrib/\nis allowed to be sloppy ;-)\n\n"},{"id":"530495","messageId":"15f07afcb66a900e5391e6b07e0701ce84236f04.1762820188.git.ben.knoble+github@gmail.com","threadId":"64439","inReplyTo":"7fbb341e8f05fcde3a1543e3bb4e5a3ec1101692.1762280097.git.ben.knoble+github@gmail.com","subject":"[PATCH v2] perl: also mark git-contacts executable","fromName":"D. Ben Knoble","fromEmail":"ben.knoble+github@gmail.com","sentAt":"2025-11-11T00:19:57Z","receivedAt":"2025-11-11T00:20:21Z","isPatch":true,"sender":{"key":"ben.knoble@gmail.com","avatar":"https://avatars.githubusercontent.com/u/22802209?v=4"},"body":"When installing git-contacts with Meson via -Dcontrib=contacts, the\ndefault Perl generation fails to mark it executable. As a result, \"git\ncontacts\" reports \"'contacts' is not a git command.\"\n\nUnlike generate-script.sh, we aren't testing the basename here; so, glob\nthe script name in the case arm to match wherever the input comes from.\n\nSigned-off-by: D. Ben Knoble <ben.knoble+github@gmail.com>\n---\n\nA small typo fix for the commit message, thanks to Patrick.\n\nv1: https://lore.kernel.org/git/7fbb341e8f05fcde3a1543e3bb4e5a3ec1101692.1762280097.git.ben.knoble+github@gmail.com/\n\n generate-perl.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/generate-perl.sh b/generate-perl.sh\nindex 65f122ebfc..796d835932 100755\n--- a/generate-perl.sh\n+++ b/generate-perl.sh\n@@ -30,7 +30,7 @@\n     \"$INPUT\" >\"$OUTPUT\"\n \n case \"$INPUT\" in\n-*.perl)\n+*.perl|*git-contacts)\n \tchmod a+x \"$OUTPUT\";;\n *)\n \t;;\n\nDiff-intervalle contre v1 :\n1:  7fbb341e8f ! 1:  15f07afcb6 perl: also mark git-contacts executable\n    @@ Metadata\n      ## Commit message ##\n         perl: also mark git-contacts executable\n     \n    -    When install git-contacts with Meson via -Dcontrib=contacts, the default\n    -    Perl generation fails to mark it executable. As a result, \"git contacts\"\n    -    reports \"'contacts' is not a git command.\"\n    +    When installing git-contacts with Meson via -Dcontrib=contacts, the\n    +    default Perl generation fails to mark it executable. As a result, \"git\n    +    contacts\" reports \"'contacts' is not a git command.\"\n     \n         Unlike generate-script.sh, we aren't testing the basename here; so, glob\n         the script name in the case arm to match wherever the input comes from.\n\nbase-commit: 7f278e958afbf9b7e0727631b4c26dcfa1c63d6e\nprerequisite-patch-id: 664e4667d11a226a89da52814505a0c8d31b9fba\n-- \n2.52.0.rc0.71.g03eda12af0.dirty\n\n"},{"id":"530523","messageId":"xmqqqzu4wg3u.fsf@gitster.g","threadId":"64439","inReplyTo":"15f07afcb66a900e5391e6b07e0701ce84236f04.1762820188.git.ben.knoble+github@gmail.com","subject":"Re: [PATCH v2] perl: also mark git-contacts executable","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-11-11T18:59:01Z","receivedAt":"2025-11-11T18:59:04Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"D. Ben Knoble\" <ben.knoble+github@gmail.com> writes:\n\n> When installing git-contacts with Meson via -Dcontrib=contacts, the\n> default Perl generation fails to mark it executable. As a result, \"git\n> contacts\" reports \"'contacts' is not a git command.\"\n>\n> Unlike generate-script.sh, we aren't testing the basename here; so, glob\n> the script name in the case arm to match wherever the input comes from.\n>\n> Signed-off-by: D. Ben Knoble <ben.knoble+github@gmail.com>\n> ---\n>\n> A small typo fix for the commit message, thanks to Patrick.\n>\n> v1: https://lore.kernel.org/git/7fbb341e8f05fcde3a1543e3bb4e5a3ec1101692.1762280097.git.ben.knoble+github@gmail.com/\n\nTogether with the html one, these patches match what I have already\nqueued with local tweaks, so I won't replace them (they are in\n'next' now).\n\nThanks.  \n\n"},{"id":"530524","messageId":"CALnO6CA2uLjWg_kwbaEGd+TZP4qQEBMus6HRVbo7Bz9oHdoYxA@mail.gmail.com","threadId":"64439","inReplyTo":"xmqqqzu4wg3u.fsf@gitster.g","subject":"Re: [PATCH v2] perl: also mark git-contacts executable","fromName":"D. Ben Knoble","fromEmail":"ben.knoble+github@gmail.com","sentAt":"2025-11-11T19:00:00Z","receivedAt":"2025-11-11T19:00:12Z","isPatch":true,"sender":{"key":"ben.knoble@gmail.com","avatar":"https://avatars.githubusercontent.com/u/22802209?v=4"},"body":"On Tue, Nov 11, 2025 at 1:59 PM Junio C Hamano <gitster@pobox.com> wrote:\n>\n> \"D. Ben Knoble\" <ben.knoble+github@gmail.com> writes:\n>\n> > When installing git-contacts with Meson via -Dcontrib=contacts, the\n> > default Perl generation fails to mark it executable. As a result, \"git\n> > contacts\" reports \"'contacts' is not a git command.\"\n> >\n> > Unlike generate-script.sh, we aren't testing the basename here; so, glob\n> > the script name in the case arm to match wherever the input comes from.\n> >\n> > Signed-off-by: D. Ben Knoble <ben.knoble+github@gmail.com>\n> > ---\n> >\n> > A small typo fix for the commit message, thanks to Patrick.\n> >\n> > v1: https://lore.kernel.org/git/7fbb341e8f05fcde3a1543e3bb4e5a3ec1101692.1762280097.git.ben.knoble+github@gmail.com/\n>\n> Together with the html one, these patches match what I have already\n> queued with local tweaks, so I won't replace them (they are in\n> 'next' now).\n>\n> Thanks.\n\nAh, sounds good. That was one of the things I wanted to ask by \"shall\nI send v2 or does Junio mind the trivial fix,\" and I should have been\nmore direct.\n\nThanks.\n"},{"id":"530542","messageId":"xmqqcy5owcel.fsf@gitster.g","threadId":"64439","inReplyTo":"CALnO6CA2uLjWg_kwbaEGd+TZP4qQEBMus6HRVbo7Bz9oHdoYxA@mail.gmail.com","subject":"Re: [PATCH v2] perl: also mark git-contacts executable","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-11-11T20:18:58Z","receivedAt":"2025-11-11T20:19:00Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"D. Ben Knoble\" <ben.knoble+github@gmail.com> writes:\n\n> On Tue, Nov 11, 2025 at 1:59 PM Junio C Hamano <gitster@pobox.com> wrote:\n>>\n>> \"D. Ben Knoble\" <ben.knoble+github@gmail.com> writes:\n>>\n>> > When installing git-contacts with Meson via -Dcontrib=contacts, the\n>> > default Perl generation fails to mark it executable. As a result, \"git\n>> > contacts\" reports \"'contacts' is not a git command.\"\n>> >\n>> > Unlike generate-script.sh, we aren't testing the basename here; so, glob\n>> > the script name in the case arm to match wherever the input comes from.\n>> >\n>> > Signed-off-by: D. Ben Knoble <ben.knoble+github@gmail.com>\n>> > ---\n>> >\n>> > A small typo fix for the commit message, thanks to Patrick.\n>> >\n>> > v1: https://lore.kernel.org/git/7fbb341e8f05fcde3a1543e3bb4e5a3ec1101692.1762280097.git.ben.knoble+github@gmail.com/\n>>\n>> Together with the html one, these patches match what I have already\n>> queued with local tweaks, so I won't replace them (they are in\n>> 'next' now).\n>>\n>> Thanks.\n>\n> Ah, sounds good. That was one of the things I wanted to ask by \"shall\n> I send v2 or does Junio mind the trivial fix,\" and I should have been\n> more direct.\n\nNo, your question did reach me loud and clear.\n"}]}