{"thread":{"id":"64432","subject":"[PATCH v2] doc: clarify server behavior for invalid 'want' lines in HTTP protocol","startedAt":"2025-11-04T10:07:10Z","lastAt":"2025-11-04T15:17:59Z","messageCount":3,"participants":["Queen Ediri Jessa","Junio C Hamano"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"530184","messageId":"20251104100653.2152-1-qjessa662@gmail.com","threadId":"64432","inReplyTo":null,"subject":"[PATCH v2] doc: clarify server behavior for invalid 'want' lines in HTTP protocol","fromName":"Queen Ediri Jessa","fromEmail":"qjessa662@gmail.com","sentAt":"2025-11-04T10:06:53Z","receivedAt":"2025-11-04T10:07:10Z","isPatch":true,"sender":{"key":"qjessa662@gmail.com","avatar":"https://avatars.githubusercontent.com/u/233464585?v=4"},"body":"From: QueenJcloud \n\n\nFrom: Queen Ediri Jessa \n\n\nUpdate the documentation to clearly describe how the server responds when a\nclient sends an invalid or malformed `want` line during the HTTP protocol\nexchange. This improves understanding of Git’s behavior when handling\nincorrect object requests and helps developers detect and handle such\nprotocol issues accurately.\n\nSigned-off-by: Queen Ediri Jessa \n\nChanges since v1:\n- Rephrased the explanation to be more concise and aligned with reviewer\n feedback.\n- Clarified that the server includes the offending object name in its error\n message.\n- Adjusted tone to describe the expected behavior rather than prescribing\n implementation-specific messages.\n- Improved readability and technical consistency of the section.\n---\n Documentation/gitprotocol-http.adoc | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)\n\ndiff --git a/Documentation/gitprotocol-http.adoc b/Documentation/gitprotocol-http.adoc\nindex d024010414..f3f48d3f35 100644\n--- a/Documentation/gitprotocol-http.adoc\n+++ b/Documentation/gitprotocol-http.adoc\n@@ -443,7 +443,10 @@ If no \"want\" objects are received, send an error:\n TODO: Define error if no \"want\" lines are requested.\n \n If any \"want\" object is not reachable, send an error:\n-TODO: Define error if an invalid \"want\" is requested.\n+When a Git server receives an invalid or malformed `want` line, it\n+responds with an error message that includes the offending object name.\n+This clarifies the expected behavior for Git implementations and helps\n+clients detect protocol issues accurately during fetch operations.\n \n Create an empty list, `s_common`.\n \n-- \n2.51.0.573.gb660e2dcb9\n\n"},{"id":"530191","messageId":"xmqqqzudrhkv.fsf@gitster.g","threadId":"64432","inReplyTo":"20251104100653.2152-1-qjessa662@gmail.com","subject":"Re: [PATCH v2] doc: clarify server behavior for invalid 'want' lines in HTTP protocol","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-11-04T14:35:44Z","receivedAt":"2025-11-04T14:35:47Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Queen Ediri Jessa writes:\n\n> From: QueenJcloud \n>\n>\n> From: Queen Ediri Jessa \n>\n>\n> Update the documentation to clearly describe how the server responds when a\n> client sends an invalid or malformed `want` line during the HTTP protocol\n> exchange. This improves understanding of Git’s behavior when handling\n> incorrect object requests and helps developers detect and handle such\n> protocol issues accurately.\n>\n> Signed-off-by: Queen Ediri Jessa \n>\n> Changes since v1:\n> - Rephrased the explanation to be more concise and aligned with reviewer\n> feedback.\n> - Clarified that the server includes the offending object name in its error\n> message.\n> - Adjusted tone to describe the expected behavior rather than prescribing\n> implementation-specific messages.\n> - Improved readability and technical consistency of the section.\n> ---\n> Documentation/gitprotocol-http.adoc | 5 ++++-\n> 1 file changed, 4 insertions(+), 1 deletion(-)\n\nI'll locally fix up before queuing this time, but\n\n * You now have one in-body header to force \"From: QueenJcloud\",\n after which the blank line declares everything below is the body\n and no in-body header remains, and then you have another line\n \"From: Queen Ediri Jessa\" that is not an in-body header. Perhaps\n you should send your e-mail only to yourself without sending to\n the list as practice to prevent them from appearing again? You\n only want the second one, IIUC.\n\n * Describing \"Changes since...\" is a very good idea, but that\n should be done _after_ the three-dash line, not beffore.\n\nThanks.\n\n> diff --git a/Documentation/gitprotocol-http.adoc b/Documentation/gitprotocol-http.adoc\n> index d024010414..f3f48d3f35 100644\n> --- a/Documentation/gitprotocol-http.adoc\n> +++ b/Documentation/gitprotocol-http.adoc\n> @@ -443,7 +443,10 @@ If no \"want\" objects are received, send an error:\n> TODO: Define error if no \"want\" lines are requested.\n> \n> If any \"want\" object is not reachable, send an error:\n> -TODO: Define error if an invalid \"want\" is requested.\n> +When a Git server receives an invalid or malformed `want` line, it\n> +responds with an error message that includes the offending object name.\n> +This clarifies the expected behavior for Git implementations and helps\n> +clients detect protocol issues accurately during fetch operations.\n> \n> Create an empty list, `s_common`.\n"},{"id":"530195","messageId":"CA+JX8FoXiDF7RtNM7Rx4idEZsQn=tsB2jUsWeCVk8o_OUR5bZA@mail.gmail.com","threadId":"64432","inReplyTo":"xmqqqzudrhkv.fsf@gitster.g","subject":"Re: [PATCH v2] doc: clarify server behavior for invalid 'want' lines in HTTP protocol","fromName":"Queen Ediri Jessa","fromEmail":"qjessa662@gmail.com","sentAt":"2025-11-04T15:17:47Z","receivedAt":"2025-11-04T15:17:59Z","isPatch":true,"sender":{"key":"qjessa662@gmail.com","avatar":"https://avatars.githubusercontent.com/u/233464585?v=4"},"body":"Thanks for the feedback, Junio.\nI’ll fix the duplicate “From” line and move the “Changes since”\nsection below the --- line as suggested.\nI’ll resend this as v3 after testing locally.\n\nOn Tue, Nov 4, 2025 at 3:35 PM Junio C Hamano wrote:\n>\n> Queen Ediri Jessa writes:\n>\n> > From: QueenJcloud \n> >\n> >\n> > From: Queen Ediri Jessa \n> >\n> >\n> > Update the documentation to clearly describe how the server responds when a\n> > client sends an invalid or malformed `want` line during the HTTP protocol\n> > exchange. This improves understanding of Git’s behavior when handling\n> > incorrect object requests and helps developers detect and handle such\n> > protocol issues accurately.\n> >\n> > Signed-off-by: Queen Ediri Jessa \n> >\n> > Changes since v1:\n> > - Rephrased the explanation to be more concise and aligned with reviewer\n> > feedback.\n> > - Clarified that the server includes the offending object name in its error\n> > message.\n> > - Adjusted tone to describe the expected behavior rather than prescribing\n> > implementation-specific messages.\n> > - Improved readability and technical consistency of the section.\n> > ---\n> > Documentation/gitprotocol-http.adoc | 5 ++++-\n> > 1 file changed, 4 insertions(+), 1 deletion(-)\n>\n> I'll locally fix up before queuing this time, but\n>\n> * You now have one in-body header to force \"From: QueenJcloud\",\n> after which the blank line declares everything below is the body\n> and no in-body header remains, and then you have another line\n> \"From: Queen Ediri Jessa\" that is not an in-body header. Perhaps\n> you should send your e-mail only to yourself without sending to\n> the list as practice to prevent them from appearing again? You\n> only want the second one, IIUC.\n>\n> * Describing \"Changes since...\" is a very good idea, but that\n> should be done _after_ the three-dash line, not beffore.\n>\n> Thanks.\n>\n> > diff --git a/Documentation/gitprotocol-http.adoc b/Documentation/gitprotocol-http.adoc\n> > index d024010414..f3f48d3f35 100644\n> > --- a/Documentation/gitprotocol-http.adoc\n> > +++ b/Documentation/gitprotocol-http.adoc\n> > @@ -443,7 +443,10 @@ If no \"want\" objects are received, send an error:\n> > TODO: Define error if no \"want\" lines are requested.\n> >\n> > If any \"want\" object is not reachable, send an error:\n> > -TODO: Define error if an invalid \"want\" is requested.\n> > +When a Git server receives an invalid or malformed `want` line, it\n> > +responds with an error message that includes the offending object name.\n> > +This clarifies the expected behavior for Git implementations and helps\n> > +clients detect protocol issues accurately during fetch operations.\n> >\n> > Create an empty list, `s_common`.\n"}]}