{"thread":{"id":"6443","subject":"[PATCH] New files in git weren't being downloaded during CVS update","startedAt":"2007-01-19T10:49:40Z","lastAt":"2007-01-20T10:41:29Z","messageCount":4,"participants":["Andy Parkins","Simon 'corecode' Schubert"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"32094","messageId":"200701191049.40833.andyparkins@gmail.com","threadId":"6443","inReplyTo":null,"subject":"[PATCH] New files in git weren't being downloaded during CVS update","fromName":"Andy Parkins","fromEmail":"andyparkins@gmail.com","sentAt":"2007-01-19T10:49:40Z","receivedAt":"2007-01-19T10:49:40Z","isPatch":true,"sender":{"key":"andyparkins@gmail.com","avatar":null},"body":"If a repository was checked out via git-cvsserver and then later a new\nfile is added to the git repository via some other method; a CVS update\nwasn't fetching the new file.\n\nIt would be reported as a new file as\n A some/dir/newfile.c\nbut would never appear in the directory.\n\nThe problem (I think) is that when git-cvsserver detected a new file, it\nwas issuing the new file message then skipping the actual file send part\nand moving to the next file its list. In fact only an updated file\nwould be transmitted.\n\nThe fix is to simply remove the \"next\" that was skipping the file\ntransmit; which is what this patch does.\n\nSigned-off-by: Andy Parkins \n---\nI don't understand enough about the CVS protocol to know whether this really\nis the right fix. It certainly addresses my problem, but I assume that the \"next\"\nwas put in there for a reason.\n\n git-cvsserver.perl | 1 -\n 1 files changed, 0 insertions(+), 1 deletions(-)\n\ndiff --git a/git-cvsserver.perl b/git-cvsserver.perl\nindex a33a876..c370a53 100755\n--- a/git-cvsserver.perl\n+++ b/git-cvsserver.perl\n@@ -882,7 +882,6 @@ sub req_update\n \t\tprint \"MT text A \\n\";\n print \"MT fname $filename\\n\";\n print \"MT newline\\n\";\n-\t\tnext;\n \n \t }\n \t else {\n-- \n1.5.0.rc1.gf4b6c\n"},{"id":"32123","messageId":"45B16E29.7000607@fs.ei.tum.de","threadId":"6443","inReplyTo":"200701191049.40833.andyparkins@gmail.com","subject":"Re: [PATCH] New files in git weren't being downloaded during CVS update","fromName":"Simon 'corecode' Schubert","fromEmail":"corecode@fs.ei.tum.de","sentAt":"2007-01-20T01:19:37Z","receivedAt":"2007-01-20T01:19:37Z","isPatch":true,"sender":{"key":"corecode@fs.ei.tum.de","avatar":"https://gravatar.com/avatar/eff9dbf0cdac0d1e6a6cd7ed0e50763edcb376b493b5253a35ff167918ad79e1?d=mp&s=160"},"body":"Andy Parkins wrote:\n> diff --git a/git-cvsserver.perl b/git-cvsserver.perl\n> index a33a876..c370a53 100755\n> --- a/git-cvsserver.perl\n> +++ b/git-cvsserver.perl\n> @@ -882,7 +882,6 @@ sub req_update\n> \t\tprint \"MT text A \\n\";\n> print \"MT fname $filename\\n\";\n> print \"MT newline\\n\";\n> -\t\tnext;\n\nI think this is the wrong fix. Reading cvs's classify.c, T_ADDED is only generated for *locally* added files, never for added files in the repo. The correct status would be \"U\" as well.\n\ncheers\n simon\n\n-- \nServe - BSD +++ RENT this banner advert +++ ASCII Ribbon /\"\\\nWork - Mac +++ space for low €€€ NOW!1 +++ Campaign \\ /\nParty Enjoy Relax | http://dragonflybsd.org Against HTML \\\nDude 2c 2 the max ! http://golden-apple.biz Mail + News / \\\n\n"},{"id":"32148","messageId":"200701201025.31251.andyparkins@gmail.com","threadId":"6443","inReplyTo":"45B16E29.7000607@fs.ei.tum.de","subject":"Re: [PATCH] New files in git weren't being downloaded during CVS update","fromName":"Andy Parkins","fromEmail":"andyparkins@gmail.com","sentAt":"2007-01-20T10:25:29Z","receivedAt":"2007-01-20T10:25:29Z","isPatch":true,"sender":{"key":"andyparkins@gmail.com","avatar":null},"body":"On Saturday 2007, January 20 01:19, Simon 'corecode' Schubert wrote:\n\n> I think this is the wrong fix. Reading cvs's classify.c, T_ADDED is\n> only generated for *locally* added files, never for added files in\n> the repo. The correct status would be \"U\" as well.\n\nI'm sure you're right; I don't know enough about CVS to comment. The \nreal fix would seem to be to completely remove the special case for \nadded files and let it drop through to the normal update code. \n\nHowever, I'm not confident about that either.\n\n\n\nAndy\n\n-- \nDr Andrew Parkins, M Eng (Hons), AMIEE\nandyparkins@gmail.com\n"},{"id":"32149","messageId":"45B1F1D9.7090903@fs.ei.tum.de","threadId":"6443","inReplyTo":"200701201025.31251.andyparkins@gmail.com","subject":"Re: [PATCH] New files in git weren't being downloaded during CVS update","fromName":"Simon 'corecode' Schubert","fromEmail":"corecode@fs.ei.tum.de","sentAt":"2007-01-20T10:41:29Z","receivedAt":"2007-01-20T10:41:29Z","isPatch":true,"sender":{"key":"corecode@fs.ei.tum.de","avatar":"https://gravatar.com/avatar/eff9dbf0cdac0d1e6a6cd7ed0e50763edcb376b493b5253a35ff167918ad79e1?d=mp&s=160"},"body":"Andy Parkins wrote:\n> On Saturday 2007, January 20 01:19, Simon 'corecode' Schubert wrote:\n> \n>> I think this is the wrong fix. Reading cvs's classify.c, T_ADDED is\n>> only generated for *locally* added files, never for added files in\n>> the repo. The correct status would be \"U\" as well.\n> \n> I'm sure you're right; I don't know enough about CVS to comment. The \n> real fix would seem to be to completely remove the special case for \n> added files and let it drop through to the normal update code. \n\nyes, that's what I ment.\n\ncheers\n simon\n\n-- \nServe - BSD +++ RENT this banner advert +++ ASCII Ribbon /\"\\\nWork - Mac +++ space for low €€€ NOW!1 +++ Campaign \\ /\nParty Enjoy Relax | http://dragonflybsd.org Against HTML \\\nDude 2c 2 the max ! http://golden-apple.biz Mail + News / \\\n\n"}]}