{"thread":{"id":"644","subject":"Re: [PATCH] uml: remove elf.h","startedAt":"2005-05-17T21:21:13Z","lastAt":"2005-05-17T21:44:51Z","messageCount":4,"participants":["Andrew Morton","Petr Baudis","Linus Torvalds"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"3473","messageId":"20050517142113.59097a3d.akpm@osdl.org","threadId":"644","inReplyTo":"200505171704.j4HH4Ne8002532@hera.kernel.org","subject":"Re: [PATCH] uml: remove elf.h","fromName":"Andrew Morton","fromEmail":"akpm@osdl.org","sentAt":"2005-05-17T21:21:13Z","receivedAt":"2005-05-17T21:21:13Z","isPatch":true,"sender":{"key":"akpm@osdl.org","avatar":null},"body":"Linux Kernel Mailing List wrote:\n>\n> tree a3d85d9f43f64bbd8437c973caf98f79d95b5f3e\n> parent a123edab03ac39e08c2f9cb4fc1af07e099c68bc\n> author Paolo 'Blaisorblade' Giarrusso Tue, 17 May 2005 11:53:14 -0700\n> committer Linus Torvalds Tue, 17 May 2005 21:59:11 -0700\n> \n> [PATCH] uml: remove elf.h\n> \n> Actually remove elf.h in the tree. The previous patch, due to a quilt\n> bug/misuse, left it in the tree as a 0-length file, preventing the build to\n> see it as missing and to generate a symlink in its place.\n> \n> Signed-off-by: Paolo 'Blaisorblade' Giarrusso \n> Signed-off-by: Andrew Morton \n> Signed-off-by: Linus Torvalds \n> \n> asm-um/elf.h | 0 \n> 1 files changed\n> \n> Index: include/asm-um/elf.h\n\nHot damn, this zero-length file is hard to get rid of. I pulled Linus's\ntree this morning with this bizarre concoction:\n\n\tcd $GIT_TREE\n\tcg-pull origin\n\ttagsha1=$(cat .git/refs/tags/v$(kversion))\n\tt=$(cat-file tag $tagsha1 | head -n 1 | sed -e 's/object //')\n\tcg-diff -r $t -r $(cat .git/refs/heads/origin) > $PULL/linus.patch\n\nand the resulting diff has:\n\nIndex: include/asm-ia64/ioctl32.h\n===================================================================\n--- eed337ef5e9ae7d62caa84b7974a11fddc7f06e0/include/asm-ia64/ioctl32.h (mode:100644 sha1:d0d227f45e05d23705ac849f4bd5c06a28288b58)\n+++ 6bb5a1cf91bbda8308ec7e6d900cb89071907dcd/include/asm-ia64/ioctl32.h (mode:100644 sha1:e69de29bb2d1d6434b8b29ae775ad8c2e48c5391)\n@@ -1 +0,0 @@\n-#include \nIndex: include/asm-um/elf.h\n===================================================================\nIndex: include/asm-x86_64/apicdef.h\n===================================================================\n\nwhich of course doesn't remove that file at all.\n\nAnd I bet that when Linus releases patch-2.6.12-rc5.gz and patch-2.6.12.gz,\nthey will have the same construct. AFAICT, the patch-based people will\nneed to download a full new tarball to get rid of this dang file.\n\nIt all wouldn't really matter much, except apparently the mere presence of\nthis file breaks the UML build.\n\nFrazzle. Paolo, I'm almost wondering if we should change that test to also\ncheck for a zero-length file.\n"},{"id":"3475","messageId":"20050517213447.GN7136@pasky.ji.cz","threadId":"644","inReplyTo":"20050517142113.59097a3d.akpm@osdl.org","subject":"Re: [PATCH] uml: remove elf.h","fromName":"Petr Baudis","fromEmail":"pasky@ucw.cz","sentAt":"2005-05-17T21:34:47Z","receivedAt":"2005-05-17T21:34:47Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Dear diary, on Tue, May 17, 2005 at 11:21:13PM CEST, I got a letter\nwhere Andrew Morton told me that...\n> Linux Kernel Mailing List wrote:\n> >\n> > tree a3d85d9f43f64bbd8437c973caf98f79d95b5f3e\n> > parent a123edab03ac39e08c2f9cb4fc1af07e099c68bc\n> > author Paolo 'Blaisorblade' Giarrusso Tue, 17 May 2005 11:53:14 -0700\n> > committer Linus Torvalds Tue, 17 May 2005 21:59:11 -0700\n> > \n> > [PATCH] uml: remove elf.h\n> > \n> > Actually remove elf.h in the tree. The previous patch, due to a quilt\n> > bug/misuse, left it in the tree as a 0-length file, preventing the build to\n> > see it as missing and to generate a symlink in its place.\n> > \n> > Signed-off-by: Paolo 'Blaisorblade' Giarrusso \n> > Signed-off-by: Andrew Morton \n> > Signed-off-by: Linus Torvalds \n> > \n> > asm-um/elf.h | 0 \n> > 1 files changed\n> > \n> > Index: include/asm-um/elf.h\n> \n> Hot damn, this zero-length file is hard to get rid of. I pulled Linus's\n> tree this morning with this bizarre concoction:\n> \n> \tcd $GIT_TREE\n> \tcg-pull origin\n> \ttagsha1=$(cat .git/refs/tags/v$(kversion))\n> \tt=$(cat-file tag $tagsha1 | head -n 1 | sed -e 's/object //')\n> \tcg-diff -r $t -r $(cat .git/refs/heads/origin) > $PULL/linus.patch\n> \n> and the resulting diff has:\n> \n> Index: include/asm-ia64/ioctl32.h\n> ===================================================================\n> --- eed337ef5e9ae7d62caa84b7974a11fddc7f06e0/include/asm-ia64/ioctl32.h (mode:100644 sha1:d0d227f45e05d23705ac849f4bd5c06a28288b58)\n> +++ 6bb5a1cf91bbda8308ec7e6d900cb89071907dcd/include/asm-ia64/ioctl32.h (mode:100644 sha1:e69de29bb2d1d6434b8b29ae775ad8c2e48c5391)\n> @@ -1 +0,0 @@\n> -#include \n> Index: include/asm-um/elf.h\n> ===================================================================\n> Index: include/asm-x86_64/apicdef.h\n> ===================================================================\n> \n> which of course doesn't remove that file at all.\n> \n> And I bet that when Linus releases patch-2.6.12-rc5.gz and patch-2.6.12.gz,\n> they will have the same construct. AFAICT, the patch-based people will\n> need to download a full new tarball to get rid of this dang file.\n\nFeeding\n--- include/asm-um/elf.h\n+++ /dev/null\npatch to cg-patch would make Cogito kill it. No help for regular patch\nthough, I fear. Perhaps some artificial timestamp could help to the file\nremoval heuristic in GNU patch. Or passing it -E, but that will\nobviously do the wrong thing to any other zero-sized files.\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\nC++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor\n"},{"id":"3477","messageId":"Pine.LNX.4.58.0505171440470.18337@ppc970.osdl.org","threadId":"644","inReplyTo":"20050517142113.59097a3d.akpm@osdl.org","subject":"Re: [PATCH] uml: remove elf.h","fromName":"Linus Torvalds","fromEmail":"torvalds@osdl.org","sentAt":"2005-05-17T21:42:44Z","receivedAt":"2005-05-17T21:42:44Z","isPatch":true,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"\n\nOn Tue, 17 May 2005, Andrew Morton wrote:\n> \n> And I bet that when Linus releases patch-2.6.12-rc5.gz and patch-2.6.12.gz,\n> they will have the same construct. AFAICT, the patch-based people will\n> need to download a full new tarball to get rid of this dang file.\n\nOr just run \"make distclean\" once.\n\n> It all wouldn't really matter much, except apparently the mere presence of\n> this file breaks the UML build.\n> \n> Frazzle. Paolo, I'm almost wondering if we should change that test to also\n> check for a zero-length file.\n\nHow many people are affected? The file _is_ gone in the git archives, and \nin fact I wonder if it was ever there, but I didn't bother to check.\n\n\t\tLinus\n"},{"id":"3478","messageId":"Pine.LNX.4.58.0505171443180.18337@ppc970.osdl.org","threadId":"644","inReplyTo":"20050517213447.GN7136@pasky.ji.cz","subject":"Re: [PATCH] uml: remove elf.h","fromName":"Linus Torvalds","fromEmail":"torvalds@osdl.org","sentAt":"2005-05-17T21:44:51Z","receivedAt":"2005-05-17T21:44:51Z","isPatch":true,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"\n\nOn Tue, 17 May 2005, Petr Baudis wrote:\n>\n> Perhaps some artificial timestamp could help to the file\n> removal heuristic in GNU patch. Or passing it -E, but that will\n> obviously do the wrong thing to any other zero-sized files.\n\n-E is always correct for the kernel, since zero-length files aren't really \nsupposed to exist anyway, and \"make distclean\" has always removed them.\n\n\t\tLinus\n"}]}