{"thread":{"id":"64385","subject":"[PATCH] contrib/credential: add install target","startedAt":"2025-10-25T20:15:40Z","lastAt":"2025-10-25T20:30:09Z","messageCount":2,"participants":["Thomas Uhle"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"529650","messageId":"84d7c984-b594-3ac7-2593-58664bd8c726@mailbox.tu-dresden.de","threadId":"64385","inReplyTo":null,"subject":"[PATCH] contrib/credential: add install target","fromName":"Thomas Uhle","fromEmail":"thomas.uhle@mailbox.tu-dresden.de","sentAt":"2025-10-25T20:15:12Z","receivedAt":"2025-10-25T20:15:40Z","isPatch":true,"sender":{"key":"thomas.uhle@mailbox.tu-dresden.de","avatar":"https://avatars.githubusercontent.com/u/6583219?v=4"},"body":"Add an install target rule to the Makefiles in contrib/credential in the\nsame manner as in other Makefiles in contrib such as for contacts or\nsubtree.\n---\nThis is the follow-up commit on top of some clean-up changes to the\nMakefiles in contrib/credential that I have been asked to send as a\nseparate patch.  Here is the previous patch:\nhttps://lore.kernel.org/git/0a61b0b3-365b-c198-6afd-f26fcd5a9c20@mailbox.tu-dresden.de/\n\n contrib/credential/libsecret/Makefile   | 7 ++++++-\n contrib/credential/osxkeychain/Makefile | 7 ++++++-\n 2 files changed, 12 insertions(+), 2 deletions(-)\n\ndiff --git a/contrib/credential/libsecret/Makefile b/contrib/credential/libsecret/Makefile\nindex 7cacc57..b10cfa3 100644\n--- a/contrib/credential/libsecret/Makefile\n+++ b/contrib/credential/libsecret/Makefile\n@@ -10,6 +10,7 @@\n CC ?= gcc\n CFLAGS ?= -g -O2 -Wall\n PKG_CONFIG ?= pkg-config\n+INSTALL ?= install\n RM ?= rm -f\n\n INCS:=$(shell $(PKG_CONFIG) --cflags libsecret-1 glib-2.0)\n@@ -21,7 +22,11 @@\n git-credential-libsecret: git-credential-libsecret.o\n \t$(CC) $(CFLAGS) -o $@ $^ $(LDFLAGS) $(LIBS)\n\n+install: git-credential-libsecret\n+\t$(INSTALL) -d -m 755 $(DESTDIR)$(gitexecdir)\n+\t$(INSTALL) -m 755 $< $(DESTDIR)$(gitexecdir)\n+\n clean:\n \t$(RM) git-credential-libsecret git-credential-libsecret.o\n\n-.PHONY: all clean\n+.PHONY: all install clean\ndiff --git a/contrib/credential/osxkeychain/Makefile b/contrib/credential/osxkeychain/Makefile\nindex c7d9121..5569581 100644\n--- a/contrib/credential/osxkeychain/Makefile\n+++ b/contrib/credential/osxkeychain/Makefile\n@@ -9,6 +9,7 @@\n\n CC ?= gcc\n CFLAGS ?= -g -O2 -Wall\n+INSTALL ?= install\n RM ?= rm -f\n\n %.o: %.c\n@@ -18,7 +19,11 @@\n \t$(CC) $(CFLAGS) -o $@ $^ $(LDFLAGS) \\\n \t\t-framework Security -framework CoreFoundation\n\n+install: git-credential-osxkeychain\n+\t$(INSTALL) -d -m 755 $(DESTDIR)$(gitexecdir)\n+\t$(INSTALL) -m 755 $< $(DESTDIR)$(gitexecdir)\n+\n clean:\n \t$(RM) git-credential-osxkeychain git-credential-osxkeychain.o\n\n-.PHONY: all clean\n+.PHONY: all install clean\n\nbase-commit: 4e98b730f18d59b670ee57b803e5048b9d14b968\n-- \n2.47.3\n"},{"id":"529651","messageId":"f67b3cbd-a117-a863-37ba-fbba7a2ca17a@mailbox.tu-dresden.de","threadId":"64385","inReplyTo":"84d7c984-b594-3ac7-2593-58664bd8c726@mailbox.tu-dresden.de","subject":"[PATCH v2] contrib/credential: add install target","fromName":"Thomas Uhle","fromEmail":"thomas.uhle@mailbox.tu-dresden.de","sentAt":"2025-10-25T20:30:07Z","receivedAt":"2025-10-25T20:30:09Z","isPatch":true,"sender":{"key":"thomas.uhle@mailbox.tu-dresden.de","avatar":"https://avatars.githubusercontent.com/u/6583219?v=4"},"body":"Add an install target rule to the Makefiles in contrib/credential in the\nsame manner as in other Makefiles in contrib such as for contacts or\nsubtree.\n\nSigned-off-by: Thomas Uhle <thomas.uhle@mailbox.tu-dresden.de>\n---\nI am terribly sorry to send this patch again as I forgot to add the\n\"Signed-off-by\" footer.  Everything else is still the same.\n\nThis is the follow-up commit on top of some clean-up changes to the\nMakefiles in contrib/credential that I have been asked to send as a\nseparate patch.  Here is the previous patch:\nhttps://lore.kernel.org/git/0a61b0b3-365b-c198-6afd-f26fcd5a9c20@mailbox.tu-dresden.de/\n\n contrib/credential/libsecret/Makefile   | 7 ++++++-\n contrib/credential/osxkeychain/Makefile | 7 ++++++-\n 2 files changed, 12 insertions(+), 2 deletions(-)\n\ndiff --git a/contrib/credential/libsecret/Makefile b/contrib/credential/libsecret/Makefile\nindex 7cacc57..b10cfa3 100644\n--- a/contrib/credential/libsecret/Makefile\n+++ b/contrib/credential/libsecret/Makefile\n@@ -10,6 +10,7 @@\n CC ?= gcc\n CFLAGS ?= -g -O2 -Wall\n PKG_CONFIG ?= pkg-config\n+INSTALL ?= install\n RM ?= rm -f\n\n INCS:=$(shell $(PKG_CONFIG) --cflags libsecret-1 glib-2.0)\n@@ -21,7 +22,11 @@\n git-credential-libsecret: git-credential-libsecret.o\n \t$(CC) $(CFLAGS) -o $@ $^ $(LDFLAGS) $(LIBS)\n\n+install: git-credential-libsecret\n+\t$(INSTALL) -d -m 755 $(DESTDIR)$(gitexecdir)\n+\t$(INSTALL) -m 755 $< $(DESTDIR)$(gitexecdir)\n+\n clean:\n \t$(RM) git-credential-libsecret git-credential-libsecret.o\n\n-.PHONY: all clean\n+.PHONY: all install clean\ndiff --git a/contrib/credential/osxkeychain/Makefile b/contrib/credential/osxkeychain/Makefile\nindex c7d9121..5569581 100644\n--- a/contrib/credential/osxkeychain/Makefile\n+++ b/contrib/credential/osxkeychain/Makefile\n@@ -9,6 +9,7 @@\n\n CC ?= gcc\n CFLAGS ?= -g -O2 -Wall\n+INSTALL ?= install\n RM ?= rm -f\n\n %.o: %.c\n@@ -18,7 +19,11 @@\n \t$(CC) $(CFLAGS) -o $@ $^ $(LDFLAGS) \\\n \t\t-framework Security -framework CoreFoundation\n\n+install: git-credential-osxkeychain\n+\t$(INSTALL) -d -m 755 $(DESTDIR)$(gitexecdir)\n+\t$(INSTALL) -m 755 $< $(DESTDIR)$(gitexecdir)\n+\n clean:\n \t$(RM) git-credential-osxkeychain git-credential-osxkeychain.o\n\n-.PHONY: all clean\n+.PHONY: all install clean\n\nbase-commit: 4e98b730f18d59b670ee57b803e5048b9d14b968\n-- \n2.47.3\n"}]}