{"thread":{"id":"64380","subject":"[PATCH] MyFirstContribution: add tip for confirming patches reached the mailing list","startedAt":"2025-10-24T15:16:04Z","lastAt":"2025-10-27T08:45:32Z","messageCount":4,"participants":["QueenJcloud","Junio C Hamano","Christian Couder"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"529608","messageId":"20251024151532.1968-1-qjessa662@gmail.com","threadId":"64380","inReplyTo":null,"subject":"[PATCH] MyFirstContribution: add tip for confirming patches reached the mailing list","fromName":"QueenJcloud","fromEmail":"qjessa662@gmail.com","sentAt":"2025-10-24T15:15:32Z","receivedAt":"2025-10-24T15:16:04Z","isPatch":true,"sender":{"key":"qjessa662@gmail.com","avatar":"https://avatars.githubusercontent.com/u/233464585?v=4"},"body":"After explaining how to send patches using `git send-email`, add a helpful tip\nfor contributors on how to confirm that their patches were successfully sent\nand appeared on the mailing list. This provides reassurance for newcomers and\nhelps them verify their submission.\n\nSigned-off-by: Queen Ediri Jessa \n---\n Documentation/MyFirstContribution.adoc | 7 +++++++\n 1 file changed, 7 insertions(+)\n\ndiff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc\nindex 02ba8ba5f6..94acdaeddd 100644\n--- a/Documentation/MyFirstContribution.adoc\n+++ b/Documentation/MyFirstContribution.adoc\n@@ -1158,6 +1158,13 @@ prompt for each patch that's about to go out. This gives you one last chance to\n edit or quit sending something (but again, don't edit code this way). Once you\n press `y` or `a` at these prompts your emails will be sent! Congratulations!\n \n+[TIP]\n+====\n+After sending your patches, you can confirm that they reached the mailing list\n+by visiting https://lore.kernel.org/git/. Use the search bar to find your name\n+or the subject of your patch. If it appears, your email was successfully delivered.\n+====|\n+\n Awesome, now the community will drop everything and review your changes. (Just\n kidding - be patient!)\n \n-- \n2.51.0.573.gb660e2dcb9\n\n"},{"id":"529612","messageId":"xmqqwm4kp9t7.fsf@gitster.g","threadId":"64380","inReplyTo":"20251024151532.1968-1-qjessa662@gmail.com","subject":"Re: [PATCH] MyFirstContribution: add tip for confirming patches reached the mailing list","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-10-24T16:02:28Z","receivedAt":"2025-10-24T16:02:31Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"QueenJcloud writes:\n\n> After explaining how to send patches using `git send-email`, add a helpful tip\n> for contributors on how to confirm that their patches were successfully sent\n> and appeared on the mailing list. This provides reassurance for newcomers and\n> helps them verify their submission.\n\nThis is a bit wider than desirable; it will bust 80-column limit\nwhen quoted twice in a discussion thread.\n\n> Signed-off-by: Queen Ediri Jessa \n> ---\n> Documentation/MyFirstContribution.adoc | 7 +++++++\n> 1 file changed, 7 insertions(+)\n\nWe want to see that author identity and the identity on Sign-off\nmatch. I can tweak the author identity on our end for this patch,\nbut if you are going to send further patches please make sure that\nyour [user] name = \"...\" configuration is what you wrote on the\nSign-off line.\n\n> diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc\n> index 02ba8ba5f6..94acdaeddd 100644\n> --- a/Documentation/MyFirstContribution.adoc\n> +++ b/Documentation/MyFirstContribution.adoc\n> @@ -1158,6 +1158,13 @@ prompt for each patch that's about to go out. This gives you one last chance to\n> edit or quit sending something (but again, don't edit code this way). Once you\n> press `y` or `a` at these prompts your emails will be sent! Congratulations!\n> \n> +[TIP]\n> +====\n> +After sending your patches, you can confirm that they reached the mailing list\n> +by visiting https://lore.kernel.org/git/. Use the search bar to find your name\n> +or the subject of your patch. If it appears, your email was successfully delivered.\n> +====|\n> +\n\nUse of [TIP] is new (we seem to use only [NOTE] adminition blocks in\nthe existing text). After reading the part before this hunk, the\nstructure of the section is\n\n (title -- sending email)\n\n It's time to mail it out, with this command\n\n $ git send-email ...\n\n [note] ...\n [note] ...\n [note] ...\n\n After you run the command above, you will be presented with a prompt...\n\nAnd you are adding a [tip] _after_ that, but the existing notes are\nalso about tips to use \"git send-email\" correctly. It is not like\nexisting explanation \"After you run ...\" is exactly correct. When\nyou get prompted, the command hasn't finished running. It merely is\n\"after you type the command and hit return\".\n\nI am tempted to move that \"After you run...\" sentence up and above\nthese three [note] admonition blocks (and rephrase it a bit, perhaps\nwith \"After\" -> \"When\"). Then add this new piece as the fourth [note].\n\nWhat's the vertical bar \"|\" after the closing example block\ndelimiter (i.e. the second \"====\")? I'll drop it as otherwise\nAsciidoctor complains\n\n asciidoctor: WARNING: MyFirstContribution.adoc: line 1162: unterminated admonition block\n\nand makes the rest of the document part of this [TIP].\n\nThanks.\n"},{"id":"529637","messageId":"20251024210433.2033-1-qjessa662@gmail.com","threadId":"64380","inReplyTo":"xmqqwm4kp9t7.fsf@gitster.g","subject":"[PATCH v2] MyFirstContribution: add note on confirming patches","fromName":"QueenJcloud","fromEmail":"qjessa662@gmail.com","sentAt":"2025-10-24T21:04:33Z","receivedAt":"2025-10-24T21:04:44Z","isPatch":true,"sender":{"key":"qjessa662@gmail.com","avatar":"https://avatars.githubusercontent.com/u/233464585?v=4"},"body":"Add a note after the `git send-email` section explaining how\ncontributors can confirm that their patches reached the mailing\nlist by checking https://lore.kernel.org/git/.\n\nSigned-off-by: QueenJcloud \n---\n Documentation/MyFirstContribution.adoc | 6 ++++++\n 1 file changed, 6 insertions(+)\n\ndiff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc\nindex 02ba8ba5f6..6e7f3036bb 100644\n--- a/Documentation/MyFirstContribution.adoc\n+++ b/Documentation/MyFirstContribution.adoc\n@@ -1153,11 +1153,17 @@ NOTE: When you are sending a real patch, it will go to git@vger.kernel.org - but\n please don't send your patchset from the tutorial to the real mailing list! For\n now, you can send it to yourself, to make sure you understand how it will look.\n \n+NOTE: After sending your patches, you can confirm that they reached the mailing\n+list by visiting https://lore.kernel.org/git/. Use the search bar to find your\n+name or the subject of your patch. If it appears, your email was successfully\n+delivered.\n+\n After you run the command above, you will be presented with an interactive\n prompt for each patch that's about to go out. This gives you one last chance to\n edit or quit sending something (but again, don't edit code this way). Once you\n press `y` or `a` at these prompts your emails will be sent! Congratulations!\n \n+\n Awesome, now the community will drop everything and review your changes. (Just\n kidding - be patient!)\n \n-- \n2.51.0.573.gb660e2dcb9\n\n"},{"id":"529705","messageId":"CAP8UFD0rMxdLN3TY3EACXHG6x40OPy-WYpbhPLx=ouk=6z7LZw@mail.gmail.com","threadId":"64380","inReplyTo":"20251024210433.2033-1-qjessa662@gmail.com","subject":"Re: [PATCH v2] MyFirstContribution: add note on confirming patches","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2025-10-27T08:45:19Z","receivedAt":"2025-10-27T08:45:32Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"On Fri, Oct 24, 2025 at 11:04 PM QueenJcloud wrote:\n>\n> Add a note after the `git send-email` section explaining how\n> contributors can confirm that their patches reached the mailing\n> list by checking https://lore.kernel.org/git/.\n>\n> Signed-off-by: QueenJcloud \n\nAre you sure that \"QueenJcloud\" is the best way to identify you? We\nprefer a real name if possible, and yeah it should match the name\nassociated with your email address.\n\nDocumentation/SubmittingPatches has the following about this:\n\n\"[[real-name]]\nPlease use a known identity in the `Signed-off-by` trailer, since we cannot\naccept anonymous contributions. It is common, but not required, to use some form\nof your real name. We realize that some contributors are not comfortable doing\nso or prefer to contribute under a pseudonym or preferred name and we can accept\nyour patch either way, as long as the name and email you use are distinctive,\nidentifying, and not misleading.\n\nThe goal of this policy is to allow us to have sufficient information to contact\nyou if questions arise about your contribution.\"\n\n> ---\n\nThis is a v2 patch, so it would be nice to know what changed since the\nprevious version of the patch. It could be added here after the line\nwith three dashes (\"---\").\n\nAlso it looks like this v2 patch was sent twice.\n\n> Documentation/MyFirstContribution.adoc | 6 ++++++\n> 1 file changed, 6 insertions(+)\n>\n> diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc\n> index 02ba8ba5f6..6e7f3036bb 100644\n> --- a/Documentation/MyFirstContribution.adoc\n> +++ b/Documentation/MyFirstContribution.adoc\n> @@ -1153,11 +1153,17 @@ NOTE: When you are sending a real patch, it will go to git@vger.kernel.org - but\n> please don't send your patchset from the tutorial to the real mailing list! For\n> now, you can send it to yourself, to make sure you understand how it will look.\n>\n> +NOTE: After sending your patches, you can confirm that they reached the mailing\n> +list by visiting https://lore.kernel.org/git/. Use the search bar to find your\n> +name or the subject of your patch. If it appears, your email was successfully\n> +delivered.\n\nThis looks good to me.\n\n> After you run the command above, you will be presented with an interactive\n> prompt for each patch that's about to go out. This gives you one last chance to\n> edit or quit sending something (but again, don't edit code this way). Once you\n> press `y` or `a` at these prompts your emails will be sent! Congratulations!\n>\n> +\n\nIt looks like there is a spurious new line here. Please remove it.\n\n> Awesome, now the community will drop everything and review your changes. (Just\n> kidding - be patient!)\n\n\nThanks.\n"}]}