{"thread":{"id":"6424","subject":"[PATCH] Shell syntax fix in git-reset","startedAt":"2007-01-18T11:15:13Z","lastAt":"2007-01-19T16:58:11Z","messageCount":2,"participants":["David Kågedal","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"31961","messageId":"87ac0gfuwu.fsf@morpheus.local","threadId":"6424","inReplyTo":null,"subject":"[PATCH] Shell syntax fix in git-reset","fromName":"David Kågedal","fromEmail":"davidk@lysator.liu.se","sentAt":"2007-01-18T11:15:13Z","receivedAt":"2007-01-18T11:15:13Z","isPatch":true,"sender":{"key":"davidk@lysator.liu.se","avatar":"https://avatars.githubusercontent.com/u/60530?v=4"},"body":"\n---\n git-reset.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\nMy /bin/sh is a symlink to dash, which is probably why I got this and\nfew others.\n\ndiff --git a/git-reset.sh b/git-reset.sh\nindex bf2a058..fee6d98 100755\n--- a/git-reset.sh\n+++ b/git-reset.sh\n@@ -43,7 +43,7 @@ case \"$1\" in --) shift ;; esac\n # affecting the working tree nor HEAD.\n if test $# != 0\n then\n-\ttest \"$reset_type\" == \"--mixed\" ||\n+\ttest \"$reset_type\" = \"--mixed\" ||\n \t\tdie \"Cannot do partial $reset_type reset.\"\n \n \tgit-diff-index --cached $rev -- \"$@\" |\n-- \n1.5.0.rc1.g04f3-dirty\n\n\n-- \nDavid Kågedal\n"},{"id":"32070","messageId":"7vr6trhs2k.fsf@assigned-by-dhcp.cox.net","threadId":"6424","inReplyTo":"87ac0gfuwu.fsf@morpheus.local","subject":"Re: [PATCH] Shell syntax fix in git-reset","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-01-19T16:58:11Z","receivedAt":"2007-01-19T16:58:11Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks for catching this.  With your fix,\n\n    $ git grep -e 'test .*==' -e '\\[ .*==' -- '*.sh'\n\ndoes not seem to hit anything else.\n"}]}