{"thread":{"id":"64175","subject":"[BUG] gitk assumes availability of `osascript` on macos","startedAt":"2025-09-20T12:07:44Z","lastAt":"2025-09-22T09:30:41Z","messageCount":4,"participants":["Robert Scott","Eric Sunshine","Johannes Sixt"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"526851","messageId":"2994140.eGJsNajkDb@alfonse","threadId":"64175","inReplyTo":null,"subject":"[BUG] gitk assumes availability of `osascript` on macos","fromName":"Robert Scott","fromEmail":"lists@humanleg.org.uk","sentAt":"2025-09-20T11:59:08Z","receivedAt":"2025-09-20T12:07:44Z","isPatch":false,"sender":{"key":"lists@humanleg.org.uk","avatar":null},"body":"Hi,\n\nTiny one here. On macos, gitk (tested 2.50.1) attempts to call `osascript` so \nit can focus/raise the UI. But it fails hard if `osascript` isn't present in \nthe $PATH.\n\nThere are a number of reasons `osascript` might not be available in a \nparticular environment, e.g. if launched from inside a \"pure\" nix shell, but \nseeing as it's just a quality-of-life feature it would be nice if failures to \ncall `osascript` could just be ignored.\n\nThanks,\n\n\nrobert.\n\n\n\n"},{"id":"526871","messageId":"CAPig+cTRYK+5ezmGxz0d1TwMTu1RKy7Xj05CzDE2-i14aUpSAg@mail.gmail.com","threadId":"64175","inReplyTo":"2994140.eGJsNajkDb@alfonse","subject":"Re: [BUG] gitk assumes availability of `osascript` on macos","fromName":"Eric Sunshine","fromEmail":"ericsunshine@gmail.com","sentAt":"2025-09-20T19:52:14Z","receivedAt":"2025-09-20T19:52:25Z","isPatch":false,"sender":{"key":"ericsunshine@gmail.com","avatar":null},"body":"On Sat, Sep 20, 2025 at 8:07 AM Robert Scott <lists@humanleg.org.uk> wrote:\n> Tiny one here. On macos, gitk (tested 2.50.1) attempts to call `osascript` so\n> it can focus/raise the UI. But it fails hard if `osascript` isn't present in\n> the $PATH.\n>\n> There are a number of reasons `osascript` might not be available in a\n> particular environment, e.g. if launched from inside a \"pure\" nix shell, but\n> seeing as it's just a quality-of-life feature it would be nice if failures to\n> call `osascript` could just be ignored.\n\nA patch[*] was posted to the mailing list years ago which, I believe,\nshould fix this problem for you. Unfortunately, the patch was never\npicked up due to the then-maintainer of Gitk being missing-in-action.\nPerhaps the current Gitk maintainer (Cc:'d) will pick up the patch.\n\n[*]: https://lore.kernel.org/git/20180724065120.7664-1-sunshine@sunshineco.com/\n"},{"id":"526915","messageId":"92bdb432-1f6d-43d9-a93b-8cbaf3c4a7fa@kdbg.org","threadId":"64175","inReplyTo":"CAPig+cTRYK+5ezmGxz0d1TwMTu1RKy7Xj05CzDE2-i14aUpSAg@mail.gmail.com","subject":"Re: [BUG] gitk assumes availability of `osascript` on macos","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2025-09-22T06:37:42Z","receivedAt":"2025-09-22T06:37:52Z","isPatch":false,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Am 20.09.25 um 21:52 schrieb Eric Sunshine:\n> On Sat, Sep 20, 2025 at 8:07 AM Robert Scott <lists@humanleg.org.uk> wrote:\n>> Tiny one here. On macos, gitk (tested 2.50.1) attempts to call `osascript` so\n>> it can focus/raise the UI. But it fails hard if `osascript` isn't present in\n>> the $PATH.\n>>\n>> There are a number of reasons `osascript` might not be available in a\n>> particular environment, e.g. if launched from inside a \"pure\" nix shell, but\n>> seeing as it's just a quality-of-life feature it would be nice if failures to\n>> call `osascript` could just be ignored.\n> \n> A patch[*] was posted to the mailing list years ago which, I believe,\n> should fix this problem for you. Unfortunately, the patch was never\n> picked up due to the then-maintainer of Gitk being missing-in-action.\n> Perhaps the current Gitk maintainer (Cc:'d) will pick up the patch.\n> \n> [*]: https://lore.kernel.org/git/20180724065120.7664-1-sunshine@sunshineco.com/\n\nI've picked up the patch:\nhttps://github.com/j6t/gitk/compare/master...es/ignore-osascript-failure\n\nPlease test and suggest improvements. Should the links in the commit\nmessage be redirected to lore.kernel.org?\n\n-- Hannes\n\n"},{"id":"526918","messageId":"CAPig+cQvjt8+3EGSj=-wP6p92402vuSg6FtU-kQ_27Ue__upsA@mail.gmail.com","threadId":"64175","inReplyTo":"92bdb432-1f6d-43d9-a93b-8cbaf3c4a7fa@kdbg.org","subject":"Re: [BUG] gitk assumes availability of `osascript` on macos","fromName":"Eric Sunshine","fromEmail":"ericsunshine@gmail.com","sentAt":"2025-09-22T09:30:29Z","receivedAt":"2025-09-22T09:30:41Z","isPatch":false,"sender":{"key":"ericsunshine@gmail.com","avatar":null},"body":"On Mon, Sep 22, 2025 at 2:37 AM Johannes Sixt <j6t@kdbg.org> wrote:\n> Am 20.09.25 um 21:52 schrieb Eric Sunshine:\n> > On Sat, Sep 20, 2025 at 8:07 AM Robert Scott <lists@humanleg.org.uk> wrote:\n> >> Tiny one here. On macos, gitk (tested 2.50.1) attempts to call `osascript` so\n> >> it can focus/raise the UI. But it fails hard if `osascript` isn't present in\n> >> the $PATH.\n> >>\n> >> There are a number of reasons `osascript` might not be available in a\n> >> particular environment, e.g. if launched from inside a \"pure\" nix shell, but\n> >> seeing as it's just a quality-of-life feature it would be nice if failures to\n> >> call `osascript` could just be ignored.\n> >\n> > A patch[*] was posted to the mailing list years ago which, I believe,\n> > should fix this problem for you. Unfortunately, the patch was never\n> > picked up due to the then-maintainer of Gitk being missing-in-action.\n> > Perhaps the current Gitk maintainer (Cc:'d) will pick up the patch.\n> >\n> > [*]: https://lore.kernel.org/git/20180724065120.7664-1-sunshine@sunshineco.com/\n>\n> I've picked up the patch:\n> https://github.com/j6t/gitk/compare/master...es/ignore-osascript-failure\n\nThank you. Looks good to me.\n\n> Please test and suggest improvements. Should the links in the commit\n> message be redirected to lore.kernel.org?\n\nUpdating the links would not be a bad idea. Here are the updated links\nif you want to amend locally:\n\n[1]: https://lore.kernel.org/git/D295145E-7596-4409-9681-D8ADBB9EBB0C@me.com/\n[2]: https://lore.kernel.org/git/CABNJ2G+h3zh+=wLA0KHjUn8TsfhqUK1Kn-1_=6hnXVRJUPhuuA@mail.gmail.com/\n\nOtherwise, I can resend.\n"}]}