{"thread":{"id":"64151","subject":"[PATCH] repo: add --all to git-repo-info","startedAt":"2025-09-15T22:36:35Z","lastAt":"2025-11-20T22:50:24Z","messageCount":30,"participants":["Lucas Seiki Oshiro","Junio C Hamano","Patrick Steinhardt","Eric Sunshine"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"526400","messageId":"20250915223618.13093-1-lucasseikioshiro@gmail.com","threadId":"64151","inReplyTo":null,"subject":"[PATCH] repo: add --all to git-repo-info","fromName":"Lucas Seiki Oshiro","fromEmail":"lucasseikioshiro@gmail.com","sentAt":"2025-09-15T22:36:17Z","receivedAt":"2025-09-15T22:36:35Z","isPatch":true,"sender":{"key":"lucasseikioshiro@gmail.com","avatar":"https://avatars.githubusercontent.com/u/12701580?v=4"},"body":"Add a new flag `--all` to git-repo-info for requesting all the available\nkeys. By using this flag, the user can retrieve all the values instead\nof searching what are the desired keys for what they wants.\n\nHelped-by: Karthik Nayak \nHelped-by: Patrick Steinhardt \nSigned-off-by: Lucas Seiki Oshiro \n---\nHi!\n\nThis patch is an epilogue of my GSoC, as it was requested to have some\nway to retrieve all the values without needing to pass all the keys.\n\nThis is built on top of the current master, a483264b01 (The ninth\nbatch, 2025-09-15).\n\n Documentation/git-repo.adoc | 6 ++--\n builtin/repo.c | 62 ++++++++++++++++++++++++++++---------\n t/t1900-repo.sh | 6 ++++\n 3 files changed, 56 insertions(+), 18 deletions(-)\n\ndiff --git a/Documentation/git-repo.adoc b/Documentation/git-repo.adoc\nindex 209afd1b61..2caf093a9a 100644\n--- a/Documentation/git-repo.adoc\n+++ b/Documentation/git-repo.adoc\n@@ -8,7 +8,7 @@ git-repo - Retrieve information about the repository\n SYNOPSIS\n --------\n [synopsis]\n-git repo info [--format=(keyvalue|nul)] [-z] [...]\n+git repo info [--format=(keyvalue|nul)] [-z] [--all] [...]\n \n DESCRIPTION\n -----------\n@@ -18,13 +18,13 @@ THIS COMMAND IS EXPERIMENTAL. THE BEHAVIOR MAY CHANGE.\n \n COMMANDS\n --------\n-`info [--format=(keyvalue|nul)] [-z] [...]`::\n+`info [--format=(keyvalue|nul)] [-z] [--all] [...]`::\n \tRetrieve metadata-related information about the current repository. Only\n \tthe requested data will be returned based on their keys (see \"INFO KEYS\"\n \tsection below).\n +\n The values are returned in the same order in which their respective keys were\n-requested.\n+requested. The `--all` flag requests all keys.\n +\n The output format can be chosen through the flag `--format`. Two formats are\n supported:\ndiff --git a/builtin/repo.c b/builtin/repo.c\nindex bbb0966f2d..906d8a3e12 100644\n--- a/builtin/repo.c\n+++ b/builtin/repo.c\n@@ -9,7 +9,7 @@\n #include \"shallow.h\"\n \n static const char *const repo_usage[] = {\n-\t\"git repo info [--format=(keyvalue|nul)] [-z] [...]\",\n+\t\"git repo info [--format=(keyvalue|nul)] [-z] [--all] [...]\",\n \tNULL\n };\n \n@@ -77,6 +77,24 @@ static get_value_fn *get_value_fn_for_key(const char *key)\n \treturn found ? found->get_value : NULL;\n }\n \n+static void print_field(enum output_format format, const char *key,\n+\t\t\tstruct strbuf *valbuf, struct strbuf *quotbuf)\n+{\n+\tstrbuf_reset(quotbuf);\n+\n+\tswitch (format) {\n+\tcase FORMAT_KEYVALUE:\n+\t\tquote_c_style(valbuf->buf, quotbuf, NULL, 0);\n+\t\tprintf(\"%s=%s\\n\", key, quotbuf->buf);\n+\t\tbreak;\n+\tcase FORMAT_NUL_TERMINATED:\n+\t\tprintf(\"%s\\n%s%c\", key, valbuf->buf, '\\0');\n+\t\tbreak;\n+\tdefault:\n+\t\tBUG(\"not a valid output format: %d\", format);\n+\t}\n+}\n+\n static int print_fields(int argc, const char **argv,\n \t\t\tstruct repository *repo,\n \t\t\tenum output_format format)\n@@ -97,21 +115,8 @@ static int print_fields(int argc, const char **argv,\n \t\t}\n \n \t\tstrbuf_reset(&valbuf);\n-\t\tstrbuf_reset("buf);\n-\n \t\tget_value(repo, &valbuf);\n-\n-\t\tswitch (format) {\n-\t\tcase FORMAT_KEYVALUE:\n-\t\t\tquote_c_style(valbuf.buf, "buf, NULL, 0);\n-\t\t\tprintf(\"%s=%s\\n\", key, quotbuf.buf);\n-\t\t\tbreak;\n-\t\tcase FORMAT_NUL_TERMINATED:\n-\t\t\tprintf(\"%s\\n%s%c\", key, valbuf.buf, '\\0');\n-\t\t\tbreak;\n-\t\tdefault:\n-\t\t\tBUG(\"not a valid output format: %d\", format);\n-\t\t}\n+\t\tprint_field(format, key, &valbuf, "buf);\n \t}\n \n \tstrbuf_release(&valbuf);\n@@ -119,6 +124,26 @@ static int print_fields(int argc, const char **argv,\n \treturn ret;\n }\n \n+static void print_all_fields(struct repository *repo,\n+\t\t\t enum output_format format)\n+{\n+\tstruct strbuf valbuf = STRBUF_INIT;\n+\tstruct strbuf quotbuf = STRBUF_INIT;\n+\n+\tfor (unsigned long i = 0; i < ARRAY_SIZE(repo_info_fields); i++) {\n+\t\tstruct field field = repo_info_fields[i];\n+\t\tget_value_fn *get_value = field.get_value;\n+\t\tconst char *key = field.key;\n+\n+\t\tstrbuf_reset(&valbuf);\n+\t\tget_value(repo, &valbuf);\n+\t\tprint_field(format, key, &valbuf, "buf);\n+\t}\n+\n+\tstrbuf_release(&valbuf);\n+\tstrbuf_release("buf);\n+}\n+\n static int parse_format_cb(const struct option *opt,\n \t\t\t const char *arg, int unset UNUSED)\n {\n@@ -140,6 +165,7 @@ static int repo_info(int argc, const char **argv, const char *prefix,\n \t\t struct repository *repo)\n {\n \tenum output_format format = FORMAT_KEYVALUE;\n+\tint all_keys = 0;\n \tstruct option options[] = {\n \t\tOPT_CALLBACK_F(0, \"format\", &format, N_(\"format\"),\n \t\t\t N_(\"output format\"),\n@@ -148,11 +174,17 @@ static int repo_info(int argc, const char **argv, const char *prefix,\n \t\t\t N_(\"synonym for --format=nul\"),\n \t\t\t PARSE_OPT_NONEG | PARSE_OPT_NOARG,\n \t\t\t parse_format_cb),\n+\t\tOPT_BOOL(0, \"all\", &all_keys, N_(\"return all keys\")),\n \t\tOPT_END()\n \t};\n \n \targc = parse_options(argc, argv, prefix, options, repo_usage, 0);\n \n+\tif (all_keys) {\n+\t\tprint_all_fields(repo, format);\n+\t\treturn 0;\n+\t}\n+\n \treturn print_fields(argc, argv, repo, format);\n }\n \ndiff --git a/t/t1900-repo.sh b/t/t1900-repo.sh\nindex 2beba67889..b1391a47b6 100755\n--- a/t/t1900-repo.sh\n+++ b/t/t1900-repo.sh\n@@ -110,4 +110,10 @@ test_expect_success 'git repo info uses the last requested format' '\n \ttest_cmp expected actual\n '\n \n+test_expect_success 'git repo info --all returns all fields' '\n+\tgit repo info layout.bare layout.shallow object.format references.format >expect &&\n+\tgit repo info --all >actual &&\n+\ttest_cmp expect actual\n+'\n+\n test_done\n-- \n2.39.5 (Apple Git-154)\n\n"},{"id":"526405","messageId":"xmqqfrcnclp3.fsf@gitster.g","threadId":"64151","inReplyTo":"20250915223618.13093-1-lucasseikioshiro@gmail.com","subject":"Re: [PATCH] repo: add --all to git-repo-info","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-09-15T23:58:32Z","receivedAt":"2025-09-15T23:58:35Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Lucas Seiki Oshiro writes:\n\n> Add a new flag `--all` to git-repo-info for requesting all the available\n> keys. By using this flag, the user can retrieve all the values instead\n> of searching what are the desired keys for what they wants.\n\nI initially read these three lines as \"we let you grab all the keys\n(without value), so that the caller do it once and then iterate over\nthem, asking for the values individually\".\n\nI think \"for requesting all the available keys\" can be tweaked to\navoid such a misunderstanding?\n\n for requesting values for all the available keys\n\nor something, perhaps?\n\n> -git repo info [--format=(keyvalue|nul)] [-z] [...]\n> +git repo info [--format=(keyvalue|nul)] [-z] [--all] [...]\n\nWouldn't it be more like\n\n\t..... [--all | ...]\n\nor does giving both --all and an indiviual key do something\ninteresting (like, just make sure these individual keys are valid,\nbut otherwise do the same as a simple --all)?\n\n> +`info [--format=(keyvalue|nul)] [-z] [--all] [...]`::\n> \tRetrieve metadata-related information about the current repository. Only\n> \tthe requested data will be returned based on their keys (see \"INFO KEYS\"\n> \tsection below).\n> +\n> The values are returned in the same order in which their respective keys were\n> -requested.\n> +requested. The `--all` flag requests all keys.\n\n\"requests values for all the keys.\"\n\n> \targc = parse_options(argc, argv, prefix, options, repo_usage, 0);\n> \n> +\tif (all_keys) {\n> +\t\tprint_all_fields(repo, format);\n> +\t\treturn 0;\n> +\t}\n> +\n> \treturn print_fields(argc, argv, repo, format);\n\nOK, so \"git repo info --all no-such-key\" will silently ignore\nno-such-key. I do not have much problem as long as it is\ndocumented, but there are a few equally plausible alternative\ndesigns.\n\n * \"git repo info --all anything\" ignores \"anything\" no matter what\n they are, as \"--all\" makes all keys on the command line ignored.\n\n * The same as above, but it warns about the extra command line\n arguments that are ignored.\n\n * \"git repo info --all object.format\" is rejected merely because\n \"--all\" is defined to be incompatible with giving any individual\n key.\n\n * \"git repo info --all object.format\" works as if the command is\n given all the defined keys and then object.format, i.e.\n object.format is reported twice. If you ask \"git repo info\n --all no.such.key\", it would fail while asking for no.such.key\n because there is no such key.\n\nI think the first one is what you have implemented.\n\nI see no practical reason why anybody want to pass a concrete key\nwhen asking \"--all\", but the first one feels the least intuitive one\namong these four. I think the last one is the most logical that\nlets users discover why it behaves that way the most easily, even\nthough it is debatable that succeeding and doing exactly what was\nrequested in that way is better than rejecting (or perhaps ignoring\nwith warning) these requests with extra command line arguments.\n\n> diff --git a/t/t1900-repo.sh b/t/t1900-repo.sh\n> index 2beba67889..b1391a47b6 100755\n> --- a/t/t1900-repo.sh\n> +++ b/t/t1900-repo.sh\n> @@ -110,4 +110,10 @@ test_expect_success 'git repo info uses the last requested format' '\n> \ttest_cmp expected actual\n> '\n> \n> +test_expect_success 'git repo info --all returns all fields' '\n> +\tgit repo info layout.bare layout.shallow object.format references.format >expect &&\n> +\tgit repo info --all >actual &&\n> +\ttest_cmp expect actual\n\nWe would want tests that asks \"--all object.format\" and \"--all no.key\",\nafter deciding what should happen.\n\nThanks.\n"},{"id":"526429","messageId":"aMkaePi90Q6sXuO4@pks.im","threadId":"64151","inReplyTo":"20250915223618.13093-1-lucasseikioshiro@gmail.com","subject":"Re: [PATCH] repo: add --all to git-repo-info","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2025-09-16T08:06:16Z","receivedAt":"2025-09-16T08:06:23Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Mon, Sep 15, 2025 at 07:36:17PM -0300, Lucas Seiki Oshiro wrote:\n> Add a new flag `--all` to git-repo-info for requesting all the available\n> keys. By using this flag, the user can retrieve all the values instead\n> of searching what are the desired keys for what they wants.\n\nOne thing I wonder is whether we actually need the \"--all\" flag in the\nfirst place. Right now, when saying `git repo info` without any further\narguments, then the user will be met with complete silence. I don't\nreally think that this is useful as a default in any way, as it makes it\nvery difficult for the user to figure out what kind of information\nexists in the first place.\n\nSo how about we don't introduce a separate flag, but instead detect the\ncase where the user passed no arguments at all and then print all values\nby default? It changes the current behaviour, but on the other hand I\nwould argue that the current behaviour is not useful in the first place.\nAnd the command is labelled as experimental anyway, so for now we still\ncan change it.\n\n> diff --git a/builtin/repo.c b/builtin/repo.c\n> index bbb0966f2d..906d8a3e12 100644\n> --- a/builtin/repo.c\n> +++ b/builtin/repo.c\n> @@ -77,6 +77,24 @@ static get_value_fn *get_value_fn_for_key(const char *key)\n> \treturn found ? found->get_value : NULL;\n> }\n> \n> +static void print_field(enum output_format format, const char *key,\n> +\t\t\tstruct strbuf *valbuf, struct strbuf *quotbuf)\n> +{\n> +\tstrbuf_reset(quotbuf);\n> +\n> +\tswitch (format) {\n> +\tcase FORMAT_KEYVALUE:\n> +\t\tquote_c_style(valbuf->buf, quotbuf, NULL, 0);\n> +\t\tprintf(\"%s=%s\\n\", key, quotbuf->buf);\n> +\t\tbreak;\n> +\tcase FORMAT_NUL_TERMINATED:\n> +\t\tprintf(\"%s\\n%s%c\", key, valbuf->buf, '\\0');\n> +\t\tbreak;\n> +\tdefault:\n> +\t\tBUG(\"not a valid output format: %d\", format);\n> +\t}\n> +}\n> +\n> static int print_fields(int argc, const char **argv,\n> \t\t\tstruct repository *repo,\n> \t\t\tenum output_format format)\n\nChanges like this which are preparatory refactorings can also be split\nout into separate commits. That makes it easier to see and review such a\nchange standalone.\n\n> @@ -119,6 +124,26 @@ static int print_fields(int argc, const char **argv,\n> \treturn ret;\n> }\n> \n> +static void print_all_fields(struct repository *repo,\n> +\t\t\t enum output_format format)\n> +{\n> +\tstruct strbuf valbuf = STRBUF_INIT;\n> +\tstruct strbuf quotbuf = STRBUF_INIT;\n> +\n> +\tfor (unsigned long i = 0; i < ARRAY_SIZE(repo_info_fields); i++) {\n> +\t\tstruct field field = repo_info_fields[i];\n> +\t\tget_value_fn *get_value = field.get_value;\n> +\t\tconst char *key = field.key;\n\nNit: I don't really feel like the `get_value` or `key` variables help\nmuch. I'd just drop those.\n\n> @@ -140,6 +165,7 @@ static int repo_info(int argc, const char **argv, const char *prefix,\n> \t\t struct repository *repo)\n> {\n> \tenum output_format format = FORMAT_KEYVALUE;\n> +\tint all_keys = 0;\n> \tstruct option options[] = {\n> \t\tOPT_CALLBACK_F(0, \"format\", &format, N_(\"format\"),\n> \t\t\t N_(\"output format\"),\n> @@ -148,11 +174,17 @@ static int repo_info(int argc, const char **argv, const char *prefix,\n> \t\t\t N_(\"synonym for --format=nul\"),\n> \t\t\t PARSE_OPT_NONEG | PARSE_OPT_NOARG,\n> \t\t\t parse_format_cb),\n> +\t\tOPT_BOOL(0, \"all\", &all_keys, N_(\"return all keys\")),\n> \t\tOPT_END()\n> \t};\n> \n> \targc = parse_options(argc, argv, prefix, options, repo_usage, 0);\n> \n> +\tif (all_keys) {\n> +\t\tprint_all_fields(repo, format);\n> +\t\treturn 0;\n> +\t}\n\nInstead of checking for `all_keys` we could check for `if (!argc)` if\nyou want to follow my suggestion.\n\n> \treturn print_fields(argc, argv, repo, format);\n> }\n> \n> diff --git a/t/t1900-repo.sh b/t/t1900-repo.sh\n> index 2beba67889..b1391a47b6 100755\n> --- a/t/t1900-repo.sh\n> +++ b/t/t1900-repo.sh\n> @@ -110,4 +110,10 @@ test_expect_success 'git repo info uses the last requested format' '\n> \ttest_cmp expected actual\n> '\n> \n> +test_expect_success 'git repo info --all returns all fields' '\n> +\tgit repo info layout.bare layout.shallow object.format references.format >expect &&\n> +\tgit repo info --all >actual &&\n> +\ttest_cmp expect actual\n> +'\n\nThis test will obviously need to be adapted every time we add a new\nfield, which I think is fine. But we should adapt it so that it's easily\nextensible without by just adding another line. E.g. like this:\n\n test_expect_success 'git repo info --all returns all fields' '\n git repo info \\\n layout.bare \\\n layout.shallow \\\n object.format \\\n references.format \\\n >expect &&\n git repo info --all >actual &&\n test_cmp expect actual\n '\n\nThis ensures that it's as simple as adding a new line when we add a\nspecific field without having to rewrite the whole line.\n\nPatrick\n"},{"id":"526452","messageId":"xmqqv7linzex.fsf@gitster.g","threadId":"64151","inReplyTo":"aMkaePi90Q6sXuO4@pks.im","subject":"Re: [PATCH] repo: add --all to git-repo-info","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-09-16T16:19:02Z","receivedAt":"2025-09-16T16:19:05Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Patrick Steinhardt writes:\n\n> One thing I wonder is whether we actually need the \"--all\" flag in the\n> first place. Right now, when saying `git repo info` without any further\n> arguments, then the user will be met with complete silence. I don't\n> really think that this is useful as a default in any way, as it makes it\n> very difficult for the user to figure out what kind of information\n> exists in the first place.\n\nIf we were talking about interactive tool, I might agree, but for a\ntool for scriptors,\n\n tool \"$@\"\n\nshould not silently turn into\n\n tool --all\n\nwhen $# == 0. That is asking for surprises.\n\n"},{"id":"526539","messageId":"aMpIaVPdgnbhBvlG@pks.im","threadId":"64151","inReplyTo":"xmqqv7linzex.fsf@gitster.g","subject":"Re: [PATCH] repo: add --all to git-repo-info","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2025-09-17T05:34:33Z","receivedAt":"2025-09-17T05:34:41Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Tue, Sep 16, 2025 at 09:19:02AM -0700, Junio C Hamano wrote:\n> Patrick Steinhardt writes:\n> \n> > One thing I wonder is whether we actually need the \"--all\" flag in the\n> > first place. Right now, when saying `git repo info` without any further\n> > arguments, then the user will be met with complete silence. I don't\n> > really think that this is useful as a default in any way, as it makes it\n> > very difficult for the user to figure out what kind of information\n> > exists in the first place.\n> \n> If we were talking about interactive tool, I might agree, but for a\n> tool for scriptors,\n> \n> tool \"$@\"\n> \n> should not silently turn into\n> \n> tool --all\n> \n> when $# == 0. That is asking for surprises.\n\nThat's fair. Let's stick with a flag then.\n\nPatrick\n"},{"id":"529664","messageId":"20251026225409.46647-1-lucasseikioshiro@gmail.com","threadId":"64151","inReplyTo":"20250915223618.13093-1-lucasseikioshiro@gmail.com","subject":"[PATCH v3 0/2] repo: add --all to git-repo-info","fromName":"Lucas Seiki Oshiro","fromEmail":"lucasseikioshiro@gmail.com","sentAt":"2025-10-26T22:52:06Z","receivedAt":"2025-10-26T22:54:27Z","isPatch":true,"sender":{"key":"lucasseikioshiro@gmail.com","avatar":"https://avatars.githubusercontent.com/u/12701580?v=4"},"body":"Hi!\n\nThis is the third version of the patchset that adds a new flag --all\nto git-repo-info for requesting the values of all the available flags.\n\nNow, in this version, git-repo-info will abort if it is called with --all\nand some key.\n\nHere's the range-diff against v2:\n\n1: 5f72f07589 = 1: 0db9aad2bc repo: factor out field printing to dedicated function\n2: b8158bb7b8 ! 2: b6ecdc2c2f repo: add --all to git-repo-info\n @@ Documentation/git-repo.adoc: THIS COMMAND IS EXPERIMENTAL. THE BEHAVIOR MAY CHAN\n The values are returned in the same order in which their respective keys were\n -requested.\n +requested. The `--all` flag requests the values for all the available keys.\n -+Keys requested after `--all` will be duplicated.\n +\n The output format can be chosen through the flag `--format`. Two formats are\n supported:\n @@ builtin/repo.c: static int print_fields(int argc, const char **argv,\n +\n +\tfor (unsigned long i = 0; i < ARRAY_SIZE(repo_info_fields); i++) {\n +\t\tstruct field field = repo_info_fields[i];\n -+\t\tget_value_fn *get_value = field.get_value;\n -+\t\tconst char *key = field.key;\n +\n +\t\tstrbuf_reset(&valbuf);\n -+\t\tget_value(repo, &valbuf);\n -+\t\tprint_field(format, key, &valbuf, "buf);\n ++\t\tfield.get_value(repo, &valbuf);\n ++\t\tprint_field(format, field.key, &valbuf, "buf);\n +\t}\n +\n +\tstrbuf_release(&valbuf);\n @@ builtin/repo.c: static int repo_info(int argc, const char **argv, const char *pr\n \n \targc = parse_options(argc, argv, prefix, options, repo_usage, 0);\n \n -+\tif (all_keys)\n ++\tif (all_keys) {\n ++\t\tif (argc)\n ++\t\t\tdie(_(\"--all and cannot be used together\"));\n ++\n +\t\tprint_all_fields(repo, format);\n ++\t\treturn 0;\n ++\t}\n +\n \treturn print_fields(argc, argv, repo, format);\n }\n @@ t/t1900-repo.sh: test_expect_success 'git repo info uses the last requested form\n +\ttest_cmp expect actual\n +'\n +\n -+test_expect_success 'git repo info --all duplicates ' '\n -+\tgit repo info $REPO_INFO_KEYS object.format >expect &&\n -+\tgit repo info --all object.format >actual &&\n ++test_expect_success 'git repo info --all aborts' '\n ++\techo \"fatal: --all and cannot be used together\" >expect &&\n ++\ttest_must_fail git repo info --all object.format 2>actual &&\n +\ttest_cmp expect actual\n +'\n -+\n -+test_expect_success 'git repo info --all warns about invalid key' '\n -+\tgit repo info $REPO_INFO_KEYS >expect &&\n -+\techo \"error: key ${SQ}no.key${SQ} not found\" >expect_err &&\n -+\ttest_must_fail git repo info --all no.key >actual 2>actual_err &&\n -+\ttest_cmp expect actual &&\n -+\ttest_cmp expect_err actual_err\n -+'\n +\n test_done\n\nLucas Seiki Oshiro (2):\n repo: factor out field printing to dedicated function\n repo: add --all to git-repo-info\n\n Documentation/git-repo.adoc | 6 ++--\n builtin/repo.c | 63 ++++++++++++++++++++++++++++---------\n t/t1900-repo.sh | 21 +++++++++++++\n 3 files changed, 72 insertions(+), 18 deletions(-)\n\n-- \n2.50.1 (Apple Git-155)\n\n"},{"id":"529665","messageId":"20251026225409.46647-2-lucasseikioshiro@gmail.com","threadId":"64151","inReplyTo":"20251026225409.46647-1-lucasseikioshiro@gmail.com","subject":"[PATCH v3 1/2] repo: factor out field printing to dedicated function","fromName":"Lucas Seiki Oshiro","fromEmail":"lucasseikioshiro@gmail.com","sentAt":"2025-10-26T22:52:07Z","receivedAt":"2025-10-26T22:54:29Z","isPatch":true,"sender":{"key":"lucasseikioshiro@gmail.com","avatar":"https://avatars.githubusercontent.com/u/12701580?v=4"},"body":"Move the field printing in git-repo-info to a new function called\n`print_field`, allowing it to be called by functions other than\n`print_fields`.\n\nSigned-off-by: Lucas Seiki Oshiro \n---\n builtin/repo.c | 33 +++++++++++++++++++--------------\n 1 file changed, 19 insertions(+), 14 deletions(-)\n\ndiff --git a/builtin/repo.c b/builtin/repo.c\nindex bbb0966f2d..3b071e9a50 100644\n--- a/builtin/repo.c\n+++ b/builtin/repo.c\n@@ -77,6 +77,24 @@ static get_value_fn *get_value_fn_for_key(const char *key)\n \treturn found ? found->get_value : NULL;\n }\n \n+static void print_field(enum output_format format, const char *key,\n+\t\t\tstruct strbuf *valbuf, struct strbuf *quotbuf)\n+{\n+\tstrbuf_reset(quotbuf);\n+\n+\tswitch (format) {\n+\tcase FORMAT_KEYVALUE:\n+\t\tquote_c_style(valbuf->buf, quotbuf, NULL, 0);\n+\t\tprintf(\"%s=%s\\n\", key, quotbuf->buf);\n+\t\tbreak;\n+\tcase FORMAT_NUL_TERMINATED:\n+\t\tprintf(\"%s\\n%s%c\", key, valbuf->buf, '\\0');\n+\t\tbreak;\n+\tdefault:\n+\t\tBUG(\"not a valid output format: %d\", format);\n+\t}\n+}\n+\n static int print_fields(int argc, const char **argv,\n \t\t\tstruct repository *repo,\n \t\t\tenum output_format format)\n@@ -97,21 +115,8 @@ static int print_fields(int argc, const char **argv,\n \t\t}\n \n \t\tstrbuf_reset(&valbuf);\n-\t\tstrbuf_reset("buf);\n-\n \t\tget_value(repo, &valbuf);\n-\n-\t\tswitch (format) {\n-\t\tcase FORMAT_KEYVALUE:\n-\t\t\tquote_c_style(valbuf.buf, "buf, NULL, 0);\n-\t\t\tprintf(\"%s=%s\\n\", key, quotbuf.buf);\n-\t\t\tbreak;\n-\t\tcase FORMAT_NUL_TERMINATED:\n-\t\t\tprintf(\"%s\\n%s%c\", key, valbuf.buf, '\\0');\n-\t\t\tbreak;\n-\t\tdefault:\n-\t\t\tBUG(\"not a valid output format: %d\", format);\n-\t\t}\n+\t\tprint_field(format, key, &valbuf, "buf);\n \t}\n \n \tstrbuf_release(&valbuf);\n-- \n2.50.1 (Apple Git-155)\n\n"},{"id":"529666","messageId":"20251026225409.46647-3-lucasseikioshiro@gmail.com","threadId":"64151","inReplyTo":"20251026225409.46647-1-lucasseikioshiro@gmail.com","subject":"[PATCH v3 2/2] repo: add --all to git-repo-info","fromName":"Lucas Seiki Oshiro","fromEmail":"lucasseikioshiro@gmail.com","sentAt":"2025-10-26T22:52:08Z","receivedAt":"2025-10-26T22:54:32Z","isPatch":true,"sender":{"key":"lucasseikioshiro@gmail.com","avatar":"https://avatars.githubusercontent.com/u/12701580?v=4"},"body":"Add a new flag `--all` to git-repo-info for requesting values for all\nthe available keys. By using this flag, the user can retrieve all the\nvalues instead of searching what are the desired keys for what they\nwants.\n\nHelped-by: Karthik Nayak \nHelped-by: Patrick Steinhardt \nSigned-off-by: Lucas Seiki Oshiro \n---\n Documentation/git-repo.adoc | 6 +++---\n builtin/repo.c | 30 +++++++++++++++++++++++++++++-\n t/t1900-repo.sh | 21 +++++++++++++++++++++\n 3 files changed, 53 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/git-repo.adoc b/Documentation/git-repo.adoc\nindex 209afd1b61..e61af9ce3b 100644\n--- a/Documentation/git-repo.adoc\n+++ b/Documentation/git-repo.adoc\n@@ -8,7 +8,7 @@ git-repo - Retrieve information about the repository\n SYNOPSIS\n --------\n [synopsis]\n-git repo info [--format=(keyvalue|nul)] [-z] [...]\n+git repo info [--format=(keyvalue|nul)] [-z] [--all | ...]\n \n DESCRIPTION\n -----------\n@@ -18,13 +18,13 @@ THIS COMMAND IS EXPERIMENTAL. THE BEHAVIOR MAY CHANGE.\n \n COMMANDS\n --------\n-`info [--format=(keyvalue|nul)] [-z] [...]`::\n+`info [--format=(keyvalue|nul)] [-z] [--all | ...]`::\n \tRetrieve metadata-related information about the current repository. Only\n \tthe requested data will be returned based on their keys (see \"INFO KEYS\"\n \tsection below).\n +\n The values are returned in the same order in which their respective keys were\n-requested.\n+requested. The `--all` flag requests the values for all the available keys.\n +\n The output format can be chosen through the flag `--format`. Two formats are\n supported:\ndiff --git a/builtin/repo.c b/builtin/repo.c\nindex 3b071e9a50..67d647bb3c 100644\n--- a/builtin/repo.c\n+++ b/builtin/repo.c\n@@ -9,7 +9,7 @@\n #include \"shallow.h\"\n \n static const char *const repo_usage[] = {\n-\t\"git repo info [--format=(keyvalue|nul)] [-z] [...]\",\n+\t\"git repo info [--format=(keyvalue|nul)] [-z] [--all | ...]\",\n \tNULL\n };\n \n@@ -124,6 +124,24 @@ static int print_fields(int argc, const char **argv,\n \treturn ret;\n }\n \n+static void print_all_fields(struct repository *repo,\n+\t\t\t enum output_format format)\n+{\n+\tstruct strbuf valbuf = STRBUF_INIT;\n+\tstruct strbuf quotbuf = STRBUF_INIT;\n+\n+\tfor (unsigned long i = 0; i < ARRAY_SIZE(repo_info_fields); i++) {\n+\t\tstruct field field = repo_info_fields[i];\n+\n+\t\tstrbuf_reset(&valbuf);\n+\t\tfield.get_value(repo, &valbuf);\n+\t\tprint_field(format, field.key, &valbuf, "buf);\n+\t}\n+\n+\tstrbuf_release(&valbuf);\n+\tstrbuf_release("buf);\n+}\n+\n static int parse_format_cb(const struct option *opt,\n \t\t\t const char *arg, int unset UNUSED)\n {\n@@ -145,6 +163,7 @@ static int repo_info(int argc, const char **argv, const char *prefix,\n \t\t struct repository *repo)\n {\n \tenum output_format format = FORMAT_KEYVALUE;\n+\tint all_keys = 0;\n \tstruct option options[] = {\n \t\tOPT_CALLBACK_F(0, \"format\", &format, N_(\"format\"),\n \t\t\t N_(\"output format\"),\n@@ -153,11 +172,20 @@ static int repo_info(int argc, const char **argv, const char *prefix,\n \t\t\t N_(\"synonym for --format=nul\"),\n \t\t\t PARSE_OPT_NONEG | PARSE_OPT_NOARG,\n \t\t\t parse_format_cb),\n+\t\tOPT_BOOL(0, \"all\", &all_keys, N_(\"return all keys\")),\n \t\tOPT_END()\n \t};\n \n \targc = parse_options(argc, argv, prefix, options, repo_usage, 0);\n \n+\tif (all_keys) {\n+\t\tif (argc)\n+\t\t\tdie(_(\"--all and cannot be used together\"));\n+\n+\t\tprint_all_fields(repo, format);\n+\t\treturn 0;\n+\t}\n+\n \treturn print_fields(argc, argv, repo, format);\n }\n \ndiff --git a/t/t1900-repo.sh b/t/t1900-repo.sh\nindex 2beba67889..51d55f11a5 100755\n--- a/t/t1900-repo.sh\n+++ b/t/t1900-repo.sh\n@@ -4,6 +4,15 @@ test_description='test git repo-info'\n \n . ./test-lib.sh\n \n+# git-repo-info keys. It must contain the same keys listed in the const\n+# repo_info_fields, in lexicographical order.\n+REPO_INFO_KEYS='\n+\tlayout.bare\n+\tlayout.shallow\n+\tobject.format\n+\treferences.format\n+'\n+\n # Test whether a key-value pair is correctly returned\n #\n # Usage: test_repo_info