{"thread":{"id":"64114","subject":"[PATCH] doc: fast-import: replace literal block with paragraph","startedAt":"2025-09-08T20:29:08Z","lastAt":"2025-09-08T21:21:22Z","messageCount":3,"participants":["kristofferhaugsbakk@fastmail.com","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"525877","messageId":"09aaad696895c18c6d4dda7d6a2f4b77f84f39ba.1757363213.git.code@khaugsbakk.name","threadId":"64114","inReplyTo":null,"subject":"[PATCH] doc: fast-import: replace literal block with paragraph","fromName":"","fromEmail":"kristofferhaugsbakk@fastmail.com","sentAt":"2025-09-08T20:28:45Z","receivedAt":"2025-09-08T20:29:08Z","isPatch":true,"sender":{"key":"kristofferhaugsbakk@fastmail.com","avatar":null},"body":"From: Kristoffer Haugsbakk <code@khaugsbakk.name>\n\n68061e34702 (fast-import: disallow \"feature export-marks\" by default,\n2019-08-29) added the documentation for this option.  The second\nparagraph is a literal block but it looks like it should just be\na regular paragraph.\n\nSigned-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>\n---\n\nNotes (series):\n    > but it looks like it should just be a regular paragraph.\n    \n    ... unless this is some kind of callout-block style?\n\n Documentation/git-fast-import.adoc | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/git-fast-import.adoc b/Documentation/git-fast-import.adoc\nindex 3144ffcdb68..c3951f5f879 100644\n--- a/Documentation/git-fast-import.adoc\n+++ b/Documentation/git-fast-import.adoc\n@@ -61,10 +61,10 @@ OPTIONS\n \tcurrently impacts only the `export-marks`, `import-marks`, and\n \t`import-marks-if-exists` feature commands.\n +\n-\tOnly enable this option if you trust the program generating the\n-\tfast-import stream! This option is enabled automatically for\n-\tremote-helpers that use the `import` capability, as they are\n-\talready trusted to run their own code.\n+Only enable this option if you trust the program generating the\n+fast-import stream! This option is enabled automatically for\n+remote-helpers that use the `import` capability, as they are\n+already trusted to run their own code.\n \n Options for Frontends\n ~~~~~~~~~~~~~~~~~~~~~\n\nbase-commit: 2462961280690837670d997bde64bd4ebf8ae66d\n-- \n2.51.0.16.gcd94ab5bf81\n\n"},{"id":"525880","messageId":"20250908210546.GA1327610@coredump.intra.peff.net","threadId":"64114","inReplyTo":"09aaad696895c18c6d4dda7d6a2f4b77f84f39ba.1757363213.git.code@khaugsbakk.name","subject":"Re: [PATCH] doc: fast-import: replace literal block with paragraph","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2025-09-08T21:05:46Z","receivedAt":"2025-09-08T21:05:48Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Mon, Sep 08, 2025 at 10:28:45PM +0200, kristofferhaugsbakk@fastmail.com wrote:\n\n>     > but it looks like it should just be a regular paragraph.\n>     \n>     ... unless this is some kind of callout-block style?\n\nNope, I think it was just a mistake on my part. IIRC it is a common\nasciidoc pitfall not to remove indentation when doing a continuation\nblock. Your patch looks like the right fix. Thanks for finding it.\n\n-Peff\n"},{"id":"525882","messageId":"724b975078daf11e17f26472c0da5638a5d1ca86.1757366352.git.code@khaugsbakk.name","threadId":"64114","inReplyTo":"09aaad696895c18c6d4dda7d6a2f4b77f84f39ba.1757363213.git.code@khaugsbakk.name","subject":"[PATCH v2] doc: fast-import: replace literal block with paragraph","fromName":"","fromEmail":"kristofferhaugsbakk@fastmail.com","sentAt":"2025-09-08T21:20:54Z","receivedAt":"2025-09-08T21:21:22Z","isPatch":true,"sender":{"key":"kristofferhaugsbakk@fastmail.com","avatar":null},"body":"From: Kristoffer Haugsbakk <code@khaugsbakk.name>\n\n68061e34702 (fast-import: disallow \"feature export-marks\" by default,\n2019-08-29) added the documentation for this option.  The second\nparagraph is a literal block but it looks like it should just be\na regular paragraph.\n\nAcked-by: Jeff King <peff@peff.net>\nSigned-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>\n---\n\nNotes (series):\n    v1:\n    \n    > but it looks like it should just be a regular paragraph.\n    \n    ... unless this is some kind of callout-block style?\n\n Documentation/git-fast-import.adoc | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/git-fast-import.adoc b/Documentation/git-fast-import.adoc\nindex 3144ffcdb68..c3951f5f879 100644\n--- a/Documentation/git-fast-import.adoc\n+++ b/Documentation/git-fast-import.adoc\n@@ -61,10 +61,10 @@ OPTIONS\n \tcurrently impacts only the `export-marks`, `import-marks`, and\n \t`import-marks-if-exists` feature commands.\n +\n-\tOnly enable this option if you trust the program generating the\n-\tfast-import stream! This option is enabled automatically for\n-\tremote-helpers that use the `import` capability, as they are\n-\talready trusted to run their own code.\n+Only enable this option if you trust the program generating the\n+fast-import stream! This option is enabled automatically for\n+remote-helpers that use the `import` capability, as they are\n+already trusted to run their own code.\n \n Options for Frontends\n ~~~~~~~~~~~~~~~~~~~~~\n\nRange-diff against v1:\n1:  09aaad69689 ! 1:  724b975078d doc: fast-import: replace literal block with paragraph\n    @@ Commit message\n         paragraph is a literal block but it looks like it should just be\n         a regular paragraph.\n     \n    +    Acked-by: Jeff King <peff@peff.net>\n         Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>\n     \n     \n      ## Notes (series) ##\n    +    v1:\n    +\n         > but it looks like it should just be a regular paragraph.\n     \n         ... unless this is some kind of callout-block style?\n\nbase-commit: 2462961280690837670d997bde64bd4ebf8ae66d\n-- \n2.51.0.16.gcd94ab5bf81\n\n"}]}