{"thread":{"id":"6406","subject":"[PATCH] Fix spurious compile error","startedAt":"2007-01-16T21:10:54Z","lastAt":"2007-01-16T21:10:54Z","messageCount":1,"participants":["Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"31846","messageId":"Pine.LNX.4.63.0701162210060.22628@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"6406","inReplyTo":null,"subject":"[PATCH] Fix spurious compile error","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-01-16T21:10:54Z","receivedAt":"2007-01-16T21:10:54Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"\n>From time to time, I would get this error:\n\n[...]\nsed: -e expression #8, char 41: Unterminated `s' command\nmake: *** [git-add--interactive] Error 1\n\nTurns out that the function WriteMakefile() called in Makefile.PL\noutputs the message \"Writing perl.mak for Git\" to stdout! Thus,\nthe output of \"make -C perl -s --no-print-directory instlibdir\"\nwould be prefixed by that message whenever Makefile.PL was newer\nthan perl.mak.\n\nThis is fixed by redirecting stdout to stderr in Makefile.PL.\n\nSigned-off-by: Johannes E. Schindelin <johannes.schindelin@gmx.de>\n---\n perl/Makefile.PL |    4 ++++\n 1 files changed, 4 insertions(+), 0 deletions(-)\n\ndiff --git a/perl/Makefile.PL b/perl/Makefile.PL\nindex 4168775..9b117fd 100644\n--- a/perl/Makefile.PL\n+++ b/perl/Makefile.PL\n@@ -20,6 +20,10 @@ if ($@) {\n my %extra;\n $extra{DESTDIR} = $ENV{DESTDIR} if $ENV{DESTDIR};\n \n+# redirect stdout, otherwise the message \"Writing perl.mak for Git\"\n+# disrupts the output for the target 'instlibdir'\n+open STDOUT, \">&STDERR\";\n+\n WriteMakefile(\n \tNAME            => 'Git',\n \tVERSION_FROM    => 'Git.pm',\n-- \n1.3.3.g79f3\n"}]}