{"thread":{"id":"63932","subject":"[PATCH] t6137-*.sh: fix test failure on cygwin","startedAt":"2025-08-08T19:35:12Z","lastAt":"2025-08-09T11:53:20Z","messageCount":3,"participants":["Ramsay Jones","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"523842","messageId":"5514f2fd-3307-42c8-97ac-bc2147a7ba41@ramsayjones.plus.com","threadId":"63932","inReplyTo":null,"subject":"[PATCH] t6137-*.sh: fix test failure on cygwin","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2025-08-08T19:32:02Z","receivedAt":"2025-08-08T19:35:12Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nCommit 6fd1106aa4 (\"t3700: Skip a test with backslashes in pathspec\",\n2009-03-13) introduced the BSLASHPSPEC prerequisite. This prerequisite\nallows tests to check for systems that can use backslashes in pathspecs\n(e.g. to escape glob special characters). On windows (and cygwin), this\ndoes not work because backslashes are used as directory separators, and\ngit eagerly converts them to forward slashes.\n\nThis test file uses the FUNNYNAMES prerequisite to skip this test file\non windows, despite not really being appropriate for this test, which\ndoes not hold on cygwin. The FUNNYNAMES prerequisite is set when the\nsystem can create files with embedded quotes (\"), tabs or newlines in\nthe name. Since cygwin can satisfy FUNNYNAMES, but not BSLASHPSPEC, this\nleads to test failures on cygwin.\n\nIn order to skip these tests on cygwin, replace the FUNNYNAMES prerequisite\nwith BSLASHPSPEC, so that this test file is skipped on both windows and\ncygwin. While here, fix a few test titles as well.\n\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Junio,\n\nThis test failure is not a regression for this cycle (it was a\nregression for v2.50.0-rc0), but it would be nice to get it applied\nbefore release, if possible.\n\n[Hmm, I have just noticed that the 'skip_all' message could drop the\nredundant 'skipping: ' at the beginning - oh well! ;) ]\n\nATB,\nRamsay Jones\n\n t/t6137-pathspec-wildcards-literal.sh | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)\n\ndiff --git a/t/t6137-pathspec-wildcards-literal.sh b/t/t6137-pathspec-wildcards-literal.sh\nindex 20abad5667..17a03085ef 100755\n--- a/t/t6137-pathspec-wildcards-literal.sh\n+++ b/t/t6137-pathspec-wildcards-literal.sh\n@@ -3,8 +3,8 @@ test_description='test wildcards and literals with git add/commit (subshell styl\n \n . ./test-lib.sh\n \n-test_have_prereq FUNNYNAMES || {\n-\tskip_all='skipping: needs FUNNYNAMES (non-Windows only)'\n+test_have_prereq BSLASHPSPEC || {\n+\tskip_all='skipping: needs BSLASHPSPEC (backslashes in pathspecs)'\n \ttest_done\n }\n \n@@ -184,7 +184,7 @@ test_expect_success 'add wildcard f?z' '\n \t)\n '\n \n-test_expect_success 'add literal \\? literal' '\n+test_expect_success 'add literal \\?' '\n \tgit init test-q-lit &&\n \t(\n \t\tcd test-q-lit &&\n@@ -241,7 +241,7 @@ test_expect_success 'add literal hello\\?world' '\n \t)\n '\n \n-test_expect_success 'add literal [abc]' '\n+test_expect_success 'add literal \\[abc\\]' '\n \tgit init test-brackets-lit &&\n \t(\n \t\tcd test-brackets-lit &&\n@@ -280,7 +280,7 @@ test_expect_success 'commit: wildcard *' '\n \t)\n '\n \n-test_expect_success 'commit: literal *' '\n+test_expect_success 'commit: literal \\*' '\n \tgit init test-c-asterisk-lit &&\n \t(\n \t\tcd test-c-asterisk-lit &&\n@@ -328,7 +328,7 @@ test_expect_success 'commit: literal f\\*' '\n \t)\n '\n \n-test_expect_success 'commit: wildcard pathspec limits commit' '\n+test_expect_success 'commit: wildcard f**' '\n \tgit init test-c-pathlimit &&\n \t(\n \t\tcd test-c-pathlimit &&\n-- \n2.50.0\n"},{"id":"523843","messageId":"xmqq8qjth7um.fsf@gitster.g","threadId":"63932","inReplyTo":"5514f2fd-3307-42c8-97ac-bc2147a7ba41@ramsayjones.plus.com","subject":"Re: [PATCH] t6137-*.sh: fix test failure on cygwin","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-08-08T20:33:05Z","receivedAt":"2025-08-08T20:33:08Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ramsay Jones <ramsay@ramsayjones.plus.com> writes:\n\n> [Hmm, I have just noticed that the 'skip_all' message could drop the\n> redundant 'skipping: ' at the beginning - oh well! ;) ]\n\nYeah, I see skip_all=\"# SKIP $skip_all\" in test-lib.sh\n\nLet me squash the following in, to further match the message we give\nwhen the test environment fails a test prerequisite.\n\n t/t6137-pathspec-wildcards-literal.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git c/t/t6137-pathspec-wildcards-literal.sh w/t/t6137-pathspec-wildcards-literal.sh\nindex 17a03085ef..e582378181 100755\n--- c/t/t6137-pathspec-wildcards-literal.sh\n+++ w/t/t6137-pathspec-wildcards-literal.sh\n@@ -4,7 +4,7 @@ test_description='test wildcards and literals with git add/commit (subshell styl\n . ./test-lib.sh\n \n test_have_prereq BSLASHPSPEC || {\n-\tskip_all='skipping: needs BSLASHPSPEC (backslashes in pathspecs)'\n+\tskip_all='missing BSLASHPSPEC (backslashes in pathspecs)'\n \ttest_done\n }\n \n\n\n\n"},{"id":"523868","messageId":"8f3e6afc-4dce-420e-a6a4-d54b0409aa2f@ramsayjones.plus.com","threadId":"63932","inReplyTo":"xmqq8qjth7um.fsf@gitster.g","subject":"Re: [PATCH] t6137-*.sh: fix test failure on cygwin","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2025-08-09T11:50:10Z","receivedAt":"2025-08-09T11:53:20Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\n\nOn 08/08/2025 21:33, Junio C Hamano wrote:\n> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:\n> \n>> [Hmm, I have just noticed that the 'skip_all' message could drop the\n>> redundant 'skipping: ' at the beginning - oh well! ;) ]\n> \n> Yeah, I see skip_all=\"# SKIP $skip_all\" in test-lib.sh\n> \n> Let me squash the following in, to further match the message we give\n> when the test environment fails a test prerequisite.\n> \n>  t/t6137-pathspec-wildcards-literal.sh | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git c/t/t6137-pathspec-wildcards-literal.sh w/t/t6137-pathspec-wildcards-literal.sh\n> index 17a03085ef..e582378181 100755\n> --- c/t/t6137-pathspec-wildcards-literal.sh\n> +++ w/t/t6137-pathspec-wildcards-literal.sh\n> @@ -4,7 +4,7 @@ test_description='test wildcards and literals with git add/commit (subshell styl\n>  . ./test-lib.sh\n>  \n>  test_have_prereq BSLASHPSPEC || {\n> -\tskip_all='skipping: needs BSLASHPSPEC (backslashes in pathspecs)'\n> +\tskip_all='missing BSLASHPSPEC (backslashes in pathspecs)'\n>  \ttest_done\n>  }\n>  \n\nLGTM. Thanks!\n\nATB,\nRamsay Jones\n\n\n"}]}