{"thread":{"id":"63885","subject":"[PATCH] docs: remove stray bracket from git-clone synopsis","startedAt":"2025-07-31T14:46:21Z","lastAt":"2025-08-12T15:55:33Z","messageCount":7,"participants":["Knut Harald Ryager via GitGitGadget","Junio C Hamano","Kristoffer Haugsbakk"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"523096","messageId":"pull.2023.git.git.1753973177262.gitgitgadget@gmail.com","threadId":"63885","inReplyTo":null,"subject":"[PATCH] docs: remove stray bracket from git-clone synopsis","fromName":"Knut Harald Ryager via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2025-07-31T14:46:17Z","receivedAt":"2025-07-31T14:46:21Z","isPatch":true,"sender":{"key":"name:Knut Harald Ryager","avatar":null},"body":"From: E-K-n <e-k-nut@hotmail.com>\n\nThe git-clone documentation contained an extra ‘]’ after\n`--also-filter-submodules]`.\n\nThis patch removes the duplicate ‘]’ so that the line reads:\n\n    [--also-filter-submodules] [--] <repository>\n\ninstead of:\n\n    [--also-filter-submodules]] [--] <repository>\n\nSigned-off-by: Knut Harald Ryager <e-k-nut@hotmail.com>\n---\n    Remove excess right bracket from git-clone docs\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2023%2FKnutRyager%2Fmaster-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2023/KnutRyager/master-v1\nPull-Request: https://github.com/git/git/pull/2023\n\n Documentation/git-clone.adoc | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-clone.adoc b/Documentation/git-clone.adoc\nindex 222d558290e..851502552f2 100644\n--- a/Documentation/git-clone.adoc\n+++ b/Documentation/git-clone.adoc\n@@ -16,7 +16,7 @@ git clone [--template=<template-directory>]\n \t  [--depth <depth>] [--[no-]single-branch] [--[no-]tags]\n \t  [--recurse-submodules[=<pathspec>]] [--[no-]shallow-submodules]\n \t  [--[no-]remote-submodules] [--jobs <n>] [--sparse] [--[no-]reject-shallow]\n-\t  [--filter=<filter-spec>] [--also-filter-submodules]] [--] <repository>\n+\t  [--filter=<filter-spec>] [--also-filter-submodules] [--] <repository>\n \t  [<directory>]\n \n DESCRIPTION\n\nbase-commit: e813a0200a7121b97fec535f0d0b460b0a33356c\n-- \ngitgitgadget\n"},{"id":"523115","messageId":"xmqqh5ysqivy.fsf@gitster.g","threadId":"63885","inReplyTo":"pull.2023.git.git.1753973177262.gitgitgadget@gmail.com","subject":"Re: [PATCH] docs: remove stray bracket from git-clone synopsis","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-07-31T19:07:13Z","receivedAt":"2025-07-31T19:07:16Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Knut Harald Ryager via GitGitGadget\" <gitgitgadget@gmail.com>\nwrites:\n\n> From: E-K-n <e-k-nut@hotmail.com>\n\nThis should be updated to match the name you use on your sign-off\nbelow.\n\n> The git-clone documentation contained an extra ‘]’ after\n> `--also-filter-submodules]`.\n\nIt is correct to point out that the brackets are not matching, but I\nthink the one that you are removing a wrong one.\n\nWhen f05da2b4 (clone, submodule: pass partial clone filters to\nsubmodules, 2022-02-04) added an option --also-filter-submodules to\nthe command, it wanted to express that the option is only valid when\nthe \"--filter=<filter-spec>\" option is also given.  And it did its\nupdate correctly:\n\n-         [--filter=<filter>] [--] <repository>\n+         [--filter=<filter> [--also-filter-submodules]] [--] <repository>\n \nLater, 76880f05 (doc: git-clone: apply new documentation formatting\nguidelines, 2024-03-29) introduced the extra closing bracket after\n\"--filter=<filter>\" to make these two look as if they are unrelated\nand independent, i.e.\n\n    [--filter=<filter>] [--also-filter-submodules]]\n\nSo, I think the one immediately after \"--filter=<filter>\" is what\nyou want to remove, not the one after \"--also-filter-submodules\".\n\n> This patch removes the duplicate ‘]’ so that the line reads:\n>\n>     [--also-filter-submodules] [--] <repository>\n>\n> instead of:\n>\n>     [--also-filter-submodules]] [--] <repository>\n\nWe do not say \"this patch does X\" in our proposed log message.\nInstead, you tell somebody sitting on the keyboard to \"Do X\".\n\nIOW, something like\n\n    Remove the extra and incorrect closing bracket, so that the line\n    reads:\n\n        [--filter=<filter> [--also-filter-submodules]]\n\n    instead of\n\n        [--filter=<filter>] [--also-filter-submodules]]\n\nis how we write this.\n\n> Signed-off-by: Knut Harald Ryager <e-k-nut@hotmail.com>\n> ---\n>     Remove excess right bracket from git-clone docs\n>\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2023%2FKnutRyager%2Fmaster-v1\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2023/KnutRyager/master-v1\n> Pull-Request: https://github.com/git/git/pull/2023\n>\n>  Documentation/git-clone.adoc | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/git-clone.adoc b/Documentation/git-clone.adoc\n> index 222d558290e..851502552f2 100644\n> --- a/Documentation/git-clone.adoc\n> +++ b/Documentation/git-clone.adoc\n> @@ -16,7 +16,7 @@ git clone [--template=<template-directory>]\n>  \t  [--depth <depth>] [--[no-]single-branch] [--[no-]tags]\n>  \t  [--recurse-submodules[=<pathspec>]] [--[no-]shallow-submodules]\n>  \t  [--[no-]remote-submodules] [--jobs <n>] [--sparse] [--[no-]reject-shallow]\n> -\t  [--filter=<filter-spec>] [--also-filter-submodules]] [--] <repository>\n> +\t  [--filter=<filter-spec>] [--also-filter-submodules] [--] <repository>\n>  \t  [<directory>]\n>  \n>  DESCRIPTION\n>\n> base-commit: e813a0200a7121b97fec535f0d0b460b0a33356c\n"},{"id":"523900","messageId":"pull.2023.v2.git.git.1754861423787.gitgitgadget@gmail.com","threadId":"63885","inReplyTo":"pull.2023.git.git.1753973177262.gitgitgadget@gmail.com","subject":"[PATCH v2] Remove the extra and incorrect closing bracket, so that the line reads:","fromName":"Knut Harald Ryager via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2025-08-10T21:30:23Z","receivedAt":"2025-08-10T21:30:26Z","isPatch":true,"sender":{"key":"name:Knut Harald Ryager","avatar":null},"body":"From: Knut Harald Ryager <e-k-nut@hotmail.com>\n\n    [--filter=<filter> [--also-filter-submodules]]\n\ninstead of\n\n    [--filter=<filter>] [--also-filter-submodules]]\n\nSigned-off-by: Knut Harald Ryager <e-k-nut@hotmail.com>\n---\n    Remove excess right bracket from git-clone docs\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2023%2FKnutRyager%2Fmaster-v2\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2023/KnutRyager/master-v2\nPull-Request: https://github.com/git/git/pull/2023\n\nRange-diff vs v1:\n\n 1:  6bb5c653356 ! 1:  bb158425b8a docs: remove stray bracket from git-clone synopsis\n     @@\n       ## Metadata ##\n     -Author: E-K-n <e-k-nut@hotmail.com>\n     +Author: Knut Harald Ryager <e-k-nut@hotmail.com>\n      \n       ## Commit message ##\n     -    docs: remove stray bracket from git-clone synopsis\n     +    Remove the extra and incorrect closing bracket, so that the line reads:\n      \n     -    The git-clone documentation contained an extra ‘]’ after\n     -    `--also-filter-submodules]`.\n     +        [--filter=<filter> [--also-filter-submodules]]\n      \n     -    This patch removes the duplicate ‘]’ so that the line reads:\n     +    instead of\n      \n     -        [--also-filter-submodules] [--] <repository>\n     -\n     -    instead of:\n     -\n     -        [--also-filter-submodules]] [--] <repository>\n     +        [--filter=<filter>] [--also-filter-submodules]]\n      \n          Signed-off-by: Knut Harald Ryager <e-k-nut@hotmail.com>\n      \n     @@ Documentation/git-clone.adoc: git clone [--template=<template-directory>]\n       \t  [--recurse-submodules[=<pathspec>]] [--[no-]shallow-submodules]\n       \t  [--[no-]remote-submodules] [--jobs <n>] [--sparse] [--[no-]reject-shallow]\n      -\t  [--filter=<filter-spec>] [--also-filter-submodules]] [--] <repository>\n     -+\t  [--filter=<filter-spec>] [--also-filter-submodules] [--] <repository>\n     ++\t  [--filter=<filter-spec> [--also-filter-submodules]] [--] <repository>\n       \t  [<directory>]\n       \n       DESCRIPTION\n\n\n Documentation/git-clone.adoc | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-clone.adoc b/Documentation/git-clone.adoc\nindex 222d558290e..d829206d1b5 100644\n--- a/Documentation/git-clone.adoc\n+++ b/Documentation/git-clone.adoc\n@@ -16,7 +16,7 @@ git clone [--template=<template-directory>]\n \t  [--depth <depth>] [--[no-]single-branch] [--[no-]tags]\n \t  [--recurse-submodules[=<pathspec>]] [--[no-]shallow-submodules]\n \t  [--[no-]remote-submodules] [--jobs <n>] [--sparse] [--[no-]reject-shallow]\n-\t  [--filter=<filter-spec>] [--also-filter-submodules]] [--] <repository>\n+\t  [--filter=<filter-spec> [--also-filter-submodules]] [--] <repository>\n \t  [<directory>]\n \n DESCRIPTION\n\nbase-commit: e813a0200a7121b97fec535f0d0b460b0a33356c\n-- \ngitgitgadget\n"},{"id":"523909","messageId":"a065e0cb-75e6-4836-9897-05089089367c@app.fastmail.com","threadId":"63885","inReplyTo":"pull.2023.v2.git.git.1754861423787.gitgitgadget@gmail.com","subject":"Re: [PATCH v2] Remove the extra and incorrect closing bracket, so that the line reads:","fromName":"Kristoffer Haugsbakk","fromEmail":"code@khaugsbakk.name","sentAt":"2025-08-11T06:14:06Z","receivedAt":"2025-08-11T06:14:40Z","isPatch":true,"sender":{"key":"code@khaugsbakk.name","avatar":"https://avatars.githubusercontent.com/u/2229597?v=4"},"body":"On Sun, Aug 10, 2025, at 23:30, Knut Harald Ryager via GitGitGadget wrote:\n> From: Knut Harald Ryager <e-k-nut@hotmail.com>\n>\n>     [--filter=<filter> [--also-filter-submodules]]\n>\n> instead of\n>\n>     [--filter=<filter>] [--also-filter-submodules]]\n>\n> Signed-off-by: Knut Harald Ryager <e-k-nut@hotmail.com>\n> ---\n>     Remove excess right bracket from git-clone docs\n>\n> Published-As:\n> https://github.com/gitgitgadget/git/releases/tag/pr-git-2023%2FKnutRyager%2Fmaster-v2\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git\n> pr-git-2023/KnutRyager/master-v2\n> Pull-Request: https://github.com/git/git/pull/2023\n>\n> Range-diff vs v1:\n>\n>  1:  6bb5c653356 ! 1:  bb158425b8a docs: remove stray bracket from\n> git-clone synopsis\n>      @@\n>        ## Metadata ##\n>      -Author: E-K-n <e-k-nut@hotmail.com>\n>      +Author: Knut Harald Ryager <e-k-nut@hotmail.com>\n>\n>        ## Commit message ##\n>      -    docs: remove stray bracket from git-clone synopsis\n>      +    Remove the extra and incorrect closing bracket, so that the line reads:\n\nIt looks like you accidentally deleted the nice subject line\n\n    docs: remove stray bracket from git-clone synopsis\n\nWhen rewriting the commit message with Junio’s suggestion.  Which made\nwhat was supposed to be the first line of the first paragraph into the\nsubject line.\n\nI think you want this:\n\n    docs: remove stray bracket from git-clone synopsis\n\n    Remove the extra and incorrect closing bracket, so that the line\n    reads:\n\n        [--filter=<filter> [--also-filter-submodules]]\n\n    instead of\n\n        [--filter=<filter>] [--also-filter-submodules]]\n\n>\n>      -    The git-clone documentation contained an extra ‘]’ after\n>      -    `--also-filter-submodules]`.\n>      +        [--filter=<filter> [--also-filter-submodules]]\n> ...\n\n-- \nKristoffer\n\n"},{"id":"523956","messageId":"xmqqms853kpu.fsf@gitster.g","threadId":"63885","inReplyTo":"a065e0cb-75e6-4836-9897-05089089367c@app.fastmail.com","subject":"Re: [PATCH v2] Remove the extra and incorrect closing bracket, so that the line reads:","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-08-11T16:07:57Z","receivedAt":"2025-08-11T16:07:59Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Kristoffer Haugsbakk\" <code@khaugsbakk.name> writes:\n\n> I think you want this:\n>\n>     docs: remove stray bracket from git-clone synopsis\n>\n>     Remove the extra and incorrect closing bracket, so that the line\n>     reads:\n>\n>         [--filter=<filter> [--also-filter-submodules]]\n>\n>     instead of\n>\n>         [--filter=<filter>] [--also-filter-submodules]]\n\nAs even the author of this patch was once confused, I think \nthe reason why this plausible change\n\n          [--filter=<filter>] [--also-filter-submodules]\n\nis not a correct fix should also be in the proposed log message to\nhelp readers.\n\n"},{"id":"523996","messageId":"pull.2023.v3.git.git.1754949872593.gitgitgadget@gmail.com","threadId":"63885","inReplyTo":"pull.2023.v2.git.git.1754861423787.gitgitgadget@gmail.com","subject":"[PATCH v3] docs: remove stray bracket from git-clone synopsis","fromName":"Knut Harald Ryager via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2025-08-11T22:04:32Z","receivedAt":"2025-08-11T22:04:35Z","isPatch":true,"sender":{"key":"name:Knut Harald Ryager","avatar":null},"body":"From: Knut Harald Ryager <e-k-nut@hotmail.com>\n\nRemove the extra and incorrect closing bracket, so that the line reads:\n\n    [--filter=<filter> [--also-filter-submodules]]\n\ninstead of\n\n    [--filter=<filter>] [--also-filter-submodules]]\n\nNote: Both filter options were grouped when --also-filter-submodules\nwas added by commit f05da2b4. The extra bracket was added\nlater by commit 76880f05.\n\nSigned-off-by: Knut Harald Ryager <e-k-nut@hotmail.com>\n---\n    Remove excess right bracket from git-clone docs\n    \n    cc: \"Kristoffer Haugsbakk\" code@khaugsbakk.name\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2023%2FKnutRyager%2Fmaster-v3\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2023/KnutRyager/master-v3\nPull-Request: https://github.com/git/git/pull/2023\n\nRange-diff vs v2:\n\n 1:  bb158425b8a ! 1:  c1a167a16fd Remove the extra and incorrect closing bracket, so that the line reads:\n     @@ Metadata\n      Author: Knut Harald Ryager <e-k-nut@hotmail.com>\n      \n       ## Commit message ##\n     +    docs: remove stray bracket from git-clone synopsis\n     +\n          Remove the extra and incorrect closing bracket, so that the line reads:\n      \n              [--filter=<filter> [--also-filter-submodules]]\n     @@ Commit message\n      \n              [--filter=<filter>] [--also-filter-submodules]]\n      \n     +    Note: Both filter options were grouped when --also-filter-submodules\n     +    was added by commit f05da2b4. The extra bracket was added\n     +    later by commit 76880f05.\n     +\n          Signed-off-by: Knut Harald Ryager <e-k-nut@hotmail.com>\n      \n       ## Documentation/git-clone.adoc ##\n\n\n Documentation/git-clone.adoc | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-clone.adoc b/Documentation/git-clone.adoc\nindex 222d558290e..d829206d1b5 100644\n--- a/Documentation/git-clone.adoc\n+++ b/Documentation/git-clone.adoc\n@@ -16,7 +16,7 @@ git clone [--template=<template-directory>]\n \t  [--depth <depth>] [--[no-]single-branch] [--[no-]tags]\n \t  [--recurse-submodules[=<pathspec>]] [--[no-]shallow-submodules]\n \t  [--[no-]remote-submodules] [--jobs <n>] [--sparse] [--[no-]reject-shallow]\n-\t  [--filter=<filter-spec>] [--also-filter-submodules]] [--] <repository>\n+\t  [--filter=<filter-spec> [--also-filter-submodules]] [--] <repository>\n \t  [<directory>]\n \n DESCRIPTION\n\nbase-commit: e813a0200a7121b97fec535f0d0b460b0a33356c\n-- \ngitgitgadget\n"},{"id":"524059","messageId":"xmqqms84v8jy.fsf@gitster.g","threadId":"63885","inReplyTo":"pull.2023.v3.git.git.1754949872593.gitgitgadget@gmail.com","subject":"Re: [PATCH v3] docs: remove stray bracket from git-clone synopsis","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-08-12T15:55:29Z","receivedAt":"2025-08-12T15:55:33Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Knut Harald Ryager via GitGitGadget\" <gitgitgadget@gmail.com>\nwrites:\n\n> From: Knut Harald Ryager <e-k-nut@hotmail.com>\n>\n> Remove the extra and incorrect closing bracket, so that the line reads:\n>\n>     [--filter=<filter> [--also-filter-submodules]]\n>\n> instead of\n>\n>     [--filter=<filter>] [--also-filter-submodules]]\n>\n> Note: Both filter options were grouped when --also-filter-submodules\n> was added by commit f05da2b4. The extra bracket was added\n> later by commit 76880f05.\n>\n> Signed-off-by: Knut Harald Ryager <e-k-nut@hotmail.com>\n> ---\n\nThanks.  Let me rewrite the proposed log message thusly:\n\n--- >8 ---\nSubject: docs: remove stray bracket from git-clone synopsis\n\nThe synopsis section has an extra closing bracket, like this:\n\n    [--filter=<filter>] [--also-filter-submodules]]\n\nThe extra one is not the one at the end of this line; it is the one\nafter \"...=<filter>\".\n\nThe \"--also-filter-submodules\" option was added by f05da2b4 (clone,\nsubmodule: pass partial clone filters to submodules, 2022-02-04).\nBecause it makes sense only when used with the \"--filter=<filter>\"\noption, these two options are enclosed in a pair of brackets.  The\nextra one was added by 76880f05 (doc: git-clone: apply new\ndocumentation formatting guidelines, 2024-03-29) by mistake.\n\nRemove the extra and incorrect closing bracket, so that the line\nreads:\n\n    [--filter=<filter> [--also-filter-submodules]]\n\nSigned-off-by: Knut Harald Ryager <e-k-nut@hotmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n"}]}