{"thread":{"id":"63750","subject":"[PATCH 0/7] move builtin help test to t1517","startedAt":"2025-07-06T21:07:34Z","lastAt":"2025-07-06T21:09:07Z","messageCount":8,"participants":["Usman Akinyemi"],"isPatch":true,"patchVersion":1,"patchTotal":7},"messages":[{"id":"521372","messageId":"20250706210725.79903-1-usmanakinyemi202@gmail.com","threadId":"63750","inReplyTo":null,"subject":"[PATCH 0/7] move builtin help test to t1517","fromName":"Usman Akinyemi","fromEmail":"usmanakinyemi202@gmail.com","sentAt":"2025-07-06T21:07:18Z","receivedAt":"2025-07-06T21:07:34Z","isPatch":true,"sender":{"key":"usmanakinyemi202@gmail.com","avatar":"https://avatars.githubusercontent.com/u/86585626?v=4"},"body":"In patch series which contain this\n\"[*]: 43a8391977 (builtin/verify-tag: stop using `the_repository`, 2025-03-07)\"\nand some other builtin commands, the help test was added into their\nrespective test files. Since it better fits thats tests that check\ncommand behavior outside a repository should be in t/t1517-outside-repo.sh.\nPatrick suggest moving the test to t/t1517-outside-repo.sh.\n\nThis patch series moved the all the test.\n\nUsman Akinyemi (7):\n  t/t1517: move checkout-index -h test to t1517\n  t/t1517: move for-each-ref -h test to t1517\n  t/t1517: move ls-files -h test to t1517\n  t/t1517: move pack-refs -h test to t1517\n  t/t1517: move send-pack -h test to t1517\n  t/t1517: move verify-commit -h test to t1517\n  t/t1517: move verify-tag -h test to t1517\n\n t/t0610-reftable-basics.sh      |  7 -----\n t/t1517-outside-repo.sh         | 49 +++++++++++++++++++++++++++++++++\n t/t2006-checkout-index-basic.sh |  7 -----\n t/t3004-ls-files-basic.sh       |  7 -----\n t/t5400-send-pack.sh            |  7 -----\n t/t6300-for-each-ref.sh         |  7 -----\n t/t7030-verify-tag.sh           |  7 -----\n t/t7510-signed-commit.sh        |  7 -----\n 8 files changed, 49 insertions(+), 49 deletions(-)\n\n-- \n2.50.0\n\n"},{"id":"521373","messageId":"20250706210725.79903-2-usmanakinyemi202@gmail.com","threadId":"63750","inReplyTo":"20250706210725.79903-1-usmanakinyemi202@gmail.com","subject":"[PATCH 1/7] t/t1517: move checkout-index -h test to t1517","fromName":"Usman Akinyemi","fromEmail":"usmanakinyemi202@gmail.com","sentAt":"2025-07-06T21:07:19Z","receivedAt":"2025-07-06T21:08:37Z","isPatch":true,"sender":{"key":"usmanakinyemi202@gmail.com","avatar":"https://avatars.githubusercontent.com/u/86585626?v=4"},"body":"The test 'checkout-index does not crash with -h' checks that\nthe command exits cleanly with usage information, both inside and\noutside of a repository.\n\nMove this test from \"t2006-checkout-index-basic.sh\" to\n\"t1517-outside-repo.sh\" since it better fits with tests that check\ncommand behavior outside a repository.\n\nSuggested-by: Patrick Steinhardt <ps@pks.im>\nSigned-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>\n---\n t/t1517-outside-repo.sh         | 7 +++++++\n t/t2006-checkout-index-basic.sh | 7 -------\n 2 files changed, 7 insertions(+), 7 deletions(-)\n\ndiff --git a/t/t1517-outside-repo.sh b/t/t1517-outside-repo.sh\nindex 6824581317..98a453db58 100755\n--- a/t/t1517-outside-repo.sh\n+++ b/t/t1517-outside-repo.sh\n@@ -114,4 +114,11 @@ test_expect_success 'update-server-info does not crash with -h' '\n \ttest_grep \"[Uu]sage: git update-server-info \" usage\n '\n \n+test_expect_success 'checkout-index does not crash with -h' '\n+\ttest_expect_code 129 git checkout-index -h >usage &&Add commentMore actions\n+\ttest_grep \"[Uu]sage: git checkout-index \" usage &&\n+\ttest_expect_code 129 nongit git checkout-index -h >usage &&\n+\ttest_grep \"[Uu]sage: git checkout-index \" usage\n+'\n+\n test_done\ndiff --git a/t/t2006-checkout-index-basic.sh b/t/t2006-checkout-index-basic.sh\nindex fedd2cc097..bac231b167 100755\n--- a/t/t2006-checkout-index-basic.sh\n+++ b/t/t2006-checkout-index-basic.sh\n@@ -21,13 +21,6 @@ test_expect_success 'checkout-index -h in broken repository' '\n \ttest_grep \"[Uu]sage\" broken/usage\n '\n \n-test_expect_success 'checkout-index does not crash with -h' '\n-\ttest_expect_code 129 git checkout-index -h >usage &&\n-\ttest_grep \"[Uu]sage: git checkout-index \" usage &&\n-\ttest_expect_code 129 nongit git checkout-index -h >usage &&\n-\ttest_grep \"[Uu]sage: git checkout-index \" usage\n-'\n-\n test_expect_success 'checkout-index reports errors (cmdline)' '\n \ttest_must_fail git checkout-index -- does-not-exist 2>stderr &&\n \ttest_grep not.in.the.cache stderr\n-- \n2.50.0\n\n"},{"id":"521374","messageId":"20250706210725.79903-3-usmanakinyemi202@gmail.com","threadId":"63750","inReplyTo":"20250706210725.79903-1-usmanakinyemi202@gmail.com","subject":"[PATCH 2/7] t/t1517: move for-each-ref -h test to t1517","fromName":"Usman Akinyemi","fromEmail":"usmanakinyemi202@gmail.com","sentAt":"2025-07-06T21:07:20Z","receivedAt":"2025-07-06T21:08:41Z","isPatch":true,"sender":{"key":"usmanakinyemi202@gmail.com","avatar":"https://avatars.githubusercontent.com/u/86585626?v=4"},"body":"The test 'for-each-ref does not crash with -h' checks that\nthe command exits cleanly with usage information, both inside and\noutside of a repository.\n\nMove this test from \"t6300-for-each-ref.sh\" to\n\"t1517-outside-repo.sh\" since it better fits with tests that check\ncommand behavior outside a repository.\n\nSuggested-by: Patrick Steinhardt <ps@pks.im>\nSigned-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>\n---\n t/t1517-outside-repo.sh | 7 +++++++\n t/t6300-for-each-ref.sh | 7 -------\n 2 files changed, 7 insertions(+), 7 deletions(-)\n\ndiff --git a/t/t1517-outside-repo.sh b/t/t1517-outside-repo.sh\nindex 98a453db58..92ad159b58 100755\n--- a/t/t1517-outside-repo.sh\n+++ b/t/t1517-outside-repo.sh\n@@ -121,4 +121,11 @@ test_expect_success 'checkout-index does not crash with -h' '\n \ttest_grep \"[Uu]sage: git checkout-index \" usage\n '\n \n+test_expect_success 'for-each-ref does not crash with -h' '\n+\ttest_expect_code 129 git for-each-ref -h >usage &&\n+\ttest_grep \"[Uu]sage: git for-each-ref \" usage &&\n+\ttest_expect_code 129 nongit git for-each-ref -h >usage &&\n+\ttest_grep \"[Uu]sage: git for-each-ref \" usage\n+'\n+\n test_done\ndiff --git a/t/t6300-for-each-ref.sh b/t/t6300-for-each-ref.sh\nindex ce9af79ab1..5db7038c41 100755\n--- a/t/t6300-for-each-ref.sh\n+++ b/t/t6300-for-each-ref.sh\n@@ -292,13 +292,6 @@ test_expect_success 'Check invalid atoms names are errors' '\n \ttest_must_fail git for-each-ref --format=\"%(INVALID)\" refs/heads\n '\n \n-test_expect_success 'for-each-ref does not crash with -h' '\n-\ttest_expect_code 129 git for-each-ref -h >usage &&\n-\ttest_grep \"[Uu]sage: git for-each-ref \" usage &&\n-\ttest_expect_code 129 nongit git for-each-ref -h >usage &&\n-\ttest_grep \"[Uu]sage: git for-each-ref \" usage\n-'\n-\n test_expect_success 'Check format specifiers are ignored in naming date atoms' '\n \tgit for-each-ref --format=\"%(authordate)\" refs/heads &&\n \tgit for-each-ref --format=\"%(authordate:default) %(authordate)\" refs/heads &&\n-- \n2.50.0\n\n"},{"id":"521375","messageId":"20250706210725.79903-4-usmanakinyemi202@gmail.com","threadId":"63750","inReplyTo":"20250706210725.79903-1-usmanakinyemi202@gmail.com","subject":"[PATCH 3/7] t/t1517: move ls-files -h test to t1517","fromName":"Usman Akinyemi","fromEmail":"usmanakinyemi202@gmail.com","sentAt":"2025-07-06T21:07:21Z","receivedAt":"2025-07-06T21:08:46Z","isPatch":true,"sender":{"key":"usmanakinyemi202@gmail.com","avatar":"https://avatars.githubusercontent.com/u/86585626?v=4"},"body":"The test 'ls-files does not crash with -h' checks that\nthe command exits cleanly with usage information, both inside and\noutside of a repository.\n\nMove this test from \"t3004-ls-files-basic.sh\" to\n\"t1517-outside-repo.sh\" since it better fits with tests that check\ncommand behavior outside a repository.\n\nSuggested-by: Patrick Steinhardt <ps@pks.im>\nSigned-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>\n---\n t/t1517-outside-repo.sh   | 7 +++++++\n t/t3004-ls-files-basic.sh | 7 -------\n 2 files changed, 7 insertions(+), 7 deletions(-)\n\ndiff --git a/t/t1517-outside-repo.sh b/t/t1517-outside-repo.sh\nindex 92ad159b58..e04be2d811 100755\n--- a/t/t1517-outside-repo.sh\n+++ b/t/t1517-outside-repo.sh\n@@ -128,4 +128,11 @@ test_expect_success 'for-each-ref does not crash with -h' '\n \ttest_grep \"[Uu]sage: git for-each-ref \" usage\n '\n \n+test_expect_success 'ls-files does not crash with -h' '\n+\ttest_expect_code 129 git ls-files -h >usage &&\n+\ttest_grep \"[Uu]sage: git ls-files \" usage &&\n+\ttest_expect_code 129 nongit git ls-files -h >usage &&\n+\ttest_grep \"[Uu]sage: git ls-files \" usage\n+'\n+\n test_done\ndiff --git a/t/t3004-ls-files-basic.sh b/t/t3004-ls-files-basic.sh\nindex 4034a5a59f..a1078f8701 100755\n--- a/t/t3004-ls-files-basic.sh\n+++ b/t/t3004-ls-files-basic.sh\n@@ -34,13 +34,6 @@ test_expect_success 'ls-files -h in corrupt repository' '\n \ttest_grep \"[Uu]sage: git ls-files \" broken/usage\n '\n \n-test_expect_success 'ls-files does not crash with -h' '\n-\ttest_expect_code 129 git ls-files -h >usage &&\n-\ttest_grep \"[Uu]sage: git ls-files \" usage &&\n-\ttest_expect_code 129 nongit git ls-files -h >usage &&\n-\ttest_grep \"[Uu]sage: git ls-files \" usage\n-'\n-\n test_expect_success SYMLINKS 'ls-files with absolute paths to symlinks' '\n \tmkdir subs &&\n \tln -s nosuch link &&\n-- \n2.50.0\n\n"},{"id":"521376","messageId":"20250706210725.79903-5-usmanakinyemi202@gmail.com","threadId":"63750","inReplyTo":"20250706210725.79903-1-usmanakinyemi202@gmail.com","subject":"[PATCH 4/7] t/t1517: move pack-refs -h test to t1517","fromName":"Usman Akinyemi","fromEmail":"usmanakinyemi202@gmail.com","sentAt":"2025-07-06T21:07:22Z","receivedAt":"2025-07-06T21:08:53Z","isPatch":true,"sender":{"key":"usmanakinyemi202@gmail.com","avatar":"https://avatars.githubusercontent.com/u/86585626?v=4"},"body":"The test 'pack-refs does not crash with -h' checks that\nthe command exits cleanly with usage information, both inside and\noutside of a repository.\n\nMove this test from \"t0610-reftable-basics.sh\" to\n\"t1517-outside-repo.sh\" since it better fits with tests that check\ncommand behavior outside a repository.\n\nSuggested-by: Patrick Steinhardt <ps@pks.im>\nSigned-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>\n---\n t/t0610-reftable-basics.sh | 7 -------\n t/t1517-outside-repo.sh    | 7 +++++++\n 2 files changed, 7 insertions(+), 7 deletions(-)\n\ndiff --git a/t/t0610-reftable-basics.sh b/t/t0610-reftable-basics.sh\nindex 3ea5d51532..ffd8ecc0ce 100755\n--- a/t/t0610-reftable-basics.sh\n+++ b/t/t0610-reftable-basics.sh\n@@ -14,13 +14,6 @@ export GIT_TEST_DEFAULT_REF_FORMAT\n \n INVALID_OID=$(test_oid 001)\n \n-test_expect_success 'pack-refs does not crash with -h' '\n-\ttest_expect_code 129 git pack-refs -h >usage &&\n-\ttest_grep \"[Uu]sage: git pack-refs \" usage &&\n-\ttest_expect_code 129 nongit git pack-refs -h >usage &&\n-\ttest_grep \"[Uu]sage: git pack-refs \" usage\n-'\n-\n test_expect_success 'init: creates basic reftable structures' '\n \ttest_when_finished \"rm -rf repo\" &&\n \tgit init repo &&\ndiff --git a/t/t1517-outside-repo.sh b/t/t1517-outside-repo.sh\nindex e04be2d811..5b4373f8cd 100755\n--- a/t/t1517-outside-repo.sh\n+++ b/t/t1517-outside-repo.sh\n@@ -135,4 +135,11 @@ test_expect_success 'ls-files does not crash with -h' '\n \ttest_grep \"[Uu]sage: git ls-files \" usage\n '\n \n+test_expect_success 'pack-refs does not crash with -h' '\n+\ttest_expect_code 129 git pack-refs -h >usage &&\n+\ttest_grep \"[Uu]sage: git pack-refs \" usage &&\n+\ttest_expect_code 129 nongit git pack-refs -h >usage &&\n+\ttest_grep \"[Uu]sage: git pack-refs \" usage\n+'\n+\n test_done\n-- \n2.50.0\n\n"},{"id":"521377","messageId":"20250706210725.79903-6-usmanakinyemi202@gmail.com","threadId":"63750","inReplyTo":"20250706210725.79903-1-usmanakinyemi202@gmail.com","subject":"[PATCH 5/7] t/t1517: move send-pack -h test to t1517","fromName":"Usman Akinyemi","fromEmail":"usmanakinyemi202@gmail.com","sentAt":"2025-07-06T21:07:23Z","receivedAt":"2025-07-06T21:08:57Z","isPatch":true,"sender":{"key":"usmanakinyemi202@gmail.com","avatar":"https://avatars.githubusercontent.com/u/86585626?v=4"},"body":"The test 'send-pack does not crash with -h' checks that\nthe command exits cleanly with usage information, both inside and\noutside of a repository.\n\nMove this test from \"t/t5400-send-pack.sh\" to\n\"t1517-outside-repo.sh\" since it better fits with tests that check\ncommand behavior outside a repository.\n\nSuggested-by: Patrick Steinhardt <ps@pks.im>\nSigned-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>\n---\n t/t1517-outside-repo.sh | 7 +++++++\n t/t5400-send-pack.sh    | 7 -------\n 2 files changed, 7 insertions(+), 7 deletions(-)\n\ndiff --git a/t/t1517-outside-repo.sh b/t/t1517-outside-repo.sh\nindex 5b4373f8cd..a140b5cc38 100755\n--- a/t/t1517-outside-repo.sh\n+++ b/t/t1517-outside-repo.sh\n@@ -142,4 +142,11 @@ test_expect_success 'pack-refs does not crash with -h' '\n \ttest_grep \"[Uu]sage: git pack-refs \" usage\n '\n \n+test_expect_success 'send-pack does not crash with -h' '\n+\ttest_expect_code 129 git send-pack -h >usage &&\n+\ttest_grep \"[Uu]sage: git send-pack \" usage &&\n+\ttest_expect_code 129 nongit git send-pack -h >usage &&\n+\ttest_grep \"[Uu]sage: git send-pack \" usage\n+'\n+\n test_done\ndiff --git a/t/t5400-send-pack.sh b/t/t5400-send-pack.sh\nindex 83b42ff073..571e8f1bc5 100755\n--- a/t/t5400-send-pack.sh\n+++ b/t/t5400-send-pack.sh\n@@ -55,13 +55,6 @@ test_expect_success setup '\n \techo Rebase &&\n \tgit log'\n \n-test_expect_success 'send-pack does not crash with -h' '\n-\ttest_expect_code 129 git send-pack -h >usage &&\n-\ttest_grep \"[Uu]sage: git send-pack \" usage &&\n-\ttest_expect_code 129 nongit git send-pack -h >usage &&\n-\ttest_grep \"[Uu]sage: git send-pack \" usage\n-'\n-\n test_expect_success 'pack the source repository' '\n \tgit repack -a -d &&\n \tgit prune\n-- \n2.50.0\n\n"},{"id":"521378","messageId":"20250706210725.79903-7-usmanakinyemi202@gmail.com","threadId":"63750","inReplyTo":"20250706210725.79903-1-usmanakinyemi202@gmail.com","subject":"[PATCH 6/7] t/t1517: move verify-commit -h test to t1517","fromName":"Usman Akinyemi","fromEmail":"usmanakinyemi202@gmail.com","sentAt":"2025-07-06T21:07:24Z","receivedAt":"2025-07-06T21:09:02Z","isPatch":true,"sender":{"key":"usmanakinyemi202@gmail.com","avatar":"https://avatars.githubusercontent.com/u/86585626?v=4"},"body":"The test 'verify-commit does not crash with -h' checks that\nthe command exits cleanly with usage information, both inside and\noutside of a repository.\n\nMove this test from \"t/t7510-signed-commit.sh\" to\n\"t1517-outside-repo.sh\" since it better fits with tests that check\ncommand behavior outside a repository.\n\nSuggested-by: Patrick Steinhardt <ps@pks.im>\nSigned-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>\n---\n t/t1517-outside-repo.sh  | 7 +++++++\n t/t7510-signed-commit.sh | 7 -------\n 2 files changed, 7 insertions(+), 7 deletions(-)\n\ndiff --git a/t/t1517-outside-repo.sh b/t/t1517-outside-repo.sh\nindex a140b5cc38..42381ef7eb 100755\n--- a/t/t1517-outside-repo.sh\n+++ b/t/t1517-outside-repo.sh\n@@ -149,4 +149,11 @@ test_expect_success 'send-pack does not crash with -h' '\n \ttest_grep \"[Uu]sage: git send-pack \" usage\n '\n \n+test_expect_success 'verify-commit does not crash with -h' '\n+\ttest_expect_code 129 git verify-commit -h >usage &&\n+\ttest_grep \"[Uu]sage: git verify-commit \" usage &&\n+\ttest_expect_code 129 nongit git verify-commit -h >usage &&\n+\ttest_grep \"[Uu]sage: git verify-commit \" usage\n+'\n+\n test_done\ndiff --git a/t/t7510-signed-commit.sh b/t/t7510-signed-commit.sh\nindex 39677e859a..0d2dd29fe6 100755\n--- a/t/t7510-signed-commit.sh\n+++ b/t/t7510-signed-commit.sh\n@@ -8,13 +8,6 @@ export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME\n GNUPGHOME_NOT_USED=$GNUPGHOME\n . \"$TEST_DIRECTORY/lib-gpg.sh\"\n \n-test_expect_success GPG 'verify-commit does not crash with -h' '\n-\ttest_expect_code 129 git verify-commit -h >usage &&\n-\ttest_grep \"[Uu]sage: git verify-commit \" usage &&\n-\ttest_expect_code 129 nongit git verify-commit -h >usage &&\n-\ttest_grep \"[Uu]sage: git verify-commit \" usage\n-'\n-\n test_expect_success GPG 'create signed commits' '\n \ttest_oid_cache <<-\\EOF &&\n \theader sha1:gpgsig\n-- \n2.50.0\n\n"},{"id":"521379","messageId":"20250706210725.79903-8-usmanakinyemi202@gmail.com","threadId":"63750","inReplyTo":"20250706210725.79903-1-usmanakinyemi202@gmail.com","subject":"[PATCH 7/7] t/t1517: move verify-tag -h test to t1517","fromName":"Usman Akinyemi","fromEmail":"usmanakinyemi202@gmail.com","sentAt":"2025-07-06T21:07:25Z","receivedAt":"2025-07-06T21:09:07Z","isPatch":true,"sender":{"key":"usmanakinyemi202@gmail.com","avatar":"https://avatars.githubusercontent.com/u/86585626?v=4"},"body":"The test 'verify-tag does not crash with -h' checks that\nthe command exits cleanly with usage information, both inside and\noutside of a repository.\n\nMove this test from \"t/t7030-verify-tag.sh\" to\n\"t1517-outside-repo.sh\" since it better fits with tests that check\ncommand behavior outside a repository.\n\nSuggested-by: Patrick Steinhardt <ps@pks.im>\nSigned-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>\n---\n t/t1517-outside-repo.sh | 7 +++++++\n t/t7030-verify-tag.sh   | 7 -------\n 2 files changed, 7 insertions(+), 7 deletions(-)\n\ndiff --git a/t/t1517-outside-repo.sh b/t/t1517-outside-repo.sh\nindex 42381ef7eb..0755757d86 100755\n--- a/t/t1517-outside-repo.sh\n+++ b/t/t1517-outside-repo.sh\n@@ -156,4 +156,11 @@ test_expect_success 'verify-commit does not crash with -h' '\n \ttest_grep \"[Uu]sage: git verify-commit \" usage\n '\n \n+test_expect_success 'verify-tag does not crash with -h' '\n+\ttest_expect_code 129 git verify-tag -h >usage &&\n+\ttest_grep \"[Uu]sage: git verify-tag \" usage &&\n+\ttest_expect_code 129 nongit git verify-tag -h >usage &&\n+\ttest_grep \"[Uu]sage: git verify-tag \" usage\n+'\n+\n test_done\ndiff --git a/t/t7030-verify-tag.sh b/t/t7030-verify-tag.sh\nindex 2c147072c1..6f526c37c2 100755\n--- a/t/t7030-verify-tag.sh\n+++ b/t/t7030-verify-tag.sh\n@@ -7,13 +7,6 @@ export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME\n . ./test-lib.sh\n . \"$TEST_DIRECTORY/lib-gpg.sh\"\n \n-test_expect_success GPG 'verify-tag does not crash with -h' '\n-\ttest_expect_code 129 git verify-tag -h >usage &&\n-\ttest_grep \"[Uu]sage: git verify-tag \" usage &&\n-\ttest_expect_code 129 nongit git verify-tag -h >usage &&\n-\ttest_grep \"[Uu]sage: git verify-tag \" usage\n-'\n-\n test_expect_success GPG 'create signed tags' '\n \techo 1 >file && git add file &&\n \ttest_tick && git commit -m initial &&\n-- \n2.50.0\n\n"}]}