{"thread":{"id":"63697","subject":"[PATCH] daemon: remove unnecesary restriction for listener fd","startedAt":"2025-06-26T09:52:42Z","lastAt":"2025-06-26T13:17:05Z","messageCount":2,"participants":["Carlo Marcelo Arenas Belón","Phillip Wood"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"520751","messageId":"20250626095139.70751-1-carenas@gmail.com","threadId":"63697","inReplyTo":null,"subject":"[PATCH] daemon: remove unnecesary restriction for listener fd","fromName":"Carlo Marcelo Arenas Belón","fromEmail":"carenas@gmail.com","sentAt":"2025-06-26T09:51:39Z","receivedAt":"2025-06-26T09:52:42Z","isPatch":true,"sender":{"key":"carenas@gmail.com","avatar":"https://avatars.githubusercontent.com/u/76036?v=4"},"body":"Since df076bdbcc ([PATCH] GIT: Listen on IPv6 as well, if available.,\n2005-07-23), any file descriptor assigned to a listening socket was\nvalidated to be within the range to be used in an FDSET later.\n\n6573faff34 (NO_IPV6 support for git daemon, 2005-09-28), moves to\nuse poll() instead of select(), that doesn't have that restriction,\nso remove the original check.\n\nSigned-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>\n---\n daemon.c | 5 -----\n 1 file changed, 5 deletions(-)\n\ndiff --git a/daemon.c b/daemon.c\nindex d1be61fd57..99741f0b45 100644\n--- a/daemon.c\n+++ b/daemon.c\n@@ -990,11 +990,6 @@ static int setup_named_sock(char *listen_addr, int listen_port, struct socketlis\n \t\tsockfd = socket(ai->ai_family, ai->ai_socktype, ai->ai_protocol);\n \t\tif (sockfd < 0)\n \t\t\tcontinue;\n-\t\tif (sockfd >= FD_SETSIZE) {\n-\t\t\tlogerror(\"Socket descriptor too large\");\n-\t\t\tclose(sockfd);\n-\t\t\tcontinue;\n-\t\t}\n \n #ifdef IPV6_V6ONLY\n \t\tif (ai->ai_family == AF_INET6) {\n-- \n2.50.0.132.g8e5a977e07\n\n"},{"id":"520757","messageId":"3e03fe38-5bb5-43da-b80e-fb8ffc1b4837@gmail.com","threadId":"63697","inReplyTo":"20250626095139.70751-1-carenas@gmail.com","subject":"Re: [PATCH] daemon: remove unnecesary restriction for listener fd","fromName":"Phillip Wood","fromEmail":"phillip.wood123@gmail.com","sentAt":"2025-06-26T13:17:02Z","receivedAt":"2025-06-26T13:17:05Z","isPatch":true,"sender":{"key":"phillip.wood@dunelm.org.uk","avatar":null},"body":"Hi Carlo\n\nOn 26/06/2025 10:51, Carlo Marcelo Arenas Belón wrote:\n> Since df076bdbcc ([PATCH] GIT: Listen on IPv6 as well, if available.,\n> 2005-07-23), any file descriptor assigned to a listening socket was\n> validated to be within the range to be used in an FDSET later.\n> \n> 6573faff34 (NO_IPV6 support for git daemon, 2005-09-28), moves to\n> use poll() instead of select(), that doesn't have that restriction,\n> so remove the original check.\n\nNice find, this patch looks good to me.\n\nThanks\n\nPhillip\n\n> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>\n> ---\n>   daemon.c | 5 -----\n>   1 file changed, 5 deletions(-)\n> \n> diff --git a/daemon.c b/daemon.c\n> index d1be61fd57..99741f0b45 100644\n> --- a/daemon.c\n> +++ b/daemon.c\n> @@ -990,11 +990,6 @@ static int setup_named_sock(char *listen_addr, int listen_port, struct socketlis\n>   \t\tsockfd = socket(ai->ai_family, ai->ai_socktype, ai->ai_protocol);\n>   \t\tif (sockfd < 0)\n>   \t\t\tcontinue;\n> -\t\tif (sockfd >= FD_SETSIZE) {\n> -\t\t\tlogerror(\"Socket descriptor too large\");\n> -\t\t\tclose(sockfd);\n> -\t\t\tcontinue;\n> -\t\t}\n>   \n>   #ifdef IPV6_V6ONLY\n>   \t\tif (ai->ai_family == AF_INET6) {\n\n"}]}