{"thread":{"id":"63633","subject":"Re: [PATCH v2] config.mak.uname: update settings for FreeBSD","startedAt":"2025-06-12T13:52:16Z","lastAt":"2025-07-02T16:22:00Z","messageCount":11,"participants":["Carlo Arenas","brian m. carlson","Junio C Hamano","Carlo Marcelo Arenas Belón"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"520170","messageId":"CAPUEspguEY+e-J0dMA2EdDgu=t4fK5ASS13Jfp_Mgwiq3Rtd0Q@mail.gmail.com","threadId":"63633","inReplyTo":null,"subject":"Re: [PATCH v2] config.mak.uname: update settings for FreeBSD","fromName":"Carlo Arenas","fromEmail":"carenas@gmail.com","sentAt":"2025-06-12T13:52:03Z","receivedAt":"2025-06-12T13:52:16Z","isPatch":true,"sender":{"key":"carenas@gmail.com","avatar":"https://avatars.githubusercontent.com/u/76036?v=4"},"body":"On Thu, Jun 12, 2025 at 12:36:46AM -0800, Brad Smith wrote:\n>\n> FreeBSD 6.0 has memmem().\n\nbut AFAIK it was buggy, uncompatible with the \"standard\" and\ndidn't perform that well, at least until FreeBSD 12.\n\nassuming that the system version is indeed faster than the\none provided with git (which should be true but worth testing)\nthen it might be better to only enable this for later versions?\n\n> With making 6.0 the minimum version drop bits for supporting\n> FreeBSD 4.x.\n\nFreeBSD 4.x is no longer supported and wouldn't even build a\ncurrent git, since it predates C99 and is missing POSIX\ncompatibility with what we require (ex: no statvfs)\n\nCarlo\n"},{"id":"520175","messageId":"aEsE8S90fJSr9Or5@fruit.crustytoothpaste.net","threadId":"63633","inReplyTo":"CAPUEspguEY+e-J0dMA2EdDgu=t4fK5ASS13Jfp_Mgwiq3Rtd0Q@mail.gmail.com","subject":"Re: [PATCH v2] config.mak.uname: update settings for FreeBSD","fromName":"brian m. carlson","fromEmail":"sandals@crustytoothpaste.net","sentAt":"2025-06-12T16:48:49Z","receivedAt":"2025-06-12T16:48:52Z","isPatch":true,"sender":{"key":"sandals@crustytoothpaste.net","avatar":"https://avatars.githubusercontent.com/u/497054?v=4"},"body":"On 2025-06-12 at 13:52:03, Carlo Arenas wrote:\n> On Thu, Jun 12, 2025 at 12:36:46AM -0800, Brad Smith wrote:\n> >\n> > FreeBSD 6.0 has memmem().\n> \n> but AFAIK it was buggy, uncompatible with the \"standard\" and\n> didn't perform that well, at least until FreeBSD 12.\n> \n> assuming that the system version is indeed faster than the\n> one provided with git (which should be true but worth testing)\n> then it might be better to only enable this for later versions?\n\nFreeBSD 11.4 (the last version of FreeBSD 11) went end of life in\nSeptember 2021, so nobody should be using it since it hasn't had\nsecurity support since then.  And it's even been functional (but slow)\nsince FreeBSD 11.0, and 10.4 went EOL in 2018.  So users shouldn't\nactually be experiencing any actual functionality problems since then.\n\nI don't think it's a big deal for people who want to use an obsolete OS\n(which, to be clear, I'm not encouraging) to tweak the Makefile knobs a\nbit.\n\n> > With making 6.0 the minimum version drop bits for supporting\n> > FreeBSD 4.x.\n> \n> FreeBSD 4.x is no longer supported and wouldn't even build a\n> current git, since it predates C99 and is missing POSIX\n> compatibility with what we require (ex: no statvfs)\n\nI definitely think getting rid of FreeBSD 4 support is fine.  It doesn't\neven support AMD64, so as a practical matter it wouldn't be useful on\nany sort of modern hardware.\n-- \nbrian m. carlson (they/them)\nToronto, Ontario, CA\n"},{"id":"520177","messageId":"xmqqy0twewc6.fsf@gitster.g","threadId":"63633","inReplyTo":"CAPUEspguEY+e-J0dMA2EdDgu=t4fK5ASS13Jfp_Mgwiq3Rtd0Q@mail.gmail.com","subject":"Re: [PATCH v2] config.mak.uname: update settings for FreeBSD","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-06-12T16:52:25Z","receivedAt":"2025-06-12T16:52:28Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Carlo Arenas <carenas@gmail.com> writes:\n\n> On Thu, Jun 12, 2025 at 12:36:46AM -0800, Brad Smith wrote:\n>>\n>> FreeBSD 6.0 has memmem().\n>\n> but AFAIK it was buggy, uncompatible with the \"standard\" and\n> didn't perform that well, at least until FreeBSD 12.\n\nDeclaring that we will not support anything older than 12, which was\nfrom Dec 2018, feels a bit too harsh, so conditional to check if we\nare at or above 12 is needed instead?\n\nDocumentation/technical/platform-support.adoc is probably a good\nplace to start a discussion.\n\n * It spells out Minimum Requirements which includes C99 at the\n   minimum, which in turn disqualifies really ancient ones and ones\n   perhaps before FreeBSD 7 (which had GCC 4)?\n\n * It also requires the platform has active security support.  If I\n   trust https://www.freebsd.org/security/#sup page, it means\n   anything older than 13.4-RELEASE are EoL already.\n\n * The document has a space at the end that is intended to list\n   contacts for ports on platforms, but currently it is not very\n   actively used.  Should we extend it to include various flavours\n   of BSDs and other systems, and start listing the minimum\n   supported versions as well?\n\nStepping back a bit, do we already have some mechanism to say \"hey\nyou seem to be on FreeBSD but you are at release N that is way older\nthan the minimum version X we support\" and stop the build?  If we\ndo, we should tell that mechanism about our decision in a patch like\nthis.\n\nIf we don't, I wonder if we want to have such a mechanism?  I am\npersonally undecided.  It would help those \"casual\" users and\nbuilders who do not get their hands dirty at all (aka \"I'll build\nonly from the official release tarballs\") if we did so when they try\nto build on something we know will not work well, especially if it\nis kept up to date relative to what the platform-support document\nlists.  But at the same time, those who do not mind fixing and\nextending to make it work on out-of-support systems will be\ninconvenienced with one more roadblock to dismantle before\nproceeding.\n\nThoughts?\n"},{"id":"520193","messageId":"p75inuvm6uf4mul7gty4jpwd74namlgfifkqgwuwzf6sqrkit5@zkimsfgxatmc","threadId":"63633","inReplyTo":"aEsE8S90fJSr9Or5@fruit.crustytoothpaste.net","subject":"Re: [PATCH v2] config.mak.uname: update settings for FreeBSD","fromName":"Carlo Marcelo Arenas Belón","fromEmail":"carenas@gmail.com","sentAt":"2025-06-12T21:31:29Z","receivedAt":"2025-06-12T21:31:32Z","isPatch":true,"sender":{"key":"carenas@gmail.com","avatar":"https://avatars.githubusercontent.com/u/76036?v=4"},"body":"On Thu, Jun 12, 2025 at 04:48:49PM -0800, brian m. carlson wrote:\n> On 2025-06-12 at 13:52:03, Carlo Arenas wrote:\n> > On Thu, Jun 12, 2025 at 12:36:46AM -0800, Brad Smith wrote:\n> > >\n> > > FreeBSD 6.0 has memmem().\n> > \n> > but AFAIK it was buggy, uncompatible with the \"standard\" and\n> > didn't perform that well, at least until FreeBSD 12.\n> > \n> > assuming that the system version is indeed faster than the\n> > one provided with git (which should be true but worth testing)\n> > then it might be better to only enable this for later versions?\n> \n> FreeBSD 11.4 (the last version of FreeBSD 11) went end of life in\n> September 2021, so nobody should be using it since it hasn't had\n> security support since then.  And it's even been functional (but slow)\n> since FreeBSD 11.0, and 10.4 went EOL in 2018.  So users shouldn't\n> actually be experiencing any actual functionality problems since then.\n> \n> I don't think it's a big deal for people who want to use an obsolete OS\n> (which, to be clear, I'm not encouraging) to tweak the Makefile knobs a\n> bit.\n\nNote that my concern wasn't about having to tweak the Makefile, but with\nthe fact that the system provided function would behave differently, and\nthere was no attempt to see if by no longer using the git provided compat\ncode, there was actually a performance improvement.\n\nIt is true that in our codebase there are no calls to memmem() where the\nneedlelen (the fourth parameter) could be zero, and that would result in\nsome of those old versions returning NULL, but it would seem to be safer\nto only use the system provided function when those issues are no longer\na concern.\n\nCarlo\n"},{"id":"520194","messageId":"xmqqv7p0bpdl.fsf_-_@gitster.g","threadId":"63633","inReplyTo":"aEsE8S90fJSr9Or5@fruit.crustytoothpaste.net","subject":"[PATCH v3] config.mak.uname: update settings for FreeBSD","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-06-12T21:51:02Z","receivedAt":"2025-06-12T21:51:06Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Even though FreeBSD 6 introduced memmem(), the implementation in\nthat version was buggy and not performant until FreeBSD 12, FreeBSD\n11.4 (the last version of FreeBSD 11) went end of life in September\n2021, so nobody should be using it since it hasn't had security\nsupport since then.  And memmem() has even been functional (but\nslow) since FreeBSD 11.0, and 10.4 went EOL in 2018.  So users\nshouldn't actually be experiencing any actual functionality problems\nsince then.\n\nLet's draw the line to require FreeBSD 12 or newer (but we do not\nofficially document it or enforce it by breaking build when compiled\non older versions, at least not yet), which allows us to drop the\nspecial casing of FreeBSD 4.x and rely on platform implementation of\nmemmem() unconditionally.\n\nSigned-off-by: Brad Smith <brad@comstyle.com>\n[jc: log message with help from info by brian carlson]\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n\n * So,... earlier I mentioned about officially documenting the EoL\n   timeline for various platform support, but without any official\n   one that documents the decision in one place, how about a commit\n   with a detailed log like this one, which I stole from brian?\n\n   No code changes since v2; only the log message talks more about\n   where we draw the line and why.\n\n config.mak.uname | 6 ------\n 1 file changed, 6 deletions(-)\n\ndiff --git a/config.mak.uname b/config.mak.uname\nindex b12d4e168a..5d18d92cb1 100644\n--- a/config.mak.uname\n+++ b/config.mak.uname\n@@ -273,16 +273,10 @@ ifeq ($(uname_S),FreeBSD)\n         ifeq ($(firstword $(subst -, ,$(uname_R))),10.1)\n \t\tOLD_ICONV = YesPlease\n         endif\n-\tNO_MEMMEM = YesPlease\n \tBASIC_CFLAGS += -I/usr/local/include\n \tBASIC_LDFLAGS += -L/usr/local/lib\n \tDIR_HAS_BSD_GROUP_SEMANTICS = YesPlease\n \tUSE_ST_TIMESPEC = YesPlease\n-        ifeq ($(shell expr \"$(uname_R)\" : '4\\.'),2)\n-\t\tPTHREAD_LIBS = -pthread\n-\t\tNO_UINTMAX_T = YesPlease\n-\t\tNO_STRTOUMAX = YesPlease\n-        endif\n \tPYTHON_PATH = /usr/local/bin/python\n \tPERL_PATH = /usr/local/bin/perl\n \tHAVE_PATHS_H = YesPlease\n-- \n2.50.0-rc2-215-g56f75d5edf\n"},{"id":"520198","messageId":"4fi5rwhpavu3se3htd2s4ym7oppswrwam545vczwf2jvumeqs3@z7imdc7cdw52","threadId":"63633","inReplyTo":"xmqqv7p0bpdl.fsf_-_@gitster.g","subject":"Re: [PATCH v3] config.mak.uname: update settings for FreeBSD","fromName":"Carlo Marcelo Arenas Belón","fromEmail":"carenas@gmail.com","sentAt":"2025-06-12T22:30:59Z","receivedAt":"2025-06-12T22:31:02Z","isPatch":true,"sender":{"key":"carenas@gmail.com","avatar":"https://avatars.githubusercontent.com/u/76036?v=4"},"body":"On Thu, Jun 12, 2025 at 02:51:02PM -0800, Junio C Hamano wrote:\n> \n>  * So,... earlier I mentioned about officially documenting the EoL\n>    timeline for various platform support, but without any official\n>    one that documents the decision in one place, how about a commit\n>    with a detailed log like this one, which I stole from brian?\n> \n>    No code changes since v2; only the log message talks more about\n>    where we draw the line and why.\n\nI was hoping something more like with the following (untested) \"fixup\"\non toa, obviously the \"unconditionally\" in the commit message should\nneed adding \"for the supported versions\"\n\ndiff --git a/config.mak.uname b/config.mak.uname\nindex 9cac400d94..cbf1f4c0d2 100644\n--- a/config.mak.uname\n+++ b/config.mak.uname\n@@ -280,6 +280,9 @@ ifeq ($(uname_S),FreeBSD)\n         ifeq ($(firstword $(subst -, ,$(uname_R))),10.1)\n \t\tOLD_ICONV = YesPlease\n         endif\n+\tifeq ($(shell test \"`expr \"$(uname_R)\" : '\\([1-9][0-9]*\\)\\.'`\" -lt 12 && echo 1),1)\n+\t\tNO_MEMMEM = UnfortunatelyYes\n+\tendif\n \tBASIC_CFLAGS += -I/usr/local/include\n \tBASIC_LDFLAGS += -L/usr/local/lib\n \tDIR_HAS_BSD_GROUP_SEMANTICS = YesPlease\n\nNote that either way the build won't be broken\n\nCarlo\n"},{"id":"520199","messageId":"xmqqjz5gbn7m.fsf@gitster.g","threadId":"63633","inReplyTo":"4fi5rwhpavu3se3htd2s4ym7oppswrwam545vczwf2jvumeqs3@z7imdc7cdw52","subject":"Re: [PATCH v3] config.mak.uname: update settings for FreeBSD","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-06-12T22:37:49Z","receivedAt":"2025-06-12T22:37:52Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Carlo Marcelo Arenas Belón <carenas@gmail.com> writes:\n\n> I was hoping something more like with the following (untested) \"fixup\"\n> on toa, obviously the \"unconditionally\" in the commit message should\n> need adding \"for the supported versions\"\n>\n> diff --git a/config.mak.uname b/config.mak.uname\n> index 9cac400d94..cbf1f4c0d2 100644\n> --- a/config.mak.uname\n> +++ b/config.mak.uname\n> @@ -280,6 +280,9 @@ ifeq ($(uname_S),FreeBSD)\n>          ifeq ($(firstword $(subst -, ,$(uname_R))),10.1)\n>  \t\tOLD_ICONV = YesPlease\n>          endif\n> +\tifeq ($(shell test \"`expr \"$(uname_R)\" : '\\([1-9][0-9]*\\)\\.'`\" -lt 12 && echo 1),1)\n> +\t\tNO_MEMMEM = UnfortunatelyYes\n> +\tendif\n>  \tBASIC_CFLAGS += -I/usr/local/include\n>  \tBASIC_LDFLAGS += -L/usr/local/lib\n>  \tDIR_HAS_BSD_GROUP_SEMANTICS = YesPlease\n>\n> Note that either way the build won't be broken\n\nAs I do not think we quite care about anything older than 12, I am\nperfectly fine being a bit extra defensive like your version.\n\nCare to assemble the final version with both code and log message\nupdates?  We are not in a hurry, as we are talking about a rather\nancient issue and this will not come close to 'master' before the\nfinal release next week anyway.\n\nThanks.\n"},{"id":"521160","messageId":"20250702093736.36074-1-carenas@gmail.com","threadId":"63633","inReplyTo":"xmqqv7p0bpdl.fsf_-_@gitster.g","subject":"[PATCH v4 0/2] config.mak.uname: update settings for FreeBSD","fromName":"Carlo Marcelo Arenas Belón","fromEmail":"carenas@gmail.com","sentAt":"2025-07-02T09:37:34Z","receivedAt":"2025-07-02T09:38:07Z","isPatch":true,"sender":{"key":"carenas@gmail.com","avatar":"https://avatars.githubusercontent.com/u/76036?v=4"},"body":"Modernize config.mak.uname defaults for FreeBSD to prioritize using the\nplatform implementation of memmem().\n\nCarlo Marcelo Arenas Belón (2):\n  config.mak.uname: set NO_MEMMEM only for functional version\n  build: retire NO_UINTMAX_T\n\n Makefile         |  5 -----\n config.mak.uname |  9 +++------\n configure.ac     |  8 --------\n meson.build      | 11 -----------\n 4 files changed, 3 insertions(+), 30 deletions(-)\n\n-- \n2.50.0.147.gafe0d4ec5b\n\n"},{"id":"521161","messageId":"20250702093736.36074-2-carenas@gmail.com","threadId":"63633","inReplyTo":"20250702093736.36074-1-carenas@gmail.com","subject":"[PATCH v4 1/2] config.mak.uname: set NO_MEMMEM only for functional version","fromName":"Carlo Marcelo Arenas Belón","fromEmail":"carenas@gmail.com","sentAt":"2025-07-02T09:37:35Z","receivedAt":"2025-07-02T09:38:08Z","isPatch":true,"sender":{"key":"carenas@gmail.com","avatar":"https://avatars.githubusercontent.com/u/76036?v=4"},"body":"FreeBSD 6 introduced memmem(), but the implementation diverged\nfrom what was standard everywhere else (including our \"compat\"\nfallback).\n\nFreeBSD 10.4 (went EOL in 2018) corrected the functionality bugs\nbut kept a suboptimal implementation until FreeBSD 11.4 (the last\nversion of FreeBSD 11, that went EOL in September 2021).\n\nLet's draw the line to require FreeBSD 12 or newer, which allows us\nto drop the special casing of FreeBSD 4.x and rely on the platform\nimplementation of memmem() unconditionally for all versions that are\nstill being supported.\n\nSuggested-by: Brad Smith <brad@comstyle.com>\nHelped-by: brian m. carlson <sandals@crustytoothpaste.net>\nSigned-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>\n---\n config.mak.uname | 9 +++------\n 1 file changed, 3 insertions(+), 6 deletions(-)\n\ndiff --git a/config.mak.uname b/config.mak.uname\nindex b12d4e168a..2b434df9e5 100644\n--- a/config.mak.uname\n+++ b/config.mak.uname\n@@ -273,16 +273,13 @@ ifeq ($(uname_S),FreeBSD)\n         ifeq ($(firstword $(subst -, ,$(uname_R))),10.1)\n \t\tOLD_ICONV = YesPlease\n         endif\n-\tNO_MEMMEM = YesPlease\n+        ifeq ($(shell v=$(uname_R) && test $${v%%.*} -lt 12 && echo 1),1)\n+\t\tNO_MEMMEM = UnfortunatelyYes\n+        endif\n \tBASIC_CFLAGS += -I/usr/local/include\n \tBASIC_LDFLAGS += -L/usr/local/lib\n \tDIR_HAS_BSD_GROUP_SEMANTICS = YesPlease\n \tUSE_ST_TIMESPEC = YesPlease\n-        ifeq ($(shell expr \"$(uname_R)\" : '4\\.'),2)\n-\t\tPTHREAD_LIBS = -pthread\n-\t\tNO_UINTMAX_T = YesPlease\n-\t\tNO_STRTOUMAX = YesPlease\n-        endif\n \tPYTHON_PATH = /usr/local/bin/python\n \tPERL_PATH = /usr/local/bin/perl\n \tHAVE_PATHS_H = YesPlease\n-- \n2.50.0.147.gafe0d4ec5b\n\n"},{"id":"521162","messageId":"20250702093736.36074-3-carenas@gmail.com","threadId":"63633","inReplyTo":"20250702093736.36074-1-carenas@gmail.com","subject":"[PATCH v4 2/2] build: retire NO_UINTMAX_T","fromName":"Carlo Marcelo Arenas Belón","fromEmail":"carenas@gmail.com","sentAt":"2025-07-02T09:37:36Z","receivedAt":"2025-07-02T09:38:09Z","isPatch":true,"sender":{"key":"carenas@gmail.com","avatar":"https://avatars.githubusercontent.com/u/76036?v=4"},"body":"A previous commit removed the last user of it, and it is no\nlonger useful with the codebase moving towards C99, which\nspecifies its definition.\n\nSigned-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>\n---\n Makefile     |  5 -----\n configure.ac |  8 --------\n meson.build  | 11 -----------\n 3 files changed, 24 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 3868edd349..ba111f191f 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -114,8 +114,6 @@ include shared.mak\n #\n # Define NO_INTPTR_T if you don't have intptr_t or uintptr_t.\n #\n-# Define NO_UINTMAX_T if you don't have uintmax_t.\n-#\n # Define NEEDS_SOCKET if linking with libc is not enough (SunOS,\n # Patrick Mauritz).\n #\n@@ -1915,9 +1913,6 @@ endif\n ifdef NO_INTPTR_T\n \tCOMPAT_CFLAGS += -DNO_INTPTR_T\n endif\n-ifdef NO_UINTMAX_T\n-\tBASIC_CFLAGS += -Duintmax_t=uint32_t\n-endif\n ifdef NO_SOCKADDR_STORAGE\n ifdef NO_IPV6\n \tBASIC_CFLAGS += -Dsockaddr_storage=sockaddr_in\ndiff --git a/configure.ac b/configure.ac\nindex 5923edc44a..d8c3af161b 100644\n--- a/configure.ac\n+++ b/configure.ac\n@@ -1121,14 +1121,6 @@ GIT_CHECK_FUNC(strlcpy,\n [NO_STRLCPY=YesPlease])\n GIT_CONF_SUBST([NO_STRLCPY])\n #\n-# Define NO_UINTMAX_T if your platform does not have uintmax_t\n-AC_CHECK_TYPE(uintmax_t,\n-[NO_UINTMAX_T=],\n-[NO_UINTMAX_T=YesPlease],[\n-#include <inttypes.h>\n-])\n-GIT_CONF_SUBST([NO_UINTMAX_T])\n-#\n # Define NO_STRTOUMAX if you don't have strtoumax in the C library.\n GIT_CHECK_FUNC(strtoumax,\n [NO_STRTOUMAX=],\ndiff --git a/meson.build b/meson.build\nindex efe2871c9d..27d5f40741 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -1331,17 +1331,6 @@ if compiler.compiles('''\n   libgit_c_args += '-DHAVE_CLOCK_MONOTONIC'\n endif\n \n-if not compiler.compiles('''\n-  #include <inttypes.h>\n-\n-  void func(void)\n-  {\n-    uintmax_t x = 0;\n-  }\n-''', name: 'uintmax_t')\n-  libgit_c_args += '-DNO_UINTMAX_T'\n-endif\n-\n has_bsd_sysctl = false\n if compiler.has_header('sys/sysctl.h')\n   if compiler.compiles('''\n-- \n2.50.0.147.gafe0d4ec5b\n\n"},{"id":"521182","messageId":"xmqqtt3uef6h.fsf@gitster.g","threadId":"63633","inReplyTo":"20250702093736.36074-1-carenas@gmail.com","subject":"Re: [PATCH v4 0/2] config.mak.uname: update settings for FreeBSD","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-07-02T16:21:58Z","receivedAt":"2025-07-02T16:22:00Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Carlo Marcelo Arenas Belón <carenas@gmail.com> writes:\n\n> Modernize config.mak.uname defaults for FreeBSD to prioritize using the\n> platform implementation of memmem().\n>\n> Carlo Marcelo Arenas Belón (2):\n>   config.mak.uname: set NO_MEMMEM only for functional version\n>   build: retire NO_UINTMAX_T\n>\n>  Makefile         |  5 -----\n>  config.mak.uname |  9 +++------\n>  configure.ac     |  8 --------\n>  meson.build      | 11 -----------\n>  4 files changed, 3 insertions(+), 30 deletions(-)\n\nThanks.  As far as I (without access to FreeBSD boxes) can see, the\npatches look good---the changes are reasonable and well described.\n\nWill replace the single patch from Brad.\n\nThanks.\n\n"}]}