{"thread":{"id":"63629","subject":"[PATCH] config.mak.uname: update settings for FreeBSD","startedAt":"2025-06-12T03:13:41Z","lastAt":"2025-07-03T12:40:58Z","messageCount":6,"participants":["Brad Smith","Collin Funk","Junio C Hamano","Renato Botelho"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"520148","messageId":"aEpF3ZjNwkR8FssX@humpty.home.comstyle.com","threadId":"63629","inReplyTo":null,"subject":"[PATCH] config.mak.uname: update settings for FreeBSD","fromName":"Brad Smith","fromEmail":"brad@comstyle.com","sentAt":"2025-06-12T03:13:33Z","receivedAt":"2025-06-12T03:13:41Z","isPatch":true,"sender":{"key":"brad@comstyle.com","avatar":"https://avatars.githubusercontent.com/u/1129902?v=4"},"body":"FreeBSD 6.0 has memmem().\n\nSigned-off-by: Brad Smith \n---\n config.mak.uname | 6 ------\n 1 file changed, 6 deletions(-)\n\ndiff --git a/config.mak.uname b/config.mak.uname\nindex b1c5c4d5e8..da592eeaa0 100644\n--- a/config.mak.uname\n+++ b/config.mak.uname\n@@ -302,16 +302,10 @@ ifeq ($(uname_S),FreeBSD)\n ifeq ($(firstword $(subst -, ,$(uname_R))),10.1)\n \t\tOLD_ICONV = YesPlease\n endif\n-\tNO_MEMMEM = YesPlease\n \tBASIC_CFLAGS += -I/usr/local/include\n \tBASIC_LDFLAGS += -L/usr/local/lib\n \tDIR_HAS_BSD_GROUP_SEMANTICS = YesPlease\n \tUSE_ST_TIMESPEC = YesPlease\n- ifeq ($(shell expr \"$(uname_R)\" : '4\\.'),2)\n-\t\tPTHREAD_LIBS = -pthread\n-\t\tNO_UINTMAX_T = YesPlease\n-\t\tNO_STRTOUMAX = YesPlease\n- endif\n \tPYTHON_PATH = /usr/local/bin/python\n \tPERL_PATH = /usr/local/bin/perl\n \tHAVE_PATHS_H = YesPlease\n-- \n2.49.0\n\n"},{"id":"520150","messageId":"87ikl1eiuf.fsf@gmail.com","threadId":"63629","inReplyTo":"aEpF3ZjNwkR8FssX@humpty.home.comstyle.com","subject":"Re: [PATCH] config.mak.uname: update settings for FreeBSD","fromName":"Collin Funk","fromEmail":"collin.funk1@gmail.com","sentAt":"2025-06-12T03:31:36Z","receivedAt":"2025-06-12T03:31:38Z","isPatch":true,"sender":{"key":"collin.funk1@gmail.com","avatar":"https://avatars.githubusercontent.com/u/65689063?v=4"},"body":"Hi Brad,\n\nBrad Smith writes:\n\n> FreeBSD 6.0 has memmem().\n>\n> Signed-off-by: Brad Smith \n> ---\n> config.mak.uname | 6 ------\n> 1 file changed, 6 deletions(-)\n>\n> diff --git a/config.mak.uname b/config.mak.uname\n> index b1c5c4d5e8..da592eeaa0 100644\n> --- a/config.mak.uname\n> +++ b/config.mak.uname\n> @@ -302,16 +302,10 @@ ifeq ($(uname_S),FreeBSD)\n> ifeq ($(firstword $(subst -, ,$(uname_R))),10.1)\n> \t\tOLD_ICONV = YesPlease\n> endif\n> -\tNO_MEMMEM = YesPlease\n\nI don't have a FreeBSD machine that old to test it. But Gnulib's\ndocumentation says it was added in FreeBSD 5.2.1 [1].\n\nReviewed-by: Collin Funk \n\n> \tBASIC_CFLAGS += -I/usr/local/include\n> \tBASIC_LDFLAGS += -L/usr/local/lib\n> \tDIR_HAS_BSD_GROUP_SEMANTICS = YesPlease\n> \tUSE_ST_TIMESPEC = YesPlease\n> - ifeq ($(shell expr \"$(uname_R)\" : '4\\.'),2)\n> -\t\tPTHREAD_LIBS = -pthread\n> -\t\tNO_UINTMAX_T = YesPlease\n> -\t\tNO_STRTOUMAX = YesPlease\n> - endif\n> \tPYTHON_PATH = /usr/local/bin/python\n> \tPERL_PATH = /usr/local/bin/perl\n> \tHAVE_PATHS_H = YesPlease\n\nCurious about this change though. Are you basing it off a FreeBSD system\nyou have? Or do we not care about that old version anymore? For\nreference, FreeBSD 4.2 was released in 2000.\n\nCollin\n\n[1] https://www.gnu.org/software/gnulib/manual/html_node/memmem.html\n[2] https://www.freebsd.org/releases/4.2R/announce/\n"},{"id":"520152","messageId":"cca64148-3f55-4ec7-9684-f475bfadeded@comstyle.com","threadId":"63629","inReplyTo":"87ikl1eiuf.fsf@gmail.com","subject":"Re: [PATCH] config.mak.uname: update settings for FreeBSD","fromName":"Brad Smith","fromEmail":"brad@comstyle.com","sentAt":"2025-06-12T03:46:31Z","receivedAt":"2025-06-12T03:46:34Z","isPatch":true,"sender":{"key":"brad@comstyle.com","avatar":"https://avatars.githubusercontent.com/u/1129902?v=4"},"body":"On 2025-06-11 11:31 p.m., Collin Funk wrote:\n> Hi Brad,\n>\n> Brad Smith writes:\n>\n>> FreeBSD 6.0 has memmem().\n>>\n>> Signed-off-by: Brad Smith \n>> ---\n>> config.mak.uname | 6 ------\n>> 1 file changed, 6 deletions(-)\n>>\n>> diff --git a/config.mak.uname b/config.mak.uname\n>> index b1c5c4d5e8..da592eeaa0 100644\n>> --- a/config.mak.uname\n>> +++ b/config.mak.uname\n>> @@ -302,16 +302,10 @@ ifeq ($(uname_S),FreeBSD)\n>> ifeq ($(firstword $(subst -, ,$(uname_R))),10.1)\n>> \t\tOLD_ICONV = YesPlease\n>> endif\n>> -\tNO_MEMMEM = YesPlease\n> I don't have a FreeBSD machine that old to test it. But Gnulib's\n> documentation says it was added in FreeBSD 5.2.1 [1].\n\nNot that it matters for git, but that does not match the actual code.\nThe first man page I see is for 6 and looking at their source repo I\nonly see memmem() on the 6 branch.\n\nhttps://svnweb.freebsd.org/base/stable/5/lib/libc/string/\nhttps://svnweb.freebsd.org/base/stable/6/lib/libc/string/\n\n\n> Reviewed-by: Collin Funk \n>\n>> \tBASIC_CFLAGS += -I/usr/local/include\n>> \tBASIC_LDFLAGS += -L/usr/local/lib\n>> \tDIR_HAS_BSD_GROUP_SEMANTICS = YesPlease\n>> \tUSE_ST_TIMESPEC = YesPlease\n>> - ifeq ($(shell expr \"$(uname_R)\" : '4\\.'),2)\n>> -\t\tPTHREAD_LIBS = -pthread\n>> -\t\tNO_UINTMAX_T = YesPlease\n>> -\t\tNO_STRTOUMAX = YesPlease\n>> - endif\n>> \tPYTHON_PATH = /usr/local/bin/python\n>> \tPERL_PATH = /usr/local/bin/perl\n>> \tHAVE_PATHS_H = YesPlease\n> Curious about this change though. Are you basing it off a FreeBSD system\n> you have? Or do we not care about that old version anymore? For\n> reference, FreeBSD 4.2 was released in 2000.\n\nI probably should have mentioned it in some manner in the commit message.\nSince the minimum version is now 6.x after this changed I removed the 4.x\nsupport. 6.0 is 19.5 years old.\n\n> Collin\n>\n> [1] https://www.gnu.org/software/gnulib/manual/html_node/memmem.html\n> [2] https://www.freebsd.org/releases/4.2R/announce/\n>\n"},{"id":"520153","messageId":"xmqqsek5fwnu.fsf@gitster.g","threadId":"63629","inReplyTo":"aEpF3ZjNwkR8FssX@humpty.home.comstyle.com","subject":"Re: [PATCH] config.mak.uname: update settings for FreeBSD","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-06-12T03:47:49Z","receivedAt":"2025-06-12T03:47:52Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Brad Smith writes:\n\n> FreeBSD 6.0 has memmem().\n\nAnd anything older than that no longer matters? \n\nThat may indeed be true (6.0 was from Nov 2005), but if that is the\nreason why we simply lose NO_MEMMEM (instead of conditionally losing\nfor 6.0 and newer), that needs to be explained in the proposed log\nmessage, together with the reason why we no longer do anything\nspecial with version \"4.x\" (which could be \"We ditch the support for\nanything older than 6.0\").\n\nAssuming that our stance is \"anything older than 6.0 no longer\nmatters\", the patch itself looks good.\n\n> Signed-off-by: Brad Smith \n> ---\n> config.mak.uname | 6 ------\n> 1 file changed, 6 deletions(-)\n>\n> diff --git a/config.mak.uname b/config.mak.uname\n> index b1c5c4d5e8..da592eeaa0 100644\n> --- a/config.mak.uname\n> +++ b/config.mak.uname\n> @@ -302,16 +302,10 @@ ifeq ($(uname_S),FreeBSD)\n> ifeq ($(firstword $(subst -, ,$(uname_R))),10.1)\n> \t\tOLD_ICONV = YesPlease\n> endif\n> -\tNO_MEMMEM = YesPlease\n> \tBASIC_CFLAGS += -I/usr/local/include\n> \tBASIC_LDFLAGS += -L/usr/local/lib\n> \tDIR_HAS_BSD_GROUP_SEMANTICS = YesPlease\n> \tUSE_ST_TIMESPEC = YesPlease\n> - ifeq ($(shell expr \"$(uname_R)\" : '4\\.'),2)\n> -\t\tPTHREAD_LIBS = -pthread\n> -\t\tNO_UINTMAX_T = YesPlease\n> -\t\tNO_STRTOUMAX = YesPlease\n> - endif\n> \tPYTHON_PATH = /usr/local/bin/python\n> \tPERL_PATH = /usr/local/bin/perl\n> \tHAVE_PATHS_H = YesPlease\n"},{"id":"520155","messageId":"ddb50b73-8f98-48e5-880b-b991508edea3@comstyle.com","threadId":"63629","inReplyTo":"xmqqsek5fwnu.fsf@gitster.g","subject":"Re: [PATCH] config.mak.uname: update settings for FreeBSD","fromName":"Brad Smith","fromEmail":"brad@comstyle.com","sentAt":"2025-06-12T03:54:11Z","receivedAt":"2025-06-12T03:54:13Z","isPatch":true,"sender":{"key":"brad@comstyle.com","avatar":"https://avatars.githubusercontent.com/u/1129902?v=4"},"body":"On 2025-06-11 11:47 p.m., Junio C Hamano wrote:\n> Brad Smith writes:\n>\n>> FreeBSD 6.0 has memmem().\n> And anything older than that no longer matters?\n\nI look at is as so. 6.0 is 19.5 years old as it is.\n\n> That may indeed be true (6.0 was from Nov 2005), but if that is the\n> reason why we simply lose NO_MEMMEM (instead of conditionally losing\n> for 6.0 and newer), that needs to be explained in the proposed log\n> message, together with the reason why we no longer do anything\n> special with version \"4.x\" (which could be \"We ditch the support for\n> anything older than 6.0\").\n>\n> Assuming that our stance is \"anything older than 6.0 no longer\n> matters\", the patch itself looks good.\n\nThis was my intent. I'll update the commit message.\n\n"},{"id":"521270","messageId":"f61f6a80-da7c-4849-bc89-806eab84662e@FreeBSD.org","threadId":"63629","inReplyTo":"xmqqsek5fwnu.fsf@gitster.g","subject":"Re: [PATCH] config.mak.uname: update settings for FreeBSD","fromName":"Renato Botelho","fromEmail":"garga@freebsd.org","sentAt":"2025-07-03T12:40:54Z","receivedAt":"2025-07-03T12:40:58Z","isPatch":true,"sender":{"key":"garga@freebsd.org","avatar":"https://gravatar.com/avatar/695c68fb2f0629998c430204a7212aec683a3f87ec5eeaae236fd2376e790bfc?d=mp&s=160"},"body":"On 12/06/25 00:47, Junio C Hamano wrote:\n> Brad Smith writes:\n> \n>> FreeBSD 6.0 has memmem().\n> \n> And anything older than that no longer matters?\n\nThe oldest supported version of FreeBSD is 13.5, which will EOL in April \n2026.\n\n> That may indeed be true (6.0 was from Nov 2005), but if that is the\n> reason why we simply lose NO_MEMMEM (instead of conditionally losing\n> for 6.0 and newer), that needs to be explained in the proposed log\n> message, together with the reason why we no longer do anything\n> special with version \"4.x\" (which could be \"We ditch the support for\n> anything older than 6.0\").\n> \n> Assuming that our stance is \"anything older than 6.0 no longer\n> matters\", the patch itself looks good.\n> \n>> Signed-off-by: Brad Smith \n>> ---\n>> config.mak.uname | 6 ------\n>> 1 file changed, 6 deletions(-)\n>>\n>> diff --git a/config.mak.uname b/config.mak.uname\n>> index b1c5c4d5e8..da592eeaa0 100644\n>> --- a/config.mak.uname\n>> +++ b/config.mak.uname\n>> @@ -302,16 +302,10 @@ ifeq ($(uname_S),FreeBSD)\n>> ifeq ($(firstword $(subst -, ,$(uname_R))),10.1)\n>> \t\tOLD_ICONV = YesPlease\n>> endif\n>> -\tNO_MEMMEM = YesPlease\n>> \tBASIC_CFLAGS += -I/usr/local/include\n>> \tBASIC_LDFLAGS += -L/usr/local/lib\n>> \tDIR_HAS_BSD_GROUP_SEMANTICS = YesPlease\n>> \tUSE_ST_TIMESPEC = YesPlease\n>> - ifeq ($(shell expr \"$(uname_R)\" : '4\\.'),2)\n>> -\t\tPTHREAD_LIBS = -pthread\n>> -\t\tNO_UINTMAX_T = YesPlease\n>> -\t\tNO_STRTOUMAX = YesPlease\n>> - endif\n>> \tPYTHON_PATH = /usr/local/bin/python\n>> \tPERL_PATH = /usr/local/bin/perl\n>> \tHAVE_PATHS_H = YesPlease\n> \n> \n\n-- \nRenato Botelho\n\n"}]}