{"thread":{"id":"63625","subject":"[PATCH 1/2] ci(coverity): fix building on Windows","startedAt":"2025-06-11T14:02:37Z","lastAt":"2025-06-11T17:27:43Z","messageCount":10,"participants":["Johannes Schindelin via GitGitGadget","Junio C Hamano","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"520100","messageId":"c65120f25704e9725c317a62b9a1231bd19f3e25.1749650552.git.gitgitgadget@gmail.com","threadId":"63625","inReplyTo":"pull.1934.git.1749650552.gitgitgadget@gmail.com","subject":"[PATCH 1/2] ci(coverity): fix building on Windows","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2025-06-11T14:02:31Z","receivedAt":"2025-06-11T14:02:37Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"From: Johannes Schindelin \n\nWhen I added the Coverity workflow in a56b6230d0b1 (ci: add a GitHub\nworkflow to submit Coverity scans, 2023-09-25), I merely converted an\nAzure Pipeline definition that had been running successfully for ages.\n\nIn the meantime, the current Coverity documentation describes a very\ndifferent way to install the analysis tool, recommending to add the\n`bin/` directory to the _end_ of `PATH` (when originally, IIRC, it was\nrecommended to add it to the _beginning_ of the `PATH`).\n\nThis is crucial! The reason is that the current incarnation of the\nWindows variant of Coverity's analysis tools come with a _lot_ of DLL\nfiles in their `bin/` directory, some of them interferring rather badly\nwith the `gcc.exe` in Git for Windows' SDK that we use to run the\nCoverity build. The symptom is a cryptic error message:\n\n make: *** [Makefile:2960: headless-git.o] Error 1\n make: *** Waiting for unfinished jobs....\n D:\\git-sdk-64-minimal\\mingw64\\bin\\windres.exe: preprocessing failed.\n make: *** [Makefile:2679: git.res] Error 1\n make: *** [Makefile:2893: git.o] Error 1\n make: *** [Makefile:2893: builtin/add.o] Error 1\n Attempting to detect unconfigured compilers in build\n |0----------25-----------50----------75---------100|\n ****************************************************\n Warning: Build command make.exe exited with code 2. Please verify that the build completed successfully.\n Warning: Emitted 0 C/C++ compilation units (0%) successfully\n\n 0 C/C++ compilation units (0%) are ready for analysis\n For more details, please look at:\n D:/a/git/git/cov-int/build-log.txt\n\nThe log (which the workflow is currently not configured to reveal) then\npoints out that the `windows.h` header cannot be found, which is _still_\nnot very helpful. The underlying root cause is that the `gcc.exe` in Git\nfor Windows' SDK determines the location of the header files via the\nlocation of certain DLL files, and finding the \"wrong\" ones first on the\n`PATH` misleads that logic.\n\nLet's fix this problem by following Coverity's current recommendation\nand append the `bin/` directory in which `cov-int` can be found to the\n_end_ of `PATH`.\n\nSigned-off-by: Johannes Schindelin \n---\n .github/workflows/coverity.yml | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml\nindex 124301dbbe2f..a5d99e59d4eb 100644\n--- a/.github/workflows/coverity.yml\n+++ b/.github/workflows/coverity.yml\n@@ -147,7 +147,7 @@ jobs:\n key: cov-build-${{ env.COVERITY_LANGUAGE }}-${{ env.COVERITY_PLATFORM }}-${{ steps.lookup.outputs.hash }}\n - name: build with cov-build\n run: |\n- export PATH=\"$RUNNER_TEMP/cov-analysis/bin:$PATH\" &&\n+ export PATH=\"$PATH:$(cygpath -au \"$RUNNER_TEMP\")/cov-analysis/bin\" &&\n cov-configure --gcc &&\n cov-build --dir cov-int make\n - name: package the build\n-- \ngitgitgadget\n\n"},{"id":"520101","messageId":"3a829f11c07ddbb0a57a1ac832db686f29a9b632.1749650552.git.gitgitgadget@gmail.com","threadId":"63625","inReplyTo":"pull.1934.git.1749650552.gitgitgadget@gmail.com","subject":"[PATCH 2/2] ci(coverity): output the build log upon error","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2025-06-11T14:02:32Z","receivedAt":"2025-06-11T14:02:38Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"From: Johannes Schindelin \n\nIt is quite helpful to know what Coverity said, exactly, in case it\nfails to analyze the code.\n\nSigned-off-by: Johannes Schindelin \n---\n .github/workflows/coverity.yml | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)\n\ndiff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml\nindex a5d99e59d4eb..1e8bd85ecd4e 100644\n--- a/.github/workflows/coverity.yml\n+++ b/.github/workflows/coverity.yml\n@@ -149,7 +149,11 @@ jobs:\n run: |\n export PATH=\"$PATH:$(cygpath -au \"$RUNNER_TEMP\")/cov-analysis/bin\" &&\n cov-configure --gcc &&\n- cov-build --dir cov-int make\n+ if ! cov-build --dir cov-int make\n+ then\n+ cat cov-int/build-log.txt\n+ exit 1\n+ fi\n - name: package the build\n run: tar -czvf cov-int.tgz cov-int\n - name: submit the build to Coverity Scan\n-- \ngitgitgadget\n"},{"id":"520102","messageId":"pull.1934.git.1749650552.gitgitgadget@gmail.com","threadId":"63625","inReplyTo":null,"subject":"[PATCH 0/2] Fix Coverity builds on Windows","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2025-06-11T14:02:30Z","receivedAt":"2025-06-11T14:02:38Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"As of three weeks ago, Git for Windows' Coverity builds fail\n[https://github.com/git-for-windows/git/actions/workflows/coverity.yml?query=branch%3Amain].\n\nThe reason is most likely the most recent Coverity release, 2025.3. Its\nrelease notes\n[https://documentation.blackduck.com/bundle/coverity-docs/page/webhelp-files/relnotes_latest.html]\ndo not shed any light into the issue (and do not mention that they bundle\nJDK20 and JDK22 in addition to a JRE, because what's better than a single\nJava installation: three, right?).\n\nMy investigation turned up .dll files that are located in Coverity's bin/\ndirectory which have the same name as .dll files in Git for Windows' SDK. As\na consequence, the former override the latter and throw off MSYS2's logic to\nfind the MSYS2 root directory given the location of certain .dll files.\n\nThis PR fixes this issue, and while at it, enhances the Coverity workflow to\nprint out the build log in case of failure.\n\nJohannes Schindelin (2):\n ci(coverity): fix building on Windows\n ci(coverity): output the build log upon error\n\n .github/workflows/coverity.yml | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)\n\n\nbase-commit: 683c54c999c301c2cd6f715c411407c413b1d84e\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1934%2Fdscho%2Ffix-coverity-builds-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1934/dscho/fix-coverity-builds-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/1934\n-- \ngitgitgadget\n"},{"id":"520103","messageId":"xmqqtt4mjqz4.fsf@gitster.g","threadId":"63625","inReplyTo":"c65120f25704e9725c317a62b9a1231bd19f3e25.1749650552.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 1/2] ci(coverity): fix building on Windows","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-06-11T14:24:47Z","receivedAt":"2025-06-11T14:24:50Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Johannes Schindelin via GitGitGadget\" \nwrites:\n\n> ...\n> In the meantime, the current Coverity documentation describes a very\n> different way to install the analysis tool, recommending to add the\n> `bin/` directory to the _end_ of `PATH` (when originally, IIRC, it was\n> recommended to add it to the _beginning_ of the `PATH`).\n> ..., and finding the \"wrong\" ones first on the\n> `PATH` misleads that logic.\n>\n> Let's fix this problem by following Coverity's current recommendation\n> and append the `bin/` directory in which `cov-int` can be found to the\n> _end_ of `PATH`.\n\nWow, that is a very well described change.\n\n> Signed-off-by: Johannes Schindelin \n> ---\n> .github/workflows/coverity.yml | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml\n> index 124301dbbe2f..a5d99e59d4eb 100644\n> --- a/.github/workflows/coverity.yml\n> +++ b/.github/workflows/coverity.yml\n> @@ -147,7 +147,7 @@ jobs:\n> key: cov-build-${{ env.COVERITY_LANGUAGE }}-${{ env.COVERITY_PLATFORM }}-${{ steps.lookup.outputs.hash }}\n> - name: build with cov-build\n> run: |\n> - export PATH=\"$RUNNER_TEMP/cov-analysis/bin:$PATH\" &&\n> + export PATH=\"$PATH:$(cygpath -au \"$RUNNER_TEMP\")/cov-analysis/bin\" &&\n\nAdditionally two things are lacking explanation in the proposed log\nmessage, though, or an uninitiated will still be left scratching his\nhead:\n\n - Why didn't the original need \"cygpath -au\"?\n\n - Even though many steps in this job deals with different\n env.COVERITY_PLATFORM, this part does not seem to be conditional.\n Why is $(cygpath -au ...) safe outside Windows environment?\n\nOther than that, nicely done and very nicely explained.\n\n\n\n> cov-configure --gcc &&\n> cov-build --dir cov-int make\n> - name: package the build\n"},{"id":"520104","messageId":"xmqqplfajqyh.fsf@gitster.g","threadId":"63625","inReplyTo":"3a829f11c07ddbb0a57a1ac832db686f29a9b632.1749650552.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 2/2] ci(coverity): output the build log upon error","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-06-11T14:25:10Z","receivedAt":"2025-06-11T14:25:12Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Johannes Schindelin via GitGitGadget\" \nwrites:\n\n> From: Johannes Schindelin \n>\n> It is quite helpful to know what Coverity said, exactly, in case it\n> fails to analyze the code.\n>\n> Signed-off-by: Johannes Schindelin \n> ---\n> .github/workflows/coverity.yml | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n\nWonderful. Will queue, together with 1/2. Thanks.\n\n>\n> diff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml\n> index a5d99e59d4eb..1e8bd85ecd4e 100644\n> --- a/.github/workflows/coverity.yml\n> +++ b/.github/workflows/coverity.yml\n> @@ -149,7 +149,11 @@ jobs:\n> run: |\n> export PATH=\"$PATH:$(cygpath -au \"$RUNNER_TEMP\")/cov-analysis/bin\" &&\n> cov-configure --gcc &&\n> - cov-build --dir cov-int make\n> + if ! cov-build --dir cov-int make\n> + then\n> + cat cov-int/build-log.txt\n> + exit 1\n> + fi\n> - name: package the build\n> run: tar -czvf cov-int.tgz cov-int\n> - name: submit the build to Coverity Scan\n"},{"id":"520108","messageId":"8d71bc71-3e5b-c59c-8948-c07d7b4f62ac@gmx.de","threadId":"63625","inReplyTo":"xmqqtt4mjqz4.fsf@gitster.g","subject":"Re: [PATCH 1/2] ci(coverity): fix building on Windows","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2025-06-11T15:53:32Z","receivedAt":"2025-06-11T15:53:36Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Junio,\n\nOn Wed, 11 Jun 2025, Junio C Hamano wrote:\n\n> \"Johannes Schindelin via GitGitGadget\" \n> writes:\n> \n> > diff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml\n> > index 124301dbbe2f..a5d99e59d4eb 100644\n> > --- a/.github/workflows/coverity.yml\n> > +++ b/.github/workflows/coverity.yml\n> > @@ -147,7 +147,7 @@ jobs:\n> > key: cov-build-${{ env.COVERITY_LANGUAGE }}-${{ env.COVERITY_PLATFORM }}-${{ steps.lookup.outputs.hash }}\n> > - name: build with cov-build\n> > run: |\n> > - export PATH=\"$RUNNER_TEMP/cov-analysis/bin:$PATH\" &&\n> > + export PATH=\"$PATH:$(cygpath -au \"$RUNNER_TEMP\")/cov-analysis/bin\" &&\n> \n> Additionally two things are lacking explanation in the proposed log\n> message, though, or an uninitiated will still be left scratching his\n> head:\n> \n> - Why didn't the original need \"cygpath -au\"?\n> \n> - Even though many steps in this job deals with different\n> env.COVERITY_PLATFORM, this part does not seem to be conditional.\n> Why is $(cygpath -au ...) safe outside Windows environment?\n\nI am delighted by your feedback which points out a functional problem. The\n`cygpath -au` is a left-over from some interactive debugging session where\nI _thought_ that `RUNNER_TEMP` contains a Windows path, and I wanted to\nmake sure that it is a Unix-like path.\n\nBut yes, this is totally in a cross-platform part of the workflow (which\nis itself already guarded by that `if:\ncontains(fromJSON(vars.ENABLE_COVERITY_SCAN_FOR_BRANCHES || '[\"\"]'),\ngithub.ref_name)` condition so that it is skipped in forks that did not\nenable this workflow explicitly.\n\nAs such, that `cygpath` call is incorrect, as it would fail on anything by\nWindows. It is also unnecessary, as I just verified in a manual run.\nTherefore I drop it from v2.\n\nThank you,\nJohannes\n"},{"id":"520112","messageId":"pull.1934.v2.git.1749657278.gitgitgadget@gmail.com","threadId":"63625","inReplyTo":"pull.1934.git.1749650552.gitgitgadget@gmail.com","subject":"[PATCH v2 0/2] Fix Coverity builds on Windows","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2025-06-11T15:54:36Z","receivedAt":"2025-06-11T15:54:41Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"As of three weeks ago, Git for Windows' Coverity builds fail\n[https://github.com/git-for-windows/git/actions/workflows/coverity.yml?query=branch%3Amain].\n\nThe reason is most likely the most recent Coverity release, 2025.3. Its\nrelease notes\n[https://documentation.blackduck.com/bundle/coverity-docs/page/webhelp-files/relnotes_latest.html]\ndo not shed any light into the issue (and do not mention that they bundle\nJDK20 and JDK22 in addition to a JRE, because what's better than a single\nJava installation: three, right?).\n\nMy investigation turned up .dll files that are located in Coverity's bin/\ndirectory which have the same name as .dll files in Git for Windows' SDK. As\na consequence, the former override the latter and throw off MSYS2's logic to\nfind the MSYS2 root directory given the location of certain .dll files.\n\nThis patch series fixes this issue, and while at it, enhances the Coverity\nworkflow to print out the build log in case of failure. It is a companion of\nhttps://github.com/git-for-windows/git/pull/5672 and of\n(https://github.com/microsoft/git/pull/764.\n\nChanges since v1:\n\n * Dropped unnecessary, non-portably cygpath call.\n\nJohannes Schindelin (2):\n ci(coverity): fix building on Windows\n ci(coverity): output the build log upon error\n\n .github/workflows/coverity.yml | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)\n\n\nbase-commit: 683c54c999c301c2cd6f715c411407c413b1d84e\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1934%2Fdscho%2Ffix-coverity-builds-v2\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1934/dscho/fix-coverity-builds-v2\nPull-Request: https://github.com/gitgitgadget/git/pull/1934\n\nRange-diff vs v1:\n\n 1: c65120f2570 ! 1: 712602c09e4 ci(coverity): fix building on Windows\n @@ .github/workflows/coverity.yml: jobs:\n - name: build with cov-build\n run: |\n - export PATH=\"$RUNNER_TEMP/cov-analysis/bin:$PATH\" &&\n -+ export PATH=\"$PATH:$(cygpath -au \"$RUNNER_TEMP\")/cov-analysis/bin\" &&\n ++ export PATH=\"$PATH:$RUNNER_TEMP/cov-analysis/bin\" &&\n cov-configure --gcc &&\n cov-build --dir cov-int make\n - name: package the build\n 2: 3a829f11c07 ! 2: 52c34977b48 ci(coverity): output the build log upon error\n @@ Commit message\n ## .github/workflows/coverity.yml ##\n @@ .github/workflows/coverity.yml: jobs:\n run: |\n - export PATH=\"$PATH:$(cygpath -au \"$RUNNER_TEMP\")/cov-analysis/bin\" &&\n + export PATH=\"$PATH:$RUNNER_TEMP/cov-analysis/bin\" &&\n cov-configure --gcc &&\n - cov-build --dir cov-int make\n + if ! cov-build --dir cov-int make\n\n-- \ngitgitgadget\n"},{"id":"520110","messageId":"712602c09e451c6c95b49b74c543817fd7477507.1749657278.git.gitgitgadget@gmail.com","threadId":"63625","inReplyTo":"pull.1934.v2.git.1749657278.gitgitgadget@gmail.com","subject":"[PATCH v2 1/2] ci(coverity): fix building on Windows","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2025-06-11T15:54:37Z","receivedAt":"2025-06-11T15:54:42Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"From: Johannes Schindelin \n\nWhen I added the Coverity workflow in a56b6230d0b1 (ci: add a GitHub\nworkflow to submit Coverity scans, 2023-09-25), I merely converted an\nAzure Pipeline definition that had been running successfully for ages.\n\nIn the meantime, the current Coverity documentation describes a very\ndifferent way to install the analysis tool, recommending to add the\n`bin/` directory to the _end_ of `PATH` (when originally, IIRC, it was\nrecommended to add it to the _beginning_ of the `PATH`).\n\nThis is crucial! The reason is that the current incarnation of the\nWindows variant of Coverity's analysis tools come with a _lot_ of DLL\nfiles in their `bin/` directory, some of them interferring rather badly\nwith the `gcc.exe` in Git for Windows' SDK that we use to run the\nCoverity build. The symptom is a cryptic error message:\n\n make: *** [Makefile:2960: headless-git.o] Error 1\n make: *** Waiting for unfinished jobs....\n D:\\git-sdk-64-minimal\\mingw64\\bin\\windres.exe: preprocessing failed.\n make: *** [Makefile:2679: git.res] Error 1\n make: *** [Makefile:2893: git.o] Error 1\n make: *** [Makefile:2893: builtin/add.o] Error 1\n Attempting to detect unconfigured compilers in build\n |0----------25-----------50----------75---------100|\n ****************************************************\n Warning: Build command make.exe exited with code 2. Please verify that the build completed successfully.\n Warning: Emitted 0 C/C++ compilation units (0%) successfully\n\n 0 C/C++ compilation units (0%) are ready for analysis\n For more details, please look at:\n D:/a/git/git/cov-int/build-log.txt\n\nThe log (which the workflow is currently not configured to reveal) then\npoints out that the `windows.h` header cannot be found, which is _still_\nnot very helpful. The underlying root cause is that the `gcc.exe` in Git\nfor Windows' SDK determines the location of the header files via the\nlocation of certain DLL files, and finding the \"wrong\" ones first on the\n`PATH` misleads that logic.\n\nLet's fix this problem by following Coverity's current recommendation\nand append the `bin/` directory in which `cov-int` can be found to the\n_end_ of `PATH`.\n\nSigned-off-by: Johannes Schindelin \n---\n .github/workflows/coverity.yml | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml\nindex 124301dbbe2f..d8a0497d596d 100644\n--- a/.github/workflows/coverity.yml\n+++ b/.github/workflows/coverity.yml\n@@ -147,7 +147,7 @@ jobs:\n key: cov-build-${{ env.COVERITY_LANGUAGE }}-${{ env.COVERITY_PLATFORM }}-${{ steps.lookup.outputs.hash }}\n - name: build with cov-build\n run: |\n- export PATH=\"$RUNNER_TEMP/cov-analysis/bin:$PATH\" &&\n+ export PATH=\"$PATH:$RUNNER_TEMP/cov-analysis/bin\" &&\n cov-configure --gcc &&\n cov-build --dir cov-int make\n - name: package the build\n-- \ngitgitgadget\n\n"},{"id":"520111","messageId":"52c34977b48a26f3f6a1a62fb81015f319be6205.1749657278.git.gitgitgadget@gmail.com","threadId":"63625","inReplyTo":"pull.1934.v2.git.1749657278.gitgitgadget@gmail.com","subject":"[PATCH v2 2/2] ci(coverity): output the build log upon error","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2025-06-11T15:54:38Z","receivedAt":"2025-06-11T15:54:43Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"From: Johannes Schindelin \n\nIt is quite helpful to know what Coverity said, exactly, in case it\nfails to analyze the code.\n\nSigned-off-by: Johannes Schindelin \n---\n .github/workflows/coverity.yml | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)\n\ndiff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml\nindex d8a0497d596d..01a0437b2f26 100644\n--- a/.github/workflows/coverity.yml\n+++ b/.github/workflows/coverity.yml\n@@ -149,7 +149,11 @@ jobs:\n run: |\n export PATH=\"$PATH:$RUNNER_TEMP/cov-analysis/bin\" &&\n cov-configure --gcc &&\n- cov-build --dir cov-int make\n+ if ! cov-build --dir cov-int make\n+ then\n+ cat cov-int/build-log.txt\n+ exit 1\n+ fi\n - name: package the build\n run: tar -czvf cov-int.tgz cov-int\n - name: submit the build to Coverity Scan\n-- \ngitgitgadget\n"},{"id":"520116","messageId":"xmqqbjqui3xv.fsf@gitster.g","threadId":"63625","inReplyTo":"8d71bc71-3e5b-c59c-8948-c07d7b4f62ac@gmx.de","subject":"Re: [PATCH 1/2] ci(coverity): fix building on Windows","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-06-11T17:27:40Z","receivedAt":"2025-06-11T17:27:43Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin writes:\n\n> As such, that `cygpath` call is incorrect, as it would fail on anything by\n> Windows. It is also unnecessary, as I just verified in a manual run.\n> Therefore I drop it from v2.\n\nGreat. Thanks. Will replace with v2.\n"}]}