{"thread":{"id":"6361","subject":"[PATCH] git-svn: fix tests to work with older svn","startedAt":"2007-01-13T10:47:53Z","lastAt":"2007-01-13T10:47:53Z","messageCount":1,"participants":["Eric Wong"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"31627","messageId":"20070113104753.GA19580@localdomain","threadId":"6361","inReplyTo":null,"subject":"[PATCH] git-svn: fix tests to work with older svn","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2007-01-13T10:47:53Z","receivedAt":"2007-01-13T10:47:53Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Some of the recent changes and shortcuts to the tests broke\nthings for people using older versions of svn:\n\nt9104-git-svn-follow-parent.sh:\n  v1.2.3 (from SuSE 10.0 as reported by riddochc on #git\n  (thanks!)) required an extra 'svn up'.  I was also able to\n  reproduce this with v1.1.4 (Debian Sarge).\n\nlib-git-svn.sh:\n  SVN::Repos bindings in versions up to and including 1.1.4\n  (Sarge again) do not pass fs-config options to the underlying\n  library.  BerkeleyDB repositories also seem completely broken\n  on all my Sarge machines; so not using FSFS does not seem to\n  be an option for most people.\n\nSigned-off-by: Eric Wong <normalperson@yhbt.net>\n---\n t/lib-git-svn.sh                 |    5 +++--\n t/t9104-git-svn-follow-parent.sh |    1 +\n 2 files changed, 4 insertions(+), 2 deletions(-)\n\ndiff --git a/t/lib-git-svn.sh b/t/lib-git-svn.sh\nindex af42ccc..a0f2814 100644\n--- a/t/lib-git-svn.sh\n+++ b/t/lib-git-svn.sh\n@@ -25,14 +25,15 @@ perl -w -e \"\n use SVN::Core;\n use SVN::Repos;\n \\$SVN::Core::VERSION gt '1.1.0' or exit(42);\n-SVN::Repos::create('$svnrepo', undef, undef, undef,\n-                           { 'fs-config' => 'fsfs'});\n+system(qw/svnadmin create --fs-type fsfs/, '$svnrepo') == 0 or exit(41);\n \"\n x=$?\n if test $x -ne 0\n then\n \tif test $x -eq 42; then\n \t\terr='Perl SVN libraries must be >= 1.1.0'\n+\telif test $x -eq 41; then\n+\t\terr='svnadmin failed to create fsfs repository'\n \telse\n \t\terr='Perl SVN libraries not found or unusable, skipping test'\n \tfi\ndiff --git a/t/t9104-git-svn-follow-parent.sh b/t/t9104-git-svn-follow-parent.sh\nindex 400c21c..8d2e2fe 100755\n--- a/t/t9104-git-svn-follow-parent.sh\n+++ b/t/t9104-git-svn-follow-parent.sh\n@@ -17,6 +17,7 @@ test_expect_success 'initialize repo' \"\n \tcd wc &&\n \techo world >> trunk/readme &&\n \tsvn commit -m 'another commit' &&\n+\tsvn up &&\n \tsvn mv -m 'rename to thunk' trunk thunk &&\n \tsvn up &&\n \techo goodbye >> thunk/readme &&\n-- \nEric Wong\n"}]}