{"thread":{"id":"63601","subject":"[PATCH] config.mak.uname: update settings for Solaris 10 and 11","startedAt":"2025-06-08T01:26:55Z","lastAt":"2025-06-08T01:46:09Z","messageCount":2,"participants":["Brad Smith","Collin Funk"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"519902","messageId":"aETm3O-FE7EpyoE5@humpty.home.comstyle.com","threadId":"63601","inReplyTo":null,"subject":"[PATCH] config.mak.uname: update settings for Solaris 10 and 11","fromName":"Brad Smith","fromEmail":"brad@comstyle.com","sentAt":"2025-06-08T01:26:52Z","receivedAt":"2025-06-08T01:26:55Z","isPatch":true,"sender":{"key":"brad@comstyle.com","avatar":"https://avatars.githubusercontent.com/u/1129902?v=4"},"body":"Solaris 10 and newer has strtoumax().\n\nSolaris 11 and newer has mkdtemp(), memmem(), and strcasestr().\n\nSigned-off-by: Brad Smith <brad@comstyle.com>\n---\n config.mak.uname | 28 +++++++++++++++++++++++++---\n 1 file changed, 25 insertions(+), 3 deletions(-)\n\ndiff --git a/config.mak.uname b/config.mak.uname\nindex 3e26bb074a..b1c5c4d5e8 100644\n--- a/config.mak.uname\n+++ b/config.mak.uname\n@@ -190,9 +190,6 @@ ifeq ($(uname_S),SunOS)\n \tSHELL_PATH = /bin/bash\n \tSANE_TOOL_PATH = /usr/xpg6/bin:/usr/xpg4/bin\n \tHAVE_ALLOCA_H = YesPlease\n-\tNO_STRCASESTR = YesPlease\n-\tNO_MEMMEM = YesPlease\n-\tNO_MKDTEMP = YesPlease\n \tNO_REGEX = YesPlease\n \tNO_MSGFMT_EXTENDED_OPTIONS = YesPlease\n \tHAVE_DEV_TTY = YesPlease\n@@ -202,7 +199,10 @@ ifeq ($(uname_S),SunOS)\n \t\tNO_IPV6 = YesPlease\n \t\tNO_SOCKADDR_STORAGE = YesPlease\n \t\tNO_UNSETENV = YesPlease\n+\t\tNO_MKDTEMP = YesPlease\n+\t\tNO_MEMMEM = YesPlease\n \t\tNO_SETENV = YesPlease\n+\t\tNO_STRCASESTR = YesPlease\n \t\tNO_STRLCPY = YesPlease\n \t\tNO_STRTOUMAX = YesPlease\n \t\tGIT_TEST_CMP = cmp\n@@ -212,23 +212,45 @@ ifeq ($(uname_S),SunOS)\n \t\tNO_IPV6 = YesPlease\n \t\tNO_SOCKADDR_STORAGE = YesPlease\n \t\tNO_UNSETENV = YesPlease\n+\t\tNO_MKDTEMP = YesPlease\n+\t\tNO_MEMMEM = YesPlease\n \t\tNO_SETENV = YesPlease\n+\t\tNO_STRCASESTR = YesPlease\n \t\tNO_STRLCPY = YesPlease\n \t\tNO_STRTOUMAX = YesPlease\n \t\tGIT_TEST_CMP = cmp\n         endif\n         ifeq ($(uname_R),5.8)\n \t\tNO_UNSETENV = YesPlease\n+\t\tNO_MKDTEMP = YesPlease\n+\t\tNO_MEMMEM = YesPlease\n \t\tNO_SETENV = YesPlease\n+\t\tNO_STRCASESTR = YesPlease\n \t\tNO_STRTOUMAX = YesPlease\n \t\tGIT_TEST_CMP = cmp\n         endif\n         ifeq ($(uname_R),5.9)\n \t\tNO_UNSETENV = YesPlease\n+\t\tNO_MKDTEMP = YesPlease\n+\t\tNO_MEMMEM = YesPlease\n \t\tNO_SETENV = YesPlease\n+\t\tNO_STRCASESTR = YesPlease\n \t\tNO_STRTOUMAX = YesPlease\n \t\tGIT_TEST_CMP = cmp\n         endif\n+        ifeq ($(uname_R),5.10)\n+\t\tNO_UNSETENV = YesPlease\n+\t\tNO_MKDTEMP = YesPlease\n+\t\tNO_MEMMEM = YesPlease\n+\t\tNO_SETENV = YesPlease\n+\t\tNO_STRCASESTR = YesPlease\n+\t\tGIT_TEST_CMP = cmp\n+        endif\n+        ifeq ($(uname_R),5.11)\n+\t\tNO_UNSETENV = YesPlease\n+\t\tNO_SETENV = YesPlease\n+\t\tGIT_TEST_CMP = cmp\n+        endif\n \tINSTALL = /usr/ucb/install\n \tTAR = gtar\n \tBASIC_CFLAGS += -D__EXTENSIONS__ -D__sun__\n-- \n2.49.0\n\n"},{"id":"519903","messageId":"87cybfhuow.fsf@gmail.com","threadId":"63601","inReplyTo":"aETm3O-FE7EpyoE5@humpty.home.comstyle.com","subject":"Re: [PATCH] config.mak.uname: update settings for Solaris 10 and 11","fromName":"Collin Funk","fromEmail":"collin.funk1@gmail.com","sentAt":"2025-06-08T01:46:07Z","receivedAt":"2025-06-08T01:46:09Z","isPatch":true,"sender":{"key":"collin.funk1@gmail.com","avatar":"https://avatars.githubusercontent.com/u/65689063?v=4"},"body":"Brad Smith <brad@comstyle.com> writes:\n\n> Solaris 10 and newer has strtoumax().\n>\n> Solaris 11 and newer has mkdtemp(), memmem(), and strcasestr().\n>\n> Signed-off-by: Brad Smith <brad@comstyle.com>\n> ---\n>  config.mak.uname | 28 +++++++++++++++++++++++++---\n>  1 file changed, 25 insertions(+), 3 deletions(-)\n\nThese versions look correct based on what we have documented in Gnulib.\n\nJust to be safe I built git with this patch applied on Solaris 10 and\nSolaris 11.3 and ran into no issues.\n\nReviewed-by: Collin Funk <collin.funk1@gmail.com>\nTested-by: Collin Funk <collin.funk1@gmail.com>\n\nThanks,\nCollin\n"}]}