{"thread":{"id":"63594","subject":"[PATCH] diff-generate-patch.adoc: drop spurious backticks","startedAt":"2025-06-06T12:31:58Z","lastAt":"2025-06-09T07:03:26Z","messageCount":2,"participants":["Martin Ågren","Jean-Noël Avila"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"519848","messageId":"20250606123138.566178-1-martin.agren@gmail.com","threadId":"63594","inReplyTo":null,"subject":"[PATCH] diff-generate-patch.adoc: drop spurious backticks","fromName":"Martin Ågren","fromEmail":"martin.agren@gmail.com","sentAt":"2025-06-06T12:31:36Z","receivedAt":"2025-06-06T12:31:58Z","isPatch":true,"sender":{"key":"martin.agren@gmail.com","avatar":null},"body":"Commit 0b080a70ab (doc: git-diff: apply format changes to\ndiff-generate-patch, 2024-11-18) wrapped the \"..\" in\n\n  mode <mode>,<mode>..<mode>\n\nin backticks. Note how the line before is quite similar,\n\n  index <hash>,<hash>..<hash>\n\nbut did not get any backticks. Remove the backticks, since they confuse\nAsciidoctor.\n\nThe exact failure mode changed with c87b2b3a6f (doc: fix asciidoctor\nsynopsis processing of triple-dots, 2025-04-12), and arguably to the\nbetter. But Asciidoctor (2.0.18) still ends up confused by these\nbackticks and leaves the manpage rendering as\n\n  index <hash>,<hash>..<hash>\n  mode <mode>,<mode>`..__<mode>__\n  {empty}`new file mode <mode>\n\nDrop the backticks. This is a no-op with asciidoc (10.2.0).\n\nSigned-off-by: Martin Ågren <martin.agren@gmail.com>\n---\n The error mode changes between 2.49.0 and 2.50.0-rc0, causing this to\n stand out in \"doc-diff\". But this is strictly speaking not a regression\n fix for 2.50.\n\n Documentation/diff-generate-patch.adoc | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/diff-generate-patch.adoc b/Documentation/diff-generate-patch.adoc\nindex e5c813c96f..7b6cdd1980 100644\n--- a/Documentation/diff-generate-patch.adoc\n+++ b/Documentation/diff-generate-patch.adoc\n@@ -138,7 +138,7 @@ or like this (when the `--cc` option is used):\n +\n [synopsis]\n index <hash>,<hash>..<hash>\n-mode <mode>,<mode>`..`<mode>\n+mode <mode>,<mode>..<mode>\n new file mode <mode>\n deleted file mode <mode>,<mode>\n +\n-- \n2.50.0.rc1.729.gfc6ec28a5d\n\n"},{"id":"519952","messageId":"172c7392-71ee-44f1-9d14-f92b1272766a@free.fr","threadId":"63594","inReplyTo":"20250606123138.566178-1-martin.agren@gmail.com","subject":"Re: [PATCH] diff-generate-patch.adoc: drop spurious backticks","fromName":"Jean-Noël Avila","fromEmail":"jn.avila@free.fr","sentAt":"2025-06-09T07:02:15Z","receivedAt":"2025-06-09T07:03:26Z","isPatch":true,"sender":{"key":"jn.avila@free.fr","avatar":"https://avatars.githubusercontent.com/u/156172?v=4"},"body":"Le 06/06/2025 à 14:31, Martin Ågren a écrit :\n> Commit 0b080a70ab (doc: git-diff: apply format changes to\n> diff-generate-patch, 2024-11-18) wrapped the \"..\" in\n> \n>   mode <mode>,<mode>..<mode>\n> \n> in backticks. Note how the line before is quite similar,\n> \n>   index <hash>,<hash>..<hash>\n> \n> but did not get any backticks. Remove the backticks, since they confuse\n> Asciidoctor.\n> \n> The exact failure mode changed with c87b2b3a6f (doc: fix asciidoctor\n> synopsis processing of triple-dots, 2025-04-12), and arguably to the\n> better. But Asciidoctor (2.0.18) still ends up confused by these\n> backticks and leaves the manpage rendering as\n> \n>   index <hash>,<hash>..<hash>\n>   mode <mode>,<mode>`..__<mode>__\n>   {empty}`new file mode <mode>\n> \n> Drop the backticks. This is a no-op with asciidoc (10.2.0).\n> \n> Signed-off-by: Martin Ågren <martin.agren@gmail.com>\n> ---\n>  The error mode changes between 2.49.0 and 2.50.0-rc0, causing this to\n>  stand out in \"doc-diff\". But this is strictly speaking not a regression\n>  fix for 2.50.\n> \n>  Documentation/diff-generate-patch.adoc | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/Documentation/diff-generate-patch.adoc b/Documentation/diff-generate-patch.adoc\n> index e5c813c96f..7b6cdd1980 100644\n> --- a/Documentation/diff-generate-patch.adoc\n> +++ b/Documentation/diff-generate-patch.adoc\n> @@ -138,7 +138,7 @@ or like this (when the `--cc` option is used):\n>  +\n>  [synopsis]\n>  index <hash>,<hash>..<hash>\n> -mode <mode>,<mode>`..`<mode>\n> +mode <mode>,<mode>..<mode>\n>  new file mode <mode>\n>  deleted file mode <mode>,<mode>\n>  +\n\n\nObviously good. Thanks for catching it!\n\n\nMore generally, this is typically the type of missed changes in\ndocumentation, which cannot be caught by just reviewing a patch proposal.\n\nThanks.\n"}]}