{"thread":{"id":"63558","subject":"[PATCH] config.mak.uname: update settings for OpenBSD","startedAt":"2025-06-02T03:14:52Z","lastAt":"2025-06-02T05:05:17Z","messageCount":4,"participants":["Brad Smith","Carlo Marcelo Arenas Belón","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"519365","messageId":"aD0XIxPRQjA5t8oi@humpty.home.comstyle.com","threadId":"63558","inReplyTo":null,"subject":"[PATCH] config.mak.uname: update settings for OpenBSD","fromName":"Brad Smith","fromEmail":"brad@comstyle.com","sentAt":"2025-06-02T03:14:43Z","receivedAt":"2025-06-02T03:14:52Z","isPatch":true,"sender":{"key":"brad@comstyle.com","avatar":"https://avatars.githubusercontent.com/u/1129902?v=4"},"body":"OpenBSD requires DIR_HAS_BSD_GROUP_SEMANTICS.\n\nOpenBSD has never had the BSD sysctl KERN_PROC_PATHNAME nor\ndoes it support or use the /proc filesystem.\n\nOpenBSD has had strcasestr() since 3.8. OpenBSD has had memmem()\nsince 5.4.\n\nSigned-off-by: Brad Smith <brad@comstyle.com>\n---\n config.mak.uname | 5 +----\n 1 file changed, 1 insertion(+), 4 deletions(-)\n\ndiff --git a/config.mak.uname b/config.mak.uname\nindex df172d5871..5a0b4200c3 100644\n--- a/config.mak.uname\n+++ b/config.mak.uname\n@@ -301,17 +301,14 @@ ifeq ($(uname_S),FreeBSD)\n \tFILENO_IS_A_MACRO = UnfortunatelyYes\n endif\n ifeq ($(uname_S),OpenBSD)\n-\tNO_STRCASESTR = YesPlease\n-\tNO_MEMMEM = YesPlease\n+\tDIR_HAS_BSD_GROUP_SEMANTICS = YesPlease\n \tUSE_ST_TIMESPEC = YesPlease\n \tNEEDS_LIBICONV = YesPlease\n \tBASIC_CFLAGS += -I/usr/local/include\n \tBASIC_LDFLAGS += -L/usr/local/lib\n \tHAVE_PATHS_H = YesPlease\n \tHAVE_BSD_SYSCTL = YesPlease\n-\tHAVE_BSD_KERN_PROC_SYSCTL = YesPlease\n \tCSPRNG_METHOD = arc4random\n-\tPROCFS_EXECUTABLE_PATH = /proc/curproc/file\n \tFREAD_READS_DIRECTORIES = UnfortunatelyYes\n \tFILENO_IS_A_MACRO = UnfortunatelyYes\n endif\n-- \n2.49.0\n\n"},{"id":"519369","messageId":"o43c7pn37zdhpw6awst7itumf2ogshie5hykrcpz4sdxbhx42x@zgqoztab3vvi","threadId":"63558","inReplyTo":"aD0XIxPRQjA5t8oi@humpty.home.comstyle.com","subject":"Re: [PATCH] config.mak.uname: update settings for OpenBSD","fromName":"Carlo Marcelo Arenas Belón","fromEmail":"carenas@gmail.com","sentAt":"2025-06-02T04:45:37Z","receivedAt":"2025-06-02T04:45:39Z","isPatch":true,"sender":{"key":"carenas@gmail.com","avatar":"https://avatars.githubusercontent.com/u/76036?v=4"},"body":"On Sun, Jun 01, 2025 at 11:14:43PM -0800, Brad Smith wrote:\n> \n> OpenBSD has never had the BSD sysctl KERN_PROC_PATHNAME nor\n> does it support or use the /proc filesystem.\n\n... since 5.7 [1]\n\nCarlo\n\n[1] https://man.openbsd.org/OpenBSD-5.6/mount_procfs.8\n"},{"id":"519370","messageId":"xmqqldqavis7.fsf@gitster.g","threadId":"63558","inReplyTo":"aD0XIxPRQjA5t8oi@humpty.home.comstyle.com","subject":"Re: [PATCH] config.mak.uname: update settings for OpenBSD","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-06-02T05:01:28Z","receivedAt":"2025-06-02T05:01:31Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Brad Smith <brad@comstyle.com> writes:\n\n> OpenBSD requires DIR_HAS_BSD_GROUP_SEMANTICS.\n>\n> OpenBSD has never had the BSD sysctl KERN_PROC_PATHNAME nor\n> does it support or use the /proc filesystem.\n>\n> OpenBSD has had strcasestr() since 3.8. OpenBSD has had memmem()\n> since 5.4.\n\n;-) Thanks.  \n\n5.4 was from Nov 2013 if I can trust\nhttps://undeadly.org/cgi?action=article;sid=20131101142807 and it is\nabout time we adjust ourselves to the more recent world order.\n\nWill apply.  Thanks.\n\n> Signed-off-by: Brad Smith <brad@comstyle.com>\n> ---\n>  config.mak.uname | 5 +----\n>  1 file changed, 1 insertion(+), 4 deletions(-)\n>\n> diff --git a/config.mak.uname b/config.mak.uname\n> index df172d5871..5a0b4200c3 100644\n> --- a/config.mak.uname\n> +++ b/config.mak.uname\n> @@ -301,17 +301,14 @@ ifeq ($(uname_S),FreeBSD)\n>  \tFILENO_IS_A_MACRO = UnfortunatelyYes\n>  endif\n>  ifeq ($(uname_S),OpenBSD)\n> -\tNO_STRCASESTR = YesPlease\n> -\tNO_MEMMEM = YesPlease\n> +\tDIR_HAS_BSD_GROUP_SEMANTICS = YesPlease\n>  \tUSE_ST_TIMESPEC = YesPlease\n>  \tNEEDS_LIBICONV = YesPlease\n>  \tBASIC_CFLAGS += -I/usr/local/include\n>  \tBASIC_LDFLAGS += -L/usr/local/lib\n>  \tHAVE_PATHS_H = YesPlease\n>  \tHAVE_BSD_SYSCTL = YesPlease\n> -\tHAVE_BSD_KERN_PROC_SYSCTL = YesPlease\n>  \tCSPRNG_METHOD = arc4random\n> -\tPROCFS_EXECUTABLE_PATH = /proc/curproc/file\n>  \tFREAD_READS_DIRECTORIES = UnfortunatelyYes\n>  \tFILENO_IS_A_MACRO = UnfortunatelyYes\n>  endif\n"},{"id":"519371","messageId":"3ef13594-41a7-4455-bec5-3da6ff517341@comstyle.com","threadId":"63558","inReplyTo":"xmqqldqavis7.fsf@gitster.g","subject":"Re: [PATCH] config.mak.uname: update settings for OpenBSD","fromName":"Brad Smith","fromEmail":"brad@comstyle.com","sentAt":"2025-06-02T05:05:13Z","receivedAt":"2025-06-02T05:05:17Z","isPatch":true,"sender":{"key":"brad@comstyle.com","avatar":"https://avatars.githubusercontent.com/u/1129902?v=4"},"body":"On 2025-06-02 1:01 a.m., Junio C Hamano wrote:\n> Brad Smith <brad@comstyle.com> writes:\n>\n>> OpenBSD requires DIR_HAS_BSD_GROUP_SEMANTICS.\n>>\n>> OpenBSD has never had the BSD sysctl KERN_PROC_PATHNAME nor\n>> does it support or use the /proc filesystem.\n>>\n>> OpenBSD has had strcasestr() since 3.8. OpenBSD has had memmem()\n>> since 5.4.\n> ;-) Thanks.\n>\n> 5.4 was from Nov 2013 if I can trust\n> https://undeadly.org/cgi?action=article;sid=20131101142807 and it is\n> about time we adjust ourselves to the more recent world order.\n>\n> Will apply.  Thanks.\n\nYup, that is correct. For us that is 23 releases and over 11+ years old. \nI think\nwe're good.\n\n>> Signed-off-by: Brad Smith <brad@comstyle.com>\n>> ---\n>>   config.mak.uname | 5 +----\n>>   1 file changed, 1 insertion(+), 4 deletions(-)\n>>\n>> diff --git a/config.mak.uname b/config.mak.uname\n>> index df172d5871..5a0b4200c3 100644\n>> --- a/config.mak.uname\n>> +++ b/config.mak.uname\n>> @@ -301,17 +301,14 @@ ifeq ($(uname_S),FreeBSD)\n>>   \tFILENO_IS_A_MACRO = UnfortunatelyYes\n>>   endif\n>>   ifeq ($(uname_S),OpenBSD)\n>> -\tNO_STRCASESTR = YesPlease\n>> -\tNO_MEMMEM = YesPlease\n>> +\tDIR_HAS_BSD_GROUP_SEMANTICS = YesPlease\n>>   \tUSE_ST_TIMESPEC = YesPlease\n>>   \tNEEDS_LIBICONV = YesPlease\n>>   \tBASIC_CFLAGS += -I/usr/local/include\n>>   \tBASIC_LDFLAGS += -L/usr/local/lib\n>>   \tHAVE_PATHS_H = YesPlease\n>>   \tHAVE_BSD_SYSCTL = YesPlease\n>> -\tHAVE_BSD_KERN_PROC_SYSCTL = YesPlease\n>>   \tCSPRNG_METHOD = arc4random\n>> -\tPROCFS_EXECUTABLE_PATH = /proc/curproc/file\n>>   \tFREAD_READS_DIRECTORIES = UnfortunatelyYes\n>>   \tFILENO_IS_A_MACRO = UnfortunatelyYes\n>>   endif\n"}]}