{"thread":{"id":"63554","subject":"[PATCH] doc: column: fix blank lines before block delimiters","startedAt":"2025-05-31T21:08:53Z","lastAt":"2025-06-01T11:37:28Z","messageCount":4,"participants":["kristofferhaugsbakk@fastmail.com","Jean-Noël AVILA","Kristoffer Haugsbakk"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"519313","messageId":"b493b07f88bc5562e03c249006f01091afd7b5fd.1748725662.git.code@khaugsbakk.name","threadId":"63554","inReplyTo":null,"subject":"[PATCH] doc: column: fix blank lines before block delimiters","fromName":"","fromEmail":"kristofferhaugsbakk@fastmail.com","sentAt":"2025-05-31T21:08:09Z","receivedAt":"2025-05-31T21:08:53Z","isPatch":true,"sender":{"key":"kristofferhaugsbakk@fastmail.com","avatar":null},"body":"From: Kristoffer Haugsbakk \n\n227c4f33a03 (doc: add a blank line around block delimiters,\n2025-03-09) added blank lines around block delimiters as a\ndefensive measure. For each block you had to mind the con-\ntext (like the commit says):\n\n• Top-level: just add blank lines\n• Block: use list continuation (+)\n\nBut list continuation was used here at the top level, which\nresults in literal `+` in the output formats.\n\nSigned-off-by: Kristoffer Haugsbakk \n---\n Documentation/git-column.adoc | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/Documentation/git-column.adoc b/Documentation/git-column.adoc\nindex 5a4f2b6fde9..8e0047214dc 100644\n--- a/Documentation/git-column.adoc\n+++ b/Documentation/git-column.adoc\n@@ -50,7 +50,7 @@ EXAMPLES\n --------\n \n Format data by columns:\n-+\n+\n ------------\n $ seq 1 24 | git column --mode=column --padding=5\n 1 4 7 10 13 16 19 22\n@@ -59,7 +59,7 @@ $ seq 1 24 | git column --mode=column --padding=5\n ------------\n \n Format data by rows:\n-+\n+\n ------------\n $ seq 1 21 | git column --mode=row --padding=5\n 1 2 3 4 5 6 7\n@@ -68,7 +68,7 @@ $ seq 1 21 | git column --mode=row --padding=5\n ------------\n \n List some tags in a table with unequal column widths:\n-+\n+\n ------------\n $ git tag --list 'v2.4.*' --column=row,dense\n v2.4.0 v2.4.0-rc0 v2.4.0-rc1 v2.4.0-rc2 v2.4.0-rc3\n\nbase-commit: 7014b55638da979331baf8dc31c4e1d697cf2d67\n-- \n2.50.0.rc0.46.g7014b55638d\n\n"},{"id":"519318","messageId":"5891508.DvuYhMxLoT@cayenne","threadId":"63554","inReplyTo":"b493b07f88bc5562e03c249006f01091afd7b5fd.1748725662.git.code@khaugsbakk.name","subject":"Re: [PATCH] doc: column: fix blank lines before block delimiters","fromName":"Jean-Noël AVILA","fromEmail":"jn.avila@free.fr","sentAt":"2025-05-31T21:46:42Z","receivedAt":"2025-05-31T21:47:00Z","isPatch":true,"sender":{"key":"jn.avila@free.fr","avatar":"https://avatars.githubusercontent.com/u/156172?v=4"},"body":"On Saturday, 31 May 2025 23:08:09 CEST kristofferhaugsbakk@fastmail.com wrote:\n> From: Kristoffer Haugsbakk \n> \n> 227c4f33a03 (doc: add a blank line around block delimiters,\n> 2025-03-09) added blank lines around block delimiters as a\n> defensive measure. For each block you had to mind the con-\n> text (like the commit says):\n> \n> • Top-level: just add blank lines\n> • Block: use list continuation (+)\n> \n> But list continuation was used here at the top level, which\n> results in literal `+` in the output formats.\n> \n> Signed-off-by: Kristoffer Haugsbakk \n> ---\n> Documentation/git-column.adoc | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/Documentation/git-column.adoc b/Documentation/git-column.adoc\n> index 5a4f2b6fde9..8e0047214dc 100644\n> --- a/Documentation/git-column.adoc\n> +++ b/Documentation/git-column.adoc\n> @@ -50,7 +50,7 @@ EXAMPLES\n> --------\n> \n> Format data by columns:\n> -+\n> +\n> ------------\n> $ seq 1 24 | git column --mode=column --padding=5\n> 1 4 7 10 13 16 19 22\n> @@ -59,7 +59,7 @@ $ seq 1 24 | git column --mode=column --padding=5\n> ------------\n> \n> Format data by rows:\n> -+\n> +\n> ------------\n> $ seq 1 21 | git column --mode=row --padding=5\n> 1 2 3 4 5 6 7\n> @@ -68,7 +68,7 @@ $ seq 1 21 | git column --mode=row --padding=5\n> ------------\n> \n> List some tags in a table with unequal column widths:\n> -+\n> +\n> ------------\n> $ git tag --list 'v2.4.*' --column=row,dense\n> v2.4.0 v2.4.0-rc0 v2.4.0-rc1 v2.4.0-rc2 v2.4.0-rc3\n> \n> base-commit: 7014b55638da979331baf8dc31c4e1d697cf2d67\n\nAcked-by: Jean-Noël Avila \n\n\n\n"},{"id":"519319","messageId":"212bce25-e8dc-42dd-a70a-573f09b1f74a@app.fastmail.com","threadId":"63554","inReplyTo":"b493b07f88bc5562e03c249006f01091afd7b5fd.1748725662.git.code@khaugsbakk.name","subject":"Re: [PATCH] doc: column: fix blank lines before block delimiters","fromName":"Kristoffer Haugsbakk","fromEmail":"code@khaugsbakk.name","sentAt":"2025-05-31T22:49:12Z","receivedAt":"2025-05-31T22:49:39Z","isPatch":true,"sender":{"key":"code@khaugsbakk.name","avatar":"https://avatars.githubusercontent.com/u/2229597?v=4"},"body":"> doc: column: fix blank lines before block delimiters\n\n“before” is technically correct since these changes happen to only be before \nthe blocks. But maybe it should be “around” in order to be stay consistent\nwith the commit message. I’ll go for that.\n"},{"id":"519349","messageId":"3c6d7b154048ef0053d15b4f86cc241211ef30dc.1748777208.git.code@khaugsbakk.name","threadId":"63554","inReplyTo":"b493b07f88bc5562e03c249006f01091afd7b5fd.1748725662.git.code@khaugsbakk.name","subject":"[PATCH v2] doc: column: fix blank lines around block delimiters","fromName":"","fromEmail":"kristofferhaugsbakk@fastmail.com","sentAt":"2025-06-01T11:36:53Z","receivedAt":"2025-06-01T11:37:28Z","isPatch":true,"sender":{"key":"kristofferhaugsbakk@fastmail.com","avatar":null},"body":"From: Kristoffer Haugsbakk \n\n227c4f33a03 (doc: add a blank line around block delimiters,\n2025-03-09) added blank lines around block delimiters as a\ndefensive measure. For each block you had to mind the con-\ntext (like the commit says):\n\n• Top-level: just add blank lines\n• Block: use list continuation (+)\n\nBut list continuation was used here at the top level, which\nresults in literal `+` in the output formats.\n\nAcked-by: Jean-Noël Avila \nSigned-off-by: Kristoffer Haugsbakk \n---\n\nNotes (series):\n v2:\n • Finally trying the “After the list reached a consensus” step of\n SubmittingPatches\n • Add Ack\n • Use “around” consistently in subject and message\n\n Documentation/git-column.adoc | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/Documentation/git-column.adoc b/Documentation/git-column.adoc\nindex 5a4f2b6fde9..8e0047214dc 100644\n--- a/Documentation/git-column.adoc\n+++ b/Documentation/git-column.adoc\n@@ -50,7 +50,7 @@ EXAMPLES\n --------\n \n Format data by columns:\n-+\n+\n ------------\n $ seq 1 24 | git column --mode=column --padding=5\n 1 4 7 10 13 16 19 22\n@@ -59,7 +59,7 @@ $ seq 1 24 | git column --mode=column --padding=5\n ------------\n \n Format data by rows:\n-+\n+\n ------------\n $ seq 1 21 | git column --mode=row --padding=5\n 1 2 3 4 5 6 7\n@@ -68,7 +68,7 @@ $ seq 1 21 | git column --mode=row --padding=5\n ------------\n \n List some tags in a table with unequal column widths:\n-+\n+\n ------------\n $ git tag --list 'v2.4.*' --column=row,dense\n v2.4.0 v2.4.0-rc0 v2.4.0-rc1 v2.4.0-rc2 v2.4.0-rc3\n\nRange-diff against v1:\n1: b493b07f88b ! 1: 3c6d7b15404 doc: column: fix blank lines before block delimiters\n @@ Metadata\n Author: Kristoffer Haugsbakk \n \n ## Commit message ##\n - doc: column: fix blank lines before block delimiters\n + doc: column: fix blank lines around block delimiters\n \n 227c4f33a03 (doc: add a blank line around block delimiters,\n 2025-03-09) added blank lines around block delimiters as a\n @@ Commit message\n But list continuation was used here at the top level, which\n results in literal `+` in the output formats.\n \n + Acked-by: Jean-Noël Avila \n Signed-off-by: Kristoffer Haugsbakk \n \n ## Documentation/git-column.adoc ##\n\nbase-commit: 7014b55638da979331baf8dc31c4e1d697cf2d67\n-- \n2.50.0.rc0.47.g3c6d7b15404.dirty\n\n"}]}