{"thread":{"id":"63311","subject":"[PATCH] environment: fix typo: 'setup_git_directory_gently'","startedAt":"2025-04-18T18:59:03Z","lastAt":"2025-04-18T21:04:33Z","messageCount":2,"participants":["Abhijeet Sonar","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"516375","messageId":"20250418185855.52950-1-abhijeet.nkt@gmaiil.com","threadId":"63311","inReplyTo":null,"subject":"[PATCH] environment: fix typo: 'setup_git_directory_gently'","fromName":"Abhijeet Sonar","fromEmail":"abhijeet.nkt@gmail.com","sentAt":"2025-04-18T18:58:48Z","receivedAt":"2025-04-18T18:59:03Z","isPatch":true,"sender":{"key":"abhijeet.nkt@gmail.com","avatar":"https://avatars.githubusercontent.com/u/40241646?v=4"},"body":"From: Abhijeet Sonar <abhijeet.nkt@gmail.com>\n\nAbove the declaration of git_work_tree_cfg, we have:\n\n  /* This is set by setup_git_dir_gently() and/or git_default_config() */\n  char *git_work_tree_cfg;\n\nIt can be verified that there is no function called\n'setup_git_dir_gently' by running grep on the codebase:\n\n  $ grep -R setup_git_dir_gently .\n  ./environment.c:/* This is set by setup_git_dir_gently() and/or git_default_config() */\n\nThe comment, introduced in e90fdc39b6 (Clean up work-tree handling), is\nthe only occurrence of the name 'setup_git_dir_gently'.\n\nIt probably meant 'setup_git_directory_gently' as that is a name of a\nreal function in setup.c. Correct it.\n\nSigned-off-by: Abhijeet Sonar <abhijeet.nkt@gmail.com>\n---\n environment.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/environment.c b/environment.c\nindex 3c32367c28..970a407753 100644\n--- a/environment.c\n+++ b/environment.c\n@@ -106,7 +106,7 @@ int auto_comment_line_char;\n /* Parallel index stat data preload? */\n int core_preload_index = 1;\n \n-/* This is set by setup_git_dir_gently() and/or git_default_config() */\n+/* This is set by setup_git_directory_gently() and/or git_default_config() */\n char *git_work_tree_cfg;\n \n /*\n-- \n2.49.0-rc0\n\n"},{"id":"516379","messageId":"xmqqy0vx9o68.fsf@gitster.g","threadId":"63311","inReplyTo":"20250418185855.52950-1-abhijeet.nkt@gmaiil.com","subject":"Re: [PATCH] environment: fix typo: 'setup_git_directory_gently'","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-04-18T21:04:31Z","receivedAt":"2025-04-18T21:04:33Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Abhijeet Sonar <abhijeet.nkt@gmail.com> writes:\n\n> From: Abhijeet Sonar <abhijeet.nkt@gmail.com>\n>\n> Above the declaration of git_work_tree_cfg, we have:\n>\n>   /* This is set by setup_git_dir_gently() and/or git_default_config() */\n>   char *git_work_tree_cfg;\n>\n> It can be verified that there is no function called\n> 'setup_git_dir_gently' by running grep on the codebase:\n>\n>   $ grep -R setup_git_dir_gently .\n>   ./environment.c:/* This is set by setup_git_dir_gently() and/or git_default_config() */\n>\n> The comment, introduced in e90fdc39b6 (Clean up work-tree handling), is\n> the only occurrence of the name 'setup_git_dir_gently'.\n>\n> It probably meant 'setup_git_directory_gently' as that is a name of a\n> real function in setup.c. Correct it.\n>\n> Signed-off-by: Abhijeet Sonar <abhijeet.nkt@gmail.com>\n> ---\n>  environment.c | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n\nWill queue.  Thanks for a well-written patch.\n\n> diff --git a/environment.c b/environment.c\n> index 3c32367c28..970a407753 100644\n> --- a/environment.c\n> +++ b/environment.c\n> @@ -106,7 +106,7 @@ int auto_comment_line_char;\n>  /* Parallel index stat data preload? */\n>  int core_preload_index = 1;\n>  \n> -/* This is set by setup_git_dir_gently() and/or git_default_config() */\n> +/* This is set by setup_git_directory_gently() and/or git_default_config() */\n>  char *git_work_tree_cfg;\n>  \n>  /*\n"}]}