{"thread":{"id":"63310","subject":"[PATCH] t/meson.build: remove deleted performance test script","startedAt":"2025-04-18T17:02:28Z","lastAt":"2025-04-18T19:51:20Z","messageCount":4,"participants":["Ramsay Jones","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"516371","messageId":"67c50fde-d29c-404b-a296-9f0e482acaf3@ramsayjones.plus.com","threadId":"63310","inReplyTo":null,"subject":"[PATCH] t/meson.build: remove deleted performance test script","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2025-04-18T16:59:18Z","receivedAt":"2025-04-18T17:02:28Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nCommit 8b0b5c7046 (p5312: removed duplicate performance test script,\n2025-04-17) removed the 't/perf/p5312-pack-bitmaps-revs.sh' script, but\nforgot to remove it from 't/meson.build', resulting in a broken build.\n\nIn order to fix the build, remove the script from 't/meson.build'.\n\nSigned-off-by: Ramsay Jones \n---\n\nHi Taylor, Junio,\n\nIf you need to re-roll the 'tb/pack-bitmap-lookup-tables' branch, could\nyou please squash this into commit 8b0b5c7046. (the meson build on the\ncurrent 'seen' branch is broken otherwise).\n\nThanks!\n\nATB,\nRamsay Jones\n \n t/meson.build | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/t/meson.build b/t/meson.build\nindex 6eeb10d616..97e6d62228 100644\n--- a/t/meson.build\n+++ b/t/meson.build\n@@ -1132,7 +1132,6 @@ benchmarks = [\n 'perf/p5304-prune.sh',\n 'perf/p5310-pack-bitmaps.sh',\n 'perf/p5311-pack-bitmaps-fetch.sh',\n- 'perf/p5312-pack-bitmaps-revs.sh',\n 'perf/p5313-pack-objects.sh',\n 'perf/p5314-name-hash.sh',\n 'perf/p5326-multi-pack-bitmaps.sh',\n-- \n2.49.0\n"},{"id":"516372","messageId":"xmqqmscdbc6g.fsf@gitster.g","threadId":"63310","inReplyTo":"67c50fde-d29c-404b-a296-9f0e482acaf3@ramsayjones.plus.com","subject":"Re: [PATCH] t/meson.build: remove deleted performance test script","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-04-18T17:40:39Z","receivedAt":"2025-04-18T17:40:42Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ramsay Jones writes:\n\n> Commit 8b0b5c7046 (p5312: removed duplicate performance test script,\n> 2025-04-17) removed the 't/perf/p5312-pack-bitmaps-revs.sh' script, but\n> forgot to remove it from 't/meson.build', resulting in a broken build.\n>\n> In order to fix the build, remove the script from 't/meson.build'.\n\nThanks.\n\n\n> Signed-off-by: Ramsay Jones \n> ---\n>\n> Hi Taylor, Junio,\n>\n> If you need to re-roll the 'tb/pack-bitmap-lookup-tables' branch, could\n> you please squash this into commit 8b0b5c7046. (the meson build on the\n> current 'seen' branch is broken otherwise).\n\nUnless the topic by Tayor gets rebased on top of what contains\nps/meson-build-perf-bench, which is not even in 'next' (hence I\nwouldn't recommend doing such a rebase), this needs to be dealt with\nas an evil-merge semantic conflict fix-up, which I did this morning\nand pushed the result out.\n"},{"id":"516374","messageId":"4b2fdfd0-72da-4c36-8b8a-4ef514873d39@ramsayjones.plus.com","threadId":"63310","inReplyTo":"xmqqmscdbc6g.fsf@gitster.g","subject":"Re: [PATCH] t/meson.build: remove deleted performance test script","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2025-04-18T18:52:01Z","receivedAt":"2025-04-18T18:52:10Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\n\nOn 18/04/2025 18:40, Junio C Hamano wrote:\n> Ramsay Jones writes:\n> \n>> Commit 8b0b5c7046 (p5312: removed duplicate performance test script,\n>> 2025-04-17) removed the 't/perf/p5312-pack-bitmaps-revs.sh' script, but\n>> forgot to remove it from 't/meson.build', resulting in a broken build.\n>>\n>> In order to fix the build, remove the script from 't/meson.build'.\n> \n> Thanks.\n> \n> \n>> Signed-off-by: Ramsay Jones \n>> ---\n>>\n>> Hi Taylor, Junio,\n>>\n>> If you need to re-roll the 'tb/pack-bitmap-lookup-tables' branch, could\n>> you please squash this into commit 8b0b5c7046. (the meson build on the\n>> current 'seen' branch is broken otherwise).\n> \n> Unless the topic by Tayor gets rebased on top of what contains\n> ps/meson-build-perf-bench, which is not even in 'next' (hence I\n> wouldn't recommend doing such a rebase), this needs to be dealt with\n> as an evil-merge semantic conflict fix-up, which I did this morning\n> and pushed the result out.\n\nAh, yes, I just fetched and found your fixup (which you did hours ago!).\nSorry for the noise.\n\nThanks.\n\nATB,\nRamsay Jones\n\n\n\n"},{"id":"516376","messageId":"xmqqbjstb64q.fsf@gitster.g","threadId":"63310","inReplyTo":"4b2fdfd0-72da-4c36-8b8a-4ef514873d39@ramsayjones.plus.com","subject":"Re: [PATCH] t/meson.build: remove deleted performance test script","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-04-18T19:51:17Z","receivedAt":"2025-04-18T19:51:20Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ramsay Jones writes:\n\n>>> If you need to re-roll the 'tb/pack-bitmap-lookup-tables' branch, could\n>>> you please squash this into commit 8b0b5c7046. (the meson build on the\n>>> current 'seen' branch is broken otherwise).\n>> \n>> Unless the topic by Tayor gets rebased on top of what contains\n>> ps/meson-build-perf-bench, which is not even in 'next' (hence I\n>> wouldn't recommend doing such a rebase), this needs to be dealt with\n>> as an evil-merge semantic conflict fix-up, which I did this morning\n>> and pushed the result out.\n>\n> Ah, yes, I just fetched and found your fixup (which you did hours ago!).\n> Sorry for the noise.\n\nI very much appreciate your being on the lookout for any breakages.\nThanks.\n"}]}