{"thread":{"id":"63299","subject":"meson build failure on 'seen'","startedAt":"2025-04-15T17:19:14Z","lastAt":"2025-04-16T09:06:10Z","messageCount":3,"participants":["Ramsay Jones","Junio C Hamano","Patrick Steinhardt"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"516212","messageId":"c358c9b7-bd83-407f-8abc-17ce9363618e@ramsayjones.plus.com","threadId":"63299","inReplyTo":null,"subject":"meson build failure on 'seen'","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2025-04-15T17:16:02Z","receivedAt":"2025-04-15T17:19:14Z","isPatch":false,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"Hi Junio,\n\nAttempting to configure a meson build of the current 'seen'@916e0fb7c0\nbranch, I find:\n\n  $ meson setup --optimization=2 -Dprefix=$HOME -Dpcre2=disabled build/\n  The Meson build system\n  ...\n\n  meson.build:769:46: ERROR: Unknown variable \"target_shell\".\n\n  A full log can be found at /home/ramsay/git/build/meson-logs/meson-log.txt\n  $ \n\nIt appears that the tip commit 916e0fb7c0 (Merge branch 'ps/meson-build-perf-bench'\ninto seen, 2025-04-14) drops the call to 'find_program()' which sets/defines the\n'target_shell' variable.\n\nThe following diff allows me to configure the build:\n\n  $ git diff\n  diff --git a/meson.build b/meson.build\n  index 015ead27e6..4d537b7a00 100644\n  --- a/meson.build\n  +++ b/meson.build\n  @@ -237,6 +237,8 @@ shell = find_program('sh', dirs: program_path, native: true)\n   tar = find_program('tar', dirs: program_path, native: true)\n   time = find_program('time', dirs: program_path, native: true, required: false)\n \n  +target_shell = find_program('sh', dirs: program_path, native: false)\n  +\n   # Sanity-check that programs required for the build exist.\n   foreach tool : ['cat', 'cut', 'grep', 'sort', 'tr', 'uname']\n     find_program(tool, dirs: program_path, native: true)\n  $ \n\nThis allows me to compile the project (I'm still waiting for the test run to\nfinish).\n\nHTH\n\nATB,\nRamsay Jones\n\n\n"},{"id":"516215","messageId":"xmqqy0w1kzob.fsf@gitster.g","threadId":"63299","inReplyTo":"c358c9b7-bd83-407f-8abc-17ce9363618e@ramsayjones.plus.com","subject":"Re: meson build failure on 'seen'","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-04-15T19:11:32Z","receivedAt":"2025-04-15T19:11:35Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ramsay Jones <ramsay@ramsayjones.plus.com> writes:\n\n> It appears that the tip commit 916e0fb7c0 (Merge branch 'ps/meson-build-perf-bench'\n> into seen, 2025-04-14) drops the call to 'find_program()' which sets/defines the\n> 'target_shell' variable.\n\nAhh, indeed.  This was the mismerge I was looking for.\n\nWill adjust the broken merge.  Thanks!\n"},{"id":"516262","messageId":"Z_9wukFkVqAykm0L@pks.im","threadId":"63299","inReplyTo":"xmqqy0w1kzob.fsf@gitster.g","subject":"Re: meson build failure on 'seen'","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2025-04-16T08:56:26Z","receivedAt":"2025-04-16T09:06:10Z","isPatch":false,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Tue, Apr 15, 2025 at 12:11:32PM -0700, Junio C Hamano wrote:\n> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:\n> \n> > It appears that the tip commit 916e0fb7c0 (Merge branch 'ps/meson-build-perf-bench'\n> > into seen, 2025-04-14) drops the call to 'find_program()' which sets/defines the\n> > 'target_shell' variable.\n> \n> Ahh, indeed.  This was the mismerge I was looking for.\n> \n> Will adjust the broken merge.  Thanks!\n\nThanks to both of you!\n\nPatrick\n"}]}