{"thread":{"id":"63261","subject":"[GSoC PATCH] environment.h: remove unused variables","startedAt":"2025-04-05T16:45:35Z","lastAt":"2025-04-07T08:03:25Z","messageCount":2,"participants":["Arnav Bhate","Patrick Steinhardt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"515700","messageId":"2c547567-2b72-476c-9fc5-71cac050fa15@gmail.com","threadId":"63261","inReplyTo":null,"subject":"[GSoC PATCH] environment.h: remove unused variables","fromName":"Arnav Bhate","fromEmail":"bhatearnav@gmail.com","sentAt":"2025-04-05T16:45:32Z","receivedAt":"2025-04-05T16:45:35Z","isPatch":true,"sender":{"key":"bhatearnav@gmail.com","avatar":"https://avatars.githubusercontent.com/u/86760472?v=4"},"body":"packed_git_window_size and packed_git_limit are not used anywhere in\nthe codebase. A search found that all references were removed in\nd284713bae (config: make `packed_git_(limit|window_size)` non-global\nvariables, 2024-12-03), except the ones in this file, as they were moved\nto struct repo_settings.\n\nRemove packed_git_window_size and packed_git_limit from environment.h.\n\nSigned-off-by: Arnav Bhate <bhatearnav@gmail.com>\n---\n environment.h | 2 --\n 1 file changed, 2 deletions(-)\n\ndiff --git a/environment.h b/environment.h\nindex 45e690f203..cf6fc04e70 100644\n--- a/environment.h\n+++ b/environment.h\n@@ -152,8 +152,6 @@ extern char *apply_default_ignorewhitespace;\n extern char *git_attributes_file;\n extern int zlib_compression_level;\n extern int pack_compression_level;\n-extern size_t packed_git_window_size;\n-extern size_t packed_git_limit;\n extern unsigned long big_file_threshold;\n extern unsigned long pack_size_limit_cfg;\n extern int max_allowed_tree_depth;\n-- \n2.49.0\n"},{"id":"515746","messageId":"Z_OGyqVHaUkFIh1T@pks.im","threadId":"63261","inReplyTo":"2c547567-2b72-476c-9fc5-71cac050fa15@gmail.com","subject":"Re: [GSoC PATCH] environment.h: remove unused variables","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2025-04-07T08:03:22Z","receivedAt":"2025-04-07T08:03:25Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Sat, Apr 05, 2025 at 10:15:32PM +0530, Arnav Bhate wrote:\n> packed_git_window_size and packed_git_limit are not used anywhere in\n> the codebase. A search found that all references were removed in\n> d284713bae (config: make `packed_git_(limit|window_size)` non-global\n> variables, 2024-12-03), except the ones in this file, as they were moved\n> to struct repo_settings.\n> \n> Remove packed_git_window_size and packed_git_limit from environment.h.\n> \n> Signed-off-by: Arnav Bhate <bhatearnav@gmail.com>\n> ---\n>  environment.h | 2 --\n>  1 file changed, 2 deletions(-)\n> \n> diff --git a/environment.h b/environment.h\n> index 45e690f203..cf6fc04e70 100644\n> --- a/environment.h\n> +++ b/environment.h\n> @@ -152,8 +152,6 @@ extern char *apply_default_ignorewhitespace;\n>  extern char *git_attributes_file;\n>  extern int zlib_compression_level;\n>  extern int pack_compression_level;\n> -extern size_t packed_git_window_size;\n> -extern size_t packed_git_limit;\n>  extern unsigned long big_file_threshold;\n>  extern unsigned long pack_size_limit_cfg;\n>  extern int max_allowed_tree_depth;\n\nGood catch indeed, the patch looks obviously good to me!\n\nPatrick\n"}]}