{"thread":{"id":"63154","subject":"[PATCH] docs: add BreakingChanges to TECH_DOCS target","startedAt":"2025-03-18T14:41:43Z","lastAt":"2025-03-19T09:33:31Z","messageCount":2,"participants":["Phillip Wood via GitGitGadget","Patrick Steinhardt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"514528","messageId":"pull.1921.git.git.1742308900290.gitgitgadget@gmail.com","threadId":"63154","inReplyTo":null,"subject":"[PATCH] docs: add BreakingChanges to TECH_DOCS target","fromName":"Phillip Wood via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2025-03-18T14:41:40Z","receivedAt":"2025-03-18T14:41:43Z","isPatch":true,"sender":{"key":"phillip.wood@dunelm.org.uk","avatar":null},"body":"From: Phillip Wood <phillip.wood@dunelm.org.uk>\n\nWhen BreakingChanges.txt was added in 57ec9254eb9 (docs: introduce\ndocument to announce breaking changes, 2024-06-14) there was no\ncorresponding change to the Makefile to build it. Fix that by adding it\nto the TECH_DOCS target.\n\nSigned-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>\n---\n    docs: add BreakingChanges to TECH_DOCS target\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1921%2Fphillipwood%2Fbuild-breaking-changes-docs-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1921/phillipwood/build-breaking-changes-docs-v1\nPull-Request: https://github.com/git/git/pull/1921\n\n Documentation/Makefile    | 1 +\n Documentation/meson.build | 1 +\n 2 files changed, 2 insertions(+)\n\ndiff --git a/Documentation/Makefile b/Documentation/Makefile\nindex 671267a8ac7..de57d5822e4 100644\n--- a/Documentation/Makefile\n+++ b/Documentation/Makefile\n@@ -109,6 +109,7 @@ SP_ARTICLES += howto/coordinate-embargoed-releases\n API_DOCS = $(patsubst %.adoc,%,$(filter-out technical/api-index-skel.adoc technical/api-index.adoc, $(wildcard technical/api-*.adoc)))\n SP_ARTICLES += $(API_DOCS)\n \n+TECH_DOCS += BreakingChanges\n TECH_DOCS += DecisionMaking\n TECH_DOCS += ReviewingGuidelines\n TECH_DOCS += MyFirstContribution\ndiff --git a/Documentation/meson.build b/Documentation/meson.build\nindex 594546d68b1..b62ec5f6010 100644\n--- a/Documentation/meson.build\n+++ b/Documentation/meson.build\n@@ -440,6 +440,7 @@ if get_option('docs').contains('html')\n   )\n \n   articles = [\n+    'BreakingChanges.adoc',\n     'DecisionMaking.adoc',\n     'MyFirstContribution.adoc',\n     'MyFirstObjectWalk.adoc',\n\nbase-commit: 683c54c999c301c2cd6f715c411407c413b1d84e\n-- \ngitgitgadget\n"},{"id":"514627","messageId":"Z9qPZ_7VVV6L95WE@pks.im","threadId":"63154","inReplyTo":"pull.1921.git.git.1742308900290.gitgitgadget@gmail.com","subject":"Re: [PATCH] docs: add BreakingChanges to TECH_DOCS target","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2025-03-19T09:33:27Z","receivedAt":"2025-03-19T09:33:31Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Tue, Mar 18, 2025 at 02:41:40PM +0000, Phillip Wood via GitGitGadget wrote:\n> From: Phillip Wood <phillip.wood@dunelm.org.uk>\n> \n> When BreakingChanges.txt was added in 57ec9254eb9 (docs: introduce\n> document to announce breaking changes, 2024-06-14) there was no\n> corresponding change to the Makefile to build it. Fix that by adding it\n> to the TECH_DOCS target.\n\nMakes sense, thanks for this improvement!\n\nPatrick\n"}]}