{"thread":{"id":"63141","subject":"[PATCH] doc: add missing commit C to the graph for --ancestry-path=H D..M","startedAt":"2025-03-16T01:47:43Z","lastAt":"2025-03-16T09:37:02Z","messageCount":3,"participants":["Han Jiang via GitGitGadget","Elijah Newren","Han Jiang"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"514369","messageId":"pull.1883.git.1742089659610.gitgitgadget@gmail.com","threadId":"63141","inReplyTo":null,"subject":"[PATCH] doc: add missing commit C to the graph for --ancestry-path=H D..M","fromName":"Han Jiang via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2025-03-16T01:47:39Z","receivedAt":"2025-03-16T01:47:43Z","isPatch":true,"sender":{"key":"jhcarl0814@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5171262?v=4"},"body":"From: Han Jiang <jhcarl0814@gmail.com>\n\nThe graph for `--ancestry-path=H D..M` should contain commit C.\n\nSigned-off-by: Han Jiang <jhcarl0814@gmail.com>\n---\n    doc: add missing commit C to the graph for --ancestry-path=H D..M\n    \n    cc:Elijah Newren newren@gmail.com,D. Ben Knoble ben.knoble@gmail.com\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1883%2Fjhcarl0814%2Fpatch_ancestry_path_doc_graph_20250315-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1883/jhcarl0814/patch_ancestry_path_doc_graph_20250315-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/1883\n\n Documentation/rev-list-options.adoc | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/rev-list-options.adoc b/Documentation/rev-list-options.adoc\nindex 785c0786e0c..5e5cedb9127 100644\n--- a/Documentation/rev-list-options.adoc\n+++ b/Documentation/rev-list-options.adoc\n@@ -640,7 +640,7 @@ commits affected by that topic, we may only want to view the subset of\n -----------------------------------------------------------------------\n \t\tE\n \t\t \\\n-\t\t  G---H---I---J\n+\t      C---G---H---I---J\n \t\t\t       \\\n \t\t\t\tL--M\n -----------------------------------------------------------------------\n\nbase-commit: 683c54c999c301c2cd6f715c411407c413b1d84e\n-- \ngitgitgadget\n"},{"id":"514383","messageId":"CABPp-BGbyKPmx=jNFE9TpvhSO0DcvqA8AETAYRt35_dG20rABQ@mail.gmail.com","threadId":"63141","inReplyTo":"pull.1883.git.1742089659610.gitgitgadget@gmail.com","subject":"Re: [PATCH] doc: add missing commit C to the graph for --ancestry-path=H D..M","fromName":"Elijah Newren","fromEmail":"newren@gmail.com","sentAt":"2025-03-16T06:53:24Z","receivedAt":"2025-03-16T06:53:36Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"On Sat, Mar 15, 2025 at 6:47 PM Han Jiang via GitGitGadget\n<gitgitgadget@gmail.com> wrote:\n>\n> From: Han Jiang <jhcarl0814@gmail.com>\n>\n> The graph for `--ancestry-path=H D..M` should contain commit C.\n\nYep, C is in the range D..M and C is also an ancestor of H.\n\n> Signed-off-by: Han Jiang <jhcarl0814@gmail.com>\n> ---\n>     doc: add missing commit C to the graph for --ancestry-path=H D..M\n>\n>     cc:Elijah Newren newren@gmail.com,D. Ben Knoble ben.knoble@gmail.com\n\nIn the future, you'll probably want to use separate cc lines for each\nperson you are cc'ing; I think gitgitgadget expects that to work.  You\nalso might want to add a space after the \"cc:\", though I don't know if\nthat's required.\n\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1883%2Fjhcarl0814%2Fpatch_ancestry_path_doc_graph_20250315-v1\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1883/jhcarl0814/patch_ancestry_path_doc_graph_20250315-v1\n> Pull-Request: https://github.com/gitgitgadget/git/pull/1883\n>\n>  Documentation/rev-list-options.adoc | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/rev-list-options.adoc b/Documentation/rev-list-options.adoc\n> index 785c0786e0c..5e5cedb9127 100644\n> --- a/Documentation/rev-list-options.adoc\n> +++ b/Documentation/rev-list-options.adoc\n> @@ -640,7 +640,7 @@ commits affected by that topic, we may only want to view the subset of\n>  -----------------------------------------------------------------------\n>                 E\n>                  \\\n> -                 G---H---I---J\n> +             C---G---H---I---J\n>                                \\\n>                                 L--M\n>  -----------------------------------------------------------------------\n>\n> base-commit: 683c54c999c301c2cd6f715c411407c413b1d84e\n> --\n> gitgitgadget\n\nPatch looks good.\n"},{"id":"514390","messageId":"CANrWfmQ6LRfqcwtE_HEoY0JzE9KCE04YGe3tMzAsBgOWm53vXw@mail.gmail.com","threadId":"63141","inReplyTo":"CABPp-BGbyKPmx=jNFE9TpvhSO0DcvqA8AETAYRt35_dG20rABQ@mail.gmail.com","subject":"Re: [PATCH] doc: add missing commit C to the graph for --ancestry-path=H D..M","fromName":"Han Jiang","fromEmail":"jhcarl0814@gmail.com","sentAt":"2025-03-16T09:36:51Z","receivedAt":"2025-03-16T09:37:02Z","isPatch":true,"sender":{"key":"jhcarl0814@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5171262?v=4"},"body":"On Sun, Mar 16, 2025 at 7:53 PM Elijah Newren <newren@gmail.com> wrote:\n>\n> In the future, you'll probably want to use separate cc lines for each\n> person you are cc'ing; I think gitgitgadget expects that to work.  You\n> also might want to add a space after the \"cc:\", though I don't know if\n> that's required.\n\nThank you for your suggestion! I will follow it next time.\n"}]}