{"thread":{"id":"63115","subject":"`--ancestry-path` documentation has wrong graph","startedAt":"2025-03-13T21:04:22Z","lastAt":"2025-03-16T01:59:34Z","messageCount":7,"participants":["Han Jiang","Elijah Newren","D. Ben Knoble"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"514230","messageId":"CANrWfmRq=7Q=vCPgmcLcek=fRsw83BPqTX7gTpcLb=JpQpYZEw@mail.gmail.com","threadId":"63115","inReplyTo":null,"subject":"`--ancestry-path` documentation has wrong graph","fromName":"Han Jiang","fromEmail":"jhcarl0814@gmail.com","sentAt":"2025-03-13T21:04:11Z","receivedAt":"2025-03-13T21:04:22Z","isPatch":false,"sender":{"key":"jhcarl0814@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5171262?v=4"},"body":"Git - git-log Documentation --ancestry-path[=]\nhttps://git-scm.com/docs/git-log#Documentation/git-log.txt---ancestry-pathltcommitgt-1\n\nThe graph for `--ancestry-path=H D..M` should contain commit C.\n\nCode:\n\nmkdir --parents -- './repo'\ncd './repo'\ngit init\nbranch_default_name=\"$(git branch --show-current)\"; echo \"$branch_default_name\"\ngit commit --message='a' --allow-empty\ngit checkout -b branch1\ngit commit --message='b' --allow-empty\ngit checkout -b branch2\ngit commit --message='d' --allow-empty\ngit commit --message='e' --allow-empty\ngit checkout branch1\ngit commit --message='c' --allow-empty\ngit merge --message='g' branch2\ngit checkout branch2\ngit commit --message='f' --allow-empty\ngit checkout branch1\ngit commit --message='h' --allow-empty\ngit merge --message='i' branch2\ngit commit --message='j' --allow-empty\ngit checkout \"$branch_default_name\"\ngit commit --message='k' --allow-empty\ngit merge --message='l' branch1\ngit commit --message='m' --allow-empty\ngit log --graph\ngit log --graph --ancestry-path=:/'h' :/'d'..:/'m'\n\nOutput:\n\n* 9e6572c - 2025-03-14 09:54 (1 second ago) m (HEAD -> refs/heads/master)\n* 9598130 - 2025-03-14 09:54 (2 seconds ago) l\n|\\\n| * 3579336 - 2025-03-14 09:54 (5 seconds ago) j (refs/heads/branch1)\n| * a144397 - 2025-03-14 09:54 (5 seconds ago) i\n| |\\\n| | * 721743e - 2025-03-14 09:54 (8 seconds ago) f (refs/heads/branch2)\n| * | ceaf310 - 2025-03-14 09:54 (6 seconds ago) h\n| * | 30e22bb - 2025-03-14 09:54 (9 seconds ago) g\n| |\\|\n| | * 0f44e94 - 2025-03-14 09:54 (12 seconds ago) e\n| | * edecedf - 2025-03-14 09:54 (13 seconds ago) d\n| * | b4c952f - 2025-03-14 09:54 (10 seconds ago) c\n| |/\n| * 11851d5 - 2025-03-14 09:54 (14 seconds ago) b\n* | 70c1b91 - 2025-03-14 09:54 (3 seconds ago) k\n|/\n* 029edb2 - 2025-03-14 09:54 (16 seconds ago) a\n\n* 9e6572c - 2025-03-14 09:54 (1 second ago) m (HEAD -> refs/heads/master)\n* 9598130 - 2025-03-14 09:54 (2 seconds ago) l\n* 3579336 - 2025-03-14 09:54 (5 seconds ago) j (refs/heads/branch1)\n* a144397 - 2025-03-14 09:54 (5 seconds ago) i\n* ceaf310 - 2025-03-14 09:54 (6 seconds ago) h\n* 30e22bb - 2025-03-14 09:54 (9 seconds ago) g\n|\\\n| * 0f44e94 - 2025-03-14 09:54 (12 seconds ago) e\n* b4c952f - 2025-03-14 09:54 (10 seconds ago) c\n"},{"id":"514274","messageId":"CABPp-BHPAEcJibTaiMVE1K7AvYE+TYmOt7=6XUtcZbm7wsWhDQ@mail.gmail.com","threadId":"63115","inReplyTo":"CANrWfmRq=7Q=vCPgmcLcek=fRsw83BPqTX7gTpcLb=JpQpYZEw@mail.gmail.com","subject":"Re: `--ancestry-path` documentation has wrong graph","fromName":"Elijah Newren","fromEmail":"newren@gmail.com","sentAt":"2025-03-14T17:16:02Z","receivedAt":"2025-03-14T17:16:15Z","isPatch":false,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"On Thu, Mar 13, 2025 at 2:04 PM Han Jiang wrote:\n>\n> Git - git-log Documentation --ancestry-path[=]\n> https://git-scm.com/docs/git-log#Documentation/git-log.txt---ancestry-pathltcommitgt-1\n>\n> The graph for `--ancestry-path=H D..M` should contain commit C.\n\nIndeed; D..H contains C, and C is an ancestor of H. I apparently\noverlooked C in that example when writing that documentation. Would\nyou like to submit a patch, or would you like me to do so and record\nyou as the reporter? I'm fine with either, but if you want to give it\na try, the relevant file is Documentation/rev-list-options.adoc in the\nrepository.\n"},{"id":"514350","messageId":"CANrWfmRpDFuqv+fkCf_p_ggHTrRjD3Vgviqrai_rA7Lu-YFEMA@mail.gmail.com","threadId":"63115","inReplyTo":"CABPp-BHPAEcJibTaiMVE1K7AvYE+TYmOt7=6XUtcZbm7wsWhDQ@mail.gmail.com","subject":"Re: `--ancestry-path` documentation has wrong graph","fromName":"Han Jiang","fromEmail":"jhcarl0814@gmail.com","sentAt":"2025-03-15T08:20:58Z","receivedAt":"2025-03-15T08:21:10Z","isPatch":false,"sender":{"key":"jhcarl0814@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5171262?v=4"},"body":"On Sat, Mar 15, 2025 at 6:16 AM Elijah Newren wrote:\n>\n> On Thu, Mar 13, 2025 at 2:04 PM Han Jiang wrote:\n> >\n> > Git - git-log Documentation --ancestry-path[=]\n> > https://git-scm.com/docs/git-log#Documentation/git-log.txt---ancestry-pathltcommitgt-1\n> >\n> > The graph for `--ancestry-path=H D..M` should contain commit C.\n>\n> Indeed; D..H contains C, and C is an ancestor of H. I apparently\n> overlooked C in that example when writing that documentation. Would\n> you like to submit a patch, or would you like me to do so and record\n> you as the reporter? I'm fine with either, but if you want to give it\n> a try, the relevant file is Documentation/rev-list-options.adoc in the\n> repository.\n\nThank you for the clarification! I'd like to try sending a patch.\nAfter doing some research on how to make contributions today, I\ndecided to try GitGitGadget way first. But I got some questions that\nthe doc doesn't clearly explain:\n\n[Git - CodingGuidelines\nDocumentation](https://git-scm.com/docs/CodingGuidelines) says:\nFor C programs: We use tabs to indent, and interpret tabs as taking up\nto 8 spaces.\n1. It seems adoc files treats tabs as 8 spaces too, is that true?\n(The prepared commit in forked repository is at\nhttps://github.com/jhcarl0814/git/commit/ce568e4a87dff14df4e7104af89be3f12616f5de\n. The source diff shows tabs as 4 spaces. The rich diff shows tabs as\n8 spaces. When I was editting the number defaults to 8 and is\nadjustable in editor options.)\n\n[Git - MyFirstContribution\nDocumentation](https://git-scm.com/docs/MyFirstContribution) says:\nFor single-patch contributions, your commit message should already be\nmeaningful and explain at a high level the purpose (what is happening\nand why) of your patch, so you usually do not need any additional\ncontext. In that case, remove the PR description that GitHub\nautomatically generates from your commit message (your PR description\nshould be empty).\n2. For single-patch contributions, is the pull request title or the\nfirst line of commit message that will become Subject of the email?\n\n[Git - SubmittingPatches\nDocumentation](https://git-scm.com/docs/SubmittingPatches) says:\nIt is a common convention to prefix your subject line with [PATCH].\n3. Which one of GitGitGadget or the pull request creator is the one\nwho add \"[PATCH]\" at the beginning of the title?\n\n[Git - MyFirstContribution\nDocumentation](https://git-scm.com/docs/MyFirstContribution) says:\nNow that your CI is passing and someone has granted you permission to\nuse GitGitGadget with the `/allow` command, sending out for review is\nas simple as commenting on your PR with `/submit`.\n4. Who is able to use `/submit` to trigger email sending action? Is it\nthe pull request creator (when `/allow`ed) or anyone (`/allow`ed)?\n5. If `/submit` sends email, then how to cc all relevant people\n(including myself) at the moment of `/submit`? Is there a place to\nfill in this parameter?\n6. Where does `/submit` send the email to, as a brand new post or as a\nreply under this post? How to configure?\n\n----\n\n7. How to make Gmail web client default to bottom-posting?\n"},{"id":"514357","messageId":"CABPp-BHn6sPBh0CPctJ4-rM3rxGwXkbG4-o236dRV8FTwdP_nQ@mail.gmail.com","threadId":"63115","inReplyTo":"CANrWfmRpDFuqv+fkCf_p_ggHTrRjD3Vgviqrai_rA7Lu-YFEMA@mail.gmail.com","subject":"Re: `--ancestry-path` documentation has wrong graph","fromName":"Elijah Newren","fromEmail":"newren@gmail.com","sentAt":"2025-03-15T16:42:14Z","receivedAt":"2025-03-15T16:42:26Z","isPatch":false,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"On Sat, Mar 15, 2025 at 1:21 AM Han Jiang wrote:\n>\n> On Sat, Mar 15, 2025 at 6:16 AM Elijah Newren wrote:\n> >\n> > On Thu, Mar 13, 2025 at 2:04 PM Han Jiang wrote:\n> > >\n> > > Git - git-log Documentation --ancestry-path[=]\n> > > https://git-scm.com/docs/git-log#Documentation/git-log.txt---ancestry-pathltcommitgt-1\n> > >\n> > > The graph for `--ancestry-path=H D..M` should contain commit C.\n> >\n> > Indeed; D..H contains C, and C is an ancestor of H. I apparently\n> > overlooked C in that example when writing that documentation. Would\n> > you like to submit a patch, or would you like me to do so and record\n> > you as the reporter? I'm fine with either, but if you want to give it\n> > a try, the relevant file is Documentation/rev-list-options.adoc in the\n> > repository.\n>\n> Thank you for the clarification! I'd like to try sending a patch.\n> After doing some research on how to make contributions today, I\n> decided to try GitGitGadget way first. But I got some questions that\n> the doc doesn't clearly explain:\n>\n> [Git - CodingGuidelines\n> Documentation](https://git-scm.com/docs/CodingGuidelines) says:\n> For C programs: We use tabs to indent, and interpret tabs as taking up\n> to 8 spaces.\n> 1. It seems adoc files treats tabs as 8 spaces too, is that true?\n> (The prepared commit in forked repository is at\n> https://github.com/jhcarl0814/git/commit/ce568e4a87dff14df4e7104af89be3f12616f5de\n> . The source diff shows tabs as 4 spaces. The rich diff shows tabs as\n> 8 spaces. When I was editting the number defaults to 8 and is\n> adjustable in editor options.)\n\nYes, assume 8 spaces per tab.\n\nNote that if you're worried, you can cd into the doc directory and run either\n make git-log.html\nor\n make git-log.1\n\nfollowed by then either\n \nor\n man ./git-log.1\n\nand look at how your changes modify the end result.\n\n> [Git - MyFirstContribution\n> Documentation](https://git-scm.com/docs/MyFirstContribution) says:\n> For single-patch contributions, your commit message should already be\n> meaningful and explain at a high level the purpose (what is happening\n> and why) of your patch, so you usually do not need any additional\n> context. In that case, remove the PR description that GitHub\n> automatically generates from your commit message (your PR description\n> should be empty).\n> 2. For single-patch contributions, is the pull request title or the\n> first line of commit message that will become Subject of the email?\n\nWhy would you make the pull request title and the first line of the\ncommit message different for a single-commit pull request? That'd be\nweird.\n\nI have a guess at the answer, but only a guess.\n\n> [Git - SubmittingPatches\n> Documentation](https://git-scm.com/docs/SubmittingPatches) says:\n> It is a common convention to prefix your subject line with [PATCH].\n> 3. Which one of GitGitGadget or the pull request creator is the one\n> who add \"[PATCH]\" at the beginning of the title?\n\nGitGitGadget will add it for you.\n\n> [Git - MyFirstContribution\n> Documentation](https://git-scm.com/docs/MyFirstContribution) says:\n> Now that your CI is passing and someone has granted you permission to\n> use GitGitGadget with the `/allow` command, sending out for review is\n> as simple as commenting on your PR with `/submit`.\n> 4. Who is able to use `/submit` to trigger email sending action? Is it\n> the pull request creator (when `/allow`ed) or anyone (`/allow`ed)?\n\nOnce you've been /allow'ed once, you can /submit that or any future\nPRs of yours.\n\n> 5. If `/submit` sends email, then how to cc all relevant people\n> (including myself) at the moment of `/submit`? Is there a place to\n> fill in this parameter?\n\nIn the PR description include a line of the form\n cc: User Name \n\n> 6. Where does `/submit` send the email to, as a brand new post or as a\n> reply under this post? How to configure?\n\nBrand new post, not configurable. Just post a response to the\noriginal thread with a link to the new submission.\n\nNow, as kind of a summary of the answers to many of these questions\nand perhaps others:\n\nIf you want to see an example, take a look at and compare\n https://github.com/gitgitgadget/git/pull/1864\nwith\n https://lore.kernel.org/git/pull.1864.git.1740139296483.gitgitgadget@gmail.com/\n\nYou'll be able to see the cc in action, see where the commit message\nand pr description go, see how the subject has '[PATCH] '\nauto-prepended, etc.\n"},{"id":"514363","messageId":"CALnO6CCppGXFHoL1jSkUWQUh41=RHb346hW6Qr9hFJpTawEW=Q@mail.gmail.com","threadId":"63115","inReplyTo":"CANrWfmRpDFuqv+fkCf_p_ggHTrRjD3Vgviqrai_rA7Lu-YFEMA@mail.gmail.com","subject":"Re: `--ancestry-path` documentation has wrong graph","fromName":"D. Ben Knoble","fromEmail":"ben.knoble@gmail.com","sentAt":"2025-03-15T21:50:35Z","receivedAt":"2025-03-15T21:50:47Z","isPatch":false,"sender":{"key":"ben.knoble@gmail.com","avatar":"https://avatars.githubusercontent.com/u/22802209?v=4"},"body":"On Sat, Mar 15, 2025 at 4:21 AM Han Jiang wrote:\n>\n>\n> 7. How to make Gmail web client default to bottom-posting?\n\nAFAIK, you cannot :/\n\n\n-- \nD. Ben Knoble\n"},{"id":"514365","messageId":"CANrWfmQdnrGmGW3ot9e0DU0vEbstrOsqzh9Puv9dy0Zsr7zQcQ@mail.gmail.com","threadId":"63115","inReplyTo":"CALnO6CCppGXFHoL1jSkUWQUh41=RHb346hW6Qr9hFJpTawEW=Q@mail.gmail.com","subject":"Re: `--ancestry-path` documentation has wrong graph","fromName":"Han Jiang","fromEmail":"jhcarl0814@gmail.com","sentAt":"2025-03-15T23:51:30Z","receivedAt":"2025-03-15T23:51:41Z","isPatch":false,"sender":{"key":"jhcarl0814@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5171262?v=4"},"body":"Thank you for the help!\nThe pull request has been created:\nhttps://github.com/gitgitgadget/git/pull/1883 . I'll `/submit` when\nsomeone `/allow`s me. (I'll also `/submit` before I'm `/allow`ed to\nsee what the bot would say.)\nAccording to https://datatracker.ietf.org/doc/html/rfc4021 and\nhttps://datatracker.ietf.org/doc/html/rfc5322 mails can use `:`\ninstead of `:` to separate mail header and\naddress list, use `,` instead of `,` to\nseparate multiple `address`es. According to\nhttps://datatracker.ietf.org/doc/html/rfc5322 and\nhttps://datatracker.ietf.org/doc/html/rfc5234, strings such as \"Cc:\"\nare case-insensitive. I'm just testing these in the `Cc` field.\n\nOn Sun, Mar 16, 2025 at 10:50 AM D. Ben Knoble wrote:\n>\n> On Sat, Mar 15, 2025 at 4:21 AM Han Jiang wrote:\n> >\n> >\n> > 7. How to make Gmail web client default to bottom-posting?\n>\n> AFAIK, you cannot :/\n>\n>\n> --\n> D. Ben Knoble\n"},{"id":"514370","messageId":"CANrWfmTFavk=q_h2yk6ORZnWyqyaANPnQ5vWiWXWXze5ng5C7Q@mail.gmail.com","threadId":"63115","inReplyTo":"CANrWfmQdnrGmGW3ot9e0DU0vEbstrOsqzh9Puv9dy0Zsr7zQcQ@mail.gmail.com","subject":"Re: `--ancestry-path` documentation has wrong graph","fromName":"Han Jiang","fromEmail":"jhcarl0814@gmail.com","sentAt":"2025-03-16T01:59:23Z","receivedAt":"2025-03-16T01:59:34Z","isPatch":false,"sender":{"key":"jhcarl0814@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5171262?v=4"},"body":"The patch is `/submit`ted to the mailing list:\nhttps://lore.kernel.org/git/pull.1883.git.1742089659610.gitgitgadget@gmail.com/\n.\nSeems either or both of changing case of case-insensitive header and\nremoving optional spaces prevented the bot from parsing the cc line\ncorrectly. (And I somehow got cc-ed twice.) I'll try again in the\nfuture someday when I have a chance.\n\nOn Sun, Mar 16, 2025 at 12:51 PM Han Jiang wrote:\n>\n> Thank you for the help!\n> The pull request has been created:\n> https://github.com/gitgitgadget/git/pull/1883 . I'll `/submit` when\n> someone `/allow`s me. (I'll also `/submit` before I'm `/allow`ed to\n> see what the bot would say.)\n> According to https://datatracker.ietf.org/doc/html/rfc4021 and\n> https://datatracker.ietf.org/doc/html/rfc5322 mails can use `:`\n> instead of `:` to separate mail header and\n> address list, use `,` instead of `,` to\n> separate multiple `address`es. According to\n> https://datatracker.ietf.org/doc/html/rfc5322 and\n> https://datatracker.ietf.org/doc/html/rfc5234, strings such as \"Cc:\"\n> are case-insensitive. I'm just testing these in the `Cc` field.\n>\n> On Sun, Mar 16, 2025 at 10:50 AM D. Ben Knoble wrote:\n> >\n> > On Sat, Mar 15, 2025 at 4:21 AM Han Jiang wrote:\n> > >\n> > >\n> > > 7. How to make Gmail web client default to bottom-posting?\n> >\n> > AFAIK, you cannot :/\n> >\n> >\n> > --\n> > D. Ben Knoble\n"}]}