{"thread":{"id":"631","subject":"Request reverting some from git-pb","startedAt":"2005-05-15T18:29:36Z","lastAt":"2005-05-15T18:29:36Z","messageCount":1,"participants":["Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"3375","messageId":"7vmzqwtka7.fsf@assigned-by-dhcp.cox.net","threadId":"631","inReplyTo":null,"subject":"Request reverting some from git-pb","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-05-15T18:29:36Z","receivedAt":"2005-05-15T18:29:36Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Petr, you added two small patches to git-pb recently.\n\n * Rename some more cache-related functions\n * Rename cache_match_stat() to ce_match_stat()\n\nI would really appreciate if you do not do these name clean-ups\nyet, _especially_ not without having GIT mailing list discussion\nabout it first.  This kind of changes inevitably introduce merge\nconflicts.\n\nI suspect this is something you lifted from a larger\nlibification patch.  While I think name cleanups are good in the\nlong run, I do not see value in lifting only some name cleanups\nfrom the libification patch and having people to adjust for the\nmerge conflicts twice (now and when libification is ready to be\nincluded).  I would not mind if these renames happen as a part\nof libification as a whole.  Pending patches need to be\ninspected and adjusted when that happens anyway.  But not until\nthen, at least please have a courtesy to give people a warning\nand an opportunity to speak out.\n\n"}]}