{"thread":{"id":"630","subject":"Request reverting some from git-pb","startedAt":"2005-05-15T18:25:02Z","lastAt":"2005-05-15T18:25:02Z","messageCount":1,"participants":["Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"3374","messageId":"7vy8agtkht.fsf@assigned-by-dhcp.cox.net","threadId":"630","inReplyTo":null,"subject":"Request reverting some from git-pb","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-05-15T18:25:02Z","receivedAt":"2005-05-15T18:25:02Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Petr, please do not do these name clean-ups yet, _especially_\nwithout having GIT mailing list discussion about renaming.  This\nkind of change inevitably introduces merge conflicts.\n\nI suspect this is something you lifted from the larger\nlibification patch.  While I think name cleanups are good in the\nlong run, I do not see value in lifting only some name cleanups\nfrom a larger libification patch and having people to adjust for\nthe merge conflicts twice.  I would not mind if these renames\nhappen as a part of libification as a whole.  Pending patches\nneed to be inspected and adjusted when that happens anyway.  But\nnot until then, at least please have a courtecy to give people a\nbit of warning and an opportunity to speak out.\n\n------------------------------------------------\nRename some more cache-related functions\n\nsame_name -> ce_same_name()\nremove_entry_at() -> remove_cache_entry_at()\n\nSigned-off-by: Brad Roberts <braddr@puremagic.com>\nSigned-off-by: Petr Baudis <pasky@ucw.cz>\n------------------------------------------------\nRename cache_match_stat() to ce_match_stat()\n\nSigned-off-by: Brad Roberts <braddr@puremagic.com>\nSigned-off-by: Petr Baudis <pasky@ucw.cz>\n------------------------------------------------\nRename cache_match_stat() to ce_match_stat()\n\nSigned-off-by: Brad Roberts <braddr@puremagic.com>\nSigned-off-by: Petr Baudis <pasky@ucw.cz>\n------------------------------------------------\n\n"}]}