{"thread":{"id":"62964","subject":"[PATCH] doc: fix typo","startedAt":"2025-02-17T13:09:16Z","lastAt":"2025-02-19T08:06:47Z","messageCount":4,"participants":["Matěj Cepl","Patrick Steinhardt","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"512511","messageId":"20250217130902.2706880-1-mcepl@cepl.eu","threadId":"62964","inReplyTo":null,"subject":"[PATCH] doc: fix typo","fromName":"Matěj Cepl","fromEmail":"mcepl@cepl.eu","sentAt":"2025-02-17T13:08:50Z","receivedAt":"2025-02-17T13:09:16Z","isPatch":true,"sender":{"key":"mcepl@cepl.eu","avatar":"https://avatars.githubusercontent.com/u/198999?v=4"},"body":"I don’t think there is an option --signed-off-cc (without -by)\nfor git send-email.\n\nSigned-off-by: Matěj Cepl \n---\n Documentation/git-send-email.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex bc3ef45acb..d762058907 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -389,7 +389,7 @@ Automating\n +\n Default is the value of `sendemail.suppressCc` configuration value; if\n that is unspecified, default to 'self' if --suppress-from is\n-specified, as well as 'body' if --no-signed-off-cc is specified.\n+specified, as well as 'body' if --no-signed-off-by-cc is specified.\n \n --[no-]suppress-from::\n \tIf this is set, do not add the From: address to the cc: list.\n-- \n2.48.1\n\n"},{"id":"512550","messageId":"Z7QszEnV4EzQMJ9R@pks.im","threadId":"62964","inReplyTo":"20250217130902.2706880-1-mcepl@cepl.eu","subject":"Re: [PATCH] doc: fix typo","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2025-02-18T06:46:36Z","receivedAt":"2025-02-18T06:46:43Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Mon, Feb 17, 2025 at 02:08:50PM +0100, Matěj Cepl wrote:\n> I don’t think there is an option --signed-off-cc (without -by)\n> for git send-email.\n\nA couple comments regarding the commit subject and body:\n\n - The subject should point out _where_ you're fixing a typo.\n\n - The message should be assertive and use imperative moot, as if\n instructing the documentation to change.\n\nI'd recommend to have a look at commit messages that relate to your file\nby doing `git log --follow Documentation/git-send-email.adoc` to get a\nbit of an idea of how this could look like.\n\n> Signed-off-by: Matěj Cepl \n> ---\n> Documentation/git-send-email.txt | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n\nYou should probably rebase your commit on the latest `master` as the\nfile has since been renamed to \"git-send-email.adoc\".\n\n> diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\n> index bc3ef45acb..d762058907 100644\n> --- a/Documentation/git-send-email.txt\n> +++ b/Documentation/git-send-email.txt\n> @@ -389,7 +389,7 @@ Automating\n> +\n> Default is the value of `sendemail.suppressCc` configuration value; if\n> that is unspecified, default to 'self' if --suppress-from is\n> -specified, as well as 'body' if --no-signed-off-cc is specified.\n> +specified, as well as 'body' if --no-signed-off-by-cc is specified.\n\nThe change itself looks obviously correct to me, thanks!\n\nPatrick\n"},{"id":"512631","messageId":"xmqqo6yzkrxd.fsf@gitster.g","threadId":"62964","inReplyTo":"Z7QszEnV4EzQMJ9R@pks.im","subject":"Re: [PATCH] doc: fix typo","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-02-18T18:51:10Z","receivedAt":"2025-02-18T18:51:13Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Patrick Steinhardt writes:\n\n> You should probably rebase your commit on the latest `master` as the\n> file has since been renamed to \"git-send-email.adoc\".\n\nThis looks like a 'maint' worthy material, though.\n\nDownporting with cherry-pick should be able to deal with the rename,\nbut queuing with the old name on an older maintenance track and\nupmerging should be cleaner, so .txt is fine in this case.\n\nNot that I plan to do Git 2.48.2 anytime soon, so either way it does\nnot really matter, though ;-)\n\nThanks for a review.\n\n\n>> diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\n>> index bc3ef45acb..d762058907 100644\n>> --- a/Documentation/git-send-email.txt\n>> +++ b/Documentation/git-send-email.txt\n>> @@ -389,7 +389,7 @@ Automating\n>> +\n>> Default is the value of `sendemail.suppressCc` configuration value; if\n>> that is unspecified, default to 'self' if --suppress-from is\n>> -specified, as well as 'body' if --no-signed-off-cc is specified.\n>> +specified, as well as 'body' if --no-signed-off-by-cc is specified.\n>\n> The change itself looks obviously correct to me, thanks!\n>\n> Patrick\n"},{"id":"512656","messageId":"9DD68D2C-1BD3-4BFB-88F7-306E5E74CB96@cepl.eu","threadId":"62964","inReplyTo":"xmqqo6yzkrxd.fsf@gitster.g","subject":"Re: [PATCH] doc: fix typo","fromName":"Matěj Cepl","fromEmail":"mcepl@cepl.eu","sentAt":"2025-02-19T08:06:41Z","receivedAt":"2025-02-19T08:06:47Z","isPatch":true,"sender":{"key":"mcepl@cepl.eu","avatar":"https://avatars.githubusercontent.com/u/198999?v=4"},"body":"\nand\n\n"}]}